Commit Graph
28 Commits
Author SHA1 Message Date
dotCooCoo c609e56b87 Dimension: no preview bounds corners for guides or compound members
- A path made into a guide draws without its strokes or effects, so its
  preview bounds give no corners.
- The members of a compound path draw with the compound path's own
  appearance, so only the compound path's preview bounds give corners.
- Another path's anchor right on a preview bounds corner takes a click
  on the anchor that corner stands in for, so the point links to that
  path.
- A corner that its path cannot hold a point at, as on a stroked dot
  whose anchors all coincide, is not snapped to, so a click by the dot
  picks its anchor.
- The pointer test before measuring a path includes the right and
  bottom edges, as the 8 pixel distance test does.

Docs: docs/dimensions.md and docs/target-app-parity.md name paths made
into guides and compound path members among the art without corners.
2026-11-18 07:33:20 -08:00
dotCooCoo 5b58497e72 Merge main into fix/issue-8537 2026-11-18 07:09:23 -08:00
dotCooCoo 62c015d393 Dimension: a preview bounds corner takes only the anchor it stands for
A corner of a path's preview bounds took a Linear pick from every anchor
of its own object within 8 pixels, so the top, left, right and bottom
anchors of a small stroked circle, and the anchors of a rotated stroked
shape when zoomed out, could no longer be picked.

- The corner now takes the pick only from the holding path's anchor at
  the same corner of the object's geometric bounds. Any other anchor,
  of that object or of other art, that is nearer the pointer takes the
  point, and the nearest anchor wins a tie as the topmost.
- The path that holds a point picked on a corner is kept from the pick,
  instead of being worked out again from the point's position, so a
  point that only happens to lie on a corner links to what is under it.
  A path deleted between the clicks holds nothing.
- A corner of a compound path whose supplying member is hidden or
  locked is not snapped to.
- The hovering test checks the "anchor" label at the corner, and a new
  test covers the anchor ring right on the end of a dimension's line.

Docs: docs/dimensions.md and docs/target-app-parity.md say that only the
four corners are snapped to, by VectorCraft's own rule, not the edges of
the preview bounds, a group's own strokes or effects, or type; that a
corner point starts no construction guides; and that the dimension
measures W and H when it is drawn, since a later stroke weight change or
a scale with Scale Strokes off moves the point with the anchors.
2026-11-18 07:06:54 -08:00
BFlat 91c6a702c6 Merge pull request #8535 from dotCooCoo/fix/dimension-line-level
Dimension tool: a dimension line placed beside another lands on its level
2026-11-18 18:25:01 +07:00
dotCooCoo 1d974067ce Fix #8537: Dimension tool points land on preview bounds corners
With Use Preview Bounds on, W and H measure a stroked path from the
outside of its stroke, while the Dimension tool's Linear points only
snapped to the path's anchors, on the stroke's centerline. A dimension
between the corners of a 12 x 6 mm rectangle with a 0.4 mm stroke then
read 11.6 x 5.6 mm.

- With Use Preview Bounds on, a Linear click within 8 pixels of a corner
  of the preview bounds of a path or compound path (strokes and effects
  included) lands on that corner instead of on that object's anchors,
  whatever the snapping options. An anchor of other art nearer the
  pointer than the corner takes the point, and a corner that is also an
  anchor takes the anchor.
- The point is held against the anchors of the path whose bounds reach
  that corner, also when the corner lies far from the path or on another
  path's segment. It moves with the path; a later change to the stroke
  weight does not move it.
- A press on such a corner picks it when the pointer moves a few pixels
  before the release, as on an anchor.
- Hovering by such a corner shows the anchor ring. The ring now also
  shows when the pointer is exactly on the point a pick lands on, which
  it did not for the end of a dimension's line.

Docs: docs/dimensions.md, docs/target-app-parity.md.
2026-11-18 01:51:42 -08:00
dotCooCoo 18a7f7b84b Dimension tool: a dimension of the same points lines up too
The level a new dimension line lands on now comes from the dimension
lines in the document before the dimension's first preview, so its own
preview is never a level. A dimension drawn earlier between the same two
points now acts as a level as well; before, every dimension of those
points was skipped.

- Of two lines on one level, a line the pointer lies across wins over a
  line whose end is nearer the pointer.
- A dropped press while placing removes the level guide with the
  preview.
- The reach uses the Smart Guides snapping tolerance helper.
- docs/dimensions.md says the rule applies to a dimension anywhere in
  the document.
- The tests are split by behavior, with new tests for the same points,
  pointer moves in small steps, the guide after a dropped press and
  with Alignment Guides off, and the tie-break.
2026-11-18 01:40:21 -08:00
dotCooCoo dc92781181 Part of #5590: Dimension tool lines line up with dimensions already drawn
A linear dimension placed next to another one had its line exactly where
the pointer was. Chained dimensions only lined up when the pointer hit
the other line's level exactly, which at a normal zoom it rarely does.

- With Smart Guides on, a linear dimension placed with its line within
  the Smart Guides snapping tolerance of the level of a parallel line of
  a visible, unlocked linear dimension already drawn has its line on
  that level. This applies to two clicked points and to a segment
  dragged out.
- With Alignment Guides on, a guide runs along that level across both
  lines while the dimension is placed.
- Smart Guides off, a level further off, a locked dimension or one that
  is not parallel leaves the line where the pointer puts it.

Docs: docs/dimensions.md, docs/target-app-parity.md.
2026-11-17 21:33:30 -08:00
dotCooCoo a8b658a33e Merge main into fix/tool-set-option-errors 2026-11-16 20:33:41 -08:00
dotCooCoo 5f996eea32 Part of #8063: Dimension tool points snap to drawn dimensions and show anchor and path labels
A Linear point picked near the end of another dimension's line landed
beside it when zoomed in: the tool's own pick skipped dimension artwork,
so that end pulled the point only within the Smart Guides tolerance,
while an anchor of the art pulls it from 8 pixels.

- With Smart Guides or Snap to Point on, a point that no anchor of the
  art within 8 pixels takes lands on the end of a visible, unlocked
  dimension's dimension line, or on the far end of its extension line,
  within 8 pixels, with no link to that dimension. The end of an
  extension line next to the point it measures is not an end, so an
  anchor that a dimension already measures still takes the point.
- A point that nothing else places lands on the closest point of such
  a line within 8 pixels, as it does on a segment of the art.
- With Smart Guides and Anchor/Path Labels on, a point on an anchor or
  a line end shows the "anchor" label, and a point on a segment or line
  shows the "path" label. A point on a line end is marked as an anchor.
- A press on a line end that moves a few pixels picks it, as a press on
  an anchor does.

Docs: docs/dimensions.md, docs/target-app-parity.md.
2026-11-16 00:59:10 -08:00
dotCooCoo fdeb3a6ab3 Merge main into fix/tool-set-option-errors
# Conflicts:
#	crates/ui-egui/src/toolbar.rs
2026-11-15 09:11:04 -08:00
dotCooCoo fc562960ec Merge main into fix/dimension-second-point-guides 2026-11-14 03:02:44 -08:00
dotCooCoo a903feb870 Dimension tool: no construction guides through a first point off the anchors
With Smart Guides on, the Dimension tool's second point snapped onto the
construction guides through the first point (Smart Guides › Construction
Guides), so a click beside a segment straight below a first point that
was not on an anchor stayed on the vertical guide instead of landing on
the segment.

The second point now has no construction guides through a first point
that is not on an anchor. After a first point picked on an anchor, the
construction guides through it still apply. The second point still snaps
to anchors, centers and alignment lines, and with Snap to Perpendicular
or Snap to Tangent on it lands where the line from the first point meets
a segment square or grazes a curve.

Docs: docs/dimensions.md, docs/target-app-parity.md.
2026-11-13 21:26:04 -08:00
dotCooCoo dea57b348b Dimension tool: the first preview of a drag-out is drawn at the pointer
Dragging out a dimension from a segment (Linear) or a corner (Angular)
drew its first preview frame at the wrong distance. The preview placed
the dimension at the pointer before reading the segment's end points or
the corner from the art, and measured the offset from the placeholder
points the dimension starts with. A drag from the top edge of a
rectangle to 40 pt above it showed an offset of 60 instead of -40.

The preview now clears the offset, reads the art's points, places the
dimension at the pointer and checks the result. Clearing the offset
keeps an out-of-range offset from the last pointer position from
failing the read.

Tests: the segment and corner drag-out tests fail without the change.
placement_recovers_after_a_position_out_of_range also passes on main;
it fails when only the offset clear is removed.
2026-11-13 19:08:02 -08:00
dotCooCoo a315b7ef6b Tools: setting a tool option with a bad value returns an error
tool.setOption checks every option it is given before it sets any. An
option the tool does not have, a value of the wrong type, a number
outside the tool's range or an unknown choice is an error that names the
tool and the option, for example "tool `smooth`: `fidelity` must be a
number from 0.05 to 100". On an error no option, saved preference or
undo step changes, also when another option in the same call is good.
`{}` reads the options and sets nothing. A `tool` that is not a string,
a `values` that is not an object, a `key` without a `value` and an
option given both as `key` and in `values` are errors too.

- Tool::check_option (and check_options for options set together) is
  added beside set_option, and every tool with options implements it.
  A tool without options takes none. Most checks use the range the
  setter clamped to. The Arc tool's lengthX and lengthY now take a
  number greater than 0 and at most 1e6, and the Line tool's length 0
  to 1e6; before, a negative length was taken as its absolute value
  and the Arc lengths had no upper limit. The Live Paint tools and the
  Shape Builder use check_builder_options, so their width and gapLength
  are still clamped to their range.
- A Place `current` given with a new `queue` is an index into that
  queue, and the queue is set first. A parametric shape's `kind` is
  set before the values given with it, and those values are checked
  against the new kind's ranges.
- Tool Options dialogs (freehand, Liquify, Symbolism, Live Paint, Shape
  Builder, Objects on Path, Flare, the grid, arc and line tools and the
  path add-ons) stay open when an option is refused.
- docs/control-protocol.md, docs/mcp.md and the tool.setOption params
  text describe the errors.
2026-11-13 17:25:12 -08:00
dotCooCoo 2129d00868 Dimension tool: a point on a Smart Guide stays on the guide
A Linear pick that the Smart Guides left where the pointer already was,
for example straight below the first point on the vertical construction
guide through it, or exactly in line with an object's center, was taken
as not snapped. The pick then moved to the closest point of a segment
within 8 pixels while the guide still showed it on the guide. The same
happened to a point already on a grid crossing with Snap to Grid on, or
on a whole pixel with Snap to Pixel on.

The pick now keeps the snapped point whenever the snap shows guides or
grid or pixel snapping is on. With Snap to Grid or Snap to Pixel on, a
pick off an anchor is no longer moved from the grid or the whole pixel
onto a segment. A point that no
anchor, guide, grid or pixel snapping places still lands on the closest
point of a segment. An anchor within 8 pixels, a segment within the
Smart Guides snapping tolerance and a nearby guide crossing still take
the point as before.

Docs: docs/dimensions.md, docs/target-app-parity.md.
2026-11-13 01:48:09 -08:00
dotCooCoo ef6d14dc22 Dimension tool: both ends of a dimension follow the art it measures
A linear dimension clicked from an anchor to a point that is not an
anchor (a point on a segment, or a point a Smart Guide gave) followed
the art at the anchor end only, so scaling the art turned it into a
long slanted dimension.

- A point on a segment is stored by its curve parameter on that
  segment, and stays on it when the segment's anchors or handles are
  edited.
- Any other point is stored against anchors (and, for a path whose
  anchors lie on one line, handles) of the path under it, or of the
  path at the other end, and moves, scales, turns and reflects with
  that path. Beside a path whose anchors and handles all lie on one
  line, such as a straight line, it keeps its distance along and
  across the path: a reflection moves it as a half turn does, and a
  scale that is not uniform moves it as a uniform scale does.
- When linked art is reflected, a linear dimension's line goes to the
  reflected side, except for art whose anchors and handles lie on one
  line.
- Deleting the art, changing its anchor count or whether it is closed,
  turning an angle's arm into a curve, or making a measured circle or
  arc no longer circular leaves the dimension where it was, no longer
  linked, instead of removing it. Undo links it again.

Docs: docs/dimensions.md, docs/target-app-parity.md.
2026-11-10 21:25:59 -08:00
dotCooCoo ed17e8fc17 Dimension tool: linear dimensions measure horizontally, vertically or aligned
A linear dimension between two clicked points, or dragged out from a
segment, always measured the straight distance between its points and
drew its line parallel to them, so two points at different heights gave
only a slanted dimension. The linear dimensions help describes aligned,
horizontal and vertical linear dimensions: after the second click,
clicking again gives an aligned one and moving the pointer gives a
horizontal or vertical one.
https://helpx.adobe.com/illustrator/desktop/measure-and-align/plot-and-measure/plot-linear-dimensions-of-objects.html

While a linear dimension is being placed, the pointer's position sets
whether it is aligned, horizontal or vertical. The rule is VectorCraft's
own. With the pointer beside the two points (the nearest point of the
line through them lies between them) or on that line, the dimension is
aligned. Past either point, the line through the points and the
perpendicular through that point bound a quarter on each side of the
line. The quarter that holds the direction straight up or down gives
the horizontal distance, and the quarter that holds the direction
straight left or right gives the vertical distance. A click within
reach of the second point, or of where the pointer was for the second
click, places it aligned. Points on one horizontal or vertical line
give an aligned dimension. The dimension stays linked to the anchors it
measures.

- Dimension recipes carry an orientation (aligned by default; files
  without it open as before). The line runs along the axis, and each
  extension line runs from its point to it.
- dimension.create and dimension.update take orientation: aligned,
  horizontal or vertical, for linear dimensions only. Any other value
  is an error. A new orientation keeps the line on the side of the
  points it was on, and an update that changes nothing records no
  undo step.
- A horizontal or vertical dimension keeps its orientation when it or
  the art it measures turns, and shows 0 when its points come into line
  across its axis. A line that lay outside the points stays outside
  them after a turn.
- The hint bar names the two-click placement.

Docs: docs/dimensions.md, the Evidence list in docs/target-app-parity.md.
2026-11-10 16:54:35 -08:00
dotCooCoo 59791c8c0f Dimension tool: a click on an anchor of any path takes that anchor
With the Linear mode, two problems kept a click on an anchor from
taking it:

- A press on an anchor that moved more than 3 pixels before the release
  dragged out the dimension of the segment under the pointer and
  committed it almost on top of the art. A press on an anchor now picks
  it unless the pointer moves past the anchor's 8-pixel reach; a longer
  drag still dimensions the segment.
- A pick linked only an anchor of the segment nearest the pointer. An
  anchor of another path near that segment, for example one inside a
  group lying just inside another object's edge, was taken at most as a
  Smart Guides point with no link, so the dimension did not follow it
  when the art changed. A pick now links the nearest anchor of any
  visible, unlocked path within reach, in groups and compound paths too.
2026-11-09 23:38:23 -08:00
dotCooCoo 38bac1114b Preview dimensions on placement press 2026-11-04 10:51:37 +07:00
dotCooCoo 4c0e0b959a Commit pending dimensions only on pointer release 2026-11-04 08:12:34 +07:00
dotCooCoo 5d0cffbba1 Canvas: a dropped press keeps what earlier clicks picked
Escape also clears state that earlier clicks set up, so taking Escape for a
dropped press lost it in five tools. Each now drops only the press:

- Blend: the object picked first and the blend being added to are put
  back as they were at the press.
- Dimension: a dropped click picks nothing, and the points or lines picked
  before stay; a dropped drag is canceled as before.
- Width: the drag ends and the width points selected at the press are
  selected again.
- Gradient: a dropped click on a freeform gradient leaves the line being
  drawn open.
- Selection: with the pointer loaded with text, a dropped press threads
  nothing and the text stays loaded; a dropped press on a port loads none.
2026-11-03 16:03:39 +07:00
vectezaandClaude Opus 5.5 1a6bc267d5 Dimension tool: Linear picks show and snap to Smart Guides
Picking the two points of a Linear dimension snapped to anchors and to the
line under the pointer, but showed no guides and ignored the art around it.
The picks now go through the drawing tools' Smart Guides (DrawSnap), hovering
too, so the guides show before each click: a point slides into line with other
objects' anchors and centres, and the second onto the construction guides
through the first. An anchor of the line under the pointer still wins (it
links the dimension to that path), then a guide, then the closest point of the
line (#2432). The guides go once the dimension is being placed.

Test: linear_picks_show_and_snap_to_smart_guides (fails on the old tool, which
showed no overlays while hovering). docs/dimensions.md updated.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-24 17:46:19 +07:00
nrq6993-a11yandCursor fd53416de3 G1: honor Show Measurement Labels on pie, corners, width, and tiling readouts
Tools that showed distance or angle overlays during drags now respect the
Units preference, consistent with shape and selection tools.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-10-20 02:23:33 +07:00
vangel76andClaude Opus 5.5 4dcd0b6caa Dimension tool: show where a Linear click snaps before the click (#2516)
The snap ring on an anchor (or a dot on a line) and the rubber band now follow the snapped point, so both measured points visibly land on anchors.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 13:20:26 +07:00
vangel76andClaude Opus 5.5 848e7a296a Dimension tool: a click near a line snaps the measured point onto the line (#2432)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 13:20:26 +07:00
vangel76andClaude Opus 5.5 6939a481a4 Dimension tool: Shift shows the constrained line while picking the second point (#2432)
The Shift click already snapped the second point to 45-degree steps, but the dashed line from the first point followed the raw pointer, so the constraint looked absent until the click.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 13:20:26 +07:00
Osama Amin 8aea665c4e Dimension tool: the documented gestures, arcs, picas and text positions; Properties section; review fixes
Drag out from a segment, corner, circle or arc to place a dimension; plain clicks pick two points or two lines. Radial dimensions on perfect arcs, picas, Away/Between and Left/Center/Right text placement. The Properties panel edits a selected dimension, with Apply to All (dimension.applyToAll) and Set as Default. Dimension Selected Paths, the Arc/R/Ø prefixes and the custom defaults are left out. The refresh returns at once in documents without dimensions (Document::dimensions); a linked dimension moved on its own keeps its place; modes, units, line types, arrows and text placement are enums; the tool has its own icon.
2026-10-16 01:36:24 +07:00
Osama Amin 9d813e906a Fix #1372: Dimension tool and Object > Dimensions: linked length, angle, radius and diameter annotations 2026-10-16 01:36:24 +07:00