Commit Graph
61 Commits
Author SHA1 Message Date
dotCooCoo 4080708714 Merge main into feat/stylus-wheel 2026-11-18 17:25:37 -08:00
dotCooCoo 18c4a7b965 Merge main into feat/stylus-wheel 2026-11-18 07:27:22 -08:00
dotCooCoo b0e4302b64 MCP: transform's schema accepts the null arguments it already takes
The transform tool treats a null reflect, copy or origin, and a null
numeric step, as given, but its inputSchema allowed only the non-null
types, so a client that validates against the schema could not send
them. Each of those properties now also allows null. The transform row
in docs/mcp.md says a step that is neither a number nor null is an
error, and that a null dx or dy counts as 0 and still runs the move.
2026-11-18 06:27:31 -08:00
dotCooCoo a51e94f337 MCP: transform's description spells center in American English
The `transform` tool description now says `origin` defaults to the
selection center.
2026-11-18 01:50:20 -08:00
dotCooCoo 7d3f7d1fa1 MCP: transform refuses a mistyped reflect, copy or origin before any step
`transform` read `reflect` with `as_str`, `copy` with `as_bool` and
passed `origin` through unchecked. A `reflect` of `42` or `true`
skipped the reflect step and reported success for the steps before it,
a `copy` of `"yes"` transformed the original instead of a copy, and an
`origin` that was not two numbers fell back to the selection centre.

The handler now checks all three before it selects `ids` or runs a
step, and returns an error that names the argument. A null value of
any of the three is left out. The tool description and the
`transform` row in docs/mcp.md say so.

Fixes #6448
2026-11-18 01:27:19 -08:00
dotCooCoo e2d7976794 Merge main into fix/shear-angle-range 2026-11-17 22:56:09 -08:00
BFlat c5712cf12c Merge pull request #8321 from yoriswind/codex/6430-mcp-path-effect-clean-main0f-20261117
Fix #6430: validate MCP path effects before creating text
2026-11-18 13:00:31 +07:00
BFlat 10b5f446ee Merge pull request #6509 from yoriswind/codex/6488-validate-transform-numeric-steps
Reject nonnumeric MCP transform steps before editing
2026-11-18 13:00:13 +07:00
dotCooCoo 9f84820d88 MCP: transform checks scale, reflect and shear before any step runs
The transform tool runs move, rotate, scale, reflect and shear as separate
commands. A shear angle that object.shear refuses, such as 90, a reflect
axis other than vertical or horizontal, or a scale of 0 failed only after
the earlier steps had changed the art and recorded undo steps. The tool now
checks those params first with the rules the commands use
(scale_factors, reflect_axis and shear_tangent, shared with object.scale,
object.reflect and object.shear), so a refused request changes nothing and
records no undo step.
2026-11-17 17:42:44 -08:00
yoriswind 9e8b6ef768 Fix #6430: validate MCP path effects before creating text 2026-11-17 05:19:31 -08:00
dotCooCoo 14d814b9f0 Merge main into feat/stylus-wheel 2026-11-17 03:57:49 -08:00
dotCooCoo 9ecc8087c3 Shape tools: Backtick held while dragging leaves copies of the shape
Holding Backtick while dragging out a rectangle, rounded rectangle,
ellipse, polygon, star or line leaves a copy of the shape being drawn
each time the pointer has moved 8 screen points with the key down, up to
128 copies a drag. Each copy is its own object, drawn as the drag showed
it then. The release keeps the copies and the last shape as one undo
step, and Escape takes them all back. The spacing and the limit are
VectorCraft's own values.

The `backquote` descriptions of `pointer_gesture` name the shape tools.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-16 04:53:06 -08:00
FredApps d2b8ebfd95 Merge origin/main into feat/cutover-remaining-codecs 2026-11-16 01:57:11 +01:00
dotCooCoo d66a84b4f6 Merge main into feat/stylus-wheel 2026-11-15 16:10:22 -08:00
dotCooCoo 24c0f89ff9 Part of #7840: the Ellipse dialog sets how many anchors the ellipse has
A click with the Ellipse tool opens a dialog with a new Anchors field
under Height, 4 by default. With 4, OK draws the same live ellipse as
before. Any other count from 2 to 1000 draws a closed plain path with
that many smooth anchors spaced evenly by angle, from the left one and
clockwise, with handles of 4/3*tan(theta/4) scaled along each axis and
the path fitted to the typed width and height. The dialog sends the
nearest whole number from 2 to 1000 (4 for an empty field or text that
is not a number). The count confirmed last is kept as the Ellipse
tool's anchors option, and the next Ellipse dialog opens on it.

shape.ellipse takes an optional anchors param (default 4). A number
that is not a whole number from 2 to 1000 gets one error naming that
range, a value that is not a number gets the usual type error, and
nothing is drawn. The MCP draw_shape tool lists anchors for ellipses.

Docs: params text, docs/mcp.md, docs/target-app-parity.md (Shapes).
2026-11-15 12:16:26 -08:00
FredApps 5d492ebad2 Merge #7664 (fix/restore-codec-cutover-ci) into feat/cutover-remaining-codecs
Conflicts resolved in favour of main/#7664 in the 13 source files both touched
(doc/cmyk.rs, metafile/dib.rs, pdf images, svg import/files.rs, render paint and
encode tests, trace, engine load.rs), keeping main's newer TIFF/CMYK, DIB and PDF
image fixes. vectorcraft-doc stays on main's version until its CMYK reader moves
to craft-tiff. The image crate keeps its format features, and usvg, tiff,
zune-jpeg, hayro-ccitt and jpeg-encoder stay for the readers not yet moved.
Codec crates pinned to craft-libs d6cd7836d364177661b0ae17f48a0805e83a5f32.

Also fixes the compile errors CodeRabbit flagged (jp2read DecodeOptions,
filters.rs use-after-move) and the encode() arity at d6cd7836d.
2026-11-15 17:35:43 +01:00
yoriswind bec29ed3cb MCP: reconcile transform validation with current main 2026-11-15 01:36:42 -08:00
dotCooCoo bdda6c2e08 Merge main into feat/stylus-wheel 2026-11-14 20:22:56 -08:00
BFlat 40f096f32b Merge pull request #7213 from dotCooCoo/feat/rotated-box-scale-reflect
Transform: Scale and Reflect act along a rotated bounding box
2026-11-15 09:47:18 +07:00
dotCooCoo 67fd1cd127 Merge main into feat/live-paint-bucket-multi-click 2026-11-14 15:48:45 -08:00
dotCooCoo 93a7d532c7 Merge main into feat/rotated-box-scale-reflect 2026-11-14 15:17:16 -08:00
Dylan M. Taylor 1d6c4dcd14 chore(codecs): cut over remaining image/tiff/ccitt codecs to craft-libs 2026-11-14 21:19:30 +00:00
dotCooCoo c7fa644f2f Merge main into fix/text-wrap-offset-refused 2026-11-14 12:30:12 -08:00
dotCooCoo 1c4cc88e90 Merge main into feat/live-paint-bucket-multi-click
# Conflicts:
#	crates/tools/src/builder/live_paint.rs
2026-11-14 10:19:24 -08:00
dotCooCoo 79954fd6c9 Merge main into feat/stylus-wheel 2026-11-14 09:53:01 -08:00
dotCooCoo b562fc1c54 Text wrap: an out-of-range or non-number offset is refused
object.textWrap.make and object.textWrap.options kept an offset outside
-1000 to 1000 pt at the nearer end of the range, and read an offset that
is not a number, or an invert that is not true or false, as if it had
been left out. Both commands now return an error for such a value and
leave the wrap options and the undo history unchanged. An omitted or
null value still takes the default (6 pt and no invert for Make, the
current options for Text Wrap Options), and Text Wrap Options with only
null values reads the current options. A stored offset outside the range
is kept when only Invert Wrap changes.

The MCP text_wrap tool checks offset, invert and release before it
changes the selection, so a refused call changes nothing, and a release
that is not true or false is an error instead of making a wrap.
2026-11-14 05:12:58 -08:00
dotCooCoo 786dcc5581 Images: scaled-down images keep their color beside clear pixels
The image crate's filtered resize filters each channel on its own, which
is correct only for premultiplied pixels, and its thumbnail averages each
channel on its own too. Placed images, linked-image previews, MCP
captures and previews, metafile bitmaps, PDF downsampling and library
thumbnails passed straight RGBA to them, so the color under clear pixels
(usually black) bled into the opaque pixels beside them and darkened
cut-out edges.

vectorcraft_doc::resample scales such images with each pixel's color
weighted by its alpha: filtered resampling premultiplies the pixels in
place and divides them back after, and averaging takes the area-weighted
mean of the pixels each new one covers. Opaque and alpha-free images are
scaled as before. PDF export also multiplies the inks of a CMYK image
with alpha by that alpha before resampling them, and divides them by the
resampled alpha after.
2026-11-14 05:07:39 -08:00
dotCooCoo 33319b2c4d Merge main into feat/live-paint-bucket-multi-click 2026-11-13 18:04:02 -08:00
dotCooCoo 4bb3ecb310 Merge main into feat/stylus-wheel 2026-11-13 16:54:59 -08:00
dotCooCoo adc60bfb16 Merge main into feat/rotated-box-scale-reflect 2026-11-13 16:42:07 -08:00
dotCooCoo 395dd5b294 Text Wrap: a negative Offset lets text run into the wrap object
The help page says a wrap object's Offset may be positive or negative
(https://help.adobe.com/archive/en_US/illustrator/cs4/illustrator_cs4_help.pdf#page=307).
Text Wrap Options, the commands, the MCP tool and .ai import already
kept a negative value, but layout set it to 0.

- Layout keeps the signed offset, within -1000 to 1000 pt like the
  commands and .ai import (a value that is not a number counts as 0).
- Around a wrap object, a negative offset shrinks the object by that
  distance from each edge, holes included, so lines beside, above and
  below it run that far into it. A shape narrower than twice the
  distance no longer moves text aside. A line may get less room than
  the exact shrunk shape leaves, for example where several edges come
  close to one piece of the band, or where a band holds more than 64
  anchor heights. It never gets less room than an offset of 0 leaves.
- With Invert Wrap, a negative offset keeps the text that far inside
  the object.
- Zero and positive offsets up to 1000 pt lay out as before. A larger
  positive offset lays out as 1000 pt.
- The params text of object.textWrap.make and object.textWrap.options
  and the MCP text_wrap offset description give the range and what a
  negative value does.

Docs: docs/target-app-parity.md.
2026-11-13 13:19:43 -08:00
dotCooCoo f9e796cb10 Live Paint: double-click floods across unstroked edges, triple-click paints the same paint
With the Live Paint Bucket, a double-click on a face fills it and every
face reached across edges that are hidden or draw no stroke; a stroked
edge, a hidden face and a Gap Detection gap stop it. On an edge, a
double-click paints the edges joined to it end to end with the same
stroke paint. A triple-click fills every face of the group with the
clicked face's fill, or paints every edge with the clicked edge's
stroke. Shift and the Paint Fills and Paint Strokes options choose a
face or an edge as for a click; Alt held paints nothing.

- livePaint.fill and livePaint.strokeEdge take scope ("one", the
  default, "connected" or "samePaint") and match, the paint compared,
  and reply with count. A bad scope or match is an error, and scope
  with a drag's points is refused.
- Each click of a double-click or triple-click paints as it arrives,
  as its own undo step. For a triple-click, and for a double-click on
  an edge, the tool sends as match the paint the face or edge had
  before the first of those clicks, including a first click that makes
  the Live Paint group from the selected paths. A double-click on a
  face sends no match.
- PointerKind::TripleClick is new: the canvas sends it on egui's
  triple-click unless a modal dialog is open, as for a double-click,
  and ui.pointer and pointer_gesture take "tripleclick".

Docs: docs/mcp.md, docs/control-protocol.md, docs/target-app-parity.md.
2026-11-13 13:01:02 -08:00
dotCooCoo d7c7b118ec Merge main into feat/rotated-box-scale-reflect 2026-11-13 11:43:40 -08:00
dotCooCoo e0ff711f8b Merge main into feat/stylus-wheel 2026-11-13 10:00:41 -08:00
dotCooCoo 78889ce8af Transform: Scale and Reflect act along a rotated bounding box
The Scale and Reflect tools, object.scale, object.reflect and the
Transform panel flips act along a rotated bounding box instead of the
page axes, until Object > Transform > Reset Bounding Box, as Free
Transform does. The Scale and Reflect dialogs and the Properties panel
flips run the same commands and follow the box too.

- object.scale and object.reflect with a named axis take
  basis?: "box"|"page" ("box" by default; "page" keeps the page axes;
  any other value is an error before anything changes). The journal
  records the basis, so recorded actions replay in the same frame; an
  older recording without it acts along the box.
- A numeric Reflect axis and a Reflect axis drawn with the tool stay
  lines on the page. While a Reflect drag has not drawn an axis away
  from the reference point, the tool uses the box's vertical axis, and
  Shift steps 45 degrees from the box.
- Mixed-angle selections and anchors selected with Direct Selection use
  the page axes; an Alt-drag copy of such anchors scales the whole
  objects along their box. Transform Again repeats the page matrix.

Docs: docs/mcp.md, docs/target-app-parity.md, docs/ui-parity.md.
2026-11-13 09:37:31 -08:00
dotCooCoo e11c21ce98 MCP: an old app's window capture goes through a private temporary folder
An app that does not send the image back wrote the window capture to
vectorcraft-window-<pid>.png directly in the system's temporary folder.
On a shared Unix temporary folder another user could put a link at
that name, and the app would then overwrite the file it points to. A
failed read also left the file behind.

The capture now goes to window.png in a new folder made for it inside
the temporary folder (owner-only on Unix; a name that is taken is
skipped). The folder is removed after the read, also when the app or
the read fails.
2026-11-13 08:19:07 -08:00
dotCooCoo e9a0d91c0a Brushes: an airbrush pen's stylus wheel varies brush size and width
Calligraphic and Scatter Brush Options offer Stylus Wheel for Size, and
Art Brush Options offer it for Width. The Paintbrush records where the
pen's finger wheel is set along each stroke (`StrokeLayer::wheel`, 0..1),
and the stroke keeps it through saving, continuing, reversing and blends.
A value on Stylus Wheel goes from its low end at one end of the wheel's
travel to its high end at the other; a stroke without a wheel draws the
value half way.

- Input: XInput2's `Abs Wheel` valuator under X11 and XWayland, and
  AppKit's `tangentialPressure` on macOS. Windows pointer messages have
  no field for the wheel.
- Commands: `path.freehand` and `brush.freehand` points take the wheel
  seventh or as `wheel`, and `pointer_gesture` events take `wheel`;
  values are clamped to 0..1 and non-numbers are refused.
- `.ai` brush definitions read and write variation code 3 as Stylus
  Wheel instead of reading it as Random, or as Fixed when the value has
  no variation.
- `appearance_heap_bytes` counts a stroke's tilt, bearing, rotation and
  wheel recordings as well as its pressure.

Docs: docs/mcp.md, docs/target-app-parity.md, docs/file-format-parity.md.
2026-11-13 04:16:09 -08:00
dotCooCoo 9c5d22bccc Merge main into feat/hpgl-export 2026-11-11 23:31:04 -08:00
HassanKhan 386e405800 Commands: draw_shape and object.reflect say which way they turn; test the notes the key walk misses (#6340)
draw_shape's rotation also turns rectangles and ellipses; object.reflect's numeric axis is counter-clockwise from horizontal. A test covers that axis and the Scatter brush's rotation range, which every_turn_param_says_which_way_it_turns can't reach.
2026-11-12 10:47:06 +05:00
dotCooCoo 987dd18aff File formats: HP-GL (.plt) plots export for pen plotters and cutters
VectorCraft could open and place HP-GL plot files but not write them,
so art for a pen plotter or a vinyl cutter had to go through another
program.

Export As, document.export and Export Selection now write HP-GL.
vectorcraft_cad::hpgl::export draws each visible path once along its
own line: a filled shape is its closed outline and a stroked path its
center line. Type is drawn as glyph outlines, a gradient mesh as its
outline, and a symbol instance as its art with its effects and the
instance's stain. Clipping masks cut the art they clip, and the art is
cut at the artboard's edges. Hidden and non-printing layers, hidden objects,
objects at 0% opacity, template layers, guides and placed images are
left out. Coordinates are plotter units (1016 to the inch, y up) from
the artboard's bottom-left corner or its center, and art more than
8,388,607 units from the origin is cut off.

Each color is a pen, in the order the plot first draws in it (up to
255), or a pen table maps each path to the pen of the nearest color.
With Use Artboards every file of the export uses the same numbering.
The pens draw in turn, each in paint order or, with sortPaths, nearest
path first. Curves are flattened to curveTolerance (0.1 pt by default).
hpglVersion "hpgl" writes IN, SP, PU and PD; "hpgl2" also writes the
palette (NP, PC) and each pen's paths as one encoded polyline (PE).
Options are checked, and Export As writes the file with the defaults.
Plots read back by the HP-GL reader give the same lines.

Docs: docs/mcp.md, docs/control-protocol.md, docs/file-format-parity.md,
docs/target-app-parity.md.
2026-11-11 20:44:32 -08:00
BFlat f83d916d8a Merge pull request #6631 from Hassan1305/docs-6340-rotation-direction
Commands: every angle and rotation param says which way it turns (#6340)
2026-11-12 01:32:17 +07:00
HassanKhan b3860bf7d0 Commands: every angle and rotation param says which way it turns (#6340)
The params docs now state the direction (and the zero) of each angle or
rotation a command takes; behaviour is unchanged. Shape creation, text.create,
the grids, add-on shapes, saved views, Liquify, Puppet Warp pins, Mirror and
Radial Repeat and Vector Halftone turn clockwise; text character rotation,
gradients, the eraser tip and print screen angles turn counter-clockwise.

view.saved.new's rotation note changes its schema, so the API level goes to 3.

A test walks every command's params doc and fails when a param named like an
angle or rotation doesn't say clockwise or counter-clockwise.
2026-11-11 21:40:27 +05:00
Fabio William Conceição 13098fa9f4 MCP: list UI_COMMANDS in command_list and close catalogue gaps (#6460)
Headless command_list exposes the desktop UI catalogue with ui: true, docs
clarify effect vs command ids, and prompts cover spelling, variables and path tools.
2026-11-11 15:48:05 +00:00
yoriswind 98fcf6a497 #6490: reject malformed move offsets before selection or copy 2026-11-10 20:45:20 -08:00
yoriswind 8dbe7bd3cb MCP: validate numeric transform steps before editing (#6488) 2026-11-10 19:17:39 -08:00
dotCooCoo d9e9adbf45 MCP: answer_dialog sets the fields and answers the dialog in one request
answer_dialog sent ui.dialog.set and then ui.dialog.confirm or
ui.dialog.cancel as two requests. A dialog another control connection
opened between them was confirmed or canceled without the fields.

ui.dialog.set takes `action: confirm | cancel`, checked before any field
is set, and confirms or cancels the dialog the fields were set in within
the same request, replying {dialog, result}. answer_dialog sends set and
action together; an app whose reply has no `dialog` key did not answer
it, and the dialog is then confirmed or canceled with its own request.
2026-11-10 14:51:50 -08:00
dotCooCoo 9172950ad5 MCP: command listings give each command with a schema an inputSchema
engine.commands, command_list and list_commands now list an inputSchema
next to schema for each command with a parameter schema. It is the same
JSON Schema 2020-12 schema with the root type "object", the form an MCP
tool's inputSchema takes
(https://modelcontextprotocol.io/specification/2026-07-28/schema);
schema keeps the root type ["object", "null"] when no parameter is
required. A command without a schema lists neither field. tools/list is
unchanged, and the commands are still run with command_run or
run_command.

brief now leaves out schema and inputSchema as well as the params text;
a listing filtered to the command's id gives them.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-09 19:34:24 -08:00
dotCooCoo 58f5789e9a Plug-ins: Open With passes an importer its parameters and adds the file to Open Recent
File › Open With asks for the parameters of an importer that declares
any, at their defaults, once the file is picked (dialog `pluginImport`),
and opens the file with the values set. `file.openWith`, `app.open` and
MCP's `open_file` take `params` and pass them to the importer;
`app.open` without them runs the importer on their defaults, with no
dialog. A file opened with Open With is added to Open Recent, as File ›
Open adds the files it opens.
2026-11-08 05:07:08 -08:00
dotCooCoo 36eec28617 MCP: open_file takes an importer plug-in to open the file with
open_file passes `importer` (an importer plug-in's format id,
plugin.<id>) on to app.open. Headless, it becomes document.open's
`importer`; in the app, app.open with `importer` runs file.openWith, so
the file opens with that importer as File > Open With does, also when a
built-in format reads its extension.
2026-11-08 04:40:23 -08:00
dotCooCoo 7ee6b429ba MCP: save_file notes name the legacy or non-PDF-compatible .ai
save_file's note for a key in `options` that the written format doesn't
read named every .ai file a PDF-compatible .ai, also when the save wrote
a version 7 file (`aiVersion: "7"`) or one without PDF content
(`pdfCompatible: false`).

The save itself now writes that note, beside its note on a top-level
`compress`, `version`, `preview` or `precision`, and names the file it
writes, including when it reuses the options the document was last saved
with. save_file returns the save's reply unchanged, and
`run_command document.save` and the other save commands give the same
notes.
2026-11-07 08:19:24 +07:00