Commit Graph
1260 Commits
Author SHA1 Message Date
bflatastic 35321b5f39 combo: #8502 2026-11-19 01:26:09 +07:00
bflatastic 86eb9aa115 Merge main into #7867 2026-11-19 01:19:48 +07:00
dotCooCoo cc52bf5042 Merge main into feat/field-x-multiply 2026-11-18 06:26:33 -08:00
HassanKhan 41f7d4e06a #8538 review: drop kept guides on transform, finish the marquee rule
A transform no longer leaves locked guide paths in place: a guide in a
group moves with its group again, as on main. Keeping them put made
Align, Transform Each, the pixel-grid snap and Objects on Path measure or
place art the transform did not move. Scaling::keep_guides and its
engine wiring and test are removed.

The marquee rule now covers the rest of the selection side, while guides
are locked or hidden:
- the guide rule goes down the walk as an explicit Rules value instead
  of a thread-local guard;
- an Enclosing Lasso loop does not take a compound path for its guide
  contours;
- an enclosing marquee measures a group without its guide paths
  (Node::without_guides);
- Direct Selection's marquee takes no anchor or crossed segment of a
  guide path.

Docs: the Guides area row, its evidence entry and the M1 row describe
the marquee behaviour; status lines and revision rows say a guide in a
group still moves with it.
2026-11-18 16:15:04 +05:00
HassanKhan c6a419a097 Lock Guides: a marquee skips guides in groups, a group's transform leaves them
While guides were locked, a guide path inside a group was still touched by
a selection marquee, so the marquee selected the group and moving the
group moved the guide (#8538). Clicks already skip guides (#3074).

- hit: marquee_in_view and enclosure_candidates take skip_guides; the
  Selection, Direct Selection, Group Selection and Enclosing Lasso tools
  pass !cx.guides, and the marquee then touches no guide path at any depth.
- doc: Scaling::keep_guides leaves the guide paths among a group's,
  layer's or Intertwine group's children in place, as a ruler guide in a
  transformed layer already stays.
- engine: transforms (apply_transform), Transform Each and Align and
  Distribute set it while Lock Guides is on; a copy takes a copy of the
  guide with the copied art and leaves the original.

Fixes #8538
2026-11-18 15:24:42 +05:00
BFlat abb2503bc9 Merge pull request #8536 from dotCooCoo/fix/dimension-arrow-previews
Dimension: Arrow Style shows each style's arrowhead drawn before its name
2026-11-18 15:23:50 +07:00
BFlat 6e1e6d579e Merge pull request #8542 from Hassan1305/feat-3644-pdf-lang
PDF export: write the document language as the catalog's /Lang
2026-11-18 15:10:05 +07:00
BFlat e3a9bca2dc Merge pull request #8541 from dotCooCoo/fix/marquee-painted-shapes
Symbols: a marquee selects where an instance's fill and stroke effects paint
2026-11-18 15:09:57 +07:00
BFlat 84c21a8b36 Merge pull request #8519 from dotCooCoo/perf/proxy-mixed-index-paths
Color: the Fill and Stroke proxies find the selected objects through the id cache
2026-11-18 13:52:56 +07:00
HassanKhan 0865242d2f PDF export: write the document language as the catalog's /Lang (#3644)
The writer passed no language to craft-pdf, so exported and printed
PDFs had no /Lang and accessibility checkers failed primary-language.
Writer::new now passes the BCP 47 tag of the Document Setup language
(new vectorcraft_doc::setup::language_tag, en-US by default) through
write::Writer::new_with_language, which writes the catalog's /Lang and
the XMP dc:language. A language with no tag writes none. /MarkInfo is
left for tagged PDF (#3643).
2026-11-18 11:46:27 +05:00
dotCooCoo c6b657b96f Merge main into feat/editable-flares 2026-11-17 22:42:31 -08:00
dotCooCoo a166087f55 Fields: test a product through a length param and keep upstream's doc text
- `Unit::parse` keeps main's paragraph about units after `*` and `/` as it
  was; the new `x` paragraph follows it, and the limit line names the
  signs it counts again.
- `object.path.offsetPath` takes `"0.05x2 in"` (0.1 in), which it refused
  before; `"0x10"` reads as 0 pt. docs/mcp.md states both.
2026-11-17 22:36:30 -08:00
dotCooCoo 84c9d93956 Symbols: a marquee touches what an instance's fill and stroke effects paint
A marquee across the shapes that the geometry effects of a symbol
instance's active fill or stroke paint outside its box now selects the
instance, as a click there does. An image is likewise touched where its
own fills and strokes paint outside its frame. Outline mode keeps the
box alone.
2026-11-17 22:18:27 -08:00
BFlat add89a0606 Merge pull request #8488 from dotCooCoo/perf/live-selected-of-one-pass
Blend: selected blends, envelopes and meshes are found along one path per object
2026-11-18 13:14:25 +07:00
BFlat dcc3b28845 Merge pull request #7433 from dotCooCoo/fix/instance-row-effects-outline-hit
Symbols: instance fill and stroke effects count in Pathfinder effects and clicks
2026-11-18 13:03:58 +07:00
BFlat 439e224933 Merge pull request #8385 from dotCooCoo/fix/twist-boundary-tangent
Twist: boundary handles follow the inward tangent
2026-11-18 13:01:25 +07:00
BFlat 3b25ff3945 Merge pull request #6697 from yoriswind/codex/6625-visible-fill-selection
Fix path interior selection across enabled fill rows
2026-11-18 13:01:16 +07:00
BFlat e53789260b Merge pull request #8418 from dotCooCoo/perf/select-behind-isolation-set
Select: Select Behind in isolation looks up the objects it found in a set
2026-11-18 13:00:49 +07:00
BFlat facb326b16 Merge pull request #8377 from dotCooCoo/perf/inline-refresh-changed-subtrees
Type: inline graphics are checked again only in the layer trees an edit changed
2026-11-18 12:57:22 +07:00
BFlat c0ec570d0f Merge pull request #8371 from dotCooCoo/feat/transform-line-properties
Transform: a live line shows Line Properties with Line Length and Line Angle
2026-11-18 12:57:04 +07:00
BFlat d5d66cf8de Merge pull request #8370 from dotCooCoo/perf/swatch-link-roots-set
Swatches: linking the selection's paints checks ancestors through a set
2026-11-18 12:55:21 +07:00
dotCooCoo 0c2d7d1488 Dimension: Arrow Style shows each style's arrowhead drawn before its name
The Arrow Style dropdown in Dimension Tool Options and in the Properties
panel's Dimension section showed only the names Filled, Open, Tick and
None. Each style now shows its arrowhead at the end of a short line
before its name, in the open list and in the closed field, drawn with
the Stroke panel's arrowhead previews. The four styles and their saved
values are unchanged.

ArrowStyle::arrowhead holds the style-to-arrowhead mapping, so the
dimension line and the preview use the same head.
dropdown_icon_names_sized takes an icon size that is not square.

Part of #8049.
2026-11-17 21:23:32 -08:00
dotCooCoo 9ffca655cd Fields: count x signs in the Unit Converter's limit too
addon.units.convert reads its value through Unit::parse, so after the
merge of main it takes x, X and × as multiplication signs as well. Its
128-sign limit counted only + - * /. The new
vectorcraft_doc::arithmetic_signs counts each multiplication sign as a
*, and both Unit::parse and the converter use it.

- The converter's params text and docs/mcp.md list the signs.
- Tests cover 2pX3 and 2p×3 (6 picas), 8.5x11 in (refused before, now
  93.5 in) and the converter's reading and limit.
- The test message says "millimeters", and the doc comments wrap at
  the file's width.
2026-11-17 21:15:25 -08:00
dotCooCoo 14a98c1367 Merge main into feat/field-x-multiply 2026-11-17 20:41:00 -08:00
BFlat 61d3190469 Merge pull request #8181 from dotCooCoo/feat/area-type-first-baseline-em-box
Type: Area Type Options First Baseline offers Em Box Height
2026-11-18 10:22:23 +07:00
BFlat 3a9bb87022 Merge pull request #7925 from dotCooCoo/feat/brush-options-of-selected-object
Brushes: Options of Selected Object changes one brushed path's brush settings without changing the brush
2026-11-18 10:18:41 +07:00
BFlat 1380e9c480 Merge pull request #7675 from dotCooCoo/feat/unit-converter
Unit Converter: one length in every unit, read from and applied to the selection
2026-11-18 10:16:26 +07:00
BFlat f66c2e78ad Merge pull request #8182 from dotCooCoo/feat/list-start-number
Lists: a numbered paragraph can start at a chosen number or restart at 1
2026-11-18 10:16:16 +07:00
dotCooCoo 0602c437da Color: the Fill and Stroke proxies find the selected objects through the id cache
DocState::proxy_mixed, which decides whether the Fill and Stroke proxies
show "?", walked every node of the document to find the selected
objects, even with one object selected. The Tools panel proxies, the
paint chips and the task bar ask for it on every frame whose revision
changed, which includes each frame of a drag preview, and new art asks
for it after a selection change.

Document::nodes_in_order finds every node with one of the given ids in
tree order. When the id cache holds each id once at a path that still
checks out, it reads the nodes along those paths; otherwise, and for a
selection of an eighth of the document or more, it walks the tree once,
as before. Unlike Document::index_paths it returns every node with a
repeated id, so a damaged file that repeats an id keeps the question
marks it had. proxy_mixed now gathers the selected objects through it.

Tests compare the result with a copy of the old walk for one object,
different fills and strokes, a group, a group with one of its objects,
two layers, a hidden object, Appearance items, picked gradient mesh
points beside another object, ids not in the document and a repeated id
with different paints, with the cache built and dropped, and for 200
random selections. A cost test shows that with one object selected only
that object is read and the tree is not walked. Document tests compare
nodes_in_order with a walk.

The gain shows on large documents. On 50,000 rectangles in 500 groups
on 5 layers (release build on Linux, thread CPU time, median of seven
alternating runs of both versions in one process; an ignored test,
proxy_mixed_timing, times them):

  Selection                    old       new
  1 object                     995 us    under 5 us
  2 objects, different fills   810 us    under 5 us
  a group of 100               875 us    5 us
  all 500 groups               3,615 us  2,575 us
  all 50,000 objects           4,075 us  3,470 us
2026-11-17 19:02:15 -08:00
dotCooCoo 51d09113f7 Fields: x multiplies in value fields, as * does
Value fields and length strings read `x`, `X` and `×` as a
multiplication sign: `10x2` is 20, `2x3 mm` is 6 mm and `3cmx50%` is
1.5 cm. A lowercase `x` right after a `p` stays the `px` unit, so
`2px x 3` is 6 px and `2px3` is not read. The change is in
`Unit::parse` and `parse_number`, so every field that reads its text
through them takes it. Each sign counts toward the 128-sign limit,
which is checked before the text is copied.

Docs: docs/mcp.md, docs/ui-parity.md, docs/target-app-parity.md.
2026-11-17 17:05:56 -08:00
dotCooCoo b029a20c2b Blend: selected blends, envelopes and meshes are found along one path per object
The Blend panel, the Object › Blend, Envelope Distort and Gradient Mesh
menu items and their commands looked up every ancestor of each selected
object by id to find its nearest blend, envelope or mesh, and dropped
repeats with a linear scan. They now read the object's cached place in
the tree once, test the nodes on that path, and keep a set of the ones
already listed. The checks of whether one is selected stop at the first
selected object that has one. An id that the lookup cache does not
place on that path (a repeated id, or a cache older than the tree) is
still looked up by id, so the results, their order and the errors are
the same. Explicit ids given to the live commands drop nested ones with
a set as well.

With Select All of 102,200 objects (100,000 rectangles, 2,000 blends and
200 envelopes), a release build took a median of 16.5 ms of thread CPU
time for the Blend check before and 0.5 ms after.
2026-11-17 15:58:02 -08:00
dotCooCoo 1c89800023 Twist: keep fractional boundary tangents accurate 2026-11-17 15:34:20 -08:00
dotCooCoo f4359f39b9 Merge main into fix/twist-boundary-tangent 2026-11-17 13:42:02 -08:00
dotCooCoo 9591bdf68d Merge main into perf/inline-refresh-changed-subtrees 2026-11-17 13:30:42 -08:00
dotCooCoo 1ea1fd8556 Merge main into feat/transform-line-properties 2026-11-17 13:26:08 -08:00
dotCooCoo 7f92a8ec6e Merge main into fix/instance-row-effects-outline-hit 2026-11-17 13:13:10 -08:00
BFlat 1f84febb08 Merge pull request #8169 from dotCooCoo/fix/symbol-lookup-index
Symbols: render and SVG/PDF export find each instance's symbol in one index
2026-11-18 03:23:44 +07:00
BFlat 409b8ce9d1 Merge pull request #8058 from dotCooCoo/perf/selection-batch-toggle
Selection: select.toggle and select.add with many ids go through the selection once
2026-11-18 03:19:52 +07:00
dotCooCoo 0da5bf3a0b Select: Select Behind in isolation looks up the objects it found in a set
Each round of the repeated hit test that Select Behind uses in isolation
mode and in Edit Contents skipped the objects already found by searching
the found list, which made one Cmd/Ctrl-click cubic in the number of
objects under the point. A set beside the ordered list answers the same
lookups, so the objects and their order do not change.

A test compares the set lookup with the list lookup on random documents
for every object isolated in turn, and an ignored timing test measures
both on 200 and 1,000 stacked objects.
2026-11-17 11:44:23 -08:00
dotCooCoo 0b25050130 Twist: compute exact directional derivatives 2026-11-17 11:34:31 -08:00
dotCooCoo ba3c7197f7 Twist: preserve boundary tangents 2026-11-17 10:45:19 -08:00
dotCooCoo 24e0208d31 Type: inline graphics are checked again only in the layer trees an edit changed
After an edit of a document with symbols, the refresh of inline graphics
walked every node of every layer. It now keeps the document the last
refresh left resolved, with the symbol bounds it measured, and checks
only the layer trees that are not the same nodes as that document's,
as long as the symbols, graph designs, pattern tiles and foreign data
(which holds the symbols' natural sizes and 9-slice guides) are the
same and each measured symbol still measures the same. Otherwise the
full pass runs, as before. Visit order is unchanged, so the document
and the ids of the texts laid out again equal the full pass's.
2026-11-17 10:08:24 -08:00
dotCooCoo cd4e9e9506 Transform: a live line shows Line Properties with Line Length and Line Angle
A line drawn with the Line Segment tool now shows Line Properties in the
Transform panel and the Properties panel's Transform section, with the two
properties the help page lists for a line:
https://helpx.adobe.com/illustrator/desktop/draw-shapes-and-paths/modify-live-shapes/live-shape-properties.html

- object.setLiveShape takes lineLength (pt, above 0) and lineAngle
  (degrees, brought into 0 to 360). Every selected line changes in one
  undo step; a value that changes nothing records none.
- VectorCraft's own rules: the angle runs counterclockwise from 3 o'clock,
  as the Rotate field does; a new length keeps the first end in place and
  a new angle turns the line about its midpoint; a line whose ends meet
  reads 0 degrees; the section shows only while every selected object is a
  live line; a line that would reach past the coordinate limit is an error
  that changes no line.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-17 09:57:07 -08:00
dotCooCoo c226533bc9 Swatches: linking the selection's paints checks ancestors through a set
Add Used Colors and New Color Group link the selected art's paints to
global swatches through Document::map_solid_paints_in, which drops each
id that sits inside another listed id. It searched the whole id list for
each ancestor of each id, so the work grew with the square of the
selection. It now looks each ancestor up in a set of the ids, as
without_inner in crates/engine/src/cmd/edit.rs does. The roots keep the
order of the list, duplicates and ids missing from the document, so the
same paints are linked in the same order.

- mapping_within_ids_matches_a_search_of_the_ids compares the count, the
  paints visited and the resulting document with the search for every
  list of up to three ids from a nested tree (nested ids in both orders,
  duplicates, a missing id and an empty list).
- crates/engine/examples/link_colors_bench.rs times both ways in one
  process. With 20,000 selected rectangles the call takes 16 ms of CPU
  time instead of 128 ms; with 2,000 it takes 1.4 ms instead of 2.5 ms.
2026-11-17 09:49:45 -08:00
dotCooCoo 8038d7bf3a Symbols: drawn art keeps its evaluation as an Evaluated
The drawn-art store that main added for clicks now keeps its entries as
the shared Evaluated type, so a kept entry is also measured again when a
symbol's 9-slice guides or natural size change. Evaluated::new builds an
entry for both stores.
2026-11-17 08:46:06 -08:00
dotCooCoo 4d1a36fb34 Merge main into fix/instance-row-effects-outline-hit 2026-11-17 08:37:25 -08:00
dotCooCoo d63d45a0bd Merge main into feat/editable-flares 2026-11-17 07:01:52 -08:00
Don Omondi 4881a46f34 Merge remote-tracking branch 'upstream/main' into fix/twist-smooth-7069
# Conflicts:
#	docs/effects-parity.md
#	docs/target-app-parity.md
2026-11-17 08:33:56 -05:00
Hamza 957cd66a82 Scale Text Attributes: path type bakes only the uniform part of a scale
Type on a path sits at fractions of its path's length. Scaling the path
non-uniformly changes where a fraction lands (CodeRabbit's case: M0 0 L100 0
L100 100 under diag(2, 1) moves the start bracket from (200, 0) to (150, 0)).

Path type now bakes the vertical scale into the character sizes and scales
its path uniformly by it, which keeps every fraction where it was; the
horizontal stretch stays in the transform.
2026-11-17 14:17:49 +05:00
Hamza 586db4da06 Scale Text Attributes: an area's frame and a path type's path keep their size
Baking an object's scale into the character attributes removed that scale
from the type's transform, but the area frame (and a path type's path), which
is drawn through that transform too, kept its unscaled size. A 120 x 80 frame
scaled 200% shrank back to 120 x 80 on the page, so the 24 pt type broke into
two lines and the rest became overset.

The frame and the path now take the scale the transform loses, so they, the
line breaks and every glyph stay where they were.

Fixes #8297
2026-11-17 13:41:14 +05:00