A range, mixed or spinner field that committed text it could not read
(`abc`, `(10+5)*2`) returned nothing and did not mark the commit as
refused. Enter in such a field then confirmed an open dialog with the old
value, and in Save for Web's Optimize to File Size rows it ran the search
with the old size.
The field now refuses that text as unit fields do: it flashes, shows its
value again, and the Enter does not confirm the dialog.
The Arrow Style dropdown in Dimension Tool Options and in the Properties
panel's Dimension section showed only the names Filled, Open, Tick and
None. Each style now shows its arrowhead at the end of a short line
before its name, in the open list and in the closed field, drawn with
the Stroke panel's arrowhead previews. The four styles and their saved
values are unchanged.
ArrowStyle::arrowhead holds the style-to-arrowhead mapping, so the
dimension line and the preview use the same head.
dropdown_icon_names_sized takes an icon size that is not square.
Part of #8049.
A click on the Control bar's X:, Y:, W: or H: label, with objects selected
or with the Artboard tool, opens the Transform panel in a popover under the
label, as the Transform link does; a second click closes it. The help page
(https://web.archive.org/web/20210601162814/https://helpx.adobe.com/pdf/illustrator_reference.pdf#page=374)
describes these labels as another way to bring up the Transform panel.
The click no longer gives the field the keyboard. A drag on the label still
scrubs the field, and the labels are not tab stops, so Tab still moves from
one field to the next.
The Blob Brush Tool Options' tip preview draws a black dot at each end
of the tip's short axis and an arrowhead on its Angle line. A click or a
drag that starts within 8 pt of a dot sets the Roundness from the
pointer's distance from the center along the short axis, as a whole
percentage of half the tip's length (0% to 100%), and keeps doing so
past the square's edge until the release. A click or a drag that starts
anywhere else in the square still sets only the Angle.
The help page describes moving a dot toward or away from the center to
change the roundness:
https://web.archive.org/web/20220911143322/https://helpx.adobe.com/pdf/cs6/illustrator_reference.pdf#page=183
The dot placement, the mapping and the 8 pt reach are VectorCraft's own.
A dot gesture gives the keyboard focus to a new Roundness slider, which
screen readers get after the Angle slider and Tab reaches after it; its
arrow keys step the Roundness by 1% (10% with Shift, Home and End to 0%
and 100%). Every catalog gets a row for the slider's name.
A graphic style dragged onto another style in the Graphic Styles panel
with Alt held gives that style the dragged style's look. The replaced
style keeps its name, place and id, and the art still linked to it
takes the new look in one undo step; the dragged style and its art stay
as they are. Without Alt the style moves, as before.
graphicStyle.redefine takes {name, from} for this. A style dropped on
itself, or on a style with the same look, records nothing. A `from` that
names no style or is not a string, or `from` with `id`, is an error.
Art dragged off the canvas and released on a symbol's tile or row in the
Symbols panel with Alt (Option on macOS) held now runs Redefine Symbol
(symbol.update) for that symbol, in thumbnail view and both list views.
The symbol under the pointer is outlined while the art is held over it
with Alt. A drop without Alt still makes a new symbol.
- A canvas art drag records the document it came from; art of another
document, objects the document no longer has and an empty drag are
not taken.
- symbol.update refuses art that holds an instance of the symbol it
redefines, directly, in an opacity mask or through the art of the
symbols it nests, so neither the menu nor the drop can make a symbol
hold itself. The symbol-editing check shares the walk and now also
looks inside opacity masks.
- Panel art drops take only a release of the primary button.
Docs: docs/mcp.md, docs/target-app-parity.md.
Art dragged off the canvas, or the Appearance panel's thumbnail, dropped
on a style in the Graphic Styles panel with Alt held runs
graphicStyle.redefine with that style's name and the object's id (the
first object of the art), in one undo step. The style keeps its name,
id and place in the list, and the art still linked to it takes the new
look. The style is outlined while one is held over it with Alt. An
object already linked to the style with its look changes nothing.
Without Alt the drop still makes a new style, and a style dropped on a
style still moves it.
A symbol dragged from the Symbols panel carries the document it came from. Dropped on the canvas after another document became active, it no longer places a same-named symbol of the active document: symbol.placeFromDocument adds the dragged symbol, with the symbols and resources its art uses, and places it in one undo step. A symbol with the same name, art and Symbol Options is reused; one with the same name but other art or options is added under a free name. The pointer chip shows the dragged symbol, and a symbol whose document was closed places nothing.
The harmony strip and the variation cells start a paint drag with the
primary button. The drag carries the grabbed color as the cell shows it
(snapped to the Limit to Library colors), and the Swatches panel's
existing drop makes a swatch of it with swatch.new: one undo step, the
color's own model, a drop on a color group joins that group, and a color
that is already a swatch is added again under another name. Starting a
drag does not apply the color or change the base or the selected cells,
and a plain click still applies the color as before.
The rows of Select by Artboards and the Variables panel, and every
collapsible section header, reported their state through
`WidgetInfo::selected`. egui writes that value as the node's toggled
state for every role, so the accessibility tree showed these rows and
headers as toggled. AccessKit keeps a list item's selection in its
selected property and a disclosure control's state in its expanded
property.
- `widgets::list_item_info` gives a row the list item role and sets its
selected property, and both lists use it.
- `section_toggle_name` sets the header's expanded property, as egui's
own collapsing header does.
- Tests draw both lists and a section header and check the role and
state of each node in the accessibility tree.
Comments in the ui-egui crate described panels, menus, dialogs, widgets
and cursors by comparison with other applications ("as in ...",
"...-style", "like ...'s"). They now say what VectorCraft does. The
section header for raster effects in nine translation catalogs changes
the same way.
The change edits comments only. No code, string or catalog row changes.
A button under the Add Color and Remove Color tools switches both Edit
tab wheels between hue with saturation and hue with brightness. On the
brightness wheel a marker's distance from the center is its brightness
(black at the center, full at the edge), a drag sets hue and brightness,
the slider under the wheel edits saturation, and Add Color adds the hue
and brightness clicked at the base color's saturation. The segmented
wheel's five rings become brightness steps. Switching changes no color,
the button is off for the color bars, and each opening shows hue and
saturation. The dialog field is `wheelAxes` (`hueSaturation`,
`hueBrightness`).
Type › Size ends with a separator and Other…, which runs the new UI
command type.highlightFontSize. It shows the Character panel and gives
its Font Size field the keyboard focus with the value selected, so a
size the list does not hold can be typed and applied with Enter.
Without selected type it fails with the existing error, as Highlight
Kerning does, and the menu item is dimmed, as Bold and Italic are.
The Font Size field now takes an armed focus: unit_field_from selects
and focuses the field as bounded_field_reading already does.
Docs: docs/mcp.md, docs/target-app-parity.md.
- Screen readers now call the search icon "Search commands" with the
shortcut, as they call the field; its tooltip stays "Search commands
and tools". paint_icon_button_named gives an icon button a name apart
from its tooltip.
- While a dialog is open the field and the icon are drawn disabled and
screen readers report them disabled, since a click on them does
nothing then.
- The titlebar test now checks that the field shows "Search commands" in
a wide window, and its comments describe the field.
- The fitting code and its tests call the community button's width and
flag `community`, and the new struct fields have doc comments.
- The new "Search commands" catalog rows move a few rows down, next to
"No recent commands" or "Switch workspace", away from the rows other
open pull requests change.
- The docs line says the app's existing rule for a focused control keeps
the app's keys off while the field has the focus, and that the
community button and Explore tutorials go at wider bars than they did
beside the icon.
Main's New Row and this branch's Add Color tool both make rows with no
current colors. A row made with New Row gives a rewritten color group no
color, and a color the Add Color tool adds joins the group. Rows the Add
Color tool adds now carry `added: true`: recolor.apply's default
groupColors and the dialog's apply_params add only those empty rows'
colors to the group, after the others, and recolor.randomize keeps the
flag.
The comments added with the Add Color and Remove Color tools spell color the American way, and the test comment for the second Add Color click describes the click the test makes.
Two buttons under the display buttons beside the Edit tab's wheel turn on
the Add Color and Remove Color tools. With Add Color, a click on either
wheel adds a color in a new row with no current colors, at the base
color's brightness. With Remove Color, a click on a marker removes that
color; a color bar's right-click menu has Remove Color too. The base
color can't be removed. With art or a color group open, a removed
color's row keeps its current colors with no new color, so the art keeps
its colors and the group's swatch at that place is removed.
recolor.apply's groupColors accepts null, which removes the group's
swatch at that place; the swatches after it keep their colors and names,
and art linked to a removed global swatch keeps its color, unlinked.
The groups that other modules draw in the Control bar (shape tool,
Dimension, Mirror & Cut, Crop Image and Puppet Warp options, image and
Image Trace controls, envelope and symbol instance controls, and the
Artboard tool's) drew fixed-width controls with no room check, so in a
narrow window they ran past or under the panel menu button.
- Each group asks a shared Fit for room before each control, leaving the
Transform link's room after it, and leaves out the rest of the group
once one control does not fit. An image's file name is left out alone,
each of the Embed, Edit Original and Unembed buttons is checked on its
own, and the Artboard tool's Transform link shows whenever it fits.
- Buttons in these groups grow to hold longer translated labels.
- The Transform link keeps room for its underline.
- Trailing spacing in the envelope and symbol groups no longer pushes
the panel menu button out of the bar.
Docs: docs/target-app-parity.md.
In a window narrower than a popup list's rows (Add New Effect, Tracing
Presets and the other lists built on menu_scroll), the list kept its rows
at full width and the popup ran past the window's right edge. The list is
now no wider than the window allows; a row that does not fit ends in an
ellipsis and shows its full text in a tooltip, dimmed rows included.
Screen readers and clicks still use the row's full text.
Menus that ask for a minimum width (the menu bar's 230 pt, submenus and
context menus) take the window's width when it is less, through
menu_min_width.
The long-popup tests now check that the popup ends inside the window,
and a new test covers a shortened row's tooltip, screen-reader name and
click.
Object › Plug-ins › Unit Converter › Unit Converter Panel opens a panel
with one number field per unit of Preferences › Units › East Asian Type
(pt, picas, in, mm, cm, px, ft & in, m, yd, ft, Q, Ha). A length typed in
any field, with units and arithmetic as every number field reads them,
updates the others as it is typed; text that does not read leaves them as
they were. From Selection reads the selection's width and height as the
Transform panel measures them, and Width or Height picks which one the
fields show; the size read is dropped when the document, its selection,
Use Preview Bounds or Measure Type by Glyph Bounds changes. Apply sets
that side through object.setBounds as the Transform panel's W or H field
does (its reference point, Constrain Width and Height Proportions and
Transform Object Only, Pattern Only or Both), as one undo step, and adds
none when the size is already that length. Each field's copy button
copies its value, with its unit when Copy with Units is on, and is named
with its unit for screen readers.
- addon.units.convert {value, unit?} gives a length in every unit, and
addon.units.selectionSize {} gives the selection's width and height the
same way. Neither changes the document. convert reads at most 1024
bytes and 128 + - * / signs.
- The decimal comma rule of the number fields moves from ui-egui to
vectorcraft_doc::decimal_point, so the command reads "0,5 mm" as the
fields do.
- The Transform panel's pattern switches are built by
with_pattern_switches, which run_transform and Apply share.
Closes#5528, as proposed by @ruchirguitar.
With a None fill, a set-value action, a key or an increment on the box
view's channel strip that leaves the number at the last solid color's
value now sets the fill, as the field and the hue ring do.
The Color Wheel panel's menu gains Wheel View and Box View, and Box
Channel with Hue, Saturation, Brightness, Red, Green and Blue while the
box shows. The box takes the wheel's place: a color field with a 22 pt
channel strip at its right. The field shows the other two components on
the Color Picker's axes (Hue: saturation across and brightness up; Red:
blue across and green up). A click or drag in the field sets those two,
and the strip sets the channel; a drag is one undo step, and picks go
through the same paint commands and color model rules as the wheel's.
With no color to edit, the field and the strip show no markers and read
0 to screen readers, as the wheel does.
ui.colorWheel {view?, channel?} sets the view and the channel and
returns them. Params that are not an object, another key or a value off
the list are an error and change nothing. Both settings are kept with
the preferences, and a saved value the build does not know reads as
that key's default without losing the other preferences.
The strip takes the arrow keys after a click and offers screen readers
its increment, decrement and set-value actions. The Color Picker's
channel slider uses the same widget, so it now takes the arrow keys and
offers those actions too. New strings have rows in the complete
catalogs, and docs/mcp.md and docs/control-protocol.md describe the
command.
Text Wrap Options showed Offset as a plain number in points. It is now a
distance field in the document's General unit: a bare number is in that
unit, a typed unit is read as typed, and OK sends points.
The field's range is the one object.textWrap.options keeps an Offset to,
-1000 to 1000 pt, read from the engine's TEXT_WRAP_OFFSET_RANGE. A value
typed outside it, or text that doesn't read, is refused: the field
flashes and the dialog stays open. The ends as the field shows them in
another unit (352.7778 mm for 1000 pt) read back as the ends.
In the dialogs drawn by the shared dialog window, a click on OK no
longer confirms the dialog when the field it takes the focus from
refuses its text, as Enter already did not. OK pressed from the keyboard
after such a click still confirms.