Commit Graph
32 Commits
Author SHA1 Message Date
BFlat 783f09d3b2 Merge pull request #8004 from dotCooCoo/fix/hit-test-follows-geometry-effects
Selection: clicks and marquees follow an object's own geometry effects
2026-11-16 09:31:55 +07:00
dotCooCoo 963c06620e Selection: clicks and marquees follow an object's own geometry effects
A click or a marquee with the selection tools now finds a path or compound
path where its live geometry effects draw it, the copies a Transform effect
makes included, and not where its own geometry no longer paints.

- The engine registers its Use Preview Bounds evaluator with
  `vectorcraft_doc::hit::set_drawn_art`. Hit testing keeps the evaluated art
  per object, evaluates it again when the object, the document's symbols,
  patterns, swatches or live inputs change, and widens each object's cull box
  by the art its effects draw.
- Groups and layers with geometry effects or fills and strokes of their own
  are hit through their evaluated art. Clicks, Select Behind, the locked
  objects under the pointer and marquees map the art back to the members it
  is drawn from, at the depth each tool selects, and Direct Selection takes a
  group whose own paint the art draws.
- Clipping paths keep their own geometry, except that a clip group's own
  effect moves where its mask outline is taken. An isolated clip group's
  members are marqueed by their own geometry, as clicks take them. A clip
  group whose evaluated art holds only its clipping path is tested member by
  member.
- Outline view uses the plain paths, and a layer with Preview off is clicked
  in outline. Intertwine groups keep their woven hit order.

Docs: docs/target-app-parity.md.
2026-11-15 15:50:59 -08:00
BFlat c514c88286 Merge pull request #7881 from dotCooCoo/fix/select-behind-one-art-limit
Selection: Select Behind keeps one limit of symbol art when it falls back
2026-11-16 04:29:02 +07:00
dotCooCoo 521f5dc6c8 Selection: Select Behind keeps one limit of symbol art when it falls back
Select Behind gave the general traversal a fresh limit of symbol art when
it fell back to it, for an envelope in Edit Contents or a root that is
not a layer. One Select Behind could then walk twice MAX_SYMBOL_NODES
objects of symbol art.

A root that is not a layer now sends Select Behind to the general
traversal before the first pass walks any art. For an envelope in Edit
Contents, the objects the first pass found stay first, and the general
traversal finds the rest with what is left of the limit.
2026-11-15 08:30:27 -08:00
dotCooCoo 74bf5c2618 Selection: an Intertwine group's members in symbol art count toward a click's object limit
A click walks a symbol instance's art within one limit of objects, but
the members of an Intertwine group in that art, and the objects of groups
nested deeper than the part path depth, were tested without taking from
it. Each object hit_any visits in placed symbol art now takes one object
from the limit, and testing stops once the limit is used up.
2026-11-15 06:36:16 -08:00
dotCooCoo 20743f4a94 Selection: a nested symbol instance's box past the outer box is not a hit
A click or marquee outside a symbol instance's box walks the instance's
art. An instance nested in that art was hit or touched anywhere in its
own box, so empty space inside the nested box, where a moved clipping
path reaches past the outer box, selected the outer instance. In that
walk a nested instance now counts only where its own art is, by the
same rule at every level. Inside the outer box nothing changes.
2026-11-15 02:01:56 -08:00
dotCooCoo 9c377b5619 Selection: one limit on the symbol art a click or marquee walks
A click or marquee outside a symbol instance's box walks the instance's
placed art, and an instance nested in that art walked its own art with
no shared limit, so deeply nested or widely repeated instances could
make one click walk far more objects than the canvas draws.

Clicks, Select Behind, the locked-object and hidden-selection lookups,
Direct Selection's part lookup and marquees now share one limit of
MAX_SYMBOL_NODES objects across every level of nested art. Once it is
used up, an instance is no longer hit or touched outside its box;
inside its box it still is. The art walk also checks the instance's
reach before starting.
2026-11-15 01:43:18 -08:00
dotCooCoo a4df0015c0 Selection: test that a symbol instance is hit on its art's stroke past its box
A click on a stroke of a symbol's art where it paints past the
instance's box selects the instance; past the stroke, and in Outline
view, it does not. The progress line names the new test.
2026-11-14 19:35:07 -08:00
dotCooCoo 4f60e14555 Selection: symbol instances are hit where their art draws past their box
A click on a symbol instance hit only its art's geometric box, and a
marquee touched only that box, so art that a clipping path's live
geometry effects move past the box could be seen but not selected.

- Outside its box, in Preview, a click hits an instance where its placed
  art hits (dynamic overrides and 9-slice placement included), and a
  marquee touches the placed art as it touches a group of that art.
  Outline view and layers with Preview off keep the box alone.
- The quick reach of an instance takes in the regions of the clipping
  paths with live effects in its art, so the groups around it no longer
  cull those clicks.
2026-11-14 16:51:33 -08:00
dotCooCoo cf8b88b0ea Merge main into fix/clip-effects-hit-test 2026-11-14 12:59:50 -08:00
dotCooCoo 3534dd7343 Symbols: measuring and picking in 9-slice instances reuse one set of symbol boxes
Measuring an instance of a symbol with 9-slice guides looked its map up
through Document::symbol_slice_map, which scanned the symbol list and
measured the art box again in new quick boxes, and NineSliceMap::place
and most_placed made new quick boxes of their own. Each of those boxes
built the symbol name index over the whole list on its first lookup, so
every 9-slice instance measured read every symbol once or more. Picking
an object inside a 9-slice instance's art with Direct Selection did the
same for each object of the art that holds a symbol instance.

- SymbolBoxes cuts the guides through the art box it has measured
  (SymbolBoxes::slice_map), and places and counts the art with itself as
  the boxes, in the mode quick boxes use. Art with no 9-slice map is
  moved by the instance's transform without looking the map up again.
- Document::symbol_slice_map, place_symbol_art,
  place_symbol_art_unclipped and edited_nine_slice use one set of quick
  boxes for each call.
- symbol_part_at and symbol_part_outline keep one set of quick boxes
  for the instance's art.

The new tests count the symbols read. Measuring 200 instances of a
symbol with guides and 200 of a symbol with guides holding it, among
2,002 symbols, read 1,205,204 symbols before; now each set of boxes
reads the list once. Picking in a 9-slice instance whose art holds 20
instances read 84,042 symbols among 2,001; now it reads the list at
most twice.
2026-11-14 10:32:20 -08:00
dotCooCoo 1d94c97425 Selection: symbol parts count the Preview of the instance's layers
Direct Selection on a dynamic symbol's instance below a layer whose
Preview is off tested and outlined the art in Preview, where the canvas
draws it in outline with the plain clipping paths. When a clipping
path's effects left no region, a selected object in its clip group kept
an outline cut to the plain clipping path.

- `hit::symbol_part_at` and `hit::symbol_part_outline_in_view` count the
  layers around the instance, the isolated container and the layers
  around it apart, as clicks outside symbols do.
  `symbol_part_outline_in_view` takes the click options in place of the
  outline flag.
- The outline of an object is empty when the effects of a clipping path
  around it leave no region.
2026-11-14 09:30:12 -08:00
dotCooCoo 11bd1659f5 Selection: symbol parts follow the region a clipping path's effects give it
Direct Selection on a dynamic symbol's instance picked an object in the
region its clipping path's effects give it, but cut the object's outline
to the plain clipping path, so the outline came out empty or cut short.
In a layer of the art whose Preview is off, it tested the effect-shaped
region and the fills, where the canvas draws the plain clipping path and
outlines.

- `hit::symbol_part_outline` cuts to the bounds of the effect-shaped
  region. The new `hit::symbol_part_outline_in_view` takes the view's
  outline state, and the Direct Selection overlay passes it.
- `hit::symbol_part_at` tests art in a layer whose Preview is off in
  outline.
2026-11-14 08:51:22 -08:00
dotCooCoo 8fa551e173 Selection: clicks in a clip group follow the region its clipping path's effects give it
The canvas clips a clip group by its clipping path with the path's live
geometry effects applied, but clicks, hovers and marquees still tested
the plain clipping path. A click where a Transform effect had moved the
clip selected nothing, and a click on the clipping path's own place
selected art that was not drawn there.

- The engine registers the effect-shaped region with the doc crate
  (`hit::set_clip_region`), as it does for image paint and live art. It
  gives a region only when the clipping path holds a visible geometry
  effect; otherwise clicks keep the plain shapes, and type keeps
  counting by its frame.
- Clicks, `objects_at`, the hidden art of a selected object, the Unlock
  submenu's list and marquees inside a clip group or a clipping layer
  use that region. Outline view and layers with Preview off draw no
  effects and keep the plain shapes; the Selection, Direct Selection
  and Enclosing Lasso marquees pass the view's outline state
  (`hit::marquee_in_view`). Each container around a selected object
  tests its clipping path in the outline state a click has there.
- A marquee touches the clipping path itself by its own geometry, as a
  click on its outline finds it, and also on the edge of the region, so
  a marquee around a clipping path that an effect moved into large art
  still selects it. `hit::marquee_in` keeps the plain shapes for the
  Color Theme Picker, which clips by them.
- The region is kept per thread until the clipping path or the live
  inputs change. A clip group's reach takes in the region's box, so
  culling does not skip art the region moved past the plain clipping
  path. Up to 4096 boxes are kept; when they are full, a new box
  replaces only as many others as it needs room for.

Docs: docs/target-app-parity.md.
2026-11-14 04:08:03 -08:00
dotCooCoo e609b26a95 Warp: bend each style as one Bézier patch, and keep saved warps' look
Each of the fifteen Warp styles now bends the bounds as one Bézier patch.
The style sets the patch's control points from the bend and the size of
the bounds, the horizontal distortion scales each column of control
points about its middle, and the vertical distortion scales each row.
The Warp effects and warp envelopes share the map (`WarpNet`). Content
with no width or no height takes the middle of the patch along that
side.

A warp carries the map it draws with as `version`. New warps, the
built-in graphic styles' Warps and warps opened from .ai files get 1.
Warps in .vectorcraft documents saved before the version existed read
as 0 and keep the earlier map, so those documents keep their look.
Edits keep a warp's version, and Warp Options editing several objects
keeps each one's own. effect.apply, effect.setParams and the warp
envelope commands take `version` 0 or 1 (`1.0` counts as 1) and refuse
any other value. An .ai file holds a warp's settings and not its
version, so a version 0 warp saved to .ai opens again with version 1.
The .ai writer compares a style's settings without the version, so
saved warps still export as editable effects.

Docs: docs/mcp.md (Envelopes), docs/effects-parity.md (Warp),
docs/target-app-parity.md.
2026-11-11 19:40:01 -08:00
HassanKhan a87d996e1d Outline view: a click on a path's outline selects it through an image or a gradient mesh in front (#6437)
In Outline view an image was still hit anywhere inside its box and a
gradient mesh inside its fill, though Outline draws only the image's
frame and the mesh lines. A path behind them could not be picked there.
Now an image is hit on its frame (unless Show Images in Outline Mode
draws its pixels) and a mesh on its edge and mesh lines. Preview is
unchanged.
2026-11-11 16:38:59 +05:00
dotCooCoo f29c75a231 Plug-ins: hit tests re-evaluate live art when a swatch or color group changes
A painted live effect's pieces name swatches, so a kept evaluation could outlive a swatch that was renamed or removed and answer a click with art the document no longer draws. The kept evaluation now holds the document's swatches and color groups and is stale when they change.
2026-11-08 19:13:37 -08:00
dotCooCoo e7c381a53f Merge main into fix/issue-3748-r
# Conflicts:
#	crates/doc/src/hit.rs
2026-11-08 13:14:33 -08:00
dotCooCoo 434c032f9e Symbols: Direct Selection sets the solid fill and stroke of one object in a dynamic instance
Squashed from #5962 onto main.
2026-11-09 00:26:11 +07:00
dotCooCoo 0416f115e0 Speed up hover hits on long plain paths 2026-11-06 11:00:14 +07:00
Ahmed Gomaa f0e72fb11a Selection: a click on a large compound path is culled by its control points
Every click and hover measured each path and compound path along its
curves to cull it (Node::reach_bounds_with), and a compound path was
then assembled whole to test its outline and fill. For a compound path
of thousands of members that took milliseconds per click.

Hit testing now culls paths and compound paths by the box of their
control points (which holds the curves), grown by their strokes' reach,
so the box is never smaller than the reach box it replaces. A compound
path's outline and fill are tested against only the members whose
control box, grown by the tolerance, holds the point: a member outside
that box is farther than the tolerance and winds zero times round the
point. Painted strokes still follow the whole compound path (alignment,
dashes, width profiles) and are measured along all of it, as before.

Tests (crates/doc/src/hit/tests.rs):
- a 2,000-member compound path hits exactly as the whole-path test did,
  at random points, on and next to anchors and on the edges of the
  members' boxes, for both fill rules, in Outline view and with Object
  Selection by Path Only;
- wide strokes painting past the control points are still hit, for a
  path and a compound path;
- the cull box holds the reach box for paths and compound paths.

Measured in a debug test build (one run, machine not idle): a click on
a 20,000-member compound path went from about 18 ms to about 1 ms.
vectorcraft-cli perf was not rerun.
2026-11-03 16:03:40 +07:00
dotCooCoo e725c4920c Tests: nested clip groups in isolation mode and Direct Selection drags
- isolation_reaches_hidden_art_only_for_the_isolated_clip_group: with the
  outer clip group isolated, clicks and marquees take the art its own mask
  hides, while an inner clip group's mask still clips that group's art;
  isolating the inner group or its art reaches the inner hidden art.
- isolation_lets_direct_selection_take_the_art_a_clip_group_hides now
  continues the press with a drag on the same tool and checks the Move
  step and its preview, for Direct Selection and Group Selection.
2026-10-31 22:26:08 -07:00
dotCooCoo 8362b7532c Eyedropper: Shift-click samples a blend's steps and an envelope's distorted art
Squashed from #4949 onto main.
2026-11-01 09:24:18 +07:00
bflatastic f22caa6108 Fix #4938: Dynamic symbols keep per-instance appearance linked to the symbol 2026-11-01 04:53:38 +07:00
dotCooCoo b6ab547f1f Merge main into fix/issue-3748
# Conflicts:
#	crates/tools/src/select/tests.rs
2026-10-30 22:48:55 -07:00
nevaremandClaude Opus 5.5 87fc61df79 Selection: a selected object's masked art is reached the way a click goes
The check of a selected object's masked art looked at its own place
only. A click goes down from the layer (or the isolated container) and
never reaches a Shaper group's original shapes outside Construction
mode, however deep the object lies in them; and below a layer whose
Preview is off it hits art in outline. A press inside such a path's
fill, or on a path in a Shaper group's hidden shapes, started a move.

The way down to the selected object is now checked as a click goes:
a Shaper group's part a click can't reach on it rules the object out,
and a Preview-off layer on it (below the isolated container) makes the
object count by its outline.

Tests also cover Shift with Direct and Group Selection (a marquee) and
an object a click hits over the masked art (it is selected).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EjfPR4a1jPek7r3nyFFNYv
2026-10-29 18:46:47 +07:00
nevaremandClaude Opus 5.5 f793547a7f Selection: a selected object's masked art counts only where a click reaches it
The selected object itself was checked for being hidden, locked or a
template, but not as a click checks it: a selected guide path was
grabbed where a mask hid it while guides were locked or hidden, though
a click on it there hits nothing.

The selected object now passes the same test a click applies to it
before its art is tried: guides while guides are locked or hidden, and
a Shaper group's hidden part, don't count.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EjfPR4a1jPek7r3nyFFNYv
2026-10-29 18:46:47 +07:00
nevaremandClaude Opus 5.5 6ecea97fdb Selection: a selected group's masked art counts only where a click hits
A selected group was grabbed by any of its contents under the pointer
where an outer mask hides them, including a hidden or locked child and
art the group's own clipping mask leaves out: none of these is drawn or
hit by a click.

A container's art now counts as a click would hit it: its contents as
the hit test tries them, through its own mask and without its hidden,
locked or template contents. The check for locked objects shares it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EjfPR4a1jPek7r3nyFFNYv
2026-10-29 18:46:47 +07:00
nevaremandClaude Opus 5.5 4cd9afe67c Selection: a press where a mask hides a selected object's art grabs it
An image in a clipping mask, picked in the Layers panel, shows its
whole frame, but a press on the part the mask hides hit nothing: the
Selection, Direct Selection and Group Selection tools started a marquee
there, which dropped the selection, so the image could be dragged only
by the part that shows.

Such a press now grabs the selection by that art, as a press on its
visible part does: a drag moves the selected object (the image, not its
clip group) and a click keeps it selected. With nothing of it selected
there, or with Shift, a press there starts a marquee as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EjfPR4a1jPek7r3nyFFNYv
2026-10-29 18:46:47 +07:00
dotCooCoo d0cb4e3cc7 Merge main into fix/issue-3748 2026-10-28 01:22:42 -07:00
aiongg f1d427762b style: cargo fmt on files moved without formatting 2026-10-26 19:32:10 +00:00
aiongg 8efb850d6d refactor(doc): move hit.rs tests to hit/tests.rs 2026-10-26 18:18:17 +00:00