Commit Graph
154 Commits
Author SHA1 Message Date
dotCooCoo 886c7bef8c Merge main into fix/graph-axes-group-edits-kept 2026-11-15 13:41:56 -08:00
dotCooCoo d39334a751 Graphs: a row written to an axis line is kept for its kind
appearance.addFill and appearance.addStroke on an axis line, tick mark
or radar ring stored only the attributes the new row changed on the
line, so a stroke the kind kept from another line came back when the
graph was drawn again, although the line showed the new black stroke.
They now store the row they add for the line's kind when it becomes the
line's topmost visible row of its kind.

An appearance.copyFrom of some attributes, appearance.setItem and
stroke.set stored only what they changed, so a paint, stroke weight,
row opacity or blend mode that the line already showed did not replace
what its kind kept. What they write to the line's topmost visible rows
is now stored for the kind, as paint.setStroke stores the paint it
writes. Row opacity and blend mode are stored apart, so an edit of one
leaves the other as the kind keeps it, and a null weight or opacity
writes nothing.
2026-11-15 08:25:21 -08:00
dotCooCoo 7c82381f5b Merge main into fix/graph-axes-group-edits-kept 2026-11-14 21:46:50 -08:00
dotCooCoo 93789dd3e3 Merge main into fix/graph-design-art-paint 2026-11-14 21:45:07 -08:00
dotCooCoo 2b164f6138 Merge main into fix/graph-design-art-paint 2026-11-14 20:04:05 -08:00
dotCooCoo 3925b0c716 Merge main into fix/graph-axes-group-edits-kept 2026-11-14 20:03:31 -08:00
dotCooCoo 39a4de61cb Merge main into fix/aligned-paint-rows-of-design-art 2026-11-14 20:00:33 -08:00
dotCooCoo b1acfaf5d4 Merge main into fix/aligned-paint-rows-of-design-art 2026-11-14 19:10:09 -08:00
dotCooCoo 6aab3e3280 Merge main into fix/graph-design-art-paint 2026-11-14 19:05:44 -08:00
dotCooCoo 63aeb358c9 Graphs: proxy recolors keep a group's own paint and spread checks on design art alone
paint.invert and paint.complement without an item recolor a given group's own fills and strokes with the objects inside it again, except with target "contents", and leave the art of graph designs inside it as it is. A given member of a compound path stands for the compound path.

paint.editGradient with a spread or a negative aspect for design art alone no longer checks it against the kind of the default gradient, so it changes nothing instead of failing. A bad value is still an error.
2026-11-14 19:05:43 -08:00
dotCooCoo f20fc32c3d Graphs: a fill or stroke added to a label or axis line keeps the other kind its kind keeps
graphicStyle.apply with add, and appearance.copyFrom with append, stored
both the fill and stroke rows a graph label or axis line showed, so a
fill-only style added to one axis line replaced the stroke the axis lines
kept from another line with the line's own black stroke. They now store
only the kinds of row they add; the row of the other kind keeps its paint
and its place relative to the characters as the kind keeps them.

appearance.moveItem of the Contents row stored the rows of every label
it was given, so a move that changed nothing on a label replaced what its
kind kept from another label. It now stores rows only for the labels
whose rows it changed.
2026-11-14 18:23:06 -08:00
dotCooCoo f6ecf49a19 Graphs: Invert, Complement and stroke weights of a design's art alone leave the new-art defaults
With only the art of a graph design in a series given or selected, paint.invert and paint.complement without an item recolored that art and remembered its new color, and stroke.set with a weight set the stroke weight for new art. Invert and Complement now leave the art out, as they do with an item, also when they are given the whole graph or a series group, and with only design art they change nothing. stroke.set with only design art leaves the weight for new art as it is.

An item the art has no row of that kind for is still an error in the commands that leave the art out, as on any other object, and so is a bad aligned or target param. Without stroke, paint.editGradient and paint.setGradientGeom read the kind of an item named on design art alone from that art's row.
2026-11-14 18:04:28 -08:00
dotCooCoo 43c67bca36 Merge fix/graph-axis-paint-kept into fix/graph-axes-group-edits-kept
Takes #7375's later fixes: Move Appearance onto an axis line behind its
source, picks and added styles without transparency, Default Fill and
Stroke on an axis line, and edits that keep only the line attributes they
change. Aligned row edits, hidden rows, reorders and Default Fill and
Stroke on labels keep this branch's behavior.
2026-11-14 16:45:22 -08:00
dotCooCoo 2d790aab20 Merge main into fix/graph-design-art-aligned-rows 2026-11-14 16:21:34 -08:00
dotCooCoo ceace52af5 Merge main into fix/graph-axes-group-edits-kept 2026-11-14 15:13:45 -08:00
dotCooCoo 9d1091331c Graphs: a reorder that changes no row keeps the line rows its kind keeps
A no-op appearance.moveItem on a graph axis line or label replaced the
rows its kind keeps with the line's own. The reorder now keeps rows only
for the lines and labels whose rows it changed.

text.setStyle keeps the default label style for a kind only when the
command gives a character attribute; justify-only and empty
featureChanges requests record nothing.
2026-11-14 15:07:45 -08:00
dotCooCoo 031fb6565e Appearance: aligned edits with a graph design's art follow the art's stack
- appearance.moveItem with from "contents" and aligned: true is refused when
  the objects' stacks differ, as it is for rows.
- paint.invert and paint.complement with an item remember the paint of an
  object they recolored, not that of design art they left out.
- effect.remove and effect.duplicate with indices and aligned: true are an
  error, and change nothing, when the design art given first has no effect
  at one of the indices.
2026-11-14 13:17:29 -08:00
dotCooCoo 289fb4b770 Graphs: a pick or added style without transparency keeps the opacity a line or label kind keeps
A whole pick of every fill and stroke attribute, or an append pick, onto
a graph's axis line, tick mark or radar ring stored the line's rows in
full, object opacity and blend mode included, even when the pick did not
apply the object's transparency. On a line that still showed 100% until
the graph was drawn again, that replaced the opacity its kind kept (40%
set on another line became 100%). An append pick onto a graph label, and
graphicStyle.apply with add on a label or line, did the same.

Without Transparency applied, these picks, and a style added on top, now
store the fill and stroke rows and leave the kept object opacity and
blend mode as they were.
2026-11-14 12:48:02 -08:00
dotCooCoo 6a895f1a3b Merge main into fix/graph-design-art-paint 2026-11-14 12:23:42 -08:00
dotCooCoo cc26358b9f Graphs: an appearance moved to an axis line behind its source is kept
Move Appearance captured the cleared source and the targets together, and
graph lines are captured in paint order, so a source in front of its target
replaced the kept axis rows with its cleared ones. The targets are now
captured again after the source.
2026-11-14 12:06:53 -08:00
dotCooCoo 771b4e54b5 Graphs: invert and complement remember the equal row they recolor; document aligned
With a mixed selection and the Appearance panel's active row, paint.invert
and paint.complement recolor each object's row equal to the active one,
but remembered the color at the active row's index in the first object in
paint order, which can be another row. They now remember the row they
recolor there, as the gradient and freeform edits do.

The params text of paint.setFill, paint.setStroke, paint.invert,
paint.complement, paint.lastColor, paint.lastGradient, stroke.setAdvanced,
paint.editGradient, paint.setGradientGeom and the paint.freeform edits now
lists `aligned`. docs/mcp.md names paint.lastColor and paint.lastGradient,
which take the same rows as paint.setFill, and docs/target-app-parity.md
gets a line for the rows of a design's art.
2026-11-14 11:14:22 -08:00
dotCooCoo 3b1c068f30 Merge main into fix/graph-design-art-aligned-rows 2026-11-14 09:57:39 -08:00
dotCooCoo c8f046c74d Merge main into fix/aligned-paint-rows-of-design-art 2026-11-14 09:00:08 -08:00
dotCooCoo 90a2bd0494 Graphs: aligned paint and stroke rows given with a design's art are rows of its stack
paint.setFill, paint.setStroke, paint.invert and paint.complement with an
item, stroke.set, stroke.setAdvanced, paint.editGradient,
paint.setGradientGeom and the paint.freeform edits read an item given with
aligned: true and the art of a graph design in a series first as a row of
the art's stack, as appearance.setItem and transparency.set do. Each other
object edits the row equal to it and an object without one is left as it
is. A row the art does not have, a row of the other kind, or a row no
other object has is an error, also when the art is the only object given,
and the document and its undo history stay as they are. Without stroke,
the gradient commands edit the kind of the art's row.

The objects and ids the commands report, a gradient spanning the
selection, and the last color and last gradient count only the objects
whose row was edited.
2026-11-14 08:54:28 -08:00
dotCooCoo d233cd8291 Merge main into fix/graph-series-group-opacity 2026-11-14 05:57:05 -08:00
dotCooCoo f4281d3cc0 Graphs: test the effect edits on rows of a design's art, document aligned on effect.apply
effect.apply and appearance.addEffect take `aligned`, and their params
text now says so, with the rule for a graph design's art given first.

The tests add appearance.addEffect, a 3D effect.apply with an object
that has no equal row, effect.setParams and effect.duplicate on a row
of the art, and the removal of an object-level effect equal to the
art's. They also check that appearance.setItem and appearance.removeItem
on a row no other object has leave the art as it is and record no undo
step.
2026-11-14 04:18:45 -08:00
dotCooCoo 9b65454983 Graphs: aligned rows given with a design's art stay rows of its stack
The Appearance and effect commands leave the art of a graph design in a
series out, and aligned rows were then matched against the first object
left over. With the art given first, appearance.removeItem with index 1
and aligned: true on art [red fill, blue fill] and a mark [blue fill,
stroke] removed the mark's stroke instead of its blue fill.

When the first object given is design art, rows and effects given with
aligned: true are now rows of the art's stack, and each other object
edits the row or effect equal to it. An object without one is left as
it is. This covers appearance.setItem, appearance.removeItem,
appearance.duplicateItem, transparency.set with an item, effect.apply,
appearance.addEffect and the effect commands that edit or remove an
effect. When no object has one, appearance.setItem and
appearance.removeItem change nothing, as they do for a row no object
has, and the other commands are an error. appearance.moveItem,
effect.move and appearance.duplicateItem with `to` compare the art's
stack too, and are an error when it differs from the other objects'.
The effect dialog reads the effects of such a row from the art's stack,
and passes the art on with the other objects.

docs/mcp.md states the rule.
2026-11-14 03:39:54 -08:00
dotCooCoo e4227d1d5b Merge main into fix/graph-axis-paint-kept 2026-11-14 03:29:24 -08:00
dotCooCoo 3fb2287d02 Merge main into fix/graph-axes-group-edits-kept 2026-11-14 02:34:24 -08:00
dotCooCoo bf3a23d031 Merge main into fix/graph-label-paint-recolor 2026-11-14 02:19:54 -08:00
dotCooCoo ded56d3d70 Merge main into fix/graph-series-group-opacity 2026-11-14 02:15:46 -08:00
dotCooCoo 6344e07ad1 Merge main into fix/graph-design-art-paint 2026-11-14 01:56:07 -08:00
dotCooCoo db1dd67818 Graphs: an Eyedropper pick of stroke options leaves the rows axis lines keep
A pick of only overprint, caps, joins, miter limit or dashes on an axis
line or radar ring no longer stores the line's paint and weight for its
kind, since the graph keeps none of those options.
2026-11-13 22:33:58 -08:00
dotCooCoo f1a79b92cc Graphs: an edit of some attributes on an axis line keeps the rest its kind keeps
An edit that changed only some attributes of a graph line, such as a
transparency-only Eyedropper pick, a cap, or a fill, kept that line's whole
fill and stroke rows for every line of its kind. A line that still showed
the default stroke until the graph was drawn again then replaced the stroke
its kind kept from another line. Such edits now keep only the attributes they
change; Clear Appearance, Move Appearance, graphic styles, and a pick of every
attribute or with append still keep the whole rows.
2026-11-13 22:11:11 -08:00
dotCooCoo 13c5df3aeb Graphs: an edit of a hidden row leaves what a label or line kind keeps
An Appearance, paint, stroke or transparency edit of a hidden fill or
stroke row of a graph label or axis line no longer stores that object's
unchanged visible rows for its kind, so a paint the kind keeps from
another label or line stays.
2026-11-13 22:07:19 -08:00
dotCooCoo 2fe4b96e48 Graphs: aligned row edits, opacity-only picks and Default Fill and Stroke keep what each kind stores
An aligned appearance.setItem, removeItem or duplicateItem given the Axes
group stores the rows of only the lines and labels that have that row, so
a category label without it no longer replaces the rows its kind keeps.
An Eyedropper pick of only the object's transparency stores only the
opacity and blend mode of an axis line or radar ring, as transparency.set
does. Default Fill and Stroke stores the black fill and no stroke for a
label's kind, and the default rows for a line's kind, also when the label
or line already showed them; a kind that keeps no style and is left at the
default style still keeps none.
2026-11-13 21:38:07 -08:00
dotCooCoo f0a8c750a3 Graphs: a whole-pie recolor leaves wedge legend labels their contrast
A recolor that reached a pie's legend labels through the graph kept their
new fill as the legend's own when every label ended up with one color (a
one-series pie), so a wedge painted light again kept a white label.
Legend label fills on such a pie are now kept only when the edit named
the labels.
2026-11-13 20:44:06 -08:00
dotCooCoo 564e769cb3 Merge main into fix/graph-axes-group-edits-kept 2026-11-13 20:13:42 -08:00
dotCooCoo 58cd62ef38 Merge main into fix/graph-axis-paint-kept 2026-11-13 19:49:27 -08:00
dotCooCoo 33be0b9e58 Graphs: Appearance edits given the Axes or Legend group are kept
The appearance.* commands, graphicStyle.apply, graphicStyle.redefine,
graphicStyle.breakLink and transparency.set with an item, given a
graph's Axes group or Legend group, edited the group's own appearance
stack. The graph draws those groups again with no rows of their own,
so the next redraw (for example after graph.setData) removed the
edit.

These commands now read such a group as they read a series group: the
Axes group stands for the axis lines, tick marks, radar rings and
labels directly in it, and the Legend group for the legend labels. The
graph keeps what the command sets for every line and label of each
kind. graphicStyle.new and the other commands that read a look read
the topmost member of a group that holds nothing of its own. A group
with a fill or stroke row of its own, or with no line or label in it,
is still edited itself, except by graphicStyle.redefine, which passes
the style to the members of a linked group.

The lines and labels of a new graph have different rows, so a row
index given the Axes group would name a different row in each. An
index or item given such a group is now an error unless `aligned` is
true, which makes it a row of the backmost member's stack.

Docs: docs/mcp.md, params text, docs/target-app-parity.md Graphs line.
2026-11-13 19:34:24 -08:00
dotCooCoo eb9976a825 Merge main into fix/graph-label-paint-recolor 2026-11-13 19:22:11 -08:00
dotCooCoo 0b207f4e85 Graphs: axis lines, tick marks and radar rings keep the paint set on them
A graph drew its axis lines and tick marks in 0.5 pt black and a radar
graph's rings in 0.25 pt gray every time, with nothing stored for them. A
stroke, fill, weight, recolor, Appearance row, graphic style, Eyedropper
pick or opacity given to them was lost when the graph was drawn again.

- The graph now stores the rows of its axis lines and tick marks
  (axisRows) and, separately, of a radar graph's rings (ringRows): the
  paint, weight, opacity and blend mode of the topmost visible fill and
  stroke row, their order, and the line's object opacity and blend mode.
  Every line of the kind is drawn with them. Dashes, caps, joins and
  arrowheads are not stored.
- These commands store a line's rows: paint.setFill, paint.setStroke,
  the stroke, gradient and recolor commands, paint.swap, paint.default,
  Apply Fill to Stroke and Stroke to Fill, the appearance commands with
  the Eyedropper, graphic styles, transparency.set and object.setProps.
  paint.setFill, paint.setStroke and the recolor commands given a whole
  graph now also store what they give its lines.
- When one command reaches several lines of a kind, the frontmost line in
  paint order sets what the kind keeps. A gradient is stored without its
  placement.
- Lines that show their default stroke store nothing, and a global swatch
  edit or a document color conversion reaches the stored paint.

Docs: docs/mcp.md, the params text of these commands,
docs/target-app-parity.md.
2026-11-13 18:06:25 -08:00
dotCooCoo 78ce56d021 MCP: an integer given as a string or a fraction is refused as the wrong type, not reported as missing
A command that needs a whole number of 0 or more, such as `index` of
`appearance.setItem`, `anchor` of `path.removeAnchor` and
`addon.pen.removePoint`, `sourceDocument` of `edit.dropSelection`, `index`
of `document.activate` and `to` of `document.move`, answered "missing
integer `index`" (or "missing index") both when the key was left out and
when it was given as a value that is not a whole number of 0 or more, such
as "3", 2.5, -1 or true. A value that is given but is not one is now
refused with "`index` must be a whole number", the message object ids
already use. A key left out or given as null is still missing, and an
optional index such as `subpath` keeps its default. Neither error changes
the document or records an undo step.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-13 18:02:42 -08:00
dotCooCoo 01043c05cd Graphs: paint, stroke and transparency commands leave a design's art in a series out
The graph draws the art of a column or marker design in a series again
from the design when its data, type or designs change, and an edit made
to that art is lost.

- stroke.set, stroke.weightUp, stroke.weightDown, stroke.setAdvanced,
  paint.editGradient, paint.setGradientGeom, object.setOverprint,
  paint.swap, paint.default, and paint.invert and paint.complement with
  an item leave the art out and edit the other objects given.
- transparency.set without an item, the paint.freeform.* commands that
  edit points and lines, graphicStyle.breakLink and
  effect.expandAppearance are an error when all their objects are
  design art. Expand Appearance is disabled for a selection of only
  design art, and it leaves the design art inside a selected graph or
  series group as it was.
- When the first selected object is design art, the commands do not
  use the Appearance panel's active row, which is a row of that art.
- The error names the command that ran.

docs/mcp.md lists the commands. The params texts of the appearance.*
commands and graphicStyle.apply name the rule, and the Graph column
designs entry in docs/target-app-parity.md states it.
2026-11-13 17:49:07 -08:00
dotCooCoo 87b4a8053b Merge main into fix/graph-series-group-opacity 2026-11-13 16:49:51 -08:00
BFlat c79a21c8b7 Merge pull request #7320 from dotCooCoo/fix/graph-design-art-appearance
Graphs: Appearance and effect commands leave a design's art in a series out
2026-11-14 07:33:59 +07:00
dotCooCoo 89ee320591 Graphs: a series group also keeps its isolation and knockout
transparency.set and object.setProps with isolate, knockout or
knockoutShape on a series group now store them for the series
(groupIsolate, groupKnockout, groupKnockoutShape), and the series group
has them again when the graph is drawn again. Randomize Opacity, Sort
Objects and Global Edit store the opacity they give a series group, so
a redraw no longer puts back an older stored value over it.

A move or copy of an appearance onto a series group whose stored values
differ from its own now counts as a change, so the edit is kept. Tests
cover graphicStyle.redefine of a style linked to a series group.
2026-11-13 16:02:54 -08:00
dotCooCoo f6d90063fc Merge main into fix/graph-label-paint-recolor 2026-11-13 15:33:30 -08:00
BFlat 6fa41d4f76 Merge pull request #7304 from dotCooCoo/fix/graph-series-object-opacity-other-commands
Graphs: Global Edit, Randomize Opacity and Sort Objects keep what they give a series
2026-11-14 06:26:22 +07:00
dotCooCoo 4129587abe Graphs: recolor, stroke and gradient edits on labels are kept for their kind
A recolor of a graph (Invert and Complement on the proxy, the Edit Colors
commands, Recolor Artwork, the color filters, Apply Nearest Swatch and the
ink limit of Print Ink Fixes) stored the new paint of the series marks but
not of the labels. stroke.set, the stroke weight steps, the gradient edits,
Swap Fill and Stroke and Default Fill and Stroke stored nothing when they
changed a label's characters. When the graph was drawn again, the labels
went back to their stored style.

- These commands now store, for every label of the kind they reach, the
  label's object rows when they change, and the fill, stroke, stroke weight,
  caps, joins, miter limit, dashes and stroke alignment of its characters
  when all of them show the change alike.
- A gradient is stored without its placement, and each label fits it to its
  own box. A stroke weight and dashes are stored as a scaled label shows
  them.
- When labels of one kind change differently, the frontmost one sets what
  the kind keeps.
- On a pie with Legends in Wedges, the legend labels' fill is stored only
  when every legend label reached ends up with the same fill, so a recolor
  of the whole pie leaves them black or white by their wedge.
- Axis lines, ticks and radar rings are not stored and are drawn again with
  their default paint.

Docs: docs/mcp.md, the commands' params text, docs/target-app-parity.md.
2026-11-13 15:22:55 -08:00