- Colors in the older color fields read gray (model 9) and CMY (model 4)
as the .cdr reader numbers them, instead of opening as black.
- A dash pattern whose lengths are all 0 draws a solid line, as for a
.cdr outline.
- A curve whose point field is too short for its count and is not whole
points with their type bytes is left out as damaged, instead of reading
coordinates as point types.
- A layer without a name comes in unnamed, and the importer names it by
its place, as for a .cdr drawing.
- After stray bytes, a chunk id starts with a letter and may hold digits
and spaces, and the id found must name a chunk the reader uses or have
a length that fits its list. Padding is no longer taken for a chunk.
- A canvas or a container in an object's attributes gives the
unsupported-objects warning.
- A page with no size and no bounds is 612 x 792 pt, VectorCraft's own
size, as for a .cdr page; PROVENANCE R61 says so. PROVENANCE also names
the other program's .cmx reader, read for field order.
.cmx exchange files with 32-bit coordinates open and place as editable
art. vectorcraft-cdr reads the RIFF form CMX1, its header, the color,
pen, line type, dash, outline and arrowhead tables, and each page's
instructions in drawing order, into the drawing model the .cdr reader
uses, so the importer maps pages, layers, groups and curves with uniform
fills and outlines the same way. A layer that holds nothing is left out.
A page that gives no size of its own takes the size of the drawing's
bounds, which the page header stores, and is centered on them.
Text, images, rectangles, ellipses, clipping paths, fills other than
uniform ones and arrowheads are left out, and lenses are not applied;
the warnings name each kind, with rows in every complete catalog.
Big-endian files and files with 16-bit coordinates are refused with a
message. Layouts and their sources are rows R53 to R63 of
crates/cdr/PROVENANCE.md; tests use synthetic files only.
Conflicts in docs only (status lines, changelog rows and table rows):
main's entries and this branch's are both kept, each once.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Answers the fourth CodeRabbit review on #8549.
When a fill pass finishes lines beyond MAX_PARKED, their unstroked
glyphs are recorded (bounded at 4096). The first stroke after that
which could have gone over one of them ends the stroke pass, so a TJ
over more than 65 lines that comes back to where it began stays a
filled object and a stroked one for each part, as documented. Any
other first stroke drops the record, so type after an overflowing TJ,
filled only or not, is matched as before.
MAX_HELD's doc now says that one operator filling the same run of more
than 4096 glyphs twice at the same places is matched as well as it can
be: the reader tells no operator's start.
Answers the third CodeRabbit review on #8549.
- stroke_last no longer restyles the glyph drawn last once a boundary
(end_fills) closed it: a stroke after an ActualText span no longer
strokes its replacement text. A glyph stroked again where it was just
drawn still stays one object.
- Past MAX_HELD, the held strokes go over the last run of consecutive
fills they match with room for all of them, not the first, so a long
stroke pass no longer takes the same glyphs an earlier operator
filled at the same place.
- Docs: the limit is 64 kept-back lines plus the open one, so a TJ over
up to 65 lines stays filled and stroked.
Answers the second CodeRabbit review on #8549.
- A stroke that goes over no filled glyph (stroked type of its own) and
the start and end of an ActualText span now end the stroke pass
(Builder::end_fills): the held strokes are matched, the parked lines
finished and the open line's fills closed, so a later stroke can't go
over an earlier fill and a later span keeps its own replacement text.
- ActualText fills are ordinary entries in the line's fill list, and
span strokes are held and matched in replay order like any other, so
an A/B/A TJ in a span strokes the replacement. The actual_fills map,
stroke_parked and has_actual_fill are gone.
- Past MAX_HELD, the held strokes are matched to the first run of
glyphs filled one right after another that they go over
(Builder::replayed), with bounded work, instead of each to its first
match, which could reach an earlier operator's fill.
- Docs state that past 64 lines in one operator each part stays a
filled object and a stroked one.
A TJ can draw the same glyph at the same place twice (its kerning goes
back), so a stroke can't be matched to a filled glyph as it arrives:
[(A) -3500 (B) 4834 (A)] TJ put the first A's stroke on the last A and
left the earlier parts unstroked. Strokes over filled glyphs are now
held until their stroke pass ends and then matched to the glyphs filled
last, in the order they were filled, so each copy is stroked where it
was filled, while a glyph filled and stroked where one filled before
stands still strokes only the newest. At most 4096 strokes are held.
Docs: ordinary text gives one filled and stroked object per part; in an
ActualText span it stays one replacement object on the first glyph's
line and style.
The reader fills every glyph of a text-showing operator, then strokes
them. When a TJ's kerning started a new line part way through, the
first line was finished before the stroke pass came back to it, so its
strokes found no filled glyph and came in as stroke-only type over
fill-only type.
A line a glyph doesn't fit is now parked while a stroke may still be
drawn over it, and a stroke-only glyph is matched against the open line
and then the parked lines, newest first. Parked lines are finished
oldest first before the open line, so drawing order is kept, and at
most 64 are parked.
The writer passed no language to craft-pdf, so exported and printed
PDFs had no /Lang and accessibility checkers failed primary-language.
Writer::new now passes the BCP 47 tag of the Document Setup language
(new vectorcraft_doc::setup::language_tag, en-US by default) through
write::Writer::new_with_language, which writes the catalog's /Lang and
the XMP dc:language. A language with no tag writes none. /MarkInfo is
left for tagged PDF (#3643).
The table opens and places PostScript through the EPS reader, so PS
leaves the missing list, and .cdr drawings now open: 33 formats, missing
FreeHand and DWG.
File > Open's Import PDF dialog now starts with Import PDF pages as links
checked for All, so every page of a PDF opened from its file opens
linked, and clears the box when Range is picked, so a range opens as
art. A box checked or cleared by hand keeps that state until the other
of All and Range is picked; ui.dialog.set of allPages does the same.
The box stays clear for a file without its path, with a password, or
over the 256 MB that linkPages takes (fileio::pages_can_link).
Docs: docs/mcp.md, docs/target-app-parity.md, docs/file-format-parity.md.
Conflicts in docs only (the status lines, the changelog rows, the M4 Files
row and the File formats rows): main's entries and this branch's are both
kept, each once.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Conflicts in docs only (the status lines, the changelog rows, the M4 Files
row and the File formats rows): main's entries and this branch's are both
kept, each once.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Look::takes let a glyph filled only join a run whose glyphs were also
stroked, so after mode 2 text a mode 0 glyph took the run's stroke:
`2 Tr (B) Tj 0 Tr (C) Tj` came in as "BC" stroked throughout. A glyph
now joins only a run drawn alike (fill, stroke, overprints), so a glyph
filled only starts a run of its own and takes a stroke only when the
matched-stroke path (#8039) strokes it.
flush_stroke no longer strokes a whole run in place: a whole run goes
through the split and join code, so fill and stroke rendering glyph by
glyph still builds one stroked run.
The check that a stack's patterns are each its own took each style item's
pattern once, but not that the drawn look places it one way:
`placed_paints` keeps a pattern's first placement, so a look filling with
one pattern at two placements, for a style that names it once, came in
with the first placement for both. `placed_paints` now also notes each
pattern the look places otherwise than its first placement, and a stack
with such a pattern keeps its drawn look. The same placement again, as a
compound path's look has for each subpath, is still one.
Test `a_look_placing_a_stacks_pattern_twice_keeps_the_drawn_look` (two
placements keep the look; the same one twice comes in as the path).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>