A quoted CSV cell keeps its line breaks, and a category or series label
draws each one as a new line, as it does a `|`. Labels beside an axis or
in a wedge counted their lines by `|` alone, so a label with a line break
was set off center, and with kept leading or paragraph spacing it was
not moved back to its middle when the graph was drawn again. The label
now counts lines in the text it lays out.
Follow-up to #6574.
- Outline Stroke on a graph's strokes, including Object > Expand with
Stroke on, adjusts the bounds the graph keeps, the same way
Create Outlines on its labels does. Before, the stroke outlines
changed the bounds of the art without type, and the next redraw
stretched the plot by the width the outlines added.
- A graph that keeps `placedArt` and has no art other than type left
is no longer measured on the bounds of all its art. A label edit on
such a graph moved and stretched the plot at the next redraw; the
plot now stays where it is.
- A redraw no longer measures a move or scale on art that has no width
or no height now, such as a graph left with one axis line. Before,
the plot collapsed to no width.
- A clipping group in a graph that holds type is measured on its clip
when the clip does not depend on type, so moving art outside the clip
does not change the bounds. Blends, envelopes and repeats are
measured whole, as they are drawn.
- The doc crate's helper is named `graph_art_without_type` and sits
with the file's other free functions.
- docs/mcp.md lists Outline Stroke and states that moving an outlined
label, a swatch, an axis or a tick mark on its own can move or scale
the plot, and that a graph left with only labels, or with art that
has no width or height, does not follow a move.
- Tests: a scale of the graph made before outlining a label, a move of
a graph opened from `.ai` after its label is restyled and moved,
Outline Stroke after a move, a graph left with only its labels or
with one line, and clipping groups holding type.
With a mixed selection and the Appearance panel's active row, paint.invert
and paint.complement recolor each object's row equal to the active one,
but remembered the color at the active row's index in the first object in
paint order, which can be another row. They now remember the row they
recolor there, as the gradient and freeform edits do.
The params text of paint.setFill, paint.setStroke, paint.invert,
paint.complement, paint.lastColor, paint.lastGradient, stroke.setAdvanced,
paint.editGradient, paint.setGradientGeom and the paint.freeform edits now
lists `aligned`. docs/mcp.md names paint.lastColor and paint.lastGradient,
which take the same rows as paint.setFill, and docs/target-app-parity.md
gets a line for the rows of a design's art.
With a graph design's art given first and an item without aligned, the
art is left out, but paint.invert and paint.complement remembered the
art's unchanged color as the last color. They now read the first object
they recolor.
paint.setFill, paint.setStroke, paint.invert and paint.complement with an
item, stroke.set, stroke.setAdvanced, paint.editGradient,
paint.setGradientGeom and the paint.freeform edits read an item given with
aligned: true and the art of a graph design in a series first as a row of
the art's stack, as appearance.setItem and transparency.set do. Each other
object edits the row equal to it and an object without one is left as it
is. A row the art does not have, a row of the other kind, or a row no
other object has is an error, also when the art is the only object given,
and the document and its undo history stay as they are. Without stroke,
the gradient commands edit the kind of the art's row.
The objects and ids the commands report, a gradient spanning the
selection, and the last color and last gradient count only the objects
whose row was edited.
- A graph opened from a .ai file now saves `placedArt` too. Moving or
restyling one of its labels before the first redraw no longer moves or
stretches the plot.
- Type > Create Outlines on a graph's labels now adjusts the saved bounds,
so the outlines do not read as a move at the next redraw. A move of
the graph made before the outlining is still followed.
- A `placedArt` with no width or height falls back to the bounds of all
of the art, as a graph saved without it does.
- `art_bounds` moves to the doc crate so the .ai reader can use it.
- docs/mcp.md describes `placedArt`, `placed` and when a redraw follows
a move.
- Tests: a legend across the top, a legend after a right value axis and
legend labels of several lines keep the plot in place through label
size changes; moving a category label on its own; outlining labels
before and after a move; a flat `placedArt`; a label moved in an
opened .ai graph.
Both .ai writers now write a graph that the .ai reader reads back as the
same graph with its records, so a saved graph opens again live, with its
table, type, axes and settings: %_Gs, the Gb, Gy, Gd, Ga/GA, Gz, Gc and
GC records, the graph's group with each series' group followed by a Go
tag, and %_GS (the published .ai file format specification, section 17
and appendix A). The records are the ones the reader in
crates/eps/src/import/ai/read/graph.rs (#7311) reads, in the form it
reads them.
The shared encoder in crates/eps/src/ai_graph.rs decides first whether
the reader keeps the graph whole: a column, stacked column, line or area
graph with a legend, settings the records carry, a table of 1 to 10,000
categories and 1 to 256 series with finite values, labels of at most 255
bytes without control characters, and art the reader attaches the graph
to. Any other graph is written as its art, with the existing warning, as
is a graph whose art the editing writer's object limit cuts short.
Tick-mark counts of 0 are written as 1, the count the reader keeps for
both.
Bar, stacked bar, scatter, pie and radar graphs, stacked column and area
graphs whose series marks carry a stroke their legend swatch lacks, and
line graphs with markers are still written as their art, with the
warning.
Only a pie with Legends in Wedges picks its legend labels' fill, white on
dark wedges. Paint visits and swatch mappings now leave its default black
legend fill out only for such a pie; other graphs draw the kept fill, so
it is visited and mapped like the other label fills. A color mode change
still leaves the default black legend fill as the default, so turning on
Legends in Wedges later keeps the white labels on dark wedges.
The next redraw of a graph compared the bounds of all its generated art,
labels included, with the bounds stored at the last generation, and took
any difference for a move or scale of the graph. Label edits that change
the size of the type (a new size, an indent, a legend size) changed those
bounds without a move, so the plot shifted and stretched when the graph
was drawn again.
The spec now also stores the bounds of the art without type
(`placedArt`), and moves and scales are measured on those. Graphs saved
without them are measured on the whole bounds as before. Moving one
label with Direct Selection no longer moves or stretches the plot at the
next redraw.
effect.apply and appearance.addEffect take `aligned`, and their params
text now says so, with the rule for a graph design's art given first.
The tests add appearance.addEffect, a 3D effect.apply with an object
that has no equal row, effect.setParams and effect.duplicate on a row
of the art, and the removal of an object-level effect equal to the
art's. They also check that appearance.setItem and appearance.removeItem
on a row no other object has leave the art as it is and record no undo
step.
The Appearance and effect commands leave the art of a graph design in a
series out, and aligned rows were then matched against the first object
left over. With the art given first, appearance.removeItem with index 1
and aligned: true on art [red fill, blue fill] and a mark [blue fill,
stroke] removed the mark's stroke instead of its blue fill.
When the first object given is design art, rows and effects given with
aligned: true are now rows of the art's stack, and each other object
edits the row or effect equal to it. An object without one is left as
it is. This covers appearance.setItem, appearance.removeItem,
appearance.duplicateItem, transparency.set with an item, effect.apply,
appearance.addEffect and the effect commands that edit or remove an
effect. When no object has one, appearance.setItem and
appearance.removeItem change nothing, as they do for a row no object
has, and the other commands are an error. appearance.moveItem,
effect.move and appearance.duplicateItem with `to` compare the art's
stack too, and are an error when it differs from the other objects'.
The effect dialog reads the effects of such a row from the art's stack,
and passes the art on with the other objects.
docs/mcp.md states the rule.
On a pie with Legends in Wedges, the graph draws legend labels white on
dark wedges unless they keep a fill of their own, and it read a kept black
fill as no fill of its own. A label recolored from white to black on a dark
wedge went back to white the next time the graph was drawn.
The graph now marks the legend labels' fill as set when a command sets it
(legendFillSet in the graph's label styles, kept through save and open), and
draws a marked fill on every wedge, black included. Undo clears the mark. A
size, font or stroke change does not set it, and neither does a whole-pie
recolor that gives the legend labels different fills; one that gives them
all the same fill sets it. A swatch edit or color conversion leaves the
default black legend fill as it is, and keeps a non-black legend fill from a
file saved without the mark as the labels' own when it turns black.
graphicStyle.new linked the object it was made from, the art of a column
or marker design in a graph series included, and graphicStyle.redefine
gave the new look to every object still linked to the style. Redefining
the style from another object then restyled that art, which the graph
draws again from the design.
- graphicStyle.new makes a style from the art without linking it.
- graphicStyle.redefine leaves the art's look as it was and unlinks it,
as an edited object is, whether the art is a linked object (as in a
document saved before this change) or the source.
Docs: docs/mcp.md, the params text of graphicStyle.new and
graphicStyle.redefine.
With apply "opacity", Sort Objects compared each object's opacity with the
value it gets as a percentage, within 1e-6. An evenly stepped value can
differ from a mark's percentage by more than that while it rounds to the
same stored opacity: marks at 30%, 65% and 100% sorted by x with
distribute on keep their opacities, yet the 65% mark counted as changed.
The sort then made an undo step and replaced the opacity the graph stores
for the series (30%) with 65%.
The sort now compares each object's stored opacity with the opacity it is
given, as stored, both to skip a run that changes nothing and to pick the
marks whose opacity the graph keeps.
stroke.setAdvanced and the strokeMode of paint.editGradient decided whether they were edits for new art after the art of a graph design in a series had been left out, so a selection holding only that art changed the stroke the next object drawn takes. Both now decide it from the objects given or selected, as stroke.set does.
A paint write that leaves a series mark's gradient as the graph drew it
now keeps the series' stored gradient and its unit-box flag in two more
cases:
- a mark with no width or no height, such as a column for a value of 0,
where the stored gradient was replaced by the mark's gradient in
document coordinates and no mark took it on the next redraw;
- a gradient kept in document coordinates (a file saved before the unit
box), which a stroke weight written as it was moved to the unit box,
so the next redraw placed it on each mark's own box.
The graph draws the art of a column or marker design in a series again
from the design when its data, type or designs change, and an edit made
to that art is lost.
- stroke.set, stroke.weightUp, stroke.weightDown, stroke.setAdvanced,
paint.editGradient, paint.setGradientGeom, object.setOverprint,
paint.swap, paint.default, and paint.invert and paint.complement with
an item leave the art out and edit the other objects given.
- transparency.set without an item, the paint.freeform.* commands that
edit points and lines, graphicStyle.breakLink and
effect.expandAppearance are an error when all their objects are
design art. Expand Appearance is disabled for a selection of only
design art, and it leaves the design art inside a selected graph or
series group as it was.
- When the first selected object is design art, the commands do not
use the Appearance panel's active row, which is a row of that art.
- The error names the command that ran.
docs/mcp.md lists the commands. The params texts of the appearance.*
commands and graphicStyle.apply name the rule, and the Graph column
designs entry in docs/target-app-parity.md states it.
The test now sets the edited label's gradient vector and aspect with paint.setGradientGeom and checks that the gradient is placed before the graph redraws, so the later check that the kept gradient has no placement fails if the redraw keeps it.
transparency.set and object.setProps with isolate, knockout or
knockoutShape on a series group now store them for the series
(groupIsolate, groupKnockout, groupKnockoutShape), and the series group
has them again when the graph is drawn again. Randomize Opacity, Sort
Objects and Global Edit store the opacity they give a series group, so
a redraw no longer puts back an older stored value over it.
A move or copy of an appearance onto a series group whose stored values
differ from its own now counts as a change, so the edit is kept. Tests
cover graphicStyle.redefine of a style linked to a series group.