Commit Graph
17504 Commits
Author SHA1 Message Date
dotCooCoo 51d09113f7 Fields: x multiplies in value fields, as * does
Value fields and length strings read `x`, `X` and `×` as a
multiplication sign: `10x2` is 20, `2x3 mm` is 6 mm and `3cmx50%` is
1.5 cm. A lowercase `x` right after a `p` stays the `px` unit, so
`2px x 3` is 6 px and `2px3` is not read. The change is in
`Unit::parse` and `parse_number`, so every field that reads its text
through them takes it. Each sign counts toward the 128-sign limit,
which is checked before the text is copied.

Docs: docs/mcp.md, docs/ui-parity.md, docs/target-app-parity.md.
2026-11-17 17:05:56 -08:00
dotCooCoo cd259b9fa8 Shear: 180 and -180 leave the art unchanged
The tangent of 180 degrees in radians is about 1e-16, not 0, so a shear
by 180 or -180 moved coordinates very slightly and recorded an undo
step. Angles within 1e-9 degrees of 0, 180 or -180 now shear by 0:
without `copy`, nothing moves and no undo step is recorded.

Docs: params text, docs/mcp.md.
2026-11-17 17:04:12 -08:00
dotCooCoo 099de92455 Width Point: the outgoing half adjusts the point after its pair
With Adjust Adjoining on, the outgoing half of a discontinuous point
looked for the point after it as the first one farther than 1e-6 from
its own place, so a point within 1e-6 of the outgoing half but not of
the pair's place was skipped. Both halves now measure from the pair's
place.
2026-11-17 17:02:33 -08:00
dotCooCoo dfd5fe71f4 Image Trace: the panel finds the object Trace acts on once per document revision
On every frame the Image Trace panel put the whole selection in paint
order twice and scanned it a third time to find the object Trace acts
on; its panel menu scanned it again. The panel and its menu now look it
up once for each document revision and reuse the result on later
frames. The lookup puts only the selected images and Image Trace
objects in paint order, and reads the target in place instead of
copying it.

The target, its flags, its stored settings and whether any selected
object is an Image Trace object are the same as before, field for
field. With 100,000 selected paths in nested groups and one selected
image, a frame's lookups took a median 120 ms before; the first frame
after a change now takes 10 ms and later frames about 50 ns.
2026-11-17 16:54:21 -08:00
dotCooCoo bcc2a5ed37 Pathfinder: warn when open subpaths cancel each other under the fill rule
Make Compound Shape now also warns when a member's subpaths, all closed,
enclose no area together: two open evenodd squares on top of each other,
or an open evenodd square over the same closed square. Each subpath is
still checked on its own, so a line beside a square still warns. A path
with one subpath skips the combined check, and an area that can't be
measured gives no warning.
2026-11-17 16:50:30 -08:00
dotCooCoo f2f33b3a32 Width Point Edit: either half finds its pair as the engine pairs it
The dialog paired the points within 1e-6 of the opened point, so with
three points each that close to the next it paired the opened point
with a different neighbor than stroke.widthPoint.set accepts, and OK
failed. It now pairs a point with the next one when they are the only
points within 1e-6 of the first one's place, as the engine does, so
either half opens the same pair.
2026-11-17 16:33:11 -08:00
dotCooCoo 507a864c29 Rerun CI 2026-11-17 16:32:22 -08:00
dotCooCoo afcf8b6f78 Rerun CI 2026-11-17 16:32:15 -08:00
dotCooCoo 03c8a4ba1b Rerun CI 2026-11-17 16:32:04 -08:00
dotCooCoo 2829343e00 Rerun CI 2026-11-17 16:32:03 -08:00
dotCooCoo 5ed88cecc9 Rerun CI 2026-11-17 16:31:55 -08:00
dotCooCoo 8dabfbabab Rerun CI 2026-11-17 16:31:45 -08:00
dotCooCoo e7428b7cd3 Rerun CI 2026-11-17 16:31:44 -08:00
dotCooCoo 579b8a0316 Rerun CI 2026-11-17 16:31:36 -08:00
dotCooCoo 92020b43bc Rerun CI 2026-11-17 16:31:34 -08:00
dotCooCoo 52c696379c Rerun CI 2026-11-17 16:31:28 -08:00
dotCooCoo fd26667fbf Rerun CI 2026-11-17 16:31:16 -08:00
dotCooCoo b4404cceb0 Rerun CI 2026-11-17 16:31:15 -08:00
dotCooCoo fa817f9b28 Rerun CI 2026-11-17 16:31:00 -08:00
dotCooCoo 0d3249e44e Rerun CI 2026-11-17 16:30:58 -08:00
dotCooCoo 8842a9d6ea Rerun CI 2026-11-17 16:30:43 -08:00
dotCooCoo d0de758155 Rerun CI 2026-11-17 16:30:39 -08:00
dotCooCoo be920daf04 Rerun CI 2026-11-17 16:30:37 -08:00
dotCooCoo ed0a241b7d Brushes: Make bristle strokes follow recorded pen pose 2026-11-17 16:27:47 -08:00
dotCooCoo 20201c98e9 Merge main into feat/swatch-options-gamut-warnings 2026-11-17 16:26:12 -08:00
dotCooCoo 771e190c9a Merge main into feat/shear-angle-axis 2026-11-17 16:25:50 -08:00
dotCooCoo dc30166813 Merge main into feat/save-for-web-delete-color 2026-11-17 16:25:37 -08:00
dotCooCoo fc294d56b6 Transform panel: the Shear field takes -359 to 359 and shows the error for an angle Shear refuses
The Shear field stopped at -89 and dropped any value of 90 or more without a word.
It now sends every typed, stepped or picked value to `object.shear`, which shears by
the tangent of an angle from -359 to 359. For ±90, ±270 and an angle outside that
range the status bar shows the command's error; the art is unchanged and no undo step
is recorded.
2026-11-17 16:25:32 -08:00
dotCooCoo de501d73f2 PDF export: Patch::apply finds where each object moved with a binary search
Patch::apply wrote each cross-reference entry by walking every edit, so a
pass with many edits took time in proportion to objects times edits. It
now keeps the running total of the length changes and finds, by binary
search over the edits' ends, how far each object moved. For every edit
set that apply still accepts, the written file is byte for byte the same.

An offset that no longer fits the ten digits of a cross-reference entry
(ISO 32000-1, 7.5.4) is now refused with an error instead of writing an
eleven-digit entry that breaks the table. A change in length too large
for an isize is refused with an error instead of wrapping.
2026-11-17 16:24:59 -08:00
dotCooCoo 336cde15fe Merge main into fix/action-batch-step-numbers 2026-11-17 16:21:50 -08:00
dotCooCoo 7083061f11 Merge main into perf/shape-builder-hatch-sweep 2026-11-17 16:21:48 -08:00
dotCooCoo b16e5f633e Docs: SVG export's single type layout is for its writers
The progress line now says that the writers share one layout of each
type object, and that the check for glyphs hanging outside a path's
brackets and the advances a reader gives live text can still lay out
a changed copy.
2026-11-17 16:15:56 -08:00
dotCooCoo f516d74fcd Place: a file read in the background goes into the layer it was placed in
File › Place and a file dropped on the canvas read the file off the UI
thread, and the file was then placed wherever new art went when the read
ended. When the user made another layer current, isolated a group or
selected an object in another layer while a large file was read, the file
went into that layer or group.

The file now goes into the layer or isolated group that was current at
the dialog's OK or the drop, as a bitmap pasted from another app already
does, and the layer or isolation the user changed meanwhile stays as the
user left it.

When that layer or group is deleted, hidden or locked while the file is
read or the bitmap is decoded, the placed file or the pasted bitmap goes
where new art goes at that point, not into the topmost layer. A paste in
Draw Inside still goes inside the object it draws into while that object
can be edited.
2026-11-17 16:06:36 -08:00
dotCooCoo 5e0496cd2e 3D and Materials: the Export 3D Object button's state is worked out once per document revision
The 3D and Materials panel checked on every frame whether a selected object has a 3D effect that Export 3D Object exports, looking up each selected object's parent and the node twice. With a plain selection of 200,000 paths that scan ran in full on every frame, about 60 ms of thread CPU time. The state is now kept in the canvas cache for the document's uid and revision, beside the other per-revision panel states, and the button shows the same state.
2026-11-17 16:05:31 -08:00
dotCooCoo c580548ef2 Symbols: find selected symbol instances once per document revision
The Properties panel's Reset quick action and the Symbols panel's Break
Link to Symbol each walked the selected subtrees on every repaint,
reading each one in full until one held an instance, to learn whether
the selection holds a symbol instance. One walk per document revision
now records the instances and whether one has appearance changes of
its own, and later frames reuse it. Whether Reset Transformation would
change an instance is worked out from those instances on the first
request and kept with them.

The buttons and menu items are enabled exactly as before. With one
selected group of 300,000 paths, the two panels' reads took a median
5.1 to 5.7 ms of thread CPU time per repaint; the first read after a
change now takes about 3 ms and later repaints about 5 ns.
2026-11-17 15:59:15 -08:00
dotCooCoo 9ed14dd264 Color Themes: Show Find Field lists My Themes by theme name
On the My Themes tab, the panel menu has a checked Show Find Field item
that shows a Find field above the list. The list then shows only the
saved themes whose names hold the field's text, anywhere and in any
letter case, in their saved order; colors are not searched, and a
search with no result shows "No matches.". A picked theme the field
hides stays picked, but Edit Theme, Add to Swatches and Delete Theme
are off until the list shows it again. The field is off in a new
session and does not change the saved themes or colorTheme.list.

The help page describes searching saved themes by name this way:
https://web.archive.org/web/20210601162814/https://helpx.adobe.com/pdf/illustrator_reference.pdf#page=255
2026-11-17 15:58:21 -08:00
dotCooCoo b029a20c2b Blend: selected blends, envelopes and meshes are found along one path per object
The Blend panel, the Object › Blend, Envelope Distort and Gradient Mesh
menu items and their commands looked up every ancestor of each selected
object by id to find its nearest blend, envelope or mesh, and dropped
repeats with a linear scan. They now read the object's cached place in
the tree once, test the nodes on that path, and keep a set of the ones
already listed. The checks of whether one is selected stop at the first
selected object that has one. An id that the lookup cache does not
place on that path (a repeated id, or a cache older than the tree) is
still looked up by id, so the results, their order and the errors are
the same. Explicit ids given to the live commands drop nested ones with
a set as well.

With Select All of 102,200 objects (100,000 rectangles, 2,000 blends and
200 envelopes), a release build took a median of 16.5 ms of thread CPU
time for the Blend check before and 0.5 ms after.
2026-11-17 15:58:02 -08:00
dotCooCoo b4d5d192ba Shear: angles from -359 to 359 shear by their own tangent instead of stopping at 89
object.shear clamped its angle to -89..89 without an error, so any angle
past 89 sheared by 89. It now takes the Shear dialog's documented range
of -359 to 359 degrees and shears by the angle's tangent, so 120 slants
as -60. An angle outside that range, and +-90 and +-270 (within 1e-9
degrees), where the tangent is unbounded, return an error naming
`angle`; nothing moves and no undo step is recorded.

Docs: params text, docs/mcp.md, docs/target-app-parity.md.
2026-11-17 15:57:45 -08:00
dotCooCoo 8cc5f194c8 Color Themes: Set Active Color paints selected characters as a swatch click does
With characters selected with the Type tool, the button colors only those
characters and leaves the default for new art as it was, as a Color panel
or Swatches click does through the same paint.setFill and paint.setStroke
path. The code comment and the docs/target-app-parity.md line now say so,
and a test compares the button with paint.setFill on a selected range.
2026-11-17 15:50:52 -08:00
dotCooCoo 70e10dd553 Width Point Edit: a discontinuous point shows and edits both sets of side widths
Opening Width Point Edit on either half of a discontinuous width point
now shows the Incoming and Outgoing side widths, each with Side 1,
Side 2, Total Width and its own link. OK sets both halves in one
stroke.widthPoint.set and one undo step, and Delete removes both.
Single Width Only keeps the incoming or the outgoing widths as one
continuous point. A continuous point keeps the one-set layout.

stroke.widthPoint.set takes outIndex, outLeft, outRight and single for
this. With adjustAdjoining, the nearest point before follows the
incoming change and the nearest point after follows the outgoing
change, once each. Indices that are not the two halves of one
discontinuous point, another t, or another single value are refused
without changing the document or its history.

Help page: https://helpx.adobe.com/illustrator/using/stroke-object.html
describes editing the widths on each side of a discontinuous point in
this dialog. The group labels, the adjoining rule and Delete removing
both halves are VectorCraft's own.
2026-11-17 15:44:09 -08:00
dotCooCoo ad5db819be Merge main into fix/issue-7849 2026-11-17 15:41:34 -08:00
dotCooCoo 1aef05110b SVG export: type is laid out once for its live, on-path, outline and character-stroke writers
SVG export lays out each type object once and hands that layout to the
writer for live text, type on a path, outlines and inside or outside
character strokes, where each of them laid the same type out again.
Type on a path, bidirectional type and type that falls back to
outlines go from two layouts to one; inside or outside character
strokes and the object's own fills go from up to four to one. The
outline and character-stroke writers also group glyphs by run in one
pass instead of filtering every glyph for each run. The written SVG,
warnings and notes are unchanged.

A test compares the export with each writer laying the type out on
its own over 17 kinds of type and checks the layout counts; an ignored
test times a large document.
2026-11-17 15:37:54 -08:00
dotCooCoo da010c6598 Isolation: Exit Isolation Mode on a sublayer goes back one layer at a time
With a sublayer isolated, Exit Isolation Mode now isolates its parent layer
and selects the sublayer, so repeated use goes up one layer at a time and
leaves isolation mode from the top-level layer, as the help page describes:
https://helpx.adobe.com/illustrator/desktop/manage-objects/select-objects/isolate-objects.html
This applies to the Layers panel menu item, the isolation bar's back arrow,
the Control bar button, the canvas context menu, a double-click outside the
art and object.exitIsolation {}. Before, each of them left isolation mode in
one step.

- object.exitIsolation takes all (default false); all: true leaves
  isolation mode from a sublayer at any depth. Any other value is an error.
- Esc and the top-level layer's crumb on the isolation bar pass all: true,
  so they still leave in one step. A sublayer's crumb isolates that
  sublayer.
- A hidden or locked parent layer is not isolated; the call leaves
  isolation mode. A step up records no undo step. Groups keep their rule.
2026-11-17 15:35:46 -08:00
dotCooCoo 1c89800023 Twist: keep fractional boundary tangents accurate 2026-11-17 15:34:20 -08:00
dotCooCoo 949171b715 Save for Web: GIF lossy moves no pixel into or out of a shifted color
Lossy compression compared each pixel with the reduction's colors, so a pixel next to a color shifted by hand could join that color and be written in its new color, and a pixel of the shifted color could leave it. Lossy now leaves the entries of shifted colors alone, as it does the transparent entry.
2026-11-17 15:32:51 -08:00
dotCooCoo 1f41683f58 Color Themes: Set Active Color paints the current fill or stroke with the selected color
A button on the Create tab, beside the pipette that copies the current
color into the theme, does the reverse: it sends the selected theme color
to the proxy in front, through paint.setFill or paint.setStroke with
keepModel, so the selection and the default for new art take it in its
own color model. A click is one undo step; a click that changes no art
adds none. The button is off without a document.

The help page describes this action for creating a color theme:
https://web.archive.org/web/20210601162814/https://helpx.adobe.com/pdf/illustrator_reference.pdf#page=222
2026-11-17 15:12:20 -08:00
dotCooCoo a5b3a216df Pen: the Info panel shows W, H, D and the angle while a drag pulls out a handle
While a Pen drag past the drag threshold shapes a handle, the Info
panel shows the change in x and y, the distance and the angle from
the anchor to the handle's end: the outgoing handle of a new, added
or last anchor, and the incoming handle of the first anchor when the
drag closes the path. Shift gives the constrained handle and Space
moves the anchor with it. The readout clears on release, a dropped
press and a tool change.
2026-11-17 14:52:13 -08:00
dotCooCoo ef366997ec .ai save: keep at most 4,096 parsed style texts per save
The writer kept every style text it checked, with its parse, until the
save ended, including texts the reader does not accept. A gradient style
placed on each object's outline is often a different text per object,
so memory grew with the number of objects checked.

The first 4,096 texts, up to 8 MiB of text, are kept parsed. Past that,
only the last text checked is kept, so the brush check that follows an
object's check reuses its parse, and other texts are parsed again when
checked. The written file is unchanged.
2026-11-17 14:51:14 -08:00
dotCooCoo dedff4e91e Save for Web: ui.dialog.set accepts __editColor to open the Color Picker
The color table's __editColor control opens the Color Picker on a source color, as a double-click on its swatch does. ui.dialog.set refused it as a protected field; Save for Web now lists it with its other controls.
2026-11-17 14:48:43 -08:00
dotCooCoo 3546b3765b Merge feat/symbols-new-symbol-shift-keeps-art into feat/symbols-panel-options-button 2026-11-17 14:44:36 -08:00