Commit Graph
105 Commits
Author SHA1 Message Date
BFlat e63768c862 Merge pull request #8425 from dotCooCoo/fix/action-batch-step-numbers
Actions: action.batch errors count steps from 1 and name the member they reject
2026-11-18 13:05:15 +07:00
BFlat 17e1aa67e1 Merge pull request #8362 from dotCooCoo/feat/place-pdf-link-default
Import PDF: All checks Import PDF pages as links and Range clears it
2026-11-18 12:57:32 +07:00
BFlat 2b91d93b8e Merge pull request #8118 from dotCooCoo/fix/confined-native-image-paths
MCP: confined native output refuses linked and data set image paths outside the read roots and leaves out an export folder outside them
2026-11-18 10:14:58 +07:00
dotCooCoo 336cde15fe Merge main into fix/action-batch-step-numbers 2026-11-17 16:21:50 -08:00
BFlat ee60c51fd9 Merge pull request #8323 from dotCooCoo/fix/psd-cmyk-placement
Fix #8316: preserve CMYK PSD images when placed or relinked
2026-11-18 03:23:55 +07:00
BFlat aab753f4f2 Merge pull request #7819 from dotCooCoo/feat/textures-map-art-and-shading
Export 3D Object: mapped graphics export as textures of their faces
2026-11-18 03:23:34 +07:00
dotCooCoo 4a60b78b5c Actions: action.batch errors count steps from 1 and name the member they reject
action.batch refused a bad step before any file opened as `commands[i]`,
counted from 0, while a step that failed as it ran was named
`action step N (`id`)`, counted from 1. A step whose params its command
refused gave only the command's own error, without saying which step it
was.

- The checks before the batch (no command, an unknown command, a nested
  batch, prefs.import) now name the step as `action step N (`id`) failed:`,
  from 1, as the runtime errors do. A long unknown id is cut short in the
  message, as an unknown key is.
- The parameter check names the action.batch step whose params it
  refuses the same way. command.batch keeps passing the step's error on
  as it is.
- Override Open matches only document.open, and Override Save only
  document.save and file.saveAs: file.open, file.save and document.close
  are not engine commands, and a step with one is refused as unknown.
  The params text no longer lists them, and docs/mcp.md says a step with
  file.open or file.save is refused as an unknown command.
2026-11-17 12:09:17 -08:00
dotCooCoo 99cb4f4190 Import PDF: All checks Import PDF pages as links and Range clears it
File > Open's Import PDF dialog now starts with Import PDF pages as links
checked for All, so every page of a PDF opened from its file opens
linked, and clears the box when Range is picked, so a range opens as
art. A box checked or cleared by hand keeps that state until the other
of All and Range is picked; ui.dialog.set of allPages does the same.
The box stays clear for a file without its path, with a password, or
over the 256 MB that linkPages takes (fileio::pages_can_link).

Docs: docs/mcp.md, docs/target-app-parity.md, docs/file-format-parity.md.
2026-11-17 09:30:55 -08:00
dotCooCoo badaf937e3 Fix #8316: preserve native CMYK PSD composites 2026-11-17 06:19:51 -08:00
dotCooCoo a31d8c31f7 MCP: confined native output refuses linked image paths outside the read roots
Under automation read roots, every output that carries the native document
(a native file or template, an EPS file, a .ai or .ait file of every
artboard, a PDF of every artboard with Preserve Editing, from
document.serialize, document.export, document.exportSelection,
document.exportPdf, the saves, file.exportAs and Export for Screens rows)
is refused with "a linked image file is outside the read roots" when that
document names a linked image or placed file, a kept relative path or a
data set's image outside the roots, or holds a stored brush entry that
does not read as a brush. Nothing is written and the error names no file
or folder. Outputs without the native document are written as before.

The native document these files carry, and the documents file.package
writes or rewrites, leave out an Export for Screens folder outside the
read roots, as SVG with Preserve Editing already did. file.package refuses
a linked file it copies as it is (a PDF, .ai or EPS file, or a native
document with relink off) whose native document keeps such a folder, with
"a linked file's export folder is outside the read roots".

Export for Screens rows that write one artboard as a native, .ai or EPS
file are checked against that artboard's art. Each asset, layer or
selected object now writes its own native, .ai or EPS file: the per-artboard
document cache was keyed by artboard index alone, so every piece after the
first wrote the first piece's document.

Both messages get rows in the complete-message catalogs.
2026-11-16 03:58:13 -08:00
dotCooCoo 893ed2c7e3 Merge main into fix/confined-exports-script-paths 2026-11-15 17:20:46 -08:00
dotCooCoo 54aa1a6d40 Merge main into fix/confined-exports-script-paths 2026-11-15 11:06:03 -08:00
dotCooCoo cbe83c89a7 Links: relinking a clipped PSD follows the new file's clipping path
links.relink and links.update kept a PSD or PSB file's clip group as it
was, so an image relinked to a file with another clipping path, or with
none, stayed clipped to the old file's path, and a plain image relinked
to a clipped PSD came in unclipped.

- The PNG a PSD or PSB file's merged image is kept as now carries the
  clipping path the file names in a text chunk, and RasterImage.clip
  holds it with its fill rule (even-odd), as it holds a DCS file's
  (nonzero).
- links.relink and links.update read that path the way they read a DCS
  file's: the clip group's clipping path becomes the new file's, a file
  that names none leaves a plain group of the image, and a later file
  that names one clips it again. A clip group whose path or fill rule
  was changed in the document stays as a clipping mask around the
  file's clip group.
- docs/mcp.md and the evidence line in docs/target-app-parity.md
  describe the new behavior.
2026-11-15 11:04:20 -08:00
dotCooCoo 7d6d9314d0 Merge main into feat/textures-map-art-and-shading 2026-11-15 07:54:36 -08:00
dotCooCoo c1de98b4fc Merge main into feat/textures-map-art-and-shading 2026-11-15 00:08:17 -08:00
dotCooCoo 7a2657f6c6 Export 3D Object: a textured face keeps its opacity in the texture
A face that is not opaque drew its texture over an opaque ground, and
the material then applied the face's opacity to the whole texture, so
an opaque graphic on a half-opaque face came out half opaque.

- The texture draws the face's color at its opacity, so the graphics
  keep their own.
- glTF's textured material takes its alpha from the texture (factor 1,
  BLEND), and USDA connects opacity to the UsdUVTexture's outputs:a.
- OBJ writes <name>-texture-1-opacity.png, the texture's alpha as gray
  levels, for the MTL's map_d, and d 1 on textured materials.
2026-11-14 22:41:27 -08:00
dotCooCoo d0b69af348 Merge main into feat/psd-import-options-import-slices-after-7649 2026-11-14 22:06:58 -08:00
dotCooCoo 7a90fe5097 Merge main into fix/confined-exports-script-paths 2026-11-14 21:50:57 -08:00
BFlat 1a596c0362 Merge pull request #7653 from dotCooCoo/fix/svg-export-confined-image-links
MCP: SVG output under read roots refuses to name a linked image file outside them
2026-11-15 12:38:16 +07:00
dotCooCoo 02bb4d50c6 Merge main into feat/textures-map-art-and-shading 2026-11-14 20:48:06 -08:00
dotCooCoo 80786c1745 Merge main into fix/confined-exports-script-paths 2026-11-14 20:42:32 -08:00
dotCooCoo 599e1705ce PSD: Import Slices brings a file's slices in as user slices on Open and Place
Read image resource 1050 (version 6 records and the version 7 and 8
descriptor) and turn each slice the file did not generate automatically
into a user slice with its name, type, link, target, message, alternative
text, cell text and background color.

- document.open takes importSlices (default true) with either layer
  choice; file.place takes it (default true embedded, false linked; true
  with link is an error) and moves and scales the slices with the placed
  art in the same undo step. file.place.info, file.place.queue and
  document.psdInfo report or pass it.
- PSD Import Options gains Import Slices, enabled for a file with slices,
  independent of the conversion choice, and remembered with the other
  choices; a file with slices asks even with fewer than two layers.
- Slices outside the canvas, and slice data that can't be read, are left
  out with a warning while the art comes in. Counts, nesting and text
  lengths read from the file are capped.
2026-11-14 20:36:31 -08:00
dotCooCoo 74961dd25e Export 3D Object: mapped graphics export as textures of their faces
Graphics mapped onto a plane or onto Extrude & Bevel's front or back cap
now export as a PNG texture of that face: the face's color with its
graphics drawn over it, flat and unlit, on a mesh of the face's own
triangles with texture coordinates.

- glTF embeds the PNG (TEXCOORD_0, baseColorTexture, clamp sampler).
- USDA reads it through primvars:st, UsdPrimvarReader_float2 and a
  UsdUVTexture connected to diffuseColor; USDZ stores the PNG after the
  layer on a 64-byte boundary.
- OBJ writes vt coordinates and an MTL map_Kd.
- OBJ and USDA write <name>-texture-1.png and so on beside them.
- assets.export3D takes textureSize (128 to 4096, default 1024); one
  export draws at most 67,108,864 texture pixels.
- Faces with the same color, graphics and bounds share one texture, and
  output without graphics is unchanged. Graphics on Revolve's side are
  not exported yet.
2026-11-14 20:15:09 -08:00
dotCooCoo fb616f2c76 Merge main into feat/psd-import-options-import-slices-after-7649 2026-11-14 19:42:05 -08:00
dotCooCoo d4c9ef84f9 Merge main into fix/confined-exports-script-paths 2026-11-14 19:20:39 -08:00
dotCooCoo 2169ddedd6 Merge main into fix/svg-export-confined-image-links 2026-11-14 19:16:58 -08:00
dotCooCoo 0680b68b6d Merge main into fix/pdf-page-links-review 2026-11-14 18:51:27 -08:00
dotCooCoo cc7d081198 Import PDF: linked pages read the file once and keep blank pages
linkPages read and checked the whole PDF again for every page it
linked. The pages are now read from the file opened once. With
cropTo: bounding, a blank page stopped the open with "has no art to
place"; it now gets its crop box, as opening the page as art does.
2026-11-14 16:42:05 -08:00
dotCooCoo af010b6dec PSD: a file's clipping path clips its merged image on Open and Place
A PSD or PSB file can name one of its saved paths (image resources 2000
to 2997) as its clipping path in resource 2999. psdread::clipping_path
reads that path in the image's pixel space, under the even-odd rule the
file format specification gives, with a subpath around the whole image
first when the initial fill record says the fill starts with all
pixels.

File > Place of such a file, and File > Open of its merged image, put
the image in a clip group of that path with no paint. file.place answers
the image's id as `image`, as for a DCS file. Replacing an image alone
in a clip group with such a file keeps the image's scale and rotation.
links.update and links.relink leave the clip group as it is. Files that
name no clipping path come in as before.
2026-11-14 15:55:34 -08:00
dotCooCoo 10645eff51 Merge main into fix/svg-export-confined-image-links
# Conflicts:
#	crates/engine/src/cmd/fileio/commands.rs
2026-11-14 15:17:48 -08:00
dotCooCoo b10ace75b6 Merge main into feat/psd-import-options 2026-11-14 13:45:30 -08:00
dotCooCoo 85dfe11cf0 Merge main into fix/confined-exports-script-paths 2026-11-14 12:31:10 -08:00
dotCooCoo 56cbdbb09c MCP: SVG output under read roots refuses to name a linked image file outside them
With automation read roots in force, an SVG or SVGZ that would name a
linked image's file outside them is refused before any file, folder or
reply is written, with "a linked image file is outside the read roots",
which names no file or folder. An <image> names the file with
images: link, and with embed when the document holds no pixels for the
image. With preserveEditing, the native document the SVG carries names
every linked image and placed file, the relative paths kept of them and
each data set's image, so those are checked too, and a stored brush
entry that does not read as a brush is refused because its links cannot
be checked.

- The check runs where the linked JavaScript check runs:
  document.serialize, document.export, document.exportSelection,
  document.exportForScreens and assets.export, every SVG and SVGZ save,
  file.exportAs and the SVG Options dialog's Show Code. It also covers
  clipboard.exportSvg, and a Copy that an automation request asks for
  puts no SVG on the system clipboard when it would name such a file.
- Only the art each file writes is checked: the selected objects with
  selectedOnly and Export Selection, the art over each chosen artboard,
  hidden layers and objects only when hiddenLayers is on (a save keeps
  them by default), never template layers or the symbol or opacity-mask
  editing layer, and the symbols, patterns and brushes that art uses.
  An image colorized with a solid fill whose pixels are gray or missing
  names no file, so it is not checked outside Preserve Editing.
- Embedded pixels, a file inside the roots, a relative path that leads
  inside them and a URL are written as before, and the person at the
  keyboard exports every link as stored.

Docs: docs/mcp.md, docs/target-app-parity.md and the params text; de
and nl rows for the new message, next to the JavaScript message's rows.
2026-11-14 11:11:20 -08:00
dotCooCoo 4d3a21eca7 PSD: Open and Place without Link ask how a layered file's layers come in
File > Open of a PSD or PSB file with two or more layers now shows PSD
Import Options: Convert Layers to Objects (with Import Hidden Layers) or
Flatten Layers to a Single Image. File > Place shows the same dialog for
such a file placed without Link, and so does a file dropped on the canvas
with Shift held. Several files placed together without Link take the
choices made last. A file placed with Link keeps its flat image.

file.place takes layers and hiddenLayers: with layers: true the layers
come in as one group named after the file, a layer as an image and a
layer group as a group, at the place the merged image would take and
clipped to the canvas when layers reach past it. link: true with layers
is an error, and so is hiddenLayers without layers. file.place.queue and
file.place.info pass both on. document.psdInfo counts a file's layers
from its layer records without decoding pixels.

Docs: the params text, docs/mcp.md, docs/file-format-parity.md and
docs/target-app-parity.md.
2026-11-14 10:45:30 -08:00
dotCooCoo fbb6546621 Merge main into fix/pdf-art-bounds-printing-layers 2026-11-14 07:15:53 -08:00
dotCooCoo 87900ab512 Export: a page of the art's bounds is measured on the art the file draws
With useArtboards off, PDF, .ai and HP-GL exports sized their one page
by every visible object, including art they then leave out. A PDF
without includeNonPrinting or createLayers drops non-printing layers, so
art on such a layer made the page larger than what was drawn, and a
document whose only visible art did not print came out as a blank page.
An HP-GL plot draws nothing of non-printing layers, objects at 0%
opacity, placed images, gradient meshes whose every point is at 0%
opacity and paths that paint nothing, and such art moved the plot's
origin.

The page is now measured with that art hidden, and a document with no
other visible art is refused. A .ai file is measured with the PDF
options it is written with, so it keeps non-printing layers unless both
createLayers and includeNonPrinting are off. The PDF writer's own
non-printing filter uses the same helper, and the HP-GL writer's
plots_nothing says which objects a plot draws nothing of. Export As
measures an HP-GL plot of the art's bounds the same way, so a document
with nothing the plot draws stays in the dialog before the save panel.
2026-11-14 05:21:54 -08:00
dotCooCoo 8459c52a8c MCP: confined exports refuse native files that name a linked JavaScript file outside the read roots
Under --automation-read-root, a document that links a JavaScript file
outside the read roots could still be written by a confined caller to
any output that carries the native document, and that document holds
the stored path. SVG and SVGZ output was already refused. This change
applies the same control to every output that carries the native
document, and they now return the same error, "a linked JavaScript file
is outside the read roots", without the path:

- document.serialize, document.export, document.exportSelection and
  document.exportEps for vectorcraft, template, EPS, .ai and .ait files
  (not a legacy version 7 .ai file, a .ai file of some of the
  artboards, or one of the art's bounds)
- PDF with Preserve Editing on, as its preset, standard and options
  leave it, when it holds every artboard, including document.exportPdf
- document.save, file.saveAs and file.saveAsTemplate
- document.exportForScreens and assets.export, checked with the
  artboards each file is written with
- file.exportAs in the app
- file.package, before the folder is made, including when a linked
  native document, or the native document a linked PDF, .ai or EPS
  file carries, links such a file

Outputs that do not carry the native document, unconfined callers and
linked files inside the read roots are written as before.
2026-11-14 05:21:40 -08:00
BFlat a47d7eec91 Merge pull request #7478 from dotCooCoo/fix/export-selection-pdf-options
Export Selection: the picked format's options dialog follows the save panel
2026-11-14 19:38:30 +07:00
dotCooCoo b39bfbed4f Export Selection: the picked format's options dialog follows the save panel
document.exportSelection run with no params or {} (a shortcut, or an
automation call) wrote the picked file straight away with each format's
defaults: a PDF used the default preset, so Save PDF's options, such as
writing long pages in points, could not be chosen. It now takes Export
As's route after the save panel: Save PDF without its Artboards
section, SVG Options without its artboards, the raster options, EPS
Options, DXF Options, Text Export Options with Selection Only on, or an
exporter plug-in's parameters. OK writes the selection alone, cropped
to it, with the chosen options. While a dialog is open the call returns
null, and OK returns what file.exportAs returns, without format or
bounds.
With a path or any option it still writes straight away.

- file.exportAs takes exportSelection: true and then writes the
  document that document.exportSelection writes
  (fileio::selection_doc), without artboard choices. The options
  dialogs and the replace-file questions pass it on.
- Nothing selected stops before the save panel.
- SVG Options opened by Export Selection leaves the remembered Use
  Artboards as it was.
- Exports through file.exportAs (Export As and the options dialogs)
  apply Appearance of Black's rich black, as document.export does.

Docs: docs/mcp.md, docs/control-protocol.md, docs/target-app-parity.md.
2026-11-13 21:44:06 -08:00
dotCooCoo 45be5112e9 Merge main into fix/save-unused-option-notes 2026-11-13 16:56:43 -08:00
dotCooCoo 3429bbc76a Save, Export for Screens: warnings name an option the file doesn't read
The save commands' warnings now follow an export's .ai rules: a legacy
.ai file (aiVersion "7") reads only its own options, and the other .ai
and .ait files don't read outlineText, hiddenObjects, transparentImages
or preserveEditing. They name any option given beside the path that the
file doesn't read, not only compress, version, preview and precision,
and any such key in options. The bytes a save writes don't change.

The Save Options dialog sends a .ai save only the options the chosen
version reads, so a save from the dialog gets none of these warnings.
When the document's own file is already a .ai, the .ai options that a
save doesn't give and its file doesn't read keep their remembered
values, so the dialog still shows them; the save doesn't write them, and
a retry in another folder doesn't send them.

Export for Screens and Export Assets already accepted a key in a format
row or in a format's settings that only another format takes. Their
warnings now name it as given (formats[0].quality, settings.png.quality).
A key in a format's settings is named only when no row of that format,
as the export writes it, reads it. The options of an exportPreset, and
for assets.export the settings the document keeps, get no warning.

Docs: params text of document.save, document.exportForScreens and
assets.export; docs/mcp.md; docs/target-app-parity.md.
2026-11-13 15:34:25 -08:00
dotCooCoo b7709a3c1f MCP: SVG export by a confined caller refuses script links outside its read roots
An SVG or SVGZ writes each linked JavaScript file of SVG Interactivity
into a <script xlink:href> element as stored, so a caller with
automation read roots could read a path outside them from the exported
text. With read roots in force, an SVG or SVGZ of a document that links
such a file is now refused with "a linked JavaScript file is outside the
read roots", an error that names no file or folder. No file or folder is
written, and the document keeps the link.

- The check uses the rule document.json already applies to
  svg_scripts: a relative path is taken from the document's folder, a
  file: URL is a file, and another URL is not checked.
- It covers document.serialize, document.export, document.exportSelection,
  document.exportForScreens and assets.export (before the folder is made
  or any row is written), the SVG and SVGZ saves (also a save without a
  path of a document saved as SVG), file.exportAs and the SVG Options
  dialog's Show Code.
- Callers without roots, and the person at the keyboard, export the
  links as stored.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-13 11:46:18 -08:00
dotCooCoo d04a19ac53 Export: warnings name an option the chosen format doesn't read
`document.export`, `document.serialize` and `document.exportSelection`
accept a key that only another format takes. `{"format": "pdf",
"quality": 80}` wrote the PDF and gave no warning about `quality`.

The reply's `warnings` now name each such key, in the wording of a
save's note: "`quality` was not used: PDF files don't read it".

- The format's own options, the commands' own keys, null values and an
  exporter plug-in's format get no note.
- The note names the kind of file written. A legacy `.ai` file
  (`aiVersion: "7"`) reads `outlineText`, `hiddenObjects`,
  `transparentImages`, the artboard choice and `useArtboards`, and
  beside `aiVersion` no other option. The other `.ai` files don't read
  those three options or `preserveEditing`, which is always on for
  them.
- An export doesn't read `separateArtboards`, or `range` for a
  `vectorcraft` or `template` file. A save reads them to write each
  artboard to a file of its own.
- In the app, an export that automation asked for (`app.export` with a
  path, `file.exportAs` run as a command) gives the same notes in its
  reply and in the status bar. A Background Export replies before the
  file is written, and that reply has the notes. An export that a
  person starts from the File menu gets none.
- Export As gives a template export no `useArtboards` or `range`: a
  template doesn't read them.
- `vectorcraft-cli convert` sends `outlineText` only with
  `--outline-text`, and `hiddenLayers` only to the formats that read
  it. A conversion then warns only about an option the command line
  gave.

`document.save` gives its notes as before: it does not apply the `.ai`
rules above.

Docs: docs/mcp.md, docs/control-protocol.md,
docs/target-app-parity.md, the params text of the three commands.
2026-11-13 06:58:28 -08:00
dotCooCoo 71da62dab2 File formats: PICT pictures open and place
File > Open and File > Place read QuickDraw pictures, versions 1 and 2,
from .pct, .pic and .pict files, with or without the file's 512 bytes
of application data; a version 2 picture also opens by its content.
The reader plays the opcodes of Apple's Opcodes in Pictures table on
the metafile player: lines, rectangles, rounded rectangles, ovals,
arcs, polygons and regions become paths, text becomes point type in
the font the picture names, bitmaps, pixel maps and QuickTime JPEG
images become images, and the clip region clips what follows it.
Place puts the picture in one group clipped to its frame. What isn't
read comes back as warnings, and a picture cut short keeps what came
before it. PICT is not written.

Images whose transform flattens them no longer leave their pixel data
in the document. Formats whose signature starts the file are detected
before PICT, which is known by bytes 522 or 10.

Docs: docs/mcp.md, docs/file-format-parity.md, docs/target-app-parity.md.
2026-11-12 19:52:06 -08:00
dotCooCoo 15ffb4ec01 Merge main into feat/export-notes-loss-first 2026-11-12 12:45:09 -08:00
BFlat a2899e538b Merge pull request #6894 from dotCooCoo/fix/read-roots-error-messages
Automation: errors name a path outside the read roots by its file name
2026-11-13 02:47:17 +07:00
dotCooCoo 369de5bc4c Merge main into fix/read-roots-error-messages 2026-11-12 09:45:21 -08:00
dotCooCoo 5006ba5a2e Merge main into feat/eps-save-use-artboards 2026-11-12 08:45:42 -08:00
dotCooCoo 766e291e3c Save and Export: notes of what the file loses come before notes on options
Each writer marks its notes as a loss (something of the document that the
file leaves out or that reaches it changed) or as a note on the options
(an option it didn't apply or applied another way while the art reaches
the file as it looks, or something an option turns off). The PDF, SVG,
EPS, legacy .ai, DXF and HP-GL writers return their notes on the options
in a list of their own (`setting_notes`) beside `warnings`, and the
engine's `Encoded` does the same.

The replies of the save and export commands, and of
`clipboard.exportPdf` and `clipboard.exportPng`, list the losses first,
each kind in the order the writers gave them, across every file that
Export for Screens writes. The status bar names the first note, so an
export to lossy WebP of type in a font that isn't installed now names the
fallback-font note instead of the lossy WebP note. A print to a file
keeps the order its notes are given in.
2026-11-12 08:33:57 -08:00
dotCooCoo baa7ada7a1 Automation: errors name a path outside the read roots by its file name
Under --automation-read-root, an error about a file or folder the client
did not give now names it whole only when it is inside the read roots.
Outside them it names the file or folder by its file name, or as "a file
or folder outside the read roots" when it has none, and keeps the roots
and the reason. A path the client gives stays whole.

This covers a save without a path (the document's own file and the files
written beside it, also inside action.batch, and the refusal to write
over a file read with losses), file.revert, script.listInstalled,
plugin.reload without a path and plugin.list's folder report, and
links.relink with copy (the document's folder, its error when the
document's path has no folder, and the copies in the reply). Export for
Screens' refusal for an export preset's folder uses the same helper.
2026-11-12 06:05:56 -08:00