Commit Graph
46 Commits
Author SHA1 Message Date
dotCooCoo 2fa55b2aeb Merge main into feat/symbols-panel-options-button 2026-11-17 22:24:17 -08:00
BFlat e49686185e Merge pull request #8465 from dotCooCoo/feat/scatter-brush-hue-jitter
Brushes: Scatter Brush Options has Hue Jitter, a per-copy hue turn
2026-11-18 13:15:11 +07:00
BFlat 0bba8a8666 Merge pull request #8423 from dotCooCoo/feat/symbols-redefine-shift-keeps-art
Symbols: Shift with Redefine Symbol keeps the art as ordinary art
2026-11-18 13:12:06 +07:00
BFlat d17d152620 Merge pull request #8386 from dotCooCoo/feat/symbols-alt-drag-redefine
Symbols: Alt-dragging art onto a symbol in the panel redefines it
2026-11-18 13:11:46 +07:00
BFlat 9e811a7d05 Merge pull request #8422 from dotCooCoo/fix/path-freehand-connect-needs-extend
Pencil: path.freehand refuses connect without extend
2026-11-18 13:11:10 +07:00
BFlat f7c7d5c1a0 Merge pull request #8490 from dotCooCoo/feat/bristle-pen-pose
Brushes: Make Bristle strokes follow recorded pen pose
2026-11-18 13:05:24 +07:00
BFlat bc30887624 Merge pull request #8382 from dotCooCoo/fix/undo-keeps-view-state
Undo: undo and redo keep the settings changed without an undo step
2026-11-18 12:57:41 +07:00
BFlat 3a9bb87022 Merge pull request #7925 from dotCooCoo/feat/brush-options-of-selected-object
Brushes: Options of Selected Object changes one brushed path's brush settings without changing the brush
2026-11-18 10:18:41 +07:00
dotCooCoo ed0a241b7d Brushes: Make bristle strokes follow recorded pen pose 2026-11-17 16:27:47 -08:00
dotCooCoo a0228dd460 Brushes: Scatter Brush Options has Hue Jitter, a per-copy hue turn
A scatter brush takes a Hue Jitter amount from 0 to 180 degrees (0 by
default). Each copy turns the hue of its solid fills and strokes, type
included, by its own amount up to that far either way, after the
colorization. The amounts come from the stroke's path and the brush
name, so a stroke draws the same colors on every redraw, after Save and
Open, and in export. Copies keep their places, sizes and rotations.

A color turns in its own model (RGB in the HSB of its values, CMYK over
C, M and Y with K kept, Lab by turning a and b). White, black and grays
stay as they are, and a symbol instance in the art turns only its stain.
A brush at 0 draws its copies in the colors the colorization gives them
and saves no hue_jitter key; a brush without the key reads as 0.

- brush.options takes hue_jitter, and brush.get shows it for every
  scatter brush. Brush Options shows a Hue Jitter field (ui.brushOptions
  field hueJitter) with rows in every catalog.
- The .ai editing data writer does not write the amount, so a jittered
  brush is left out of the Brushes panel there and reported, as other
  brushes that would open with other settings are.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-17 14:24:19 -08:00
dotCooCoo cc4ce97fc3 Symbols: Shift with New Symbol keeps the art as ordinary art
Making a new symbol from the selected art with Shift held now adds the
symbol and leaves the art as ordinary art, as the Create a symbol section
of the help page describes
(https://web.archive.org/web/20210601162814/https://helpx.adobe.com/pdf/illustrator_reference.pdf#page=192).
Without Shift the art still becomes an instance.

- symbol.new takes keepArt (default false). With true the art keeps its
  ids, layer and stacking position and stays selected, apart from art
  that cannot be selected, frames of threaded text stay in their
  thread, and the result's id is null. A keepArt that is not true or
  false is an error.
- The Symbols panel's New Symbol button and its New Symbol... menu item
  read Shift when clicked and carry it through Symbol Options' OK;
  Shift with Alt on the button makes the symbol at once and keeps the
  art. Art dragged onto the panel reads Shift as it is released.
- ui.symbolOptions takes keepArt for a new symbol and refuses it when
  editing a symbol.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-17 13:18:49 -08:00
dotCooCoo 6252d4b29e Pencil: path.freehand refuses connect without extend
path.freehand ignored a connect given without extend and drew a new
path. It now refuses it with "connect needs extend". A connect given
with extend is checked (its id, a path other than the one extended
with an open end, and an end of "start" or "end") before a stroke of
one point returns, so a bad connect is refused there too, and
brush.freehand no longer changes the path's brush or the selection
before refusing it. A null connect is still a key left out.

Docs: params text, docs/mcp.md, docs/target-app-parity.md. i18n: the
new message in the catalogs that carry the other connect messages.
2026-11-17 11:56:49 -08:00
dotCooCoo 3919a1a5df Symbols: Shift with Redefine Symbol keeps the art as ordinary art
Redefine Symbol chosen from the Symbols panel menu with Shift held now
updates the symbol and its instances from the selected art and leaves
that art as ordinary art, as the Edit symbols help page describes
(https://helpx.adobe.com/illustrator/desktop/manage-objects/traces-mockups-symbols/edit-symbols.html).
Without Shift the art still becomes an instance.

- symbol.update takes keepArt (default false). With true the art keeps
  its ids, layer and stacking position and stays selected, apart from
  art that is hidden or locked, and the result's id is null. A keepArt
  that is not true or false is an error.
- Redefining the symbol being edited with keepArt still leaves symbol
  editing mode in the same undo step.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-17 11:51:44 -08:00
dotCooCoo 999e538fd6 Symbols: Alt-dragging art onto a symbol in the panel redefines it
Art dragged off the canvas and released on a symbol's tile or row in the
Symbols panel with Alt (Option on macOS) held now runs Redefine Symbol
(symbol.update) for that symbol, in thumbnail view and both list views.
The symbol under the pointer is outlined while the art is held over it
with Alt. A drop without Alt still makes a new symbol.

- A canvas art drag records the document it came from; art of another
  document, objects the document no longer has and an empty drag are
  not taken.
- symbol.update refuses art that holds an instance of the symbol it
  redefines, directly, in an opacity mask or through the art of the
  symbols it nests, so neither the menu nor the drop can make a symbol
  hold itself. The symbol-editing check shares the walk and now also
  looks inside opacity masks.
- Panel art drops take only a release of the primary button.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-17 10:36:06 -08:00
dotCooCoo 6e44c63cc3 Undo: undo and redo keep the settings changed without an undo step
Undo and redo put back the whole document a step stored, so settings
that change without an undo step went back with it. Undoing any
earlier edit turned the perspective grid's Lock Grid off again, turned
its Snap to Grid back on, showed a hidden grid and switched the active
plane back. It also reset the grid from Gridline every and
Subdivisions, the export settings assets.settings.set stores, and the
current brush and symbol.

Each undo step now also records these settings as the step left them.
Undo and redo compare that record with the document they bring back:
a setting the step did not change stays as it is now, and a setting
the step changed comes back with the step. So undoing a perspective
grid preset still hides the grid the preset showed, and undoing a grid
definition that locked the grid unlocks it. The point Automatic Plane
Positioning holds still follows the steps, and is let go when the
active plane kept is another one.
2026-11-17 08:40:50 -08:00
dotCooCoo 75b02ea8df Symbols: the panel reads the current symbol without running symbol.list
The Symbols panel and its panel menu asked for the current symbol on
every frame by running symbol.list, which builds a row per symbol and
walks the whole document once per symbol to count its instances. They
now read it from the active document with cmd::current_symbol, the
rule symbol.list itself uses for its `current`: the stored name while
a symbol has it, else the first symbol. symbol.sortByName,
symbol.place, symbol.options and text.insertInline use the same
function, and symbol.list's reply is unchanged.

An idle frame of the panel or its menu now runs no command, so on
macOS the native menu is not brought up to date on every frame while
the panel is open. In a document with 200 symbols and 50,000 objects
the read takes 0.035 us instead of 48.5 ms in a release build (thread
CPU time on Linux, median of 7 runs). The gain matters on large
documents; on small ones it is too small to notice.
2026-11-16 05:29:31 -08:00
dotCooCoo be12c9ed36 Brushes: Options of Selected Object keeps a path's null modes and largest width, and its document
- A calligraphic path's `modes: null` (modes that follow its values) stays
  when another value changes, instead of falling back to the brush's modes.
- An art `width` without a `width_max` keeps the largest width of each path
  whose width follows the pen, so editing Width no longer moves the other end.
- OK changes nothing when another document has become the active one since
  the dialog opened, as Delete Brush does.
2026-11-15 17:52:41 -08:00
dotCooCoo fd7bdee746 Merge main into feat/brush-options-of-selected-object 2026-11-15 16:35:36 -08:00
dotCooCoo 628bd5229c Brushes: Options of Selected Object keeps the mode each path draws with when a value changes
A path without modes of its own takes them from its values, so a changed calligraphic variation or scatter range could change the mode the dialog showed (a Random size became Fixed when its two ends met). brush.objectOptions now keeps each path's drawn mode for every item params does not set, and still sets the modes params give.

The params text also says which way the calligraphic angle and the scatter rotation turn, as every_turn_param_says_which_way_it_turns requires.
2026-11-15 13:18:05 -08:00
dotCooCoo 74370b1cdb Brushes: a Paintbrush stroke that changes a path's brush clears the path's own brush settings
Extending a path with brush.freehand and another brush set the new brush
but kept the settings Options of Selected Object stored for the old one.
They are now cleared, as brush.apply clears them.
2026-11-15 10:49:11 -08:00
dotCooCoo 87acb57d0d Brushes: Options of Selected Object keeps each path's values the dialog did not change
With several brushed paths selected, editing one end of a range in the
dialog sent the whole range, so every path took the first path's other
end. The dialog now sends only the items and colorization fields that
changed, and brush.objectOptions reads a null item of an array as each
path's own item, else the brush's. A null mode keeps the mode the path
has with its other values, and modes that change nothing are not stored.
2026-11-15 10:17:25 -08:00
dotCooCoo 5437bdeacd Merge main into feat/brush-options-of-selected-object 2026-11-15 09:07:51 -08:00
dotCooCoo 0daad87499 Brushes: Options of Selected Object changes one brushed path's brush settings without changing the brush
The Brushes panel menu gains Options of Selected Object…. It opens the
brush type's options dialog for the selected brushed paths, without the
Name row, and OK stores the changed values on those paths' strokes only.
The brush and its other strokes keep their settings.

- brush.objectOptions {ids?, params?, reset?} sets the settings, clears
  them with reset, and returns them when given neither. It refuses
  params with reset, a selection with no brushed path, brushes of
  different types, a bristle brush, a field the type does not take and
  a value of the wrong kind. One undo step, none when nothing changes.
- The stroke saves the settings as brush_options in the native file, and
  the brush renderer, the expansion of pattern tiles whose brushes vary
  at random and color conversion of Hue Shift keys read them.
- Applying another brush, removing the brush or a brush change carried
  by Global Edit clears them; renaming the brush keeps them.
- Docs: docs/mcp.md, docs/ui-parity.md; i18n rows for the new strings.
2026-11-15 08:50:04 -08:00
dotCooCoo bb6a8076f3 Brushes: a one-point brush.freehand continuation follows keepSelected
A brush.freehand call that continued a path by one point changed the
path's brush and left the selection as it was. With keepSelected off the
path stayed selected, and with it on the path was not selected, unlike a
longer continuation and unlike what path.freehand's params text says.
The brush edit now selects the path, or deselects it while the rest of
the selection stays, as a longer continuation does. A call that leaves
the brush as it is still changes nothing.
2026-11-15 06:55:16 -08:00
dotCooCoo ba9acf808e Brushes: brush.freehand is one undo step and refuses strokeless paths and unknown keys
brush.freehand drew the path with one edit and set the brush with a
second, so one Undo left the path without its brush. The brush is now
set in the same edit that draws, continues or redraws the path, and the
step is named Paintbrush whatever the style.

A brush for a path with no stroke (a continued or redrawn path without
one, or a new filled "pencil" path while the stroke is None) was skipped
and the call still succeeded. It is now refused with "cannot apply brush
`<name>`: path has no stroke" before anything changes. The Paintbrush
tool sends brush.freehand when a brush is current, so continuing or
redrawing such a path with it now shows this error. This rule is
VectorCraft's own.

brush.freehand is no longer in UNCHECKED: it takes the path.freehand
keys and `brush`, and any other key is refused with "unknown parameter".
2026-11-14 17:31:16 -08:00
dotCooCoo f37c5c293e Brushes: brush.freehand refuses a brush or style it cannot use
brush.freehand drew the plain path when `brush` named no brush in the
document or was not a string, and drew a pencil stroke for any `style`
other than "brush". It now refuses an unknown name with "no brush named
`<name>`", as brush.apply and brush.setCurrent do, a `brush` that is not
a string, and a `style` other than "pencil" or "brush". The document does
not change and no undo step is recorded. A `brush` left out or null still
draws the plain path.

The Paintbrush skips a tool brush or current brush that has been deleted
and paints with the other, or draws the plain path when neither is in the
document, so a stroke after a brush is deleted is not refused.
2026-11-14 04:41:02 -08:00
dotCooCoo 711d7163f8 Brushes: repeated brush names are numbered when a document loads
A document or brush library file could hold two brushes of one name.
Renaming the first in Brush Options moved every stroke of that name and
left the second brush unreachable, deleting by name removed both, and
the Brushes panel could not select the second row.

Reading a stored brush library now keeps the first brush of a name as
stored and numbers each later one with the first "Name 2", "Name 3" and
so on that the file does not already have. Strokes name their brush,
and a name always found the first brush, so every stroke keeps drawing
the brush it drew before. The rule applies to opened documents and to
brush library files; brushes added to a document that already has the
name keep today's numbering.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-13 09:37:14 -08:00
dotCooCoo d69e9c10d7 Brushes: Alt-drag art onto a brush to replace its art
Art Alt-dragged (Option-dragged on macOS) from the canvas onto a
scatter, art or pattern brush in the Brushes panel becomes its art
(brush.replaceArt). When strokes use the brush, the app checks the art
first, then a dialog offers Apply to Strokes, which redraws them with
the new art, Leave Strokes, which keeps the brush and its strokes as
they were and adds "<name> copy" with the new art as the current brush,
and Cancel. Each change is one undo step.

A pattern brush takes back the tile groups brush.placeArt places, frames
included, and takes other art as its side tile. Calligraphic and
bristle brushes, an empty selection and art with no width are refused.

Art Alt-dragged off the canvas now reaches the panels as the art the
drag started with. Before, the panels got the ids of the copy the drag
previews, which no longer exist once the release over a panel ends the
move.

brush.new now also measures a symbol instance in the selected art by its
symbol's art when it checks that the art has width.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-11 22:11:17 -08:00
dotCooCoo bcc9901419 Brushes: drag a brush onto the canvas to place a copy of its art
A scatter, art or pattern brush dragged from the Brushes panel onto an
empty part of the canvas places a copy of its art there to edit,
centered where it is dropped (brush.placeArt). Dropped on a path, a
brush is still applied to it. A pattern brush is placed as its tiles in
a row, 10 pt apart, each in a group named for its tile, with an
unpainted rectangle at the back of a tile that has a repeat frame.
Calligraphic and bristle brushes have no art and are refused. A symbol
instance in the art is measured by its symbol's art.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-11 22:09:58 -08:00
dotCooCoo c0be73df11 Symbols: the panel menu sorts by name and offers Small and Large List views
The Symbols panel menu gains Sort by Name, which puts the document's
symbols in name order, ignoring case, as one undo step
(`symbol.sortByName`). Symbols whose names differ only in case keep their
order, the current symbol stays current, and no undo step is added when
the symbols are already in order.

The menu's Thumbnail View and List View become Thumbnail View, Small List
View (18-point rows, 14-point thumbnails) and Large List View (the former
List View's 26-point rows and 22-point thumbnails), as in the Graphic
Styles panel. Clicking, double-clicking and dragging a symbol work the
same in every view.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-11 16:29:20 -08:00
dotCooCoo 988bfeb6ec Symbols: Break Link keeps new art on a locked artboard selected
Break Link to Symbol on an instance just placed on a locked artboard
selected nothing: the art that replaced the instance has a new id, so the
locked-artboard check did not see it as new art. The art of an instance
that was new art is now checked without the locked artboards, and the
session keeps it selected as new art. The art of an older instance on a
locked artboard, named by id, is still left out of the selection.
2026-11-10 22:54:05 -08:00
dotCooCoo d069e0e4be Symbols: Break Link selects no art inside a hidden or locked group
Break Link to Symbol on a selected group selected the art of every
instance it expanded that was itself shown and unlocked, including art in
a hidden or locked group inside the selection. The art now goes into the
selection only when it and every group and layer holding it are shown and
unlocked, the check Select All uses (select::is_selectable).
2026-11-10 21:08:57 -08:00
dotCooCoo 2faadd28f4 Symbols: Break Link keeps a hidden or locked instance's art hidden or locked
Break Link to Symbol on a selected group, and Delete Symbol with its
instances expanded, turned a hidden or locked instance into visible,
unlocked art. The art now keeps the instance's hidden and locked state,
as Object > Expand does, and Break Link leaves hidden or locked art out of
the selection.
2026-11-10 20:09:28 -08:00
dotCooCoo fff2ecd76b Symbols: Reset Transformation tests cover a mixed selection and negative stored sizes
An instance in perspective selected with a turned instance stays as it
was while the other is reset and returned in one undo step. Stored
natural sizes that are negative on either side give the art its own
size, unmirrored, as a zero size does.
2026-11-08 12:21:14 +07:00
dotCooCoo 1cd607f596 Symbols: Reset Transformation keeps the art's size when the stored size is not positive 2026-11-08 12:21:14 +07:00
dotCooCoo d687456978 Symbols: Reset Transformation returns an instance to its symbol's scale, rotation and shear
The Symbols panel menu's Reset Transformation and the Control bar's Reset
(shown while symbol instances are selected) give the selected instances
their symbol's own scale again, without rotation, shear or reflection, as
one undo step (symbol.instance.resetTransform). Each instance keeps the
center of its art's bounding box in place. Instances in perspective and
instances already at their symbol's scale are left as they are, no undo
step is added when nothing changes, and both controls are enabled only
while a selected instance would change.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-08 12:21:12 +07:00
dotCooCoo 1968077984 UI-1676: Ignore hidden symbol tint when expanding 2026-11-05 05:54:43 +07:00
dotCooCoo ac0ca081bb Commands: a color param with an alpha part is refused instead of losing its alpha
Squashed from #5603 onto main.
2026-11-04 20:08:42 +07:00
dotCooCoo 5c224a0d08 Symbols: Break Link keeps the instance's opacity mask
Break Link to Symbol dropped the instance's opacity mask. The art now
keeps it, or a group around the art holds it when the symbol's art has
a mask of its own. The objects in the instance's mask art count against
Break Link's limit of 1,000,000 objects.
2026-11-04 12:44:46 +07:00
dotCooCoo e8e09af782 Brushes: Calligraphic and Scatter values follow pen tilt, bearing and rotation
Squashed from #5031 onto main.
2026-11-02 14:33:02 +07:00
dotCooCoo ff036557fb Symbols: Edit Symbol opens the symbol in its own editing mode, and every instance follows each edit
Squashed from #5064 onto main.
2026-11-01 11:09:03 +07:00
Don Omondi 961694cba6 Fix #4918: delete nested picks safely, keep picks per document
symbol.delete {names} expands every instance of the named symbols,
round by round, before it removes any definition, so a symbol and the
one placed inside it delete alike in either order. The Symbols panel's
picks belong to the document they were made in, and a single picked
symbol is deleted only while symbol.unused still lists it.
2026-11-01 07:38:01 +07:00
Don Omondi 5b639169cd Fix #4918: Symbols panel Select All Unused
symbol.unused lists the symbols nothing places: instances in the art
(opacity masks included), graph designs, pattern tiles and brush art
count, and so do instances in a used symbol's art. The Symbols panel
menu's Select All Unused shows them selected, and Delete Symbol asks
once and deletes those still unused in one undo step
(symbol.delete {names}).
2026-11-01 07:38:01 +07:00
dotCooCoo 012af4fd49 Brushes: each Pattern Brush Options tile can be set to a pattern swatch or None
A menu under each of the five tiles in Pattern Brush Options lists None,
Original and the document's pattern swatches; the corner menus keep the
four automatic corners. A swatch choice copies the swatch's whole art and
its tile frame into the brush, so the brush keeps drawing after the swatch
is deleted, and the menu then shows that art as Original. Side cannot be
None: OK shows "You must choose a side pattern." and keeps the dialog open.

brush.options takes side_tile, outer_corner_tile, inner_corner_tile,
start_tile and end_tile (a pattern name, none, original, the corner auto
ids, or {"pattern": name} for a swatch named like one of those words), and
rejects side_tile "none" and unknown names before editing.
2026-11-01 01:22:03 +07:00
dotCooCoo b1aa576764 Brushes: Delete Brush asks Yes or No for unused brushes, and Remove Strokes or Cancel for brushes in use
The question for brushes no stroke uses reads "Delete the brush selection?" with Yes and No, from the bottom button and the panel menu, and Alt-click (Option-click on macOS) on the button still deletes them without asking. When a stroke uses one of the brushes, the button, Alt-click and the menu item ask with Remove Strokes and Cancel; Remove Strokes deletes the brushes and the strokes that used them become plain strokes.

brush.unused also counts the tile that pattern editing's Cancel puts back, which brush.delete already clears, so the panel asks the in-use question for a brush only that tile uses.
2026-11-01 01:21:54 +07:00
aiongg 83eec43b18 refactor(engine): move tests_*.rs to tests/<topic>.rs 2026-10-26 18:26:56 +00:00