Commit Graph
75 Commits
Author SHA1 Message Date
dotCooCoo b697ecbf07 Merge main into fix/erase-region-params-refused 2026-11-15 18:40:58 -08:00
dotCooCoo 418ae818e5 Merge main into fix/erase-region-params-refused 2026-11-15 16:06:28 -08:00
dotCooCoo 46e5ab21e0 Merge main into fix/pen-input-params-pressure-tilt-rotation 2026-11-15 16:06:17 -08:00
BFlat 6a3c9cfc8b Merge pull request #7957 from dotCooCoo/feat/eraser-alt-drag-marquee
Eraser: an Alt-drag erases everything inside a marquee, a square with Shift
2026-11-16 06:55:17 +07:00
dotCooCoo deaff22280 Merge main into fix/erase-region-params-refused 2026-11-15 13:42:46 -08:00
BFlat 8920f24351 Merge pull request #7920 from dotCooCoo/fix/smooth-corners-dense-paths
Smooth tool: keep corners on a path cut into very many short segments
2026-11-16 04:30:41 +07:00
dotCooCoo 6c74a77a6d Eraser: an Alt-drag erases everything inside a marquee, a square with Shift
With Alt held at the press, an Eraser drag draws a marquee from the press
point to the pointer instead of a stroke, and the release erases everything
inside it. Alt+Shift keeps the marquee square on its larger side, Escape
cancels it, and a click or a drag along one axis erases nothing.

path.eraseRegion takes {rect: [x, y, width, height]} in place of points.
Closed paths lose the rectangle's area; open paths are cut where they cross
its edges, found from the exact crossings, so a narrow rectangle across a
long segment still cuts it. A width or height of 0 or less, a non-finite
value, or points and rect together is an error, and nothing erased adds no
undo step.

Docs: docs/mcp.md, docs/ui-parity.md.
2026-11-15 12:13:13 -08:00
dotCooCoo 2f432926b2 Smooth tool: keep corners on a path cut into very many short segments
The Smooth tool measured the turn around each corner by walking at most
256 segments from the anchor, and did not keep an anchor as a corner
when twice the reach lay farther than that. A corner of a path cut into
short segments was rounded off: an open path with 0.05 pt segments at
the default 12 pt reach, or a square in 0.25 pt segments with a 40 pt
reach.

The walk now has no segment limit. Each segment's length is measured
once per path, and the lengths are added up in blocks of 2, 4, 8 and
more segments, so finding the point a reach away skips whole blocks and
measures only the segment it lands in. Each block adds up only its own
segments, so short segments keep their lengths next to very long ones.
2026-11-15 10:41:11 -08:00
dotCooCoo bb6a8076f3 Brushes: a one-point brush.freehand continuation follows keepSelected
A brush.freehand call that continued a path by one point changed the
path's brush and left the selection as it was. With keepSelected off the
path stayed selected, and with it on the path was not selected, unlike a
longer continuation and unlike what path.freehand's params text says.
The brush edit now selects the path, or deselects it while the rest of
the selection stays, as a longer continuation does. A call that leaves
the brush as it is still changes nothing.
2026-11-15 06:55:16 -08:00
dotCooCoo 495513f0b6 Pen input: out-of-range pressure, tilt, rotation and size values are refused
The drawing commands that read pen values at their points (path.freehand,
brush.freehand, path.knife, path.eraseRegion, path.eraseSegments,
path.smoothRegion, path.joinScrub and path.blob) now refuse a pressure
outside 0 to 1, a tiltX or tiltY outside -90 to 90 and a rotation outside
0 to 360, naming the key. A tilt was kept within range and a pressure or
rotation was passed on. A point array of more than six numbers is refused,
naming the point, instead of having its extra entries ignored.

path.blob and path.eraseRegion refuse a size outside 0.1 to 1000 pt, the
range of the Blob Brush and Eraser tool options. path.blob refuses a
sizeVariation outside 0 to 1000 pt in every sizeMode and with the mode left
out. path.eraseRegion refuses a sizeVariation over 1000 pt in every mode
with the same message, and a negative one still gives "sizeVariation must
be 0 or more". Each refusal leaves the document, the selection and the
undo history unchanged; null and omitted values still take the defaults.

The tip variation test uses a 1000 pt tip and a 1000 pt Fixed variation,
the largest values path.eraseRegion now takes.

Docs: params text, docs/mcp.md, docs/target-app-parity.md.
2026-11-15 03:28:25 -08:00
BFlat 8138a6e973 Merge pull request #7814 from dotCooCoo/feat/editing-one-anchor-copies-the-whole-anchor-list
Paths: editing one anchor of a long path keeps one chunk of anchors for undo
2026-11-15 17:31:01 +07:00
dotCooCoo 7104cd05f3 Merge main into feat/editing-one-anchor-copies-the-whole-anchor-list 2026-11-14 22:05:53 -08:00
dotCooCoo a5493a1cd0 Paths: editing one anchor of a long path keeps one chunk of anchors for undo
A subpath's anchors are now an `Anchors` list held in chunks of up to
256 anchors behind `Arc`s. Copying a path copies the chunk table and
shares the chunks, and editing one anchor copies only the chunk that
holds it, so the undo step of a one-anchor edit no longer keeps a copy
of every anchor of the path. Inserting or removing an anchor copies the
chunk it is in and rebuilds the table. Reads and edits follow the Vec
and slice methods the code used; files write and read each subpath's
anchors as one list, as before, within the same anchor read budget.

The undo memory estimate counts only the chunks the other version of
the path does not hold, and the renderer's kept paths compare only the
chunks an edit copied when they look for moved anchors.

Moving one anchor of an open path of 10,000 or 200,000 anchors
(path.moveAnchor, path.setHandle, path.moveAnchors, a nudge) keeps at
most 48 KiB in its undo and redo steps, where it kept 56 bytes per
anchor.
2026-11-14 21:25:15 -08:00
dotCooCoo 8c4516aa87 Merge main into fix/one-undo-step-a-refused-brush-on-a-path-with-no 2026-11-14 21:02:12 -08:00
dotCooCoo 4a0332e30f Merge main into fix/erase-region-params-refused 2026-11-14 20:42:40 -08:00
dotCooCoo ba9acf808e Brushes: brush.freehand is one undo step and refuses strokeless paths and unknown keys
brush.freehand drew the path with one edit and set the brush with a
second, so one Undo left the path without its brush. The brush is now
set in the same edit that draws, continues or redraws the path, and the
step is named Paintbrush whatever the style.

A brush for a path with no stroke (a continued or redrawn path without
one, or a new filled "pencil" path while the stroke is None) was skipped
and the call still succeeded. It is now refused with "cannot apply brush
`<name>`: path has no stroke" before anything changes. The Paintbrush
tool sends brush.freehand when a brush is current, so continuing or
redrawing such a path with it now shows this error. This rule is
VectorCraft's own.

brush.freehand is no longer in UNCHECKED: it takes the path.freehand
keys and `brush`, and any other key is refused with "unknown parameter".
2026-11-14 17:31:16 -08:00
dotCooCoo 6c585de940 Eraser: Angle, Roundness and Size vary with Random, Pressure, Tilt, Bearing or Rotation
Eraser Tool Options gives Angle, Roundness and Size each a variation menu
(Fixed, Random, Pressure, Tilt, Bearing, Rotation) and a Variation field.
path.eraseRegion takes angleMode, roundnessMode and sizeMode with their
variations, sweeps a varying tip as a Calligraphic nib with what the pen
read along the drag, and refuses an unknown mode or a variation out of
range. The Eraser records the pen's pressure, tilt and rotation when a
mode follows them, and its tip outline at the pointer takes the angle,
roundness and size the pen gives while it erases.
2026-11-14 17:08:14 -08:00
dotCooCoo de515d4f73 Merge main into fix/erase-region-params-refused 2026-11-14 13:46:21 -08:00
dotCooCoo 3674865d62 Merge main into feat/smooth-keeps-corners 2026-11-14 09:42:14 -08:00
BFlat d89f593bfa Merge pull request #7380 from ncic/pencil-cursors
Pencil: shows where a stroke continues, connects and closes
2026-11-15 00:38:01 +07:00
dotCooCoo da8f6ab721 Smooth tool: a whole closed path with a corner starts nearest its old start
When a drag reaches every anchor of a closed path that has a corner, the
path is cut open at the corner and refitted. The result started at the
corner unless the refit kept an anchor exactly at the old first anchor.
It now starts at its point nearest the old first anchor, at an anchor
there or at a new anchor split into the curve, as the other closed-path
cases do.
2026-11-14 08:31:41 -08:00
dotCooCoo 132becf3ad Merge main into feat/smooth-keeps-corners 2026-11-14 07:20:07 -08:00
ncic fc47e4782b Pencil: Use Precise Cursors shows the plain crosshair again; a far close is a straight segment 2026-11-14 13:23:22 +01:00
dotCooCoo 952a014694 Merge main into fix/erase-region-params-refused 2026-11-14 04:22:04 -08:00
dotCooCoo 135fc6a3ac Merge main into feat/smooth-keeps-corners 2026-11-14 02:09:42 -08:00
ncic cbd1c142dc Merge remote-tracking branch 'upstream/main' into pencil-cursors
# Conflicts:
#	docs/target-app-parity.md
2026-11-14 09:05:01 +01:00
dotCooCoo b4a7f106ac Merge main into fix/smooth-keeps-closed-start 2026-11-13 22:58:44 -08:00
BFlat 2169e229f6 Merge pull request #7376 from dotCooCoo/fix/int-param-wrong-type
MCP: an integer given as a string or a fraction is refused as the wrong type, not reported as missing
2026-11-14 13:43:27 +07:00
dotCooCoo 0263b4af13 Merge main into fix/smooth-keeps-closed-start 2026-11-13 20:38:29 -08:00
dotCooCoo f9b1c2504f Smooth tool: measure twice the reach along a curve that leaves without a handle
Near an anchor whose handle does not reach out, the curve starts more slowly than its control polygon, so the finely cut stretch could end before twice the reach and the turn there was measured along a long chord. The stretches past it are now cut as finely until the pieces reach three times the reach. docs/mcp.md says the one-eighth cap applies to a closed path the drag reaches all the way round.
2026-11-13 20:28:08 -08:00
dotCooCoo 2b64456e5c Smooth tool: keep corners where the path turns by more than 57.5°
The Smooth tool refit every anchor in the smoothed stretch with a corner
angle of 179°, so a drag across a corner rounded it off. An anchor is now
kept as a corner when the path turns there by more than 57.5° (an
interior angle under 122.5°) at the anchor itself, over the Smooth
radius and over twice the radius on either side. On a closed path the
distances are no more than an eighth of its length. The stretch is cut
at each corner, each part is refit on its own, and the corner keeps its
position. The threshold is the same on every pass and has no setting.

A jag or bump smaller than the radius is not kept: the path does not
turn by that much over twice the radius. A whole closed path with
corners keeps its start anchor when the refit keeps an anchor there. A
drag that changes nothing adds no anchors and no undo step.

Docs: params text for path.smoothRegion, docs/mcp.md,
docs/target-app-parity.md.
2026-11-13 19:01:56 -08:00
ncic 5a55fdce0e Merge upstream main into pencil-cursors
# Conflicts:
#	docs/mcp.md
#	docs/target-app-parity.md
2026-11-14 03:17:11 +01:00
dotCooCoo 78ce56d021 MCP: an integer given as a string or a fraction is refused as the wrong type, not reported as missing
A command that needs a whole number of 0 or more, such as `index` of
`appearance.setItem`, `anchor` of `path.removeAnchor` and
`addon.pen.removePoint`, `sourceDocument` of `edit.dropSelection`, `index`
of `document.activate` and `to` of `document.move`, answered "missing
integer `index`" (or "missing index") both when the key was left out and
when it was given as a value that is not a whole number of 0 or more, such
as "3", 2.5, -1 or true. A value that is given but is not one is now
refused with "`index` must be a whole number", the message object ids
already use. A key left out or given as null is still missing, and an
optional index such as `subpath` keeps its default. Neither error changes
the document or records an undo step.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-13 18:02:42 -08:00
ncic b48688cb1c Pencil: a closed stroke closes with a straight segment
A closed freehand stroke is fitted as the open stroke would be and closed by a
straight segment from its end back to its start. Fitted as one loop, the
closing segment curved on past both ends and back, like a hat's brim.
2026-11-14 02:10:48 +01:00
dotCooCoo 5002b6ac8c Eraser: path.eraseRegion refuses an angle or roundness outside its range
path.eraseRegion clamped roundness to 1-100 and used any finite angle
as given, so a stroke with roundness 400 or 0 erased like one with 100
or 1, an angle of 540 erased like 180, and the call did not report the
bad value. It now refuses an angle outside -180 to 180 degrees and a
roundness outside 1 to 100% with an error naming the key and the range,
and the document does not change. A key left out or null still takes
its default (0 degrees, 100%).

path.split refuses a t outside 0 to 1 the same way. Before, such a t
cut at the segment's end anchor with `segment` and was ignored with
`anchor`.

The Eraser's ranges match its Tool Options fields and are VectorCraft's
own values. The help page gives no range for Angle or Roundness:
https://helpx.adobe.com/illustrator/desktop/draw-shapes-and-paths/modify-paths/erase-paths-using-eraser-tool.html

Adds @msg rows for the two Eraser messages to every complete catalog.
2026-11-13 16:40:54 -08:00
BFlat be1810e0c9 Merge pull request #7263 from dotCooCoo/feat/smooth-free-end-tangent
Smooth tool: an open path's end turns with the smoothing when a drag reaches it
2026-11-14 06:26:31 +07:00
dotCooCoo 380f03345f Merge main into feat/smooth-free-end-tangent 2026-11-13 14:01:37 -08:00
dotCooCoo cccc17d8f5 Merge main into fix/smooth-keeps-closed-start 2026-11-13 13:43:28 -08:00
ncic b67a08dc0a Pencil: shows where a stroke continues, connects and closes
The continuation cursor (a short rising line) shows over an open end of a
selected path before any press, freehand too, and while a continuing stroke
nears an open end of another selected path it connects to. The straight-line
cursor becomes a short level line. A stroke continuing a path, a straight line
too, shows the closing ring within Close Paths When Ends Are Within of the
path's other end, and the release closes it; path.freehand takes the tool's
closed for extend instead of its own four-Fidelity distance.
2026-11-13 22:29:09 +01:00
dotCooCoo 4ea2f2e9c6 Merge main into fix/smooth-fidelity-screen-pixels 2026-11-13 13:03:29 -08:00
dotCooCoo 1567957482 Smooth tool: an open path's end turns with the smoothing when a drag reaches it
When a Smooth tool drag refits the stretch at the first or last anchor
of an open path, the curve there now leaves or arrives along the
smoothed path within the tool's reach instead of along the first or
last segment, so a jagged end no longer keeps its jag. The end point
stays where it is. An end where the smoothed path turns back by 90
degrees or more keeps its segment's direction, and a stretch that ends
inside the path keeps the direction of the part outside the drag.

- pathops: SimplifyOptions gains free_start and free_end, off by
  default; closed subpaths and simplify_part ignore them, so Simplify
  and Object > Path > Smooth give the same output as before.
- engine: path.smoothRegion sets them for the ends of an open path
  that a run's refit reaches.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-13 11:51:02 -08:00
dotCooCoo fb476ca64d Smooth tool: smoothing over a closed path's first anchor keeps its start
When a drag reached the first anchor of a closed path, the smoothed path
started at the first anchor past the drag, and a drag over the whole
path could start it at a corner the refit kept. Dashes and type on the
path then started somewhere else.

The smoothed path now starts at its point nearest where the first anchor
was: at an anchor there, or at a new anchor split into the segment
there, which leaves the outline as it is. Of points equally near, the
one earliest along the path before smoothing, from its first anchor,
is used. A drag that does not reach the first anchor leaves it first,
as before.

Part of #2224.
2026-11-13 11:49:35 -08:00
dotCooCoo d1f76ede8a Smooth: a drag along a segment smooths it when its anchors are out of reach
A Smooth drag along the middle of a curved segment smoothed nothing when
neither of the segment's anchors was within the reach, and paths of two
anchors were never smoothed.

- path.smoothRegion searches each curved segment where it can come
  within the reach, halving it down to pieces no longer than half the
  reach, and adds an anchor in the middle of each stretch in reach; the
  existing reach split then cuts the segment where the drag enters and
  leaves the reach. A drag that only grazes a curve finds the place on
  it nearest the drag. The search is bounded per drag and shared
  equally by the segments in reach.
- Paths of two anchors are smoothed, open or closed.
- Alt with the Paintbrush smooths a selected two-anchor curve; a
  two-anchor straight line still gets the closed stroke. Both sides use
  one segment_is_straight test.

Part of #2224
2026-11-13 10:44:19 -08:00
dotCooCoo 1b935b6d0a Merge main into fix/smooth-fidelity-screen-pixels 2026-11-13 10:13:12 -08:00
BFlat 4f0d3f1eb3 Merge pull request #7111 from dotCooCoo/fix/freehand-tolerance-low-zoom
Pencil: Fidelity keeps its screen size at low zoom
2026-11-14 00:50:47 +07:00
dotCooCoo 137bc11a2c Merge main into fix/smooth-fidelity-screen-pixels 2026-11-13 08:28:42 -08:00
BFlat 43d0b50760 Merge pull request #7157 from dotCooCoo/fix/remove-anchors-one-pass
Paths: Remove Anchor Points removes many anchors of a subpath in one pass
2026-11-13 23:15:10 +07:00
dotCooCoo 3348b41796 Merge main into fix/freehand-tolerance-low-zoom 2026-11-13 08:12:01 -08:00
BFlat d26413c3fb Merge pull request #7117 from dotCooCoo/fix/smooth-tool-smooths
Smooth tool: each drag smooths the path under it, and repeated drags keep smoothing
2026-11-13 23:04:21 +07:00
dotCooCoo fad839f843 Merge main into fix/smooth-fidelity-screen-pixels 2026-11-13 07:29:34 -08:00