A listed word whose text already equals `to` is now left out of the edit.
When every listed word does, the command makes no edit and no undo step,
so the redo history is kept, and `changed` is 0.
text.spelling.check listed at most 10,000 words and always started each
type object at its first byte, so the dialog could not go on inside an
object. With 10,001 unknown words in one object, Ignore ended the check
after the first 10,000. Change All stopped when a round changed nothing,
so a target after 10,000 other unknown words was never reached. Follow-up
to #7744; part of #4936.
- text.spelling.check takes from {id, byte}, which goes on from that
byte of that type object and then the objects after it, and max
(1 to 10,000). The paragraphs before the one that holds from are not
checked again.
- The dialog keeps the words a check lists after the one shown, and
Ignore and Ignore All take the next word from them. A new check goes
on from the last word listed once they run out. Every word is reached,
in a selected group's type too.
- text.spelling.change {to, words} replaces every listed word in one
undo step and lays each object out once. Change All finds every
occurrence with one check after another, then changes them with it.
- Change and Change All to the word shown make no edit and no undo step.
- When another command changes the document or the custom dictionary
while the dialog is open, the next step checks the scope again from
its start. An ignored occurrence stays skipped while the same word is
at the same bytes.
Done ran text.spelling.removeWord and text.spelling.addWord one word at a
time, each saving the file, so a save that failed after a delete was saved
left that word deleted even after Cancel. text.spelling.editDictionary
{remove, add} makes every change, saves once and takes all of them back when
the save fails; Done runs it once.
The custom dictionary's words in a list, with an Entry field and Add, Delete
and Change, applied on Done, as the public Check and correct spelling page
describes it. The menu item moves from the Spelling submenu to the Edit menu,
where the page puts it.
- A custom dictionary file that is there but can't be read whole (not a
file, unreadable, or larger than the 1,000,000 bytes craft-proof reads)
is not loaded and never written over: attaching it logs why, and every
add, delete or change is refused with that reason. A missing file is
still created by the first save.
- When a save fails, the command takes back only its own change, so memory
and file agree; words the save took in from the file stay.
text.spelling.addWord, removeWord and changeWord are Check Spelling's Add
and Edit Custom Dictionary's Add, Delete and Change; text.spelling.dictionary
lists the words. They live in craft-proof, which every language's check
reads. The desktop app and vectorcraft-cli keep them in
`Custom Dictionary.txt` next to the preferences (none without preferences);
elsewhere they last until the app closes.
text.spelling.ignoreAll is Ignore All: the active document's checks skip the
word while it is open; not saved, not undoable, and not a change to the
document's revision.
Behaviour: https://helpx.adobe.com/illustrator/desktop/design-with-text/edit-format-text/check-and-correct-spelling.html
- text.spelling.check gives craft-proof one paragraph at a time, as
check_text_with expects: its language detection reads a paragraph, so a
Vietnamese paragraph no longer leaves the English ones after it unchecked,
and the check stops at the paragraph where the 10,000-word list fills up
instead of proofing the rest of the text first.
- Given `ids` are checked in paint order, as the result promises, not in the
order they were passed.
- Docs: English words come from the first dictionary craft-proof finds
(dictionaries folder Hunspell, SCOWL from craft-i18n, system Hunspell),
with the Moby word list as the last fallback, not from Moby alone.
- Doc comments on the command functions and test helpers.
- text.spelling.check checks a given `ids` as edit.findReplace does
(checked_ids_param): a non-array, a negative, non-numeric or unknown id is
an error instead of a check of the whole document. Null still means every
visible, unlocked type object.
- The byte-offset test puts an em dash, not "café", before the unknown word,
so it passes whichever dictionaries craft-proof is built with (CI builds
with craft-i18n's, where "café" is unknown).
- Docs: the spell check engine in target-app-parity.md (Type advanced rows
and evidence), gaps.md (G4), roadmap.md (M7) and the Language per
character rows of type-parity.md, with status lines and revision history.
The Edit > Spelling items have been placeholders with nothing behind them. This adds the
engine half of Check Spelling on craft-proof, the shared spelling engine in craft-libs (at the
revision the other craft-libs crates already pin), so no word list is copied here:
- text.spelling.check {ids?} lists the words the dictionaries don't know in every visible,
unlocked type object (or ids), each run checked in its Character panel Language (English
when it has none; nothing in a language without a dictionary), as {id, start, end, word,
lang}. start/end are byte offsets in the object's text, the ones text.editRange takes, so a
word is changed with text.editRange as one undo step. At most 10,000 words, with `more`.
- text.spelling.suggest {word, max?, lang?} gives the dictionary's suggestions, asked for one
word at a time as craft-proof recommends.
English comes from the public-domain Moby word list built into craft-proof. Its dependencies
(log, miniz_oxide, toml, unicode-normalization) are already in the lockfile. The Check
Spelling dialog, Auto Spell Check and Edit Custom Dictionary follow in later PRs.