Answers the second CodeRabbit review on #8549.
- A stroke that goes over no filled glyph (stroked type of its own) and
the start and end of an ActualText span now end the stroke pass
(Builder::end_fills): the held strokes are matched, the parked lines
finished and the open line's fills closed, so a later stroke can't go
over an earlier fill and a later span keeps its own replacement text.
- ActualText fills are ordinary entries in the line's fill list, and
span strokes are held and matched in replay order like any other, so
an A/B/A TJ in a span strokes the replacement. The actual_fills map,
stroke_parked and has_actual_fill are gone.
- Past MAX_HELD, the held strokes are matched to the first run of
glyphs filled one right after another that they go over
(Builder::replayed), with bounded work, instead of each to its first
match, which could reach an earlier operator's fill.
- Docs state that past 64 lines in one operator each part stays a
filled object and a stroked one.
- With the Artboard tool chosen, align.toKeyObject fails with "Align to
Key Object isn't available with the Artboard tool" instead of "no key
object": the selected objects can still have a key in that state. The
message has a row in every catalog that has "no key object".
- Align to Key Object is off in Object › Align and the Align panel when
the topmost selected object is inside another selected object, the
case where choosing it already failed.
- The align.toSelection params text says the selected objects keep
their key with the Artboard tool chosen; ui_catalog.rs regenerated.
- A test pins Align to Key Object with a key anchor: checked, the menu
name kept, and the key anchor kept.
The level a new dimension line lands on now comes from the dimension
lines in the document before the dimension's first preview, so its own
preview is never a level. A dimension drawn earlier between the same two
points now acts as a level as well; before, every dimension of those
points was skipped.
- Of two lines on one level, a line the pointer lies across wins over a
line whose end is nearer the pointer.
- A dropped press while placing removes the level guide with the
preview.
- The reach uses the Smart Guides snapping tolerance helper.
- docs/dimensions.md says the rule applies to a dimension anywhere in
the document.
- The tests are split by behavior, with new tests for the same points,
pointer moves in small steps, the guide after a dropped press and
with Alignment Guides off, and the tie-break.
The preview segment from an anchor with an outgoing handle was drawn as a
quadratic curve through that handle, while a click appends a corner
anchor, which makes the cubic curve that leaves along the handle and
arrives without one. The segment changed shape when the anchor went
down. The rubber band now draws that cubic curve.
Part of #8296.
recolor.apply with `group` rewrote the group by place: the new colors went
to its swatches in order, so a gradient, pattern or None swatch in the group
took a color or was removed, at OK and in the live preview.
The group's colors, from the rows or from `groupColors`, now go to its color
swatches in order, and every other swatch keeps its place and its paint.
`groupColors` counts the color swatches only, as the dialog already does
when it lists a group's colors. swatch.editGroup is unchanged.
`transform` read `reflect` with `as_str`, `copy` with `as_bool` and
passed `origin` through unchecked. A `reflect` of `42` or `true`
skipped the reflect step and reported success for the steps before it,
a `copy` of `"yes"` transformed the original instead of a copy, and an
`origin` that was not two numbers fell back to the selection centre.
The handler now checks all three before it selects `ids` or runs a
step, and returns an error that names the argument. A null value of
any of the three is left out. The tool description and the
`transform` row in docs/mcp.md say so.
Fixes#6448
The Command Palette entry said a result matched through a typo comes
after every result the query matches without one. A result the query
matches only through its description ranks below a typo match, as
a_description_match_ranks_below_a_typo checks. The sentence now limits
the comparison to name, menu path and id matches and states that typo
matches come before description-only matches.
A TJ can draw the same glyph at the same place twice (its kerning goes
back), so a stroke can't be matched to a filled glyph as it arrives:
[(A) -3500 (B) 4834 (A)] TJ put the first A's stroke on the last A and
left the earlier parts unstroked. Strokes over filled glyphs are now
held until their stroke pass ends and then matched to the glyphs filled
last, in the order they were filled, so each copy is stroked where it
was filled, while a glyph filled and stroked where one filled before
stands still strokes only the newest. At most 4096 strokes are held.
Docs: ordinary text gives one filled and stroked object per part; in an
ActualText span it stays one replacement object on the first glyph's
line and style.
The reader fills every glyph of a text-showing operator, then strokes
them. When a TJ's kerning started a new line part way through, the
first line was finished before the stroke pass came back to it, so its
strokes found no filled glyph and came in as stroke-only type over
fill-only type.
A line a glyph doesn't fit is now parked while a stroke may still be
drawn over it, and a stroke-only glyph is matched against the open line
and then the parked lines, newest first. Parked lines are finished
oldest first before the open line, so drawing order is kept, and at
most 64 are parked.
The writer passed no language to craft-pdf, so exported and printed
PDFs had no /Lang and accessibility checkers failed primary-language.
Writer::new now passes the BCP 47 tag of the Document Setup language
(new vectorcraft_doc::setup::language_tag, en-US by default) through
write::Writer::new_with_language, which writes the catalog's /Lang and
the XMP dc:language. A language with no tag writes none. /MarkInfo is
left for tagged PDF (#3643).