Commit Graph
34 Commits
Author SHA1 Message Date
yoriswind 3f09579dcd Merge upstream main to resolve PR #6601 documentation conflicts 2026-11-18 02:41:17 -08:00
BFlat 18f8c57a5a Merge pull request #8037 from dotCooCoo/fix/erase-segments-width-bound
Path Eraser: path.eraseSegments refuses a width outside 0.001 to 1000 pt
2026-11-18 10:21:33 +07:00
yoriswind 5f0e011379 Preserve open outlines painted by ancestor strokes 2026-11-17 07:48:02 -08:00
yoriswind 0774371250 #6582: preserve straight fill closure during erasure 2026-11-16 10:57:58 -08:00
yoriswind ffa507e293 M2: reconcile Eraser imports with current Scissors changes (#6582) 2026-11-16 09:44:37 -08:00
dotCooCoo a10c403df6 Scissors: paths a cut makes have every stroke aligned Center
path.split (Scissors) and path.cutAtAnchors (Cut Path at Selected
Anchor Points) keep the source path's fill and stroke settings on the
paths they make, and now set every stroke's alignment to Center in the
same undo step, as the help page describes:
https://helpx.adobe.com/illustrator/desktop/draw-shapes-and-paths/modify-paths/split-paths.html

Every stroke row is reset, hidden ones included. A path of several
subpaths has one appearance, so its other subpaths' strokes are
centered too, and a cut member of a compound path centers the compound
path's strokes. An appearance whose strokes are already centered is
left shared. Knife, the erasers and Divide are unchanged.
2026-11-16 03:46:53 -08:00
yoriswind 573a924d19 M2: preserve evaluated ancestor gradients while erasing 2026-11-15 23:07:02 -08:00
dotCooCoo ea5ab86429 Path Eraser: path.eraseSegments refuses a width outside 0.001 to 1000 pt
path.eraseSegments checked only that `width` was a positive number, so a
width such as 1e300 erased every selected path and a width such as 1e-300
sampled the path too coarsely to find the band. It now refuses a width
outside 0.001 to 1000 pt with "`width` must be from 0.001 to 1000" before
reading the document; nothing changes and no undo step is recorded. Left
out or null, the width is still 8 pt. The range is VectorCraft's own: it
holds every width the Path Eraser tool sends across the view zoom and UI
Scaling limits, and its top matches the Eraser's largest Size.
2026-11-15 21:35:25 -08:00
yoriswind 3d5cce66e1 M2: reconcile gradient-preserving Eraser fix with main (#6582) 2026-11-15 21:22:58 -08:00
yoriswind 1012d7d2b5 M2: preserve gradient placement while erasing 2026-11-15 21:09:45 -08:00
yoriswind 14972b7667 M2: keep erased contours in their clipping mask 2026-11-15 19:49:07 -08:00
yoriswind 2315dc39d5 M2: reconcile open-fill Eraser with current main (#6582) 2026-11-15 18:43:14 -08:00
dotCooCoo b697ecbf07 Merge main into fix/erase-region-params-refused 2026-11-15 18:40:58 -08:00
yoriswind 9db12a27f2 M2: preserve open fills with rectangular erasing 2026-11-15 18:30:22 -08:00
dotCooCoo 418ae818e5 Merge main into fix/erase-region-params-refused 2026-11-15 16:06:28 -08:00
dotCooCoo 46e5ab21e0 Merge main into fix/pen-input-params-pressure-tilt-rotation 2026-11-15 16:06:17 -08:00
dotCooCoo 6c74a77a6d Eraser: an Alt-drag erases everything inside a marquee, a square with Shift
With Alt held at the press, an Eraser drag draws a marquee from the press
point to the pointer instead of a stroke, and the release erases everything
inside it. Alt+Shift keeps the marquee square on its larger side, Escape
cancels it, and a click or a drag along one axis erases nothing.

path.eraseRegion takes {rect: [x, y, width, height]} in place of points.
Closed paths lose the rectangle's area; open paths are cut where they cross
its edges, found from the exact crossings, so a narrow rectangle across a
long segment still cuts it. A width or height of 0 or less, a non-finite
value, or points and rect together is an error, and nothing erased adds no
undo step.

Docs: docs/mcp.md, docs/ui-parity.md.
2026-11-15 12:13:13 -08:00
dotCooCoo 495513f0b6 Pen input: out-of-range pressure, tilt, rotation and size values are refused
The drawing commands that read pen values at their points (path.freehand,
brush.freehand, path.knife, path.eraseRegion, path.eraseSegments,
path.smoothRegion, path.joinScrub and path.blob) now refuse a pressure
outside 0 to 1, a tiltX or tiltY outside -90 to 90 and a rotation outside
0 to 360, naming the key. A tilt was kept within range and a pressure or
rotation was passed on. A point array of more than six numbers is refused,
naming the point, instead of having its extra entries ignored.

path.blob and path.eraseRegion refuse a size outside 0.1 to 1000 pt, the
range of the Blob Brush and Eraser tool options. path.blob refuses a
sizeVariation outside 0 to 1000 pt in every sizeMode and with the mode left
out. path.eraseRegion refuses a sizeVariation over 1000 pt in every mode
with the same message, and a negative one still gives "sizeVariation must
be 0 or more". Each refusal leaves the document, the selection and the
undo history unchanged; null and omitted values still take the defaults.

The tip variation test uses a 1000 pt tip and a 1000 pt Fixed variation,
the largest values path.eraseRegion now takes.

Docs: params text, docs/mcp.md, docs/target-app-parity.md.
2026-11-15 03:28:25 -08:00
yoriswind 5bddcd83eb M2: preserve fill-only erasure with varying tips 2026-11-14 21:46:29 -08:00
dotCooCoo 4a0332e30f Merge main into fix/erase-region-params-refused 2026-11-14 20:42:40 -08:00
dotCooCoo 6c585de940 Eraser: Angle, Roundness and Size vary with Random, Pressure, Tilt, Bearing or Rotation
Eraser Tool Options gives Angle, Roundness and Size each a variation menu
(Fixed, Random, Pressure, Tilt, Bearing, Rotation) and a Variation field.
path.eraseRegion takes angleMode, roundnessMode and sizeMode with their
variations, sweeps a varying tip as a Calligraphic nib with what the pen
read along the drag, and refuses an unknown mode or a variation out of
range. The Eraser records the pen's pressure, tilt and rotation when a
mode follows them, and its tip outline at the pointer takes the angle,
roundness and size the pen gives while it erases.
2026-11-14 17:08:14 -08:00
dotCooCoo 5002b6ac8c Eraser: path.eraseRegion refuses an angle or roundness outside its range
path.eraseRegion clamped roundness to 1-100 and used any finite angle
as given, so a stroke with roundness 400 or 0 erased like one with 100
or 1, an angle of 540 erased like 180, and the call did not report the
bad value. It now refuses an angle outside -180 to 180 degrees and a
roundness outside 1 to 100% with an error naming the key and the range,
and the document does not change. A key left out or null still takes
its default (0 degrees, 100%).

path.split refuses a t outside 0 to 1 the same way. Before, such a t
cut at the segment's end anchor with `segment` and was ignored with
`anchor`.

The Eraser's ranges match its Tool Options fields and are VectorCraft's
own values. The help page gives no range for Angle or Roundness:
https://helpx.adobe.com/illustrator/desktop/draw-shapes-and-paths/modify-paths/erase-paths-using-eraser-tool.html

Adds @msg rows for the two Eraser messages to every complete catalog.
2026-11-13 16:40:54 -08:00
yoriswind 00ee02fde0 Merge current main for Eraser fill repair (#6582) 2026-11-12 05:40:57 -08:00
dotCooCoo 5c2e182388 MCP: a malformed object id is refused as such, not reported as missing
Commands that need an object id read it with `id_param`, which returns
None for a value that is not a non-negative integer, so `{"id": "5"}` or
`{"id": -1}` was refused with "missing id". They now read it with
`object_param`, which refuses such a value with "`id` must be a whole
number", naming the key. This covers `document.node`, the `path.*` anchor
and handle commands, the `text.*` range and path commands, the mesh,
envelope and slice point commands, `layer.target`, `layer.move`,
`node.move`, `select.magicWand`, and the `source`, `target`, `group` and
`path` keys of `appearance.transfer`, `appearance.copyFrom`, the
`livePaint.*` commands and `text.createInPath`.

The optional `group` of `livePaint.fill` and `parent` of `node.move` are
refused the same way when given. Before, a malformed `parent` moved the
object to the top level and a malformed `group` fell back to the
selection.
2026-11-11 12:47:49 -08:00
yoriswind 1869fc4ae8 M2: scope open-path erasing to fill-only artwork 2026-11-11 12:40:24 -08:00
yoriswind f6c48fd86b G11: preserve explicit strokes when erasing ordinary filled open paths 2026-11-11 12:08:18 -08:00
yoriswind ff9f18e8ef M2: preserve Eraser appearance and outline grouping 2026-11-11 07:21:55 -08:00
yoriswind 24078d6071 M2: preserve filled open paths when erasing (#6582) 2026-11-11 06:42:13 -08:00
dotCooCoo 7eb1006abb Scissors: a cut leaves one of the two new end points selected
After a Scissors cut (`path.split`) the whole path stayed selected: both
pieces of an open path, or the opened path of a closed one. A Direct
Selection drag from the cut then moved every anchor, so an ellipse cut
at an anchor could not be pulled open by dragging its end.

- `path.split` selects the first anchor of the piece after the cut and
  nothing else, as `path.cutAtAnchors` does: anchor 0 of an opened
  closed subpath, of the new path when an open path becomes two, or of
  the subpath added to a path of several subpaths.
- A Direct Selection press on anchors of a selected path that lie on top
  of each other takes the selected one. It took the first in path order,
  which in a path of several subpaths was the unselected end.

Docs: docs/mcp.md, docs/target-app-parity.md, the `path.split` params
text.
2026-11-10 15:04:50 -08:00
dotCooCoo e8e09af782 Brushes: Calligraphic and Scatter values follow pen tilt, bearing and rotation
Squashed from #5031 onto main.
2026-11-02 14:33:02 +07:00
bflatastic 71fbdf5ff0 Eraser: Size follows the pen pressure too (#3961)
Eraser Tool Options' Size takes Fixed or Pressure and a Variation as the
Blob Brush's does: the tool records the pen, and path.eraseRegion outlines
the squashed drag at the pen's widths, stretched back to the tip's angle
and roundness. The pressure parsing and outline move to draw2's common
helpers, shared by both commands.
2026-10-30 01:13:20 +07:00
NetterSilverandClaude Opus 5.5 b6422e5ba1 Keep compound path holes when using the Eraser and Knife
Fixes #4495

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 09:57:34 +07:00
Dylan M. Taylor 7043ef6f3d Extract geometry command helpers 2026-10-28 16:44:11 +00:00
aiongg 71aef5cc85 refactor(engine): move cmd/draw2.rs items to cmd/draw2/{anchors,commands,common,cut,freehand,smooth}.rs 2026-10-26 22:01:25 +00:00