Commit Graph
16972 Commits
Author SHA1 Message Date
dotCooCoo 432413274e UI: comments describe the behavior instead of comparing it with other apps
Comments in the ui-egui crate described panels, menus, dialogs, widgets
and cursors by comparison with other applications ("as in ...",
"...-style", "like ...'s"). They now say what VectorCraft does. The
section header for raster effects in nine translation catalogs changes
the same way.

The change edits comments only. No code, string or catalog row changes.
2026-11-16 06:17:59 -08:00
dotCooCoo 2a464df744 Magic Wand: test that magicWand.set refuses a reset that is not true, false or null
The rejection test now gives `reset` a string and checks that the call returns an error and leaves the settings unchanged.
2026-11-16 06:10:21 -08:00
dotCooCoo 28f492043f Expand: Alt/Option on Object › Expand… expands at once with the last OK'd choices
The Expand dialog now keeps the Object, Fill, Stroke, Expand Gradient
To and steps choices that OK last expanded with, until the app quits,
and opens on them. Cancel and an OK that fails leave them as they were.

Choosing Object › Expand… in the in-window menu bar with Alt (Option on
macOS) held expands the selection at once with those choices, in one undo step, as OK would.
Before any OK it uses the dialog's defaults. When none of the choices
has something to expand in the selection, the dialog opens on them
instead and nothing changes. The help page describes the shortcut for
gradients:
https://helpx.adobe.com/illustrator/desktop/manage-objects/arrange-objects/expand-objects.html

ui.expandDialog takes immediate?: bool for this. A null immediate is
treated as omitted, and any other value that is not true or false is
an error.
2026-11-16 06:02:12 -08:00
dotCooCoo 9973247dfc Type: test that Show Similar Fonts puts a family without numbers first when asked about it
The test now lists that family last, so it passes only when the family
asked about is moved to the front and the others keep their order.
2026-11-16 06:00:19 -08:00
dotCooCoo 2be34a95f1 Merge main into feat/symbols-drag-to-new-duplicates 2026-11-16 06:00:13 -08:00
dotCooCoo 8ca9613337 Isolation mode: a click on the isolation bar's empty space exits isolation mode
A click on the isolation bar's empty space, or on the isolated object's
name at the end of the breadcrumbs, leaves isolation mode altogether, as
Exit Isolation Mode does, nested isolation included. The back arrow, the
breadcrumbs of the levels above and the pattern buttons keep their own
actions, and a drag across the bar does not exit.

While an opacity mask is edited the click stops editing the mask. In
symbol editing mode it leaves the mode, also from a group isolated inside
the symbol's art and together with the isolation the mode was entered
from. While a pattern is edited it does nothing; Save a Copy, Done and
Cancel end pattern editing.

Docs: docs/target-app-parity.md.
2026-11-16 05:56:36 -08:00
FredApps 4a328df848 Merge remote-tracking branch 'origin/main' into refactor/eps-shared-write 2026-11-16 14:56:00 +01:00
dotCooCoo 70fdab8445 Export for Screens: Single file PDFs are refused for assets, layers and each object
With `pdfs: "single"` and several assets, layers or selected objects
(`selection: "each"`), document.exportForScreens wrote one PDF named
after the document holding only the first item's art, and every other
item's PDF was left out. Single file puts artboards on the pages of one
PDF; each asset, layer or object is cut out of the document with its own
art, so the export now refuses that combination before it writes any
file, and the Example line refuses it too. `pdfs: "multiple"` still
writes a PDF of each item, and `selection: "one"` writes one PDF either
way.

Docs: params text, docs/mcp.md, docs/target-app-parity.md.
2026-11-16 05:50:00 -08:00
dotCooCoo 756341ddc9 Character panel: work out the selected stories once, not once per field
With the Selection tool, every Character and Paragraph field read its
value through selected_stories, which walked the selected objects and
looked up each type object's story again. With the default panels open
that was 24 builds of the same list per frame.

selected_stories and selected_story_texts now keep the last list,
with the document (a held Weak keeps its address from being reused),
its revision and a copy of the selected objects. A change to any of
them builds the list again. Type objects are still resolved from the
current document on every read, so the panels show the same values.

Tests compare the kept list with a fresh build after an edit, a
reordered or replaced selection, a selection set without a new
revision, a selected group and a switch to another document at the
same revision; compare what both panels draw and their field values
with and without the kept list; and count one build per frame.
2026-11-16 05:41:04 -08:00
dotCooCoo f76735fcb4 Merge main into fix/similar-fonts-no-numbers 2026-11-16 05:38:12 -08:00
dotCooCoo c6046dacec Graphic Styles: the white fill of a no-paint preview covers type's characters
A style with no fill and no stroke whose Characters row sits above some of
its rows showed its type preview with the characters' own fill over the
white backing when Override Character Color was off. The backing now puts
every row above the contents, so the white fill covers the characters.
2026-11-16 05:37:33 -08:00
FredApps b352745d44 Merge pull request #8117 from storytold/imoto/svg-writer-consumer
svg: write the document wrapper through craft-svg
2026-11-16 14:36:56 +01:00
dotCooCoo 69b4f3ae96 Shape tools: Backtick held at the press measures the first copy from there
A drag that starts with Backtick already down set the copy spacing origin at the first drag event, so a short first stretch of the drag could leave no copy. The press now sets it.
2026-11-16 05:34:43 -08:00
dotCooCoo a7c7e2bed8 Arrange: a floating window does not take a tab transfer whose target changed
A release over another document's floating window is handled before the
frame's drag cleanup. When another document became current after a tab
hover started the transfer, cleanup would have canceled it, but the
floating window still copied the artwork. The pane drop now also checks
that the transfer's target is still the current document, as cleanup does.
2026-11-16 05:33:31 -08:00
dotCooCoo ebeffa15ab Live Paint: a Bucket drag from an edge strokes every edge it crosses
A press on an edge (Shift with Paint Fills alone, or a plain press with
Paint Strokes on) now starts a drag, as a press on a face does. The drag
paints the edge and every visible edge of the same group that it crosses
or comes within 0.0001 pt of, between pointer events and on the release,
as one undo step; Escape cancels it. Edges of other groups and hidden
edges keep their strokes, a drag over edges that already have the stroke
records no undo step, and a drag that starts on a face still fills only
faces. A double-click after such a drag joins through the edges the drag
stroked as the paint they had before it.

livePaint.strokeEdge takes the drag's points and continuation as
livePaint.fill does, and both refuse them with scope connected or
samePaint.

Help page: https://helpx.adobe.com/illustrator/desktop/paint-and-fill/learn-painting-basics/paint-with-the-live-paint-bucket-tool.html
2026-11-16 05:32:00 -08:00
dotCooCoo 75b02ea8df Symbols: the panel reads the current symbol without running symbol.list
The Symbols panel and its panel menu asked for the current symbol on
every frame by running symbol.list, which builds a row per symbol and
walks the whole document once per symbol to count its instances. They
now read it from the active document with cmd::current_symbol, the
rule symbol.list itself uses for its `current`: the stored name while
a symbol has it, else the first symbol. symbol.sortByName,
symbol.place, symbol.options and text.insertInline use the same
function, and symbol.list's reply is unchanged.

An idle frame of the panel or its menu now runs no command, so on
macOS the native menu is not brought up to date on every frame while
the panel is open. In a document with 200 symbols and 50,000 objects
the read takes 0.035 us instead of 48.5 ms in a release build (thread
CPU time on Linux, median of 7 runs). The gain matters on large
documents; on small ones it is too small to notice.
2026-11-16 05:29:31 -08:00
dotCooCoo 3a3bafd006 Layers: a target circle dropped on Delete Selection reduces the item to basic appearance
Dropping a layer, group or object's target circle on the Layers panel's
Delete Selection button now runs Reduce to Basic Appearance on that item
instead of Clear Appearance. The item keeps its topmost visible fill and
stroke, loses its other rows and its effects, and is not deleted. A drop
that changes nothing records no undo step. The help page describes this
drag as the alternative to Reduce To Basic Appearance:
https://helpx.adobe.com/illustrator/using/appearance-attributes.html

Before this change the drop also removed the remaining fill and stroke
and reset the object's opacity and blend mode.
2026-11-16 05:29:10 -08:00
dotCooCoo c8ca3a2f58 MCP: confined exporter plug-ins and unreadable linked files keep paths outside the read roots
Under automation read roots, an exporter plug-in's format (plugin.<id>)
counts as an output that carries the native document, since its plug-in
is given the document's JSON. document.serialize, document.export,
document.exportSelection, Export for Screens and assets.export rows and
file.exportAs refuse it before the plug-in runs and before any file or
folder is written when the document links a JavaScript file, a linked
image or placed file, a kept relative path or a data set's image outside
the roots, with the existing errors. The JSON the plug-in is given leaves
out an Export for Screens folder outside the roots.

file.package refuses, before anything is written, a linked file whose
native document it can't read to check: a native document that doesn't
load, a PDF or .ai file that can't be opened (one that needs a password
to open, or a damaged one), and a PDF, .ai or EPS file whose editing data
doesn't load. The error, "a linked file's editing data can't be read to
check it against the read roots", names no file or folder and gets rows
in the complete-message catalogs. A PDF or EPS file without editing data
is copied as before, and packages made without read roots are unchanged.
2026-11-16 05:24:45 -08:00
dotCooCoo 8e59bcb026 Arrange: the canvas takes a drop where the button went up
The canvas took carried artwork only while the pointer was over it at the
end of the frame. A release inside the canvas followed in the same frame by
a move onto the tab strip kept the drag alive past cleanup, and the drop was
lost when the frame ended. The canvas now checks the release position
against its own rect and layer, as the tiled and floating panes do
(canvas/panes.rs artwork_over).
2026-11-16 05:21:53 -08:00
dotCooCoo 8a47799f17 Magic Wand: Fill Color and Stroke Color tolerances compare CMYK values in a CMYK document
In a CMYK document the Fill Color and Stroke Color tolerances run from 0
to 100 and measure the Euclidean distance between the C, M, Y and K
percentages; RGB, Gray and Lab colors are converted to CMYK. RGB
documents keep the 0 to 255 RGB distance. The panel's fields take the
range of the active document.

A tolerance above 100 set in an RGB document is kept and applies as 100
while a CMYK document is active. magicWand.set now returns an error for
a tolerance that is out of range or not a number, and for a switch that
is not true or false, and then changes no setting, reset included;
before, it clamped the values and applied reset first.
2026-11-16 05:15:24 -08:00
dotCooCoo 0897b32a78 Isolation mode: the canvas context menu isolates one selected path
With one path selected, a member of a group or a compound path included,
the canvas context menu now has Isolate Selected Path (object.isolate),
next to where Isolate Selected Group shows for one group or compound path.
Neither item shows for an object that object.isolate refuses: a hidden or
locked object, one in a hidden or locked group or layer, a guide while
Lock Guides is on, and, while a symbol is edited, an object outside the
symbol's art.

Help page: https://web.archive.org/web/20210601162814/https://helpx.adobe.com/pdf/illustrator_reference.pdf#page=324
2026-11-16 05:06:04 -08:00
dotCooCoo edecf9bf41 Shape Builder: the status bar says why a click or drag built nothing
A Shape Builder gesture that builds nothing now says why when it is
released: "select paths or compound paths" when nothing usable is
selected, "select all paths you want to merge" when the pointer is over
a path or compound path outside the selection, and "no region under the
pointer" otherwise. The message changes nothing in the document, the
selection or the undo history, and the next gesture that builds
something clears it. A gesture made while a large selection's map is
being built gives its message once, when it is replayed.

Tools get Action::Status, which the session passes to the status bar;
the new message has a row in every complete-message catalog.
2026-11-16 05:05:16 -08:00
dotCooCoo 7522575af2 MCP: a confined single-file PDF checks only the document it carries
With Export PDFs As set to a single file, a PDF row writes the first
item's document alone. The check for linked images outside the read
roots now looks only at that document, so an image linked in a later
asset no longer refuses a file that does not carry it.
2026-11-16 05:01:46 -08:00
dotCooCoo 101e4625e9 Graphic Styles: a style with no fill and no stroke shows an outlined shape with a red slash
A style whose rows paint nothing showed as a blank white tile. Its
thumbnail now shows the preview square or type outlined in black and
filled with white, with the style's effects, under a red slash. The
panel's views, the Control bar's Style picker and chip, the dragged
chip, graphic style library panels and the large preview on the
selected object all show it. A row that paints None does not count as a
fill or stroke; a hidden row or one with zero opacity does.
2026-11-16 04:59:07 -08:00
dotCooCoo 9ecc8087c3 Shape tools: Backtick held while dragging leaves copies of the shape
Holding Backtick while dragging out a rectangle, rounded rectangle,
ellipse, polygon, star or line leaves a copy of the shape being drawn
each time the pointer has moved 8 screen points with the key down, up to
128 copies a drag. Each copy is its own object, drawn as the drag showed
it then. The release keeps the copies and the last shape as one undo
step, and Escape takes them all back. The spacing and the limit are
VectorCraft's own values.

The `backquote` descriptions of `pointer_gesture` name the shape tools.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-16 04:53:06 -08:00
dotCooCoo 64dfd6ca14 Repeat: dragging a Radial Repeat's splitter hides instances and the others keep their places
With one radial repeat selected, the Selection tool shows a splitter on
its circle, half a step past the last instance shown. Dragging it back
around the circle hides the instances it passes, and dragging it forward
shows them again; one instance stays shown at least. The instances left
keep their places: the repeat keeps the count shown in instances and
spaces them a full circle's step apart with endAngle, and the full
circle's count is read back from that step. Each drag previews and
commits object.repeat.options as one undo step, Escape cancels it, and a
drag that ends where it began leaves no undo step. There is no splitter
when the step does not divide a full turn, for one instance to a turn or
with a radius of 0. The radius handle of a single instance sits opposite
it.
2026-11-16 04:50:48 -08:00
dotCooCoo bf8c08e2a1 Recolor Artwork: the Edit tab's wheel can show brightness and hue
A button under the Add Color and Remove Color tools switches both Edit
tab wheels between hue with saturation and hue with brightness. On the
brightness wheel a marker's distance from the center is its brightness
(black at the center, full at the edge), a drag sets hue and brightness,
the slider under the wheel edits saturation, and Add Color adds the hue
and brightness clicked at the base color's saturation. The segmented
wheel's five rings become brightness steps. Switching changes no color,
the button is off for the color bars, and each opening shows hue and
saturation. The dialog field is `wheelAxes` (`hueSaturation`,
`hueBrightness`).
2026-11-16 04:50:45 -08:00
dotCooCoo cc6721f2d0 Type: Size › Other… gives the Character panel's Font Size field the focus
Type › Size ends with a separator and Other…, which runs the new UI
command type.highlightFontSize. It shows the Character panel and gives
its Font Size field the keyboard focus with the value selected, so a
size the list does not hold can be typed and applied with Enter.
Without selected type it fails with the existing error, as Highlight
Kerning does, and the menu item is dimmed, as Bold and Italic are.

The Font Size field now takes an armed focus: unit_field_from selects
and focuses the field as bounded_field_reading already does.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-16 04:49:31 -08:00
dotCooCoo 7b04069d1e Arrange: a drop uses the position and Alt of the button release
A frame can carry the primary button's release and then a pointer move or
a change of modifiers. The tiled pane, the floating window and the canvas
read the pointer position and Alt at the end of the frame, so a move after
the release could change where the artwork landed or which pane took it,
and Alt let go in the same frame moved the originals instead of copying
them. The drop now takes its position and Alt from the release event, as
the canvas already does for its own drags (canvas/input.rs release_pos).
2026-11-16 04:47:18 -08:00
Sven Lafebre ab141cfa10 Fix #8093: members of a clipping path that clips by nothing are hidden
A clip group whose clipping path clips by nothing (an empty group) hides its
members on the canvas, but Pathfinder skipped the group altogether, so
Intersect gave the other objects' overlap. Its members now get an empty
region and count as hidden like any other masked art.
2026-11-16 13:45:59 +01:00
dotCooCoo 4e8ff28cb4 .ai graphs: a filled-line series keeps no stroke, so turning Draw Filled Lines off draws its thin line
A series read from bands with unstroked markers, or bands alone, kept an
explicit no-stroke paint. With Draw Filled Lines turned off, the thin line
took that paint and was not drawn. Such a series now keeps no stroke, as a
graph drawn here does, and its thin line is drawn in the series color at
1 pt. A series whose markers carry a stroke keeps it.
2026-11-16 04:36:43 -08:00
dotCooCoo 10edf89f36 Glyphs: read a face's character list once instead of on every frame
The Glyphs panel asked the face for its characters on every frame, and
each call read the whole cmap, sorted it and removed repeated
characters. A face now keeps the list the first time it is asked for
(FontFace::mapped_chars) and shares it; FontFace::chars returns a copy
of it, in the same order. The panel finds a Unicode subset's characters
by searching the sorted list, and Entire Font uses the face's shared
list of unencoded glyphs instead of copying it each frame. The cells the
panel shows do not change.

Measured in one release process, old read and shared list alternating,
median of 7 samples of 100 calls, wall-clock times from a single run:
- Source Sans 3 Regular, 1,614 characters: 0.0101 ms to 0.000004 ms
- a test font of 50,000 characters: 0.2347 ms to 0.000004 ms
The saving matters for fonts with large character maps, such as CJK
fonts.
2026-11-16 04:35:29 -08:00
Dylan M. Taylor 568d25bf17 Merge main and preserve EPS shared writer dependency 2026-11-16 07:34:47 -05:00
dotCooCoo 9e58e137e1 Merge main into feat/place-linked-eps 2026-11-16 04:24:51 -08:00
dotCooCoo 549d1fb967 Package: copy a placed document's held PostScript bytes only under a PostScript file name
When a placed EPS or PostScript .ai file is gone, File > Package writes
the PostScript bytes the document holds only for a placed document whose
file name ends in .eps, .epsf, .ps, .ai or .ait. Under any other name,
or for a linked image, the link is reported as missing and nothing is
written for it.
2026-11-16 04:23:06 -08:00
Dylan M. Taylor ebf49351e6 build(eps): pin merged shared PostScript writer 2026-11-16 07:15:30 -05:00
dotCooCoo 70a8ccc8a2 Merge main into feat/radial-repeat-splitter 2026-11-16 04:13:30 -08:00
ruchirguitar d7a1877e98 #8053: keep French tangent punctuation nonbreaking 2026-11-16 17:41:20 +05:30
Sven Lafebre 099ab6ea13 Fix #8093: a hidden operand is an empty shape where it changes the result
A selected object its clipping masks hide altogether was left out of the
operation. For Intersect, Minus Front (hidden at the back), Minus Back
(hidden in front) and Crop (hidden on top) that changed the result: the
others' overlap or the next object down took its place. It now stays in as
an empty shape for those four, which then give nothing. The other operations
still leave it out, which gives the same art and keeps its style off the
result.
2026-11-16 13:11:07 +01:00
dotCooCoo f54a3faa39 Packaging Tools: Check Fold Lines reports overshooting and stacked fold lines
- A crease that runs past the cut outline by the tolerance or more is
  reported as outside, though its hinge is still built.
- Two lines that fold, of any role, on top of each other are reported as
  duplicate; a line drawn twice is still checked for where it lies.
- Hidden lines are left out in every scope, members of a selected group
  included.
- The ids scope gets its own noCut message.
- The notStraight, ambiguous and summary texts say what the check finds:
  the summary counts hinges, not creases.
- The fold angle fields, which nothing in this change reads, are removed.
- A window drawn as open cut lines stays a hole when a cut line crosses
  it or when slits join it to an outline of open lines, so that three
  lines meet at a corner. Cut lines drawn whole that cross a cell leave
  it material.
- A slot drawn across the outline is a notch, not a hole, as when the
  notch is drawn in the outline; a crease in it lies outside the blank.
- notStraight measures each hinge piece at its farthest point from the
  hinge line instead of at five samples.
- Cut lines drawn on top of each other so many times that the gap search
  would look at more than 16,777,216 pairs are reported as tooComplex
  before the search.
2026-11-16 04:10:41 -08:00
FredApps 631441ce86 svg: write the document wrapper through craft-svg (#778, #789)
The XML declaration, DOCTYPE entity subset and root <svg> open now go
through SvgWriter. Mapping and the rest of the document stay in the app.
Width and height stay unitless in one place so #7105 can rebase.
2026-11-16 13:10:03 +01:00
dotCooCoo ec57fd6625 Merge main into fix/status-notes-copy-cut-trace 2026-11-16 04:06:45 -08:00
dotCooCoo a31d8c31f7 MCP: confined native output refuses linked image paths outside the read roots
Under automation read roots, every output that carries the native document
(a native file or template, an EPS file, a .ai or .ait file of every
artboard, a PDF of every artboard with Preserve Editing, from
document.serialize, document.export, document.exportSelection,
document.exportPdf, the saves, file.exportAs and Export for Screens rows)
is refused with "a linked image file is outside the read roots" when that
document names a linked image or placed file, a kept relative path or a
data set's image outside the roots, or holds a stored brush entry that
does not read as a brush. Nothing is written and the error names no file
or folder. Outputs without the native document are written as before.

The native document these files carry, and the documents file.package
writes or rewrites, leave out an Export for Screens folder outside the
read roots, as SVG with Preserve Editing already did. file.package refuses
a linked file it copies as it is (a PDF, .ai or EPS file, or a native
document with relink off) whose native document keeps such a folder, with
"a linked file's export folder is outside the read roots".

Export for Screens rows that write one artboard as a native, .ai or EPS
file are checked against that artboard's art. Each asset, layer or
selected object now writes its own native, .ai or EPS file: the per-artboard
document cache was keyed by artboard index alone, so every piece after the
first wrote the first piece's document.

Both messages get rows in the complete-message catalogs.
2026-11-16 03:58:13 -08:00
dotCooCoo 5e36bba7d6 Merge main into fix/arc-params-reject-invalid 2026-11-16 03:52:45 -08:00
dotCooCoo 66c7dcd38f Shapes: invalid arc options and grid counts are errors instead of defaults
shape.arc returns an error for a reference that is not a whole number
from 0 to 8, a baseAlong other than x or y (either case), null included
for both, and a slope outside -100 to 100, in both of its forms. Before,
such a value drew the arc from reference point 0 or 8, along the X axis
or with the nearest slope. shape.rectangularGrid and shape.polarGrid
return an error for a divider count that is not a whole number of at
least 0; before, it took the default 5. Each error names the key,
nothing is drawn and no undo step is added. Left-out values keep their
defaults.
2026-11-16 03:52:38 -08:00
dotCooCoo 72b14d6aaa Merge main into feat/drag-into-floating-window 2026-11-16 03:52:07 -08:00
FredApps 7452b6f383 Merge pull request #7669 from storytold/feat/cutover-remaining-codecs
refactor(codecs): partial shared image-codec cutover, preserving remaining readers
2026-11-16 12:50:00 +01:00
ruchirguitar 49637d63ac 4028: merge main and exercise picker and row-menu UI 2026-11-16 17:18:38 +05:30
dotCooCoo 52bbca2ecb Type: Show Similar Fonts lists a family with no numbers in common after the measured ones
FontLikeness::distance left out every number either face does not give,
so a family whose faces give none of them (static faces with no OS/2 or
post table) was 0 from every family, and Show Similar Fonts could list
it right after the chosen family, as an exact match. Faces that share
no number to compare are now f32::INFINITY apart, so such a family
comes after every family of its script group that shares one, and
families equally far keep their order. The order of measured families
does not change. This is VectorCraft's own rule.

Builds on #7983, which added Show Similar Fonts.
2026-11-16 03:47:51 -08:00
dotCooCoo a10c403df6 Scissors: paths a cut makes have every stroke aligned Center
path.split (Scissors) and path.cutAtAnchors (Cut Path at Selected
Anchor Points) keep the source path's fill and stroke settings on the
paths they make, and now set every stroke's alignment to Center in the
same undo step, as the help page describes:
https://helpx.adobe.com/illustrator/desktop/draw-shapes-and-paths/modify-paths/split-paths.html

Every stroke row is reset, hidden ones included. A path of several
subpaths has one appearance, so its other subpaths' strokes are
centered too, and a cut member of a compound path centers the compound
path's strokes. An appearance whose strokes are already centered is
left shared. Knife, the erasers and Divide are unchanged.
2026-11-16 03:46:53 -08:00