* cad: export DXF through craft-dxf's drawing writer
Delete the local ASCII writer and map the document through
craft_dxf::drawing. Public vectorcraft_cad::export, DxfOptions and
DxfVersion stay so vectorcraft#3068 can rebase without a writer API
change. Pin craft-dxf at the craft-libs#1588 branch tip; update the
rev after that PR merges. Golden files lock shapes_doc() bytes for
R12 and 2018 against the old writer. Part of storytold/craft-libs#791
and #778.
* cad: pin craft-dxf to the #1588 tip with Dylan's writer fixes
Point craft-dxf (and craft-codepage from the same rev) at
0b6244f2b9971deaeb6a79d932c818ff94479757, which includes the
Windows golden line-ending fix, BYBLOCK and image-dictionary
key changes, and the compile fix for the dictionary-key test.
Update the pin again to the merge commit after #1588 lands.
* cad: pin shared DXF writer to merged craft-libs #1588
---------
Co-authored-by: FredApps <FredApps@users.noreply.github.com>
Column… and Marker… count a graph's series as graph.column and
graph.marker do, so a graph whose data was cleared shows neither.
When a translated Graph Type… or Graph Data… label does not fit in half
of the panel, each button of the pair takes a row of its own at full
width instead of clipping its label.
When an arriving box that joins everything it overlaps covers an open
box to the right and above, and ends higher than it, the open box now
keeps only its part below the arriving box's bottom. The sweep's tree
holds each open box by its current top, at a place that is either a
box's top or just below a box's bottom, so a box can be cut short from
above, from below, or both. Any later box that would have met a removed
part meets the arriving box instead, which is open at least as long and
in the same set, so the groups stay the same. A box held by an open box
is not opened and cuts nothing short.
512 boxes, each 1 pt right of and above the one before, or left of and
below it, now meet 511 open boxes in the sweep instead of 130,816, with
and without transparency.
SVG reorders right-to-left characters only within a text chunk, while one
text object reorders the whole line. In
<text x="100 160 220" direction="rtl">אbג</text> the left-to-right b is
drawn right before ג with no kerning between them, so ג stayed where the
line put it and the import warned.
When kerning cannot put every absolutely placed character on its x, the
text is now cut before each such character and each piece is placed
again, and the text imports as a group of point type objects named after
the element. A text one object can place stays one object. A split text
in a clip path clips by the outlines of all its objects.
An image that SVG import writes again as PNG (a TIFF, or a PNG, JPEG,
GIF or WebP whose orientation turns it) now keeps the ICC profile its
file carries, as an iCCP chunk, when the profile's color space is the
stored samples': gray for gray samples, RGB for RGB ones. Open and
Place already keep it. Profiles of another color space, ones too short
to be a profile, and the profile of a TIFF whose own reader converts
its pixels to RGBA are left out, and the image still imports. Sample
types a PNG doesn't hold are stored as 8-bit RGBA, as Open and Place
store them.
Graph Type… now opens Object › Graph › Type…'s own dialog (graphType)
since main made Graph Type a dialog of its own, so the test checks that
kind and the graph's column type instead of the generic command dialog.
Reuse the panel deletion helper so the clicked swatch is deleted only after confirmation. Cover confirmation text, cancellation, clicked-item targeting and Undo across all five views. All 39 Swatches tests and all 13 local CI gates pass; fresh deep CodeRabbit review reports zero findings.
When image resource 1050 declared more bytes than the image resources
hold, the lookup stopped as if the file stored no slices, and Open and
Place brought the artwork in without the warning that the slices were
left out. The new psdread::resource tells a cut-short resource 1050
apart from one that is absent or that follows another block cut short,
and the slices reader passes that error on, so the warning names it.
Other resource readers keep their behavior.
Paste without Formatting sets each pie legend label in a wedge to white or
black from the wedge colors before it pastes, but a wedge linked to a global
swatch that the document gives another color takes the document's color
only during the paste (swatchConflict "merge", the default). A light wedge
merged into a dark swatch kept a black label, and a later redraw turned it
white.
The copied colors linked to merged swatches now take the document's color
before the labels are set, so the labels match what a redraw sets. Graphic
style links are left for the paste to relink.
With the art of a graph design in a series given first and aligned: true,
effect.remove and effect.duplicate with `indices` skipped an effect of the
art that no other object has, and edited the others. With art [shadow,
roughen], a mark [shadow] and indices [0, 1], effect.remove took the
mark's shadow off and succeeded. Such an edit is now an error that leaves
the document and its undo history as they are, as the same index given
alone already was. An object that lacks one of the effects while another
object has it is still left out for that effect.