Main now stores a line's or label's added rows by kind (Keep::Kinds),
rewritten paint and row attributes (capture_line_row_writes) and no-op
reorders the way this branch did, so its versions are kept. The branch
adds on top: a stroke painted on a line after its kind lost its stroke
keeps that line's weight, a pasted graph's axis and ring line rows follow
a renamed swatch, and the paint.swap params text says only what the swap
changes is stored.
Graph Type has a Line Width field next to Draw Filled Lines, and
`graph.setType` takes `lineWidth` in points (0.01 to 1000; 3 when the
graph sets none). Filled lines are drawn at that width, and the width is
kept through save and open. A graph stores a width only when it is not
3 pt, and a graph with a width of its own is written to .ai as its art.
`graph.setType` with options that leave the graph as it is records no
undo step.
A default legend swatch of a stacked column, stacked bar, area or pie
series now has the thin white stroke the series' marks have, beside the
plot or across the top. Before, the swatch had no stroke, so the series
group painted with two strokes and a drawn stacked column or area graph
was saved to .ai as plain art with a warning. Both now open again as live
graphs. Stacked bar graphs are still written as art: the .ai reader has
no type for them.
When one line of a kind had its stroke set to None, the kind kept a zero
stroke weight. Painting the stroke of another line of that kind kept only
the new paint, so the next redraw drew every line of the kind with no
weight. The kind now takes the painted line's weight when it kept no
stroke paint before the edit. A zero weight set together with a stroke
color, or kept with a painted stroke, stays as set.
paint.setFill, paint.setStroke, addon.color.fillToStroke and
addon.color.strokeToFill on an axis line, tick mark or radar ring that
already showed the paint they write stored nothing, so a paint its kind
kept from another line came back when the graph was drawn again. The
paint written to the line's topmost visible fill or stroke row is now
stored for its kind; its other attributes stay as the kind keeps them.
That capture runs after the change-based one, so the frontmost written
line sets the paint its kind keeps.
An appearance.moveItem that left a graph label's rows or Contents row
where they were stored that label's rows for its kind, replacing the
rows the kind kept from another label, and recorded an undo step. A
reorder now keeps rows only for the labels and lines whose stack it
changed.
paint.invert and paint.complement given a group with a fill or stroke of
its own remembered the new paint of the first object inside it, while the
Fill and Stroke proxies show the group's own paint. The remembered paint
now follows the proxy: for each object given, in order, a group whose own
fill or stroke changed gives that paint, otherwise the first object inside
it that is not graph design art does.
paint.invert and paint.complement given a group whose own fill or stroke
changed, with only graph design art inside it, left the last color and
the recent colors as they were, because the remembered paint was taken
only from the objects inside the group. It now comes from the first
group whose own fill or stroke changed. A recolor that changes no
group's paint, such as the complement of a gray fill, remembers nothing.
When a pasted pie's wedge links a global swatch that the document gives
another color (swatchConflict "merge", the default), the wedge takes the
document's color. Its legend label kept the contrast it had in the copy,
so a wedge that turned dark could show a black label, and one that
turned light a white label, until the pie was drawn again.
Pasting now reads which wedges show a dark fill before the copy is
linked to the document's swatches. A pie whose wedges change darkness
gets the legend label contrast a redraw sets: white on a dark wedge,
black on a light one. Pies whose legend labels have a fill of their own
keep it. This applies to every paste command, Paste without Formatting
included, and to pies inside opacity masks.
With the art of a graph design in a series given first and aligned: true,
effect.remove and effect.duplicate with `indices` skipped an effect of the
art that no other object has, and edited the others. With art [shadow,
roughen], a mark [shadow] and indices [0, 1], effect.remove took the
mark's shadow off and succeeded. Such an edit is now an error that leaves
the document and its undo history as they are, as the same index given
alone already was. An object that lacks one of the effects while another
object has it is still left out for that effect.
paint.invert and paint.complement given only the art of a graph design,
with no item, returned success for a target other than "object" or
"contents", because the topmost-fill path read the target only after the
early return for design art. The target is now read before that return.
appearance.addFill and appearance.addStroke on an axis line, tick mark
or radar ring stored only the attributes the new row changed on the
line, so a stroke the kind kept from another line came back when the
graph was drawn again, although the line showed the new black stroke.
They now store the row they add for the line's kind when it becomes the
line's topmost visible row of its kind.
An appearance.copyFrom of some attributes, appearance.setItem and
stroke.set stored only what they changed, so a paint, stroke weight,
row opacity or blend mode that the line already showed did not replace
what its kind kept. What they write to the line's topmost visible rows
is now stored for the kind, as paint.setStroke stores the paint it
writes. Row opacity and blend mode are stored apart, so an edit of one
leaves the other as the kind keeps it, and a null weight or opacity
writes nothing.
appearance.copyFrom with append stored every fill and stroke row a graph
label or line showed for its kind. A fill-only pick appended to one line
or label copied its old stroke over the stroke another one had set, and
the next redraw lost it. The kind now keeps only the kinds of row the
pick adds that are visible in the source, as graphicStyle.apply with add
does, and the object opacity and blend mode only when the pick applies
the object's transparency.
paint.swap on an axis line stored the line's whole fill and stroke rows,
so a fill opacity its kind kept from another line went back to 100%. It
now keeps only the paints the swap changed.
Paste without Formatting dropped the label formats a pasted graph keeps
but left the mark that its legend labels' fill is their own. After a later
change to a legend label (its size, for example), the next redraw read the
default black fill as the labels' own and drew them black on dark wedges
again. The mark now stays behind with the other formats.
A pie's legend label whose series name holds line breaks of its own (from
a quoted CSV cell) is now located by all of its lines, as a redraw centers
it. Before, only `|` counted as a line break, so a tall label on stacked
pies could take the contrast of the wrong ring.
Paste no longer recolors the legend labels of a pie whose wedges a merged
or changed swatch recolors. That is a separate change to Paste and goes in
its own pull request. Paste without Formatting sets the legend labels by
the wedge colors as copied.
A graph keeps its labels' character and paragraph formats for each redraw.
Paste without Formatting reset the labels' text but left those formats in
the graph, so the next redraw (Graph Data, Graph Type) gave the labels their
source formatting back.
Paste without Formatting now drops the formats the graph keeps and sets the
pasted labels as a new graph's labels are set: 9 pt black, unscaled (a
rotated graph's labels keep their rotation), default paragraph attributes,
each keeping its alignment, and white on a dark pie wedge. Before, they took
12 pt and lost their alignment. The rest of the graph's art is pasted as it
was copied. A swatch-linked character fill the graph kept for its labels
stays behind with the other formats.
When the document's swatches give a pasted pie's wedges another color (a
swatch merged into the document's swatch of that name, or a swatch changed
in the document the pie was copied from), Paste and Paste without Formatting
set the legend labels in those wedges white on a dark wedge and black on a
light one, as a redraw does. Before, they kept the color chosen for the
copied wedge, which could leave white text on a light wedge. A label whose
characters are not all white or all black keeps its colors.
graphicStyle.apply with add stored both the fill and stroke rows a graph
label or line showed for its kind. A fill-only style added to one line
copied that line's old stroke over the stroke another line had set, and
the next redraw lost it. The kind now keeps only the kinds of row visible
in the style, with the other kind of row kept in its place relative to
the characters.
Expand Appearance leaves the art of a graph design in a series as it is. A Transform effect of a
series group that makes copies gave each copy new ids, so the copies were expanded and their own
effects, such as a drop shadow, became embedded images. The new ids of those copies are now left out
too; the series group's own effect still bakes into them.
paint.invert and paint.complement without an item recolor a given group's own fills and strokes with the objects inside it again, except with target "contents", and leave the art of graph designs inside it as it is. A given member of a compound path stands for the compound path.
paint.editGradient with a spread or a negative aspect for design art alone no longer checks it against the kind of the default gradient, so it changes nothing instead of failing. A bad value is still an error.
graphicStyle.apply with add, and appearance.copyFrom with append, stored
both the fill and stroke rows a graph label or axis line showed, so a
fill-only style added to one axis line replaced the stroke the axis lines
kept from another line with the line's own black stroke. They now store
only the kinds of row they add; the row of the other kind keeps its paint
and its place relative to the characters as the kind keeps them.
appearance.moveItem of the Contents row stored the rows of every label
it was given, so a move that changed nothing on a label replaced what its
kind kept from another label. It now stores rows only for the labels
whose rows it changed.
With only the art of a graph design in a series given or selected, paint.invert and paint.complement without an item recolored that art and remembered its new color, and stroke.set with a weight set the stroke weight for new art. Invert and Complement now leave the art out, as they do with an item, also when they are given the whole graph or a series group, and with only design art they change nothing. stroke.set with only design art leaves the weight for new art as it is.
An item the art has no row of that kind for is still an error in the commands that leave the art out, as on any other object, and so is a bad aligned or target param. Without stroke, paint.editGradient and paint.setGradientGeom read the kind of an item named on design art alone from that art's row.
paint.setFill, paint.setStroke, addon.color.fillToStroke and
addon.color.strokeToFill on an axis line, tick mark or radar ring that
already showed the paint they write stored nothing, so a paint its kind
kept from another line came back when the graph was drawn again. The
paint written to the line's topmost visible fill or stroke row is now
stored for its kind; its other attributes stay as the kind keeps them.
Takes #7375's later fixes: Move Appearance onto an axis line behind its
source, picks and added styles without transparency, Default Fill and
Stroke on an axis line, and edits that keep only the line attributes they
change. Aligned row edits, hidden rows, reorders and Default Fill and
Stroke on labels keep this branch's behavior.