Commit Graph
74 Commits
Author SHA1 Message Date
dotCooCoo cbee54549b Merge main into fix/graph-axis-paint-kept 2026-11-15 13:41:36 -08:00
dotCooCoo f60d329363 Graphs: rewritten axis line paint and no-op reorders keep what a kind keeps
paint.setFill, paint.setStroke, addon.color.fillToStroke and
addon.color.strokeToFill on an axis line, tick mark or radar ring that
already showed the paint they write stored nothing, so a paint its kind
kept from another line came back when the graph was drawn again. The
paint written to the line's topmost visible fill or stroke row is now
stored for its kind; its other attributes stay as the kind keeps them.
That capture runs after the change-based one, so the frontmost written
line sets the paint its kind keeps.

An appearance.moveItem that left a graph label's rows or Contents row
where they were stored that label's rows for its kind, replacing the
rows the kind kept from another label, and recorded an undo step. A
reorder now keeps rows only for the labels and lines whose stack it
changed.
2026-11-15 10:39:30 -08:00
dotCooCoo 24867f7827 Paste: legend labels in a pie's wedges follow wedges that take the document's swatch
When a pasted pie's wedge links a global swatch that the document gives
another color (swatchConflict "merge", the default), the wedge takes the
document's color. Its legend label kept the contrast it had in the copy,
so a wedge that turned dark could show a black label, and one that
turned light a white label, until the pie was drawn again.

Pasting now reads which wedges show a dark fill before the copy is
linked to the document's swatches. A pie whose wedges change darkness
gets the legend label contrast a redraw sets: white on a dark wedge,
black on a light one. Pies whose legend labels have a fill of their own
keep it. This applies to every paste command, Paste without Formatting
included, and to pies inside opacity masks.
2026-11-15 08:53:31 -08:00
dotCooCoo 94d2625c60 Graphs: an appended pick or a swap on a label or axis line keeps only what it changes
appearance.copyFrom with append stored every fill and stroke row a graph
label or line showed for its kind. A fill-only pick appended to one line
or label copied its old stroke over the stroke another one had set, and
the next redraw lost it. The kind now keeps only the kinds of row the
pick adds that are visible in the source, as graphicStyle.apply with add
does, and the object opacity and blend mode only when the pick applies
the object's transparency.

paint.swap on an axis line stored the line's whole fill and stroke rows,
so a fill opacity its kind kept from another line went back to 100%. It
now keeps only the paints the swap changed.
2026-11-15 06:57:45 -08:00
dotCooCoo a83c7a8bb3 Merge main into fix/graph-axis-paint-kept 2026-11-15 06:08:10 -08:00
dotCooCoo cb368c29e4 Merge main into fix/paste-plain-graph-labels 2026-11-14 23:52:57 -08:00
dotCooCoo f3a4c0ac1a Paste: Paste without Formatting also drops a pie's own legend fill mark
Paste without Formatting dropped the label formats a pasted graph keeps
but left the mark that its legend labels' fill is their own. After a later
change to a legend label (its size, for example), the next redraw read the
default black fill as the labels' own and drew them black on dark wedges
again. The mark now stays behind with the other formats.

A pie's legend label whose series name holds line breaks of its own (from
a quoted CSV cell) is now located by all of its lines, as a redraw centers
it. Before, only `|` counted as a line break, so a tall label on stacked
pies could take the contrast of the wrong ring.

Paste no longer recolors the legend labels of a pie whose wedges a merged
or changed swatch recolors. That is a separate change to Paste and goes in
its own pull request. Paste without Formatting sets the legend labels by
the wedge colors as copied.
2026-11-14 23:51:27 -08:00
dotCooCoo 277fdb15c7 Paste: Paste without Formatting keeps a pasted graph's labels plain when it is drawn again
A graph keeps its labels' character and paragraph formats for each redraw.
Paste without Formatting reset the labels' text but left those formats in
the graph, so the next redraw (Graph Data, Graph Type) gave the labels their
source formatting back.

Paste without Formatting now drops the formats the graph keeps and sets the
pasted labels as a new graph's labels are set: 9 pt black, unscaled (a
rotated graph's labels keep their rotation), default paragraph attributes,
each keeping its alignment, and white on a dark pie wedge. Before, they took
12 pt and lost their alignment. The rest of the graph's art is pasted as it
was copied. A swatch-linked character fill the graph kept for its labels
stays behind with the other formats.

When the document's swatches give a pasted pie's wedges another color (a
swatch merged into the document's swatch of that name, or a swatch changed
in the document the pie was copied from), Paste and Paste without Formatting
set the legend labels in those wedges white on a dark wedge and black on a
light one, as a redraw does. Before, they kept the color chosen for the
copied wedge, which could leave white text on a light wedge. A label whose
characters are not all white or all black keeps its colors.
2026-11-14 22:09:08 -08:00
dotCooCoo 021e4dc4ca Graphs: a style added to a label or axis line keeps only the rows it shows
graphicStyle.apply with add stored both the fill and stroke rows a graph
label or line showed for its kind. A fill-only style added to one line
copied that line's old stroke over the stroke another line had set, and
the next redraw lost it. The kind now keeps only the kinds of row visible
in the style, with the other kind of row kept in its place relative to
the characters.
2026-11-14 21:38:42 -08:00
dotCooCoo 0b42788d6b Merge main into fix/graph-axis-paint-kept 2026-11-14 20:00:48 -08:00
dotCooCoo ea3397b35d Merge main into feat/graph-type-dialog 2026-11-14 19:13:24 -08:00
BFlat d593b41961 Merge pull request #7691 from dotCooCoo/feat/variable-library-every-kind
Variables: Load and Save Variable Library hold visibility, image and graph variables
2026-11-15 08:24:45 +07:00
dotCooCoo a73ee755f8 Merge main into feat/graph-type-dialog 2026-11-14 15:16:55 -08:00
BFlat 9153900b1f Merge pull request #7322 from dotCooCoo/fix/graph-series-group-opacity
Graphs: the transparency set on a series group is kept
2026-11-15 05:30:04 +07:00
dotCooCoo 647a59db01 Merge main into feat/graph-type-dialog 2026-11-14 13:27:10 -08:00
dotCooCoo c5649c7529 Merge main into feat/variable-library-every-kind 2026-11-14 13:25:37 -08:00
dotCooCoo e90c4e6fb2 Variables: Load and Save Variable Library hold visibility, image and graph variables
Load Variable Library defines each variable with the kind of its trait
(textcontent, visibility, fileref, graphdata; any other or none is the
unknown kind) and reads visibility values from true or false, image
values from a file's absolute path or file: URL, and graph values from
a data element of series names and rows. A document variable declared
with the same name and kind keeps its bindings. Save Variable Library
writes every kind in the same forms and is enabled with any variable.
Image values that aren't absolute paths and graph data past what a
graph holds are refused, so every saved file loads back.
2026-11-14 13:23:02 -08:00
BFlat 20ae675b9b Merge pull request #7622 from dotCooCoo/fix/graph-label-restyle-keeps-plot
Graphs: restyling the labels leaves the plot where it is at the next redraw
2026-11-15 04:22:27 +07:00
dotCooCoo 289fb4b770 Graphs: a pick or added style without transparency keeps the opacity a line or label kind keeps
A whole pick of every fill and stroke attribute, or an append pick, onto
a graph's axis line, tick mark or radar ring stored the line's rows in
full, object opacity and blend mode included, even when the pick did not
apply the object's transparency. On a line that still showed 100% until
the graph was drawn again, that replaced the opacity its kind kept (40%
set on another line became 100%). An append pick onto a graph label, and
graphicStyle.apply with add on a label or line, did the same.

Without Transparency applied, these picks, and a style added on top, now
store the fill and stroke rows and leave the kept object opacity and
blend mode as they were.
2026-11-14 12:48:02 -08:00
dotCooCoo a134cf6f8d Graphs: Graph Type is a dialog of its own with type buttons and a page per axis
Object > Graph > Type... and a double click on a graph tool open Graph
Type (dialog `graphType`) instead of the generic parameter dialog. A
menu at the top shows Graph Options, Value Axis (Left Axis and Right
Axis with the value axis on both sides) or Category Axis. Graph Options
has a button per graph type, Value Axis with Separate Scales, the Style
checkboxes and the options of the type picked. The axis pages hold Tick
Values with Override Calculated Values, Tick Marks and Add Labels.

Override Calculated Values starts from the values the axis would be
calculated with for the options shown; the engine exposes them as
`graph_type_subject` and `graph_calculated_axes`. With series picked by
Group Selection, the type and value axis go to those series. OK changes
the graph and series the dialog opened on, and with nothing changed it
adds no step of history.

Docs: docs/mcp.md, docs/ui-parity.md and the tool.options text.
2026-11-14 10:27:41 -08:00
dotCooCoo d3789f2b0c Graphs: outlined labels and opened .ai graphs keep the plot in place at the next redraw
- A graph opened from a .ai file now saves `placedArt` too. Moving or
  restyling one of its labels before the first redraw no longer moves or
  stretches the plot.
- Type > Create Outlines on a graph's labels now adjusts the saved bounds,
  so the outlines do not read as a move at the next redraw. A move of
  the graph made before the outlining is still followed.
- A `placedArt` with no width or height falls back to the bounds of all
  of the art, as a graph saved without it does.
- `art_bounds` moves to the doc crate so the .ai reader can use it.
- docs/mcp.md describes `placedArt`, `placed` and when a redraw follows
  a move.
- Tests: a legend across the top, a legend after a right value axis and
  legend labels of several lines keep the plot in place through label
  size changes; moving a category label on its own; outlining labels
  before and after a move; a flat `placedArt`; a label moved in an
  opened .ai graph.
2026-11-14 08:47:03 -08:00
dotCooCoo d233cd8291 Merge main into fix/graph-series-group-opacity 2026-11-14 05:57:05 -08:00
dotCooCoo f1a79b92cc Graphs: an edit of some attributes on an axis line keeps the rest its kind keeps
An edit that changed only some attributes of a graph line, such as a
transparency-only Eyedropper pick, a cap, or a fill, kept that line's whole
fill and stroke rows for every line of its kind. A line that still showed
the default stroke until the graph was drawn again then replaced the stroke
its kind kept from another line. Such edits now keep only the attributes they
change; Clear Appearance, Move Appearance, graphic styles, and a pick of every
attribute or with append still keep the whole rows.
2026-11-13 22:11:11 -08:00
dotCooCoo 58cd62ef38 Merge main into fix/graph-axis-paint-kept 2026-11-13 19:49:27 -08:00
dotCooCoo eb9976a825 Merge main into fix/graph-label-paint-recolor 2026-11-13 19:22:11 -08:00
dotCooCoo 0b207f4e85 Graphs: axis lines, tick marks and radar rings keep the paint set on them
A graph drew its axis lines and tick marks in 0.5 pt black and a radar
graph's rings in 0.25 pt gray every time, with nothing stored for them. A
stroke, fill, weight, recolor, Appearance row, graphic style, Eyedropper
pick or opacity given to them was lost when the graph was drawn again.

- The graph now stores the rows of its axis lines and tick marks
  (axisRows) and, separately, of a radar graph's rings (ringRows): the
  paint, weight, opacity and blend mode of the topmost visible fill and
  stroke row, their order, and the line's object opacity and blend mode.
  Every line of the kind is drawn with them. Dashes, caps, joins and
  arrowheads are not stored.
- These commands store a line's rows: paint.setFill, paint.setStroke,
  the stroke, gradient and recolor commands, paint.swap, paint.default,
  Apply Fill to Stroke and Stroke to Fill, the appearance commands with
  the Eyedropper, graphic styles, transparency.set and object.setProps.
  paint.setFill, paint.setStroke and the recolor commands given a whole
  graph now also store what they give its lines.
- When one command reaches several lines of a kind, the frontmost line in
  paint order sets what the kind keeps. A gradient is stored without its
  placement.
- Lines that show their default stroke store nothing, and a global swatch
  edit or a document color conversion reaches the stored paint.

Docs: docs/mcp.md, the params text of these commands,
docs/target-app-parity.md.
2026-11-13 18:06:25 -08:00
dotCooCoo 87b4a8053b Merge main into fix/graph-series-group-opacity 2026-11-13 16:49:51 -08:00
dotCooCoo 89ee320591 Graphs: a series group also keeps its isolation and knockout
transparency.set and object.setProps with isolate, knockout or
knockoutShape on a series group now store them for the series
(groupIsolate, groupKnockout, groupKnockoutShape), and the series group
has them again when the graph is drawn again. Randomize Opacity, Sort
Objects and Global Edit store the opacity they give a series group, so
a redraw no longer puts back an older stored value over it.

A move or copy of an appearance onto a series group whose stored values
differ from its own now counts as a change, so the edit is kept. Tests
cover graphicStyle.redefine of a style linked to a series group.
2026-11-13 16:02:54 -08:00
dotCooCoo 4129587abe Graphs: recolor, stroke and gradient edits on labels are kept for their kind
A recolor of a graph (Invert and Complement on the proxy, the Edit Colors
commands, Recolor Artwork, the color filters, Apply Nearest Swatch and the
ink limit of Print Ink Fixes) stored the new paint of the series marks but
not of the labels. stroke.set, the stroke weight steps, the gradient edits,
Swap Fill and Stroke and Default Fill and Stroke stored nothing when they
changed a label's characters. When the graph was drawn again, the labels
went back to their stored style.

- These commands now store, for every label of the kind they reach, the
  label's object rows when they change, and the fill, stroke, stroke weight,
  caps, joins, miter limit, dashes and stroke alignment of its characters
  when all of them show the change alike.
- A gradient is stored without its placement, and each label fits it to its
  own box. A stroke weight and dashes are stored as a scaled label shows
  them.
- When labels of one kind change differently, the frontmost one sets what
  the kind keeps.
- On a pie with Legends in Wedges, the legend labels' fill is stored only
  when every legend label reached ends up with the same fill, so a recolor
  of the whole pie leaves them black or white by their wedge.
- Axis lines, ticks and radar rings are not stored and are drawn again with
  their default paint.

Docs: docs/mcp.md, the commands' params text, docs/target-app-parity.md.
2026-11-13 15:22:55 -08:00
dotCooCoo 0d26724a7c Graphs: Appearance and effect commands leave a design's art in a series out
A graph draws the art of a column or marker design inside a series again
from the stored design. Rows, effects and graphic styles that a command
gave that art were lost the next time the graph's data, type or size
changed. The paint commands already left the art out.

- The appearance.* row and whole-appearance commands, effect.apply,
  appearance.addEffect and the effect.* commands that edit, move or
  remove an effect, threeD.mapGraphic, graphicStyle.apply,
  graphicStyle.addFromLibrary with apply, transparency.set with a fill
  or stroke item, and appearance.copyFrom (as the target) leave out any
  object inside a series group other than a path directly in it, given
  by id, selected or reached through target: "contents". They edit the
  other objects given, and a command whose objects are all design art
  is an error.
- appearance.transfer with design art as its target, or as its source
  without copy, is an error.
- A Pathfinder effect no longer groups selected design art.
- The paint commands given a design's copy with a fill or stroke item
  leave it out as well.

docs/mcp.md states the rule, and the Graphs line in
docs/target-app-parity.md names it.
2026-11-13 14:51:31 -08:00
dotCooCoo 5c0f22b345 Graphs: Appearance edits on a label are kept for every label of its kind
A fill or stroke row that the Appearance commands gave a graph label, its
object opacity, and the characters the Eyedropper gave it lasted only
until the graph was drawn again: the graph stored nothing for a label's
rows, and the Eyedropper's character attributes were not stored.

- The graph keeps, for value axis numbers, category labels and legend
  labels, the paint, weight, opacity and blend mode of a label's topmost
  visible fill and stroke row, their order and place relative to the
  Characters row, and the label's object opacity and blend mode
  (labelStyles valuesRows, categoriesRows, legendRows). Every label of
  the kind gets those rows when the graph is drawn again, with a placed
  gradient fitted to each label.
- Every appearance.* command stores them, and so do graphicStyle.apply
  and redefine and the paint, stroke, gradient and transparency edits
  aimed at a row, even when the label already showed them.
  transparency.set without a row and object.setProps store only the
  object opacity and blend mode. With several labels of a kind, the last
  one edited wins.
- appearance.copyFrom onto all of a label's text stores the character
  attributes it applied and, from type, the paragraph attributes; a
  transparency pick stores the object opacity and blend mode, and
  append stores the rows.
- paint.setFill and paint.setStroke store a character fill or stroke
  only when the characters take the paint (the whole label, or all of
  its text highlighted with the Type tool); aimed at a row, they store
  the row.
- Document Color Mode and swatch edits reach the kept rows.

Docs: docs/mcp.md, the commands' params text, docs/target-app-parity.md.
2026-11-13 11:35:27 -08:00
dotCooCoo 3c434a7e90 Merge main into fix/graph-series-paint-visible-rows 2026-11-13 10:02:14 -08:00
dotCooCoo b6aaea6c97 Graphs: Appearance commands and graphic styles given a series group edit its marks
A graph draws its series groups again with no rows of their own, so a
fill, stroke, opacity or graphic style that a command put on a series
group was lost the next time the graph's data, type or size changed,
and the graph stored nothing. paint.setFill and paint.setStroke already
pass a series group's id on to the paths directly inside it.

- appearance.addFill, addStroke, setItem, removeItem, duplicateItem and
  moveItem, graphicStyle.apply and transparency.set with a fill or
  stroke item now edit the paths directly in a series group given by id
  or picked with Group Selection, and the graph stores what they change.
  A series group with no such path, or with a fill or stroke row of its
  own, is still edited itself, and appearance.moveItem from "contents"
  still moves the group's own Contents row.
- appearance.clear, appearance.reduceToBasic, appearance.showAllHidden
  and graphicStyle.breakLink edit the group as well as its paths.
- graphicStyle.apply without add and appearance.transfer onto a series
  group clear the group's own opacity, blend mode, isolation, knockout,
  effects and style link, and graphicStyle.apply with add unlinks the
  group. A transfer source that is one of the group's paths keeps its
  look, and a source that is the group's only path is an error.
- graphicStyle.redefine passes the style to the paths of a linked series
  group, other than the source and the linked paths whose look was
  edited, and clears and unlinks the group.
- graphicStyle.new, graphicStyle.redefine and appearance.transfer read a
  series group that holds no row, effect, opacity, blend mode,
  isolation, knockout or style link of its own through the topmost path
  directly in it, and a move clears each of those paths. A series group
  that holds one of them is read itself, as before.
- The Graphic Styles panel reads the style link of such a selected
  series group from that path.

Docs: docs/mcp.md, docs/target-app-parity.md. Not yet: the Appearance
panel and appearance.setActiveItem still read the selected group's own
rows, and the effect commands and the paint, stroke and gradient
commands with an item still edit the group itself.

Follows #5501.
2026-11-13 07:25:03 -08:00
dotCooCoo 2343e0e8b0 Graphs: paint commands store a series' paint only from the row a mark shows
paint.setFill, paint.setStroke, paint.none, Apply Fill to Stroke, Apply
Stroke to Fill and a library gradient or pattern applied with library.use
stored the topmost fill or stroke row of a graph series mark on the graph
even when that row was hidden, and stored a stroke set on a Filled Lines
band. When the graph was drawn again, every mark of the series took a
paint that the edited mark never showed, and a band took the stroke color
as its fill.

These commands now follow the rules of the Appearance commands:

- The graph stores the paint only when the row the command wrote is the
  topmost visible row of its kind, or when the command changed what the
  mark shows. With `item`, that is the named row.
- A series that draws Filled Lines bands stores no stroke paint or
  weight; the band keeps its own outline.
- A row without paint before and after the command keeps what the graph
  stores, so None on a marker without a stroke no longer removes the
  line's stored stroke.
- When one command writes several marks of a series, the frontmost mark
  sets what the graph stores, whatever the order of the ids.
- Apply Fill to Stroke and Apply Stroke to Fill on a mark whose row
  already has the paint store it, as paint.setFill does.

A document without graph series marks among the edited objects skips the
comparison of paints.

Docs: docs/mcp.md and the params text of the paint commands.
2026-11-13 06:20:05 -08:00
dotCooCoo cf4d27c38e Graphs: stroke, gradient and recolor commands update a series' stored paint
A stroke weight set with stroke.set or stroke.weightUp/weightDown, a
gradient made, placed or edited with paint.editGradient,
paint.setGradientGeom or the freeform gradient edits, and colors changed
by paint.invert, paint.complement, the Edit Colors recolor and Blend
commands, recolor.apply, addon.color.filter,
addon.color.applyNearestSwatch or the ink limit of
addon.color.printFixes changed a series mark but not the paint the graph
stores, so the mark went back to the old paint when the graph was drawn
again.

appearance::edit_items now stores what its edit changes on the topmost
visible fill and stroke of series marks, as the Appearance commands do,
and the recolor pass does the same for the series marks it reaches,
including those inside a series group or a graph it is given. When one
command changes several marks of a series, the frontmost one sets the
stored paint. A gradient is stored with its placement.

These commands do not store the colors they give a graph's axes and
labels. docs/mcp.md, the params text and the Graphs line in
docs/target-app-parity.md say what is stored.
2026-11-13 05:08:19 -08:00
dotCooCoo 23d371ca28 Graphs: graph.setType, setData and create refuse params of the wrong type
graph.setType read `axisMin: "10"` as a cleared bound, so the axis went
back to the calculated range, and it ignored a string or number given for
a true/false option, a string for a number and a number for a text option.
graph.setData and graph.create ignored a `csv` that is not a string and
`series`, `categories` or `rows` that are not lists, and read a string in
`rows` as a blank cell.

The three commands now refuse such a value with an error naming the key,
and leave the graph and the undo history as they were. A null is still
read as a key left out, and a null axis bound still goes back to the
calculated value. A negative tick count is refused too.
2026-11-11 16:41:13 -08:00
dotCooCoo e76524fd8b Graphs: labels keep paragraph settings and anti-aliasing when the graph is drawn again
Paragraph settings given to all of a graph label's text with
text.setFormat (indents, spacing, hyphenation, Justification options,
composer, direction, kashida, kinsoku, mojikumi, burasagari and the
rest) and the label's anti-aliasing method were lost when the graph
drew its labels again, because the graph kept only a character style
for each kind of label. Each kind now also keeps its paragraph settings
and anti-aliasing method, saved with the graph in its label styles, and
the graph still sets each label's alignment for its place.

The legend spaces its entries by the kept legend settings: Legend
Across Top measures each label with its indents and spacing, both
legend layouts make room for extra leading or paragraph spacing, and a
label with a negative indent or negative space before moves right or
down so it stays clear of its swatch and of the entry above it.
2026-11-10 23:40:25 -08:00
dotCooCoo 5a9a08fcb1 Graphs: a series keeps the object opacity and blend modes set on one of its marks
An object opacity or blend mode set on a path directly in a graph series, and
the blend mode of its topmost visible fill or stroke, were lost when the graph
was drawn again. The graph now stores them per series next to the row opacity
it already stores, and puts them on every path directly in the series when it
draws the series again.

- transparency.set and object.setProps store the object's opacity and blend
  mode. A value the mark already has still replaces the value another mark of
  the series stored.
- appearance.clear, appearance.transfer, appearance.copyFrom with Transparency
  picked up, graphicStyle.apply without add and graphicStyle.redefine store
  the object's opacity and blend mode they leave on the mark.
- The other Appearance and style commands store them when they change them
  on a mark.
- Every command that stores the opacity of the topmost visible fill or stroke
  also stores its blend mode. A Filled Lines band's outline takes the stored
  stroke opacity and blend mode and keeps its black 0.25 pt stroke.
- An opacity and blend mode are stored as a pair from the edited mark:
  setting only the opacity of one mark also stores that mark's blend mode.
- A graph design's copy in a series keeps its own values.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-07 04:28:27 -08:00
dotCooCoo 9fe7aec49c Graphs: Appearance commands and the Eyedropper update a series' stored paint
paint.setFill, paint.setStroke, paint.none, Apply Fill to Stroke and Apply
Stroke to Fill stored a series' paint on the graph. appearance.setItem, the
Eyedropper, appearance.transfer, Clear Appearance, Reduce to Basic Appearance
and the add, remove, move and duplicate row commands stored no paint or weight.
An Eyedropper pick of a blue fill at 40% onto a red column drew red at 40%
after the next redraw.

These commands and Show All Hidden Attributes now store the paint and weight
of the topmost visible fill and stroke of a path directly in a series group,
in the same undo step. A color, weight or opacity that a command writes to that
row replaces the stored value even when the mark's own value does not change. A
row that has no paint before and after the command does not change the stored
paint. These commands store no stroke for a series that draws Filled Lines
bands, and a band no longer takes its color from an empty stored stroke.

The stored opacity also comes from the topmost visible row: hiding a top row
stores the row under it, and an opacity set on a hidden top row is not stored.

Follows #5501.
2026-11-07 00:07:40 -08:00
dotCooCoo c8128ee65b Graphs: series marks keep a fill or stroke opacity when the graph is drawn again
A graph keeps the paint and stroke weight given to a series' marks, but not
the opacity of their fill or stroke row. An opacity set with
`transparency.set {item}` or `appearance.setItem {opacity}` on a column,
bar, line or other series path was lost the next time the graph was drawn
(a data, type or option change).

- `SeriesPaint` gains `fillOpacity` and `strokeOpacity`. A setItem opacity
  on the topmost fill or stroke of a series path stores it, in the same
  undo step, and the generator puts it on the topmost fill and stroke of
  every path directly in that series' group. Graph designs keep their own
  opacity. A value read from a file is held to 0..1.
- The Appearance commands that change the opacity of a series path's
  topmost fill or stroke (add, remove, duplicate and move a row, Clear
  Appearance, Reduce to Basic Appearance, `appearance.transfer` and the
  Eyedropper) update the stored opacity. They do not change the stored
  paint, which only `paint.setFill` and `paint.setStroke` set.
- An edit that leaves a series path fully opaque stores nothing for a
  series the graph keeps nothing for.
2026-11-04 11:45:16 +07:00
dotCooCoo 6be88a24b4 Fix #785: commands refuse an id that isn't an object id instead of using the selection
Commands whose `id` or `ids` the shared check in Session::execute does not
read still parsed them with id_param/ids_param, which drop anything that is
not a non-negative integer, and then acted on the selection or the current
layer. `object.blend.make {"ids": 3}` blended the selection,
`object.envelope.makeWithWarp {"ids": [2, "x"]}` warped the selection,
`graph.setData {"id": "2"}` changed the selected graph and
`layer.newSublayer {"parent": "2"}` added a sublayer to the current layer.

- cmd::named_ids and cmd::named_id read `ids`/`id` as targets does: a value
  that is not an object id, or an unresolved step reference, is an error.
- The symbol and brush, Live Paint, Shape Builder and Image Trace, blend,
  envelope and mesh, perspective, Liquify, Puppet Warp and graph helpers use
  them in place of the lenient readers.
- layer.clippingMask.toggle checks `id`, and layer.newSublayer checks
  `parent`, with checked_id before falling back to the highlighted row or the
  current layer.
2026-11-02 14:32:49 +07:00
Dylan M. Taylor 7043ef6f3d Extract geometry command helpers 2026-10-28 16:44:11 +00:00
aiongg f209d2aba2 refactor(engine): move cmd/graph.rs items to cmd/graph/{axis,columns,commands,data,designs,edit,generate,labels,markers,series}.rs 2026-10-26 22:01:25 +00:00
aiongg 2cd1a3a3f1 refactor(engine): move cmd/graph.rs tests to cmd/graph/tests.rs 2026-10-26 18:18:16 +00:00
Dylan M. TaylorandClaude Opus 5.5 b12ee928f3 Security: document model generation budgets for live art, clipping runs, placed documents, graph masks, path reading and native entries
CodeRabbit findings #58, #75, #82, #113, #159, #175, #187:

- Live evaluation (expansion, envelope mapping and everything inside) makes at most 4M
  objects (`MAX_GENERATED`); deep expansion counts what each live object makes, and envelope
  image pieces count before they are cut.
- Clipping runs copy at most 8M clip path elements together; past it runs are plain groups.
- Exports read at most 256 placed documents; the rest show their previews.
- Graph design and marker budgets count opacity-mask art (`Node::count_with_masks`).
- Native files read at most 32M anchors (4M on wasm) of paths; the web build allows 1 GiB of
  entries after the JSON.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-24 17:19:16 +07:00
bflatastic adbe0566a6 G4: System Layout spaces every text object in whole points
Squashed from #3412 onto main.
2026-10-22 00:54:43 +07:00
dotCooCoo d55a5245fb Graphs: column designs show each column's value where their type has % and two digits
The reference app's graphs help describes adding totals to a column
design: type in the design holds a percent sign followed by two digits.
VectorCraft drew that type as typed, stretched with the design.

Type in a column design that holds a % followed by two digits now shows
the value of each column or stacked segment in place of the % and the
two digits. The first digit is the least number of places before the
decimal point, with zeros added in front (0 for as many as the value
needs), and the second is the number of places after it. Values are
rounded half away from zero. The type keeps its own size and moves to
where the design's copy puts the point it is set from. A repeating
design shows it once per column, where a whole copy ending at the value
end puts it, and Chop Design does not cut it. A sliding design moves it
with the part of the design on its side of the guide. Type inside a
group that clips or has its own opacity, blend mode, appearance or
opacity mask, or inside a blend, compound shape, envelope, repeat or
intertwine, stays in the design and shows the value in each copy. Type
inside a symbol stays as typed. The legend swatch leaves the totals
out.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-10-21 16:46:15 +07:00
dotCooCoo b9309f7985 Graphs: Object › Graph › Column draws columns with graph designs
Object › Graph › Column… was a menu stub, so a graph's columns and bars
were always plain rectangles. The reference app fills them with a graph
design, vertically scaled, uniformly scaled, repeated with a value for
each copy, or stretched at a guide line.

graph.column (Column…) draws the columns, bars or stacked segments and
the legend swatch of the series picked with Group Selection with a
design saved by Object › Graph › Design. Vertically Scaled stretches the
design to each column's length at the column's width. Uniformly Scaled
scales it both ways to that length and centers it on the column.
Repeating stacks a copy for each Each Design Represents value out from
the zero line, and For Fractions chops the last copy at the value or
scales it down. Sliding keeps the part above the design's horizontal
guide line in proportion and stretches the part below. The design and
its options are saved with the graph, and the graph follows the design
when it is renamed or deleted. Columns drawn with a design cast no drop
shadow.

A marker or legend design made of one path is now drawn in a group of
its own. Painting a series with Group Selection then leaves the design's
paint alone, as it already did for designs of several objects.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-10-17 15:14:43 +07:00
NetterSilverandClaude Haiku 5.5 92647fa5b6 Quote graph data CSV labels so they round-trip through graph.setData
Found while testing crates/doc/src/graph.rs:429 (GraphSpec::to_csv) and crates/engine/src/cmd/graph.rs:85 (parse_csv)

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 13:20:23 +07:00
NetterSilverandClaude Haiku 5.5 8ca4cd2cbf Fix graph axis labels saturating beyond the i64 range
Found while testing crates/engine/src/cmd/graph.rs:193 (fmt_value)

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-17 12:50:37 +07:00