Commit Graph
15419 Commits
Author SHA1 Message Date
BFlat 61091515b3 Merge pull request #7624 from dotCooCoo/fix/cmyk-tiff-alpha-and-extra-sample
TIFF: alpha after another extra sample places and opens as transparency
2026-11-15 08:24:36 +07:00
BFlat 2331fd44fa Merge pull request #7680 from dotCooCoo/feat/radial-blur-center
Effects: Radial Blur turns about a Blur Center set in its dialog
2026-11-15 08:24:28 +07:00
BFlat bb2322c568 Merge pull request #7678 from dotCooCoo/fix/optical-keeps-tsume
Type: Optical kerning keeps the space Tsume takes out
2026-11-15 08:24:19 +07:00
BFlat 905eb30384 Merge pull request #7716 from dotCooCoo/fix/svg-import-budget-shared
SVG import: bound selector matching and share the limits with linked and embedded SVGs
2026-11-15 08:24:10 +07:00
BFlat 69a9df31fe Merge pull request #7700 from dotCooCoo/fix/svg-clip-use-both-clips
SVG import: a use in a clip path clips by its own clip path and its text's
2026-11-15 08:24:03 +07:00
BFlat c6a085f20e Merge pull request #7704 from dotCooCoo/fix/perspective-repeated-ids
Perspective: a repeated id attaches, moves or transforms an object once
2026-11-15 08:23:55 +07:00
BFlat c18a83f028 Merge pull request #7698 from dotCooCoo/fix/save-checks-files-beside-read-file
Save: File > Save no longer writes over the file the document was read from through a file written beside the path
2026-11-15 08:23:45 +07:00
BFlat c605d0ded8 Merge pull request #7671 from dotCooCoo/fix/prefs-reset-row
Preferences: Reset Preferences shares the row of Export and Import
2026-11-15 08:23:38 +07:00
BFlat 17dfe41a7e Merge pull request #7672 from dotCooCoo/fix/export-selection-doc-save-panel
MCP: docs say document.exportSelection with options and no path still asks for the file
2026-11-15 08:23:31 +07:00
BFlat 40d1fc913a Merge pull request #7702 from dotCooCoo/fix/reverse-compound-stroke-records
Paths: Reverse Path Direction turns a compound path's own stroke width profile and pen records
2026-11-15 08:23:22 +07:00
BFlat dc870ecf9c Merge pull request #7686 from dotCooCoo/fix/export-places-symbols-in-masks
Export: symbol instances in opacity masks draw their art's live effects
2026-11-15 08:23:13 +07:00
BFlat 410bb908ce Merge pull request #7695 from dotCooCoo/fix/issue-7275-rename
Fix #7275: Rename artboards in Export for Screens by double-clicking their names
2026-11-15 08:23:04 +07:00
dotCooCoo d0200d0e5c Swatches: merging a swatch drops the process plates of the gradient stops linked to it
Merge Swatches relinked a gradient stop linked to a merged spot swatch to
the kept swatch but kept the process plates it printed with the old ink,
so a kept spot swatch printed them beside its own tint and a kept global
process swatch held them for a later change back to spot. The merge now
clears those plates in the art, gradient swatches, graphic styles, the art
of brushes and the fill and stroke for new art, in the same undo step.
Stops linked to other swatches keep their plates.
2026-11-14 17:20:23 -08:00
dotCooCoo 8d5a76b342 Image Trace: a trace started before Revert does not apply after it
File > Revert keeps the document's tab and uid, so a trace prepared
before the revert compared equal to one prepared after it when the
restored image, object and settings were the same. A background trace
that finished after the revert then applied to the restored content, and
a result handed to imageTrace.make or imageTrace.makeAndExpand stood in
for a fresh trace.

The trace inputs now record the document's revert count. A run prepared
before a revert is no longer current, the commands drop its result and
trace the restored image again as one undo step, and the status bar says
"Image Trace finished, but its document was reverted: trace it again".
Reverting another document, or a revert that fails, does not affect the
run.
2026-11-14 17:09:50 -08:00
dotCooCoo 6c585de940 Eraser: Angle, Roundness and Size vary with Random, Pressure, Tilt, Bearing or Rotation
Eraser Tool Options gives Angle, Roundness and Size each a variation menu
(Fixed, Random, Pressure, Tilt, Bearing, Rotation) and a Variation field.
path.eraseRegion takes angleMode, roundnessMode and sizeMode with their
variations, sweeps a varying tip as a Calligraphic nib with what the pen
read along the drag, and refuses an unknown mode or a variation out of
range. The Eraser records the pen's pressure, tilt and rotation when a
mode follows them, and its tip outline at the pointer takes the angle,
roundness and size the pen gives while it erases.
2026-11-14 17:08:14 -08:00
dotCooCoo b599942e21 Fix #7524: the canvas's frame fits the display's largest texture side
The canvas rendered its art at the display's pixels per point whatever
the canvas's size, so a canvas more device pixels across than egui's
max_texture_side asked for a texture larger than the display supports.
The tiled panes did the same, and Pixel Preview allowed regions of up to
16,384 document pixels. In
canvas::panes::tests::tiled_documents_fit_their_panes_at_every_ui_scaling,
the pass where a new UI zoom takes effect sizes the screen from the
default 10,000-point viewport, and the test failed whenever the render
worker finished that frame before the next pass.

- The canvas and the tiled panes lower the frame's pixels per point when
  a side would pass max_texture_side, and draw the frame over the whole
  canvas at that lower resolution.
- Pans, scrolls and scroll bar drags move the view by whole pixels of
  that frame, so a pan still copies the pixels it moved.
- Pixel Preview shows the normal render when its region of document
  pixels is larger than max_texture_side.
- Tests that drew a canvas wider than egui's default limit of 2,048
  pixels now state the limit their display reports.
2026-11-14 17:07:48 -08:00
dotCooCoo a3cb4462af OpenType panel: checkboxes after Select All read every frame of the story
After Select All in a threaded story whose edited frame is empty, the
panel's commands style the text of every frame, but the checkbox rows,
Stylistic Sets and the East Asian items read only the empty frame. They
now read the runs of every frame, leaving out runs with no text while
any run has text, so a feature the story's text has shows checked and a
click turns it off.
2026-11-14 17:03:36 -08:00
dotCooCoo a3ac628576 .ai import: symbol instances in older files are read, so art outside the artboard opens
Files saved for versions 10 to 13 place each symbol instance with a
TransformMatrix. On the page it takes the symbol's art to the canvas
(y down); in a symbol's art, it takes the art to that symbol's space. The
reader only knew the RTransformMatrix of newer files, so any such
instance made the editing data unreadable, and the file opened from its
PDF part alone, which holds only the art on the artboards.

The reader now converts a TransformMatrix with the canvas point of art
space's origin that the template box gives. A file whose symbol
instances were the only part it could not read now opens from its
layers, with the art outside its artboards.

The symbols fuzz test also damages the same data in the older form.

Docs: docs/target-app-parity.md, docs/file-format-parity.md.
2026-11-14 17:03:22 -08:00
dotCooCoo 7d205368e8 PDF export: Convert to Destination converts tagged images to sRGB
With Output > Convert to Destination and an sRGB destination, a gray or
RGB image that carries an ICC profile (a Display P3 TIFF, a PNG or JPEG
with an embedded profile) is converted from that profile to sRGB with
the color settings' rendering intent and written without the profile.
Before, it kept its own numbers and profile.

- A 16-bit image that is not resampled or recompressed stays at 16 bits
  a sample from PDF 1.5 on.
- A JPEG kept as JPEG whose samples the conversion leaves unchanged (an
  sRGB profile) keeps its JPEG data; other JPEGs are encoded again.
- A black-and-white image whose converted levels are gray is compressed
  as grayscale.
- A profile the color engine can't read is kept, with a warning.
- Without conversion, and with Preserve Numbers, images keep their
  profile as before.

IccProfile::to_srgb_pixels converts a run of pixels in one pass.
Docs: docs/mcp.md, document.exportPdf params, target-app-parity.
2026-11-14 16:59:18 -08:00
Dylan M. Taylor 2f5c8a6d35 fix(trace): preserve CMYK and Lab TIFF alpha outlines 2026-11-14 19:56:11 -05:00
dotCooCoo 1ba9b9e7cd PDF export: a knockout group that does not isolate is written without /I true
An opaque knockout group in Normal mode with isolate off and nothing
blending inside was written as an isolated PDF knockout group (/I true
/K true), and a clipped one was drawn in an isolated form. The group's
elements now start from the art below it, as on the canvas: the /K
group carries no /I, and a clipped group gets no isolated form. An
isolated knockout group keeps /I true.
2026-11-14 16:53:01 -08:00
dotCooCoo 4f60e14555 Selection: symbol instances are hit where their art draws past their box
A click on a symbol instance hit only its art's geometric box, and a
marquee touched only that box, so art that a clipping path's live
geometry effects move past the box could be seen but not selected.

- Outside its box, in Preview, a click hits an instance where its placed
  art hits (dynamic overrides and 9-slice placement included), and a
  marquee touches the placed art as it touches a group of that art.
  Outline view and layers with Preview off keep the box alone.
- The quick reach of an instance takes in the regions of the clipping
  paths with live effects in its art, so the groups around it no longer
  cull those clicks.
2026-11-14 16:51:33 -08:00
dotCooCoo 6911fd0cfd .ai export: paragraphs keep Kinsoku, Kinsoku Shori Type, Burasagari and Bunri-Kinshi
The editable text of an .ai save now lists the Hard and Soft Kinsoku sets
(resource key 4) and writes each paragraph's Kinsoku set (key 27, /nil for
None), Kinsoku Shori Type (25), Burasagari (24) and Bunri-Kinshi (23), in
every paragraph run, the normal paragraph style and the document's
defaults, in the form the .ai reader reads. The four settings reopen as
set, including Burasagari and Bunri-Kinshi under Kinsoku None, and are no
longer reported as left out.

Docs: docs/mcp.md (Bunri-Kinshi), docs/target-app-parity.md.
2026-11-14 16:49:24 -08:00
dotCooCoo b78aa4cc33 Graphs: a paint written to an axis line that already shows it is kept for its kind
paint.setFill, paint.setStroke, addon.color.fillToStroke and
addon.color.strokeToFill on an axis line, tick mark or radar ring that
already showed the paint they write stored nothing, so a paint its kind
kept from another line came back when the graph was drawn again. The
paint written to the line's topmost visible fill or stroke row is now
stored for its kind; its other attributes stay as the kind keeps them.
2026-11-14 16:46:07 -08:00
dotCooCoo 43c67bca36 Merge fix/graph-axis-paint-kept into fix/graph-axes-group-edits-kept
Takes #7375's later fixes: Move Appearance onto an axis line behind its
source, picks and added styles without transparency, Default Fill and
Stroke on an axis line, and edits that keep only the line attributes they
change. Aligned row edits, hidden rows, reorders and Default Fill and
Stroke on labels keep this branch's behavior.
2026-11-14 16:45:22 -08:00
dotCooCoo dcdd871a4d 3D: shadow validation casts from the solids it checks
With Shadows on, the check a command runs for Extrude & Bevel, Inflate
and Rotate built every solid a second time to check its shadow. It now
casts the shadow from the faces kept by the builds that check the solids,
as drawing does, so each solid is built once.

A stroke whose solid is left out of the art past its own limits no
longer gets a solid built for the shadow alone: it casts nothing, as it
draws nothing.
2026-11-14 16:42:47 -08:00
dotCooCoo d078e13ad8 Plug-ins: painted live effects refuse gradient stop plates without a spot link
A gradient stop's process plates print beside the tint of the spot swatch
that the stop itself links to. A painted live effect could return a stop
with `plates` and no link, or a link to a process swatch or Registration,
and the result was drawn with plates that no plate ever prints.

- The painted-output decoder refuses `plates` on a stop with no `swatch`
  (absent or null). The gradient's own `swatch` does not link its stops.
- The reference check refuses `plates` on a stop linked to a swatch that
  is not a spot swatch. It runs again on a cached result, so a result is
  refused once its swatch stops being a spot swatch. A missing swatch
  keeps the error that names the swatch.
- Either fault refuses the whole result, and `lastError` names the
  stop's `plates`. Plates on a stop linked to a spot swatch, all-zero
  ones included, are kept. Filter and importer output keep clamping and
  unlinking plates as before.

Docs: docs/plugins.md, docs/target-app-parity.md. The new message has a
row in every complete message catalog.
2026-11-14 16:42:12 -08:00
dotCooCoo e6bfe40d30 Import PDF: linked .ai pages open on their trim boxes with the bleed
With linkPages and cropTo: crop, a PDF-compatible .ai opened on its crop
boxes, while opening it as art uses its trim boxes. It now uses the trim
boxes too. A page on its trim box shows its bleed box round the
artboard, and the pages' bleed (the widest on each side) becomes the
document's bleed, as the importer sets it.
2026-11-14 16:42:06 -08:00
dotCooCoo cc7d081198 Import PDF: linked pages read the file once and keep blank pages
linkPages read and checked the whole PDF again for every page it
linked. The pages are now read from the file opened once. With
cropTo: bounding, a blank page stopped the open with "has no art to
place"; it now gets its crop box, as opening the page as art does.
2026-11-14 16:42:05 -08:00
dotCooCoo c730a1c776 Import PDF: linked pages refuse a .ai saved without PDF compatibility
linkPages refused other files but let a .ai whose page is only a
placeholder through, and each such page then showed the file's editing
data. A page read from editing data is now refused with the existing
error. The file is also hashed once for all its linked pages instead
of once per page.
2026-11-14 16:42:05 -08:00
dotCooCoo f681284dfb 3D: art at NaN or infinite opacity casts no shadow
Extrude & Bevel, Inflate and Rotate decided whether a fill, stroke or
member casts part of the shadow with `opacity > 0.0` and skipped it with
`opacity <= 0.0`. A NaN opacity failed both tests, so the part was
neither cast nor skipped: the shadow cast from the solids drawn added its
faces with a NaN ink, giving the shadow fill a NaN opacity, and the
shadow built for itself recorded an empty part.

Both paths now use one rule, `shadow::Ink::casts`: art casts only when
its opacity is a finite number above zero. NaN and infinite opacity cast
nothing, as 0 % does, and the art beside it still casts. Finite opacity
casts as before.
2026-11-14 16:40:34 -08:00
dotCooCoo 8eded96792 PSD: transform a file's clipping path in place instead of copying it
file_clipped owns the path psdread::clipping_path reads, so it moves it
to the image's place without making a second copy of every anchor.
2026-11-14 16:39:17 -08:00
dotCooCoo 0f8b20c489 Type: glyph forms and width forms follow the OpenType rules
- A form other than the default, set with text.setRangeStyle or
  text.setFormat, takes away the characters' glyph choice, which would
  otherwise keep drawing its own glyph. "default" keeps it.
- With a width form (fwid, hwid, twid, qwid), shaping leaves out palt and
  turns kern and apkn off, and SVG output writes font-kerning: none and no
  palt, as the OpenType feature list asks. proportionalMetrics and kerning
  keep their values.
- The Glyphs panel menu counts a width form as available when a face has
  the feature in GSUB or GPOS.
- At a caret, the menu's check marks and its no-op check read all the
  text of the object, which is what the command formats. Choosing the
  current form again is not skipped when a character has a glyph choice.
2026-11-14 16:39:01 -08:00
dotCooCoo 8cba5fae0c Merge main into fix/live-paint-make-drawn-rows 2026-11-14 16:37:54 -08:00
Dylan M. Taylor fb45e7ecb5 fix(render): validate dimensions in PNG header estimate 2026-11-15 00:37:40 +00:00
Dylan M. Taylor 118a9b627f fix(render): use integer divisibility helper 2026-11-15 00:35:33 +00:00
dotCooCoo 15a6171021 Tests: texture-file tests remove their folders when they fail
The Rough Pastels and Glass texture tests make their folders with
vectorcraft_testkit::TempDir, which removes them on every exit path.
2026-11-14 16:32:18 -08:00
dotCooCoo c7aa27ec12 Transform: saved Scale and Reflect steps without a basis keep the page's axes
An action or journal entry recorded before Scale and Reflect followed the
turned bounding box has no basis value. Replayed, such a step now acts along
the page's axes, as it did when it was recorded; steps recorded now carry
basis "box" and replay along the box. The built-in Reflect Horizontal action
names basis "box", so it keeps reflecting across the box's own axis.

The symbol test that reflects a turned instance names basis "page", which
is the reflection it was written for.
2026-11-14 16:30:56 -08:00
Dylan M. Taylor eb9c049af0 fix(render): estimate streaming for truncated PNG headers 2026-11-15 00:29:35 +00:00
dotCooCoo eff1500bd2 Object: a Distribute submenu runs the Align panel's distribute buttons
Object › Distribute follows Object › Align and lists Horizontal
Distribute Left, Center and Right, Vertical Distribute Top, Center and
Bottom, Horizontal Distribute Space and Vertical Distribute Space. Each
item runs the button's `align.distribute*` command, so it uses Align To,
the key object and the Distribute Spacing value, and with the Artboard
tool chosen it spaces the selected artboards.
2026-11-14 16:28:19 -08:00
dotCooCoo 8dfbe54db6 Units: a very long expression reads as nothing instead of overflowing the stack
Unit::parse took one level of recursion per + - * / sign, so a text such
as "1+1+...+1" with 200,000 terms overflowed the stack and aborted the
process. Every number field, parse_number and every command parameter read
as a length went through it.

Text with more than 128 + - * / signs now reads as nothing; text with 128
or fewer reads as before. docs/mcp.md states the limit for length strings.
The test a_very_long_expression_reads_as_nothing aborted with a stack
overflow before the change.
2026-11-14 16:26:09 -08:00
dotCooCoo e10f87818b OpenType panel: caret checkboxes read the whole text they change
At a Type tool caret the panel's commands style all of the text, but the
checkbox rows, Stylistic Sets and the H or V Style and Roman Italics
items showed only the caret's style. A click could then turn a feature
off for the whole text while most of it did not have the feature. At a
caret they now read every character of the text: a mixed row shows a
dash, a mixed item shows unchecked, and a click turns the feature on
throughout.
2026-11-14 16:24:52 -08:00
Dylan M. Taylor 2e6d3f8f94 fix: preserve large 16-bit PNG import limit 2026-11-15 00:24:26 +00:00
dotCooCoo da426c8781 Merge main into feat/psd-import-options-import-slices-after-7649 2026-11-14 16:23:44 -08:00
dotCooCoo 06fbf967a9 Merge feat/psd-import-options into feat/psd-import-options-import-slices-after-7649 2026-11-14 16:23:42 -08:00
dotCooCoo 2d790aab20 Merge main into fix/graph-design-art-aligned-rows 2026-11-14 16:21:34 -08:00
dotCooCoo 67f427b2b4 Merge main into fix/ai-pen-samples-test-after-path 2026-11-14 16:21:15 -08:00
dotCooCoo d0f1346f87 Docs: record the PSD clipping path in the PSB row and the evidence list
The PSB row of docs/file-format-parity.md says the merged image comes in
clipped by the file's clipping path, as the PSD row does, and
docs/target-app-parity.md's evidence list gets a line for it.
2026-11-14 16:20:16 -08:00
BFlat 895e9493d2 Merge pull request #7693 from dotCooCoo/fix/hidden-chars-test-retry-edit
Tests: each Show Hidden Characters retry sets new text
2026-11-15 07:11:58 +07:00
dotCooCoo 89f20c45c4 SVG import: bound selector matching and share the limits with linked and embedded SVGs
The measurement that runs before the style cascade and usvg now covers
the inputs that still got past it:

- usvg matches a selector without keeping what it found, so one whose
  leftmost part matches nothing tests every set of ancestors in turn.
  The measurement counts those tests for each copy and stops at
  50,000,000; past that the SVG is refused with "the SVG's style sheets
  take too long to match". An SVG image's matching stops at what the
  SVG showing it left.
- A test counts one more for every 16 attributes a lookup scans and
  every 16 bytes of the value it compares, so many classes against a
  long class list count the work they do, in usvg's matching and in
  the import's own cascade.
- The declarations the import's own cascade keeps, once per element,
  count toward the 64 MB, including those of `:not()` rules, which usvg
  drops. Each `:not()` alternative counts as a test.
- A linked SVG file is measured before its cascade runs. The linked SVG
  files share one measurement: once they pass the limits together, the
  files after that are shown without their links. The tests a file past
  the limits made still count.
- SVG images share the element limit and the selector tests with the
  SVG showing them, as they already shared the 64 MB.

The svg_filters reader measures its SVG before the cascade too.
2026-11-14 16:10:10 -08:00