Select > Same, Select by Color (select.color) and document.find looked up
the parent of every object they checked by its id, through
Document::parent_of and Document::node, to tell members of a compound
path and faces of a Live Paint group from other objects. The walk
already stands on that parent, so it now hands it to the check with the
object. walk_selectable keeps its signature and visits the same objects
in the same order.
The selected objects, their order and the count reply are the same as
before, and so is the Reselect state of Select > Same. Tests compare the
walk and the parents it hands out with the old walk and
Document::parent_of, and the results of six Same commands and
select.color with the old per-id loop, in four isolation scopes, from
rectangles at the top level, in a group and in a sublayer, compound path
members, Live Paint faces and a compound path. In a damaged document
that holds an id twice, the parent read is the one that holds the
object being checked.
The gain shows on large documents. With 220,482 objects, the search of
Select > Same > Fill Color takes a median of 24 ms of CPU time instead
of 83 ms, and of Stroke Color 22 ms instead of 60 ms (release build on
Linux, seven alternating runs of both loops in one process; an ignored
test, select_same_perf, times them).
- The Blend Options dialog sends the spacing, count or orientation only
when it was set in the dialog or differs from the first blend's, so
OK on several blends no longer copies the first blend's spacing and
orientation onto the others.
- object.blend.options: a spacing mode without a count keeps the count
of a blend already in that mode. An orientation other than page or
path, a spacing that is not a string, and `value` without `spacing`
are errors (orientation also in object.blend.make and the options new
blends start with).
- The Blend panel dims Type and Ramp while any selected blend has no
spine, since the command refuses easing for such a selection.
- Tests check the live preview while a Ramp or Shift drag is under way.
Supersedes #8022 by ruchirguitar.
A Shift-click with the place cursor now opens the current file's import
options (Text, DXF, Place PDF or Place PSD) before it is placed, whether
the cursor was loaded with Show Import Options on or off or by
file.place.queue. OK places the file at the click and the cursor moves to
the next file. The options the cursor was loaded with for the file's
format are put aside so the dialog opens, and are used when no dialog
opens for the file (a PNG image, a one-page PDF, a linked PSD file). A
Shift-drag places at the dragged size, as a drag does. Headless, where no
dialog can open, a Shift-click places as a click does.
The place tool marks a Shift-click's file.place with
showImportOptions: true.
Docs: docs/mcp.md, docs/target-app-parity.md.
select.magicWand searched lists in three places: paintable looked up
each object's parent in the list of compound paths, add mode looked up
each hit in the selection, and subtract mode looked up each selected
object in the hits. These lookups now use HashSets. The output is still
built by walking the lists, so the wand selects the same objects in the
same order as before.
A test compares paintable, added, subtracted and select.magicWand in
set, add and subtract mode with copies of the earlier searches on a
20,000-path document. An ignored release-build probe times both.
object.blend.options wrote the first selected blend's spacing, orientation,
type, ramp and shift onto every selected blend, whatever the call gave. Each
blend now takes only the values given and keeps its own for the rest, through
one closure used for the selection and for `id`.
- `id` edits that blend alone. A hidden or locked blend and an object that
is not a blend are errors, and the blend's own spine decides whether
easing is allowed.
- A call that changes no blend records no undo step.
- The Blend panel's Ramp and Shift sliders share one helper: a drag
previews on the canvas and records one undo step on release, instead of
one per frame.
Builds on #8022 by ruchirguitar.
Docs: docs/mcp.md, docs/target-app-parity.md.
Direction Handles cleared the selection and then added each path on its
own, and each add searched the paths already selected, so building the
selection took time that grows with the square of the path count. The
command now selects the paths with one Selection::set call and adds the
anchor sets in one extend. The selection is the same: paths keep their
order, a repeated path keeps its first place and its last anchor set,
and the side fields are cleared as before.
crates/engine/examples/direction_handles_bench.rs times both ways on the
same paths in one process. With 20,000 four-anchor paths, building the
selection takes 1.9 ms of thread CPU time against 69 ms one path at a
time.
With the Flare tool, an Alt-click (Option-click on macOS) now draws a flare
centered at the click at once, with the tool's current options, instead of
opening the Flare Tool Options. Alt counts when it is held as the button goes
down; a drag with Alt draws the flare in two stages as before. While the
perspective grid shows with an active plane, the flare is drawn on that plane
from the click, as the dialog's OK draws it, and a click the plane cannot take
reports the error. A plain click still opens the dialog.
A trim checked and changed the selection once for every trimmed path
and every piece, and each check or removal went through all selected
objects, so a trim of thousands of selected paths spent time
quadratic in their number on the selection alone. The command now
reads the selection through a set and removes and adds objects once
at the end. The resulting selection is the same as before, including
object order, the key object and key anchor, the direct-selected
anchors and segments, and the fields that a change to the object
selection clears.
Package copied a placed EPS file as it is, but did not read the native
document a VectorCraft EPS file carries, so the images that document
links stayed out of the package. Placing the EPS reads that document
and looks for its linked files, so once the original folder was gone
the packaged copy showed only the previews.
Package now reads the carried document of a placed EPS or PostScript
file the way it reads a .ai file's editing data, and copies the files
it links beside the EPS file's copy, which finds them there by name.
Cut Path at Selected Anchor Points cleared the selection and then added
each cut path in turn, and each add searched the paths already added, so
selecting the cut ends took time that grows with the square of the number
of cut paths. The command now selects them with one Selection::set call,
which skips repeats through a hash set and keeps the order in which each
path first appears, and then adds each cut end's anchor. The selection is
the same in every field; a new test compares it with the one-by-one build
on open, closed and multi-subpath cuts, long lists and an empty list.
The gain shows on large documents. With the 8 middle anchors of each of
5,000 open paths of 10 anchors selected, building the selection of 40,000
cut ends takes 9.7 ms instead of 232 ms of CPU time, and with 2,000 paths
3.2 ms instead of 39 ms (medians of 7 runs of the new
cut_path_select_bench example, both ways in one process).
Under Include Bleed, a PDF row that sets no bleed now keeps the bleed values a saved PDF preset writes out and turns on useDocument, instead of replacing the whole bleed object. Its file key then matches a row of the same preset that asks for the document's bleed, so the two rows write one PDF.