Commit Graph
441 Commits
Author SHA1 Message Date
HassanKhan d9a404f91b PDF import: no stroke match over lines finished past the limit (#8543)
Answers the fourth CodeRabbit review on #8549.

When a fill pass finishes lines beyond MAX_PARKED, their unstroked
glyphs are recorded (bounded at 4096). The first stroke after that
which could have gone over one of them ends the stroke pass, so a TJ
over more than 65 lines that comes back to where it began stays a
filled object and a stroked one for each part, as documented. Any
other first stroke drops the record, so type after an overflowing TJ,
filled only or not, is matched as before.

MAX_HELD's doc now says that one operator filling the same run of more
than 4096 glyphs twice at the same places is matched as well as it can
be: the reader tells no operator's start.
2026-11-18 16:03:34 +05:00
HassanKhan f23eb05224 PDF import: keep stroke boundaries in the fallback and long passes (#8543)
Answers the third CodeRabbit review on #8549.

- stroke_last no longer restyles the glyph drawn last once a boundary
  (end_fills) closed it: a stroke after an ActualText span no longer
  strokes its replacement text. A glyph stroked again where it was just
  drawn still stays one object.
- Past MAX_HELD, the held strokes go over the last run of consecutive
  fills they match with room for all of them, not the first, so a long
  stroke pass no longer takes the same glyphs an earlier operator
  filled at the same place.
- Docs: the limit is 64 kept-back lines plus the open one, so a TJ over
  up to 65 lines stays filled and stroked.
2026-11-18 15:27:08 +05:00
HassanKhan 8796b773ec PDF import: a stroke pass matches only glyphs filled since its last boundary (#8543)
Answers the second CodeRabbit review on #8549.

- A stroke that goes over no filled glyph (stroked type of its own) and
  the start and end of an ActualText span now end the stroke pass
  (Builder::end_fills): the held strokes are matched, the parked lines
  finished and the open line's fills closed, so a later stroke can't go
  over an earlier fill and a later span keeps its own replacement text.
- ActualText fills are ordinary entries in the line's fill list, and
  span strokes are held and matched in replay order like any other, so
  an A/B/A TJ in a span strokes the replacement. The actual_fills map,
  stroke_parked and has_actual_fill are gone.
- Past MAX_HELD, the held strokes are matched to the first run of
  glyphs filled one right after another that they go over
  (Builder::replayed), with bounded work, instead of each to its first
  match, which could reach an earlier operator's fill.
- Docs state that past 64 lines in one operator each part stays a
  filled object and a stroked one.
2026-11-18 14:46:42 +05:00
HassanKhan b3fd70bc52 Merge remote-tracking branch 'upstream/main' into fix-8543-pdf-tj-fill-stroke
# Conflicts:
#	docs/file-format-parity.md
#	docs/roadmap.md
#	docs/target-app-parity.md
2026-11-18 13:12:26 +05:00
HassanKhan e318f6cc67 PDF import: match a stroke pass to the glyphs filled last, in fill order (#8543)
A TJ can draw the same glyph at the same place twice (its kerning goes
back), so a stroke can't be matched to a filled glyph as it arrives:
[(A) -3500 (B) 4834 (A)] TJ put the first A's stroke on the last A and
left the earlier parts unstroked. Strokes over filled glyphs are now
held until their stroke pass ends and then matched to the glyphs filled
last, in the order they were filled, so each copy is stroked where it
was filled, while a glyph filled and stroked where one filled before
stands still strokes only the newest. At most 4096 strokes are held.

Docs: ordinary text gives one filled and stroked object per part; in an
ActualText span it stays one replacement object on the first glyph's
line and style.
2026-11-18 13:02:58 +05:00
HassanKhan 851c7cb372 PDF import: a TJ whose kerning starts a new line comes in filled and stroked (#8543)
The reader fills every glyph of a text-showing operator, then strokes
them. When a TJ's kerning started a new line part way through, the
first line was finished before the stroke pass came back to it, so its
strokes found no filled glyph and came in as stroke-only type over
fill-only type.

A line a glyph doesn't fit is now parked while a stroke may still be
drawn over it, and a stroke-only glyph is matched against the open line
and then the parked lines, newest first. Parked lines are finished
oldest first before the open line, so drawing order is kept, and at
most 64 are parked.
2026-11-18 12:23:10 +05:00
HassanKhan 0865242d2f PDF export: write the document language as the catalog's /Lang (#3644)
The writer passed no language to craft-pdf, so exported and printed
PDFs had no /Lang and accessibility checkers failed primary-language.
Writer::new now passes the BCP 47 tag of the Document Setup language
(new vectorcraft_doc::setup::language_tag, en-US by default) through
write::Writer::new_with_language, which writes the catalog's /Lang and
the XMP dc:language. A language with no tag writes none. /MarkInfo is
left for tagged PDF (#3643).
2026-11-18 11:46:27 +05:00
BFlat 3b25ff3945 Merge pull request #6697 from yoriswind/codex/6625-visible-fill-selection
Fix path interior selection across enabled fill rows
2026-11-18 13:01:16 +07:00
BFlat a92df52b69 Merge pull request #8245 from datatimp/fix/8237-layers-alt-drop-copy-beside-itself
Layers panel: an Alt-drag copies a row above or below itself
2026-11-18 12:55:56 +07:00
datatimp f531179713 Merge upstream/main into fix/8237-layers-alt-drop-copy-beside-itself 2026-11-17 12:58:32 -05:00
dotCooCoo 0a14dc0a8c Docs: wrap the Enclosing Lasso paragraph in docs/roadmap.md 2026-11-17 07:43:48 -08:00
dotCooCoo d1afba560d Enclosing Lasso: the tool is in the Lasso tool's flyout
The Enclosing Lasso Tool joins the Lasso group in both shipped
toolbars, right after the Lasso, and stays in Object › Plug-ins ›
Enclosing Lasso. The All Tools drawer lists it once, under Select, and
Edit › Keyboard Shortcuts › Tools lists it once. It has no default
shortcut, and the Lasso keeps Q. A toolbar the user already edited
keeps its saved layout; Reset Toolbar adds the tool.

Fixes #6117
2026-11-17 06:51:00 -08:00
HassanKhan 007180e2f3 PDF import: a glyph filled only after one filled and stroked stays unstroked (#8300)
Look::takes let a glyph filled only join a run whose glyphs were also
stroked, so after mode 2 text a mode 0 glyph took the run's stroke:
`2 Tr (B) Tj 0 Tr (C) Tj` came in as "BC" stroked throughout. A glyph
now joins only a run drawn alike (fill, stroke, overprints), so a glyph
filled only starts a run of its own and takes a stroke only when the
matched-stroke path (#8039) strokes it.

flush_stroke no longer strokes a whole run in place: a whole run goes
through the split and join code, so fill and stroke rendering glyph by
glyph still builds one stroked run.
2026-11-17 15:59:49 +05:00
HassanKhan b12bacf3c8 Merge remote-tracking branch 'upstream/main' into fix-8015-pdf-text-fill-stroke
# Conflicts:
#	docs/roadmap.md
#	docs/target-app-parity.md
2026-11-17 12:34:29 +05:00
HassanKhan 971b13843b PDF import: translucent fill-and-stroke type stays two objects (#8015)
A fill and a stroke at the same opacity below 1 were joined into one
type object whose opacity then applies to both together, losing the
darker overlap the file composites. stroke_filled now takes a stroke
only when the fill and the stroke are opaque.

An upright glyph filled and stroked was kept as an outline for the
reshaped-outline fallback while upright glyphs filled only were not;
it is no longer kept either, so such a line can't come in as the
outlines of its stroked glyphs alone.

Docs: the #8015 entries say what is left (translucent type, and a TJ
that starts a new line part way through).
2026-11-17 11:59:20 +05:00
HassanKhan d3640da834 Merge remote-tracking branch 'upstream/main' into fix-8015-pdf-text-fill-stroke
# Conflicts:
#	docs/roadmap.md
#	docs/target-app-parity.md
2026-11-17 11:33:21 +05:00
datatimp e300ca95f0 Merge branch 'fix/8241-panel-copy-cursor-on-windows' into fix/8217-layers-alt-drag-copy-cursor
# Conflicts:
#	docs/roadmap.md
#	docs/target-app-parity.md
#	docs/ui-parity.md
2026-11-16 18:19:32 -05:00
datatimp a932ab543f Docs: #8241 roadmap row 2026-11-16 17:59:06 -05:00
datatimp 2a090b450e Docs: #8217 roadmap row 2026-11-16 17:57:38 -05:00
datatimp ea69ba0b97 Layers: a c opy never goes inside a top-level layer it copies; roadmap row (#8237) 2026-11-16 17:52:20 -05:00
BFlat 5a4cda6382 Merge pull request #8114 from dotCooCoo/feat/drag-into-floating-window
Arrange: a Selection drag released in another document's floating window drops the artwork there
2026-11-16 23:54:12 +07:00
ruchirguitar 49637d63ac 4028: merge main and exercise picker and row-menu UI 2026-11-16 17:18:38 +05:30
dotCooCoo b429b00851 Arrange: a Selection drag released in another document's floating window drops the artwork there
With Window › Arrange › Float in Window, a Selection move released over
the art area of another document's floating window copies the artwork
into that document with edit.dropSelection, as a release over a tiled
pane does. The window becomes the current one, and the grab point lands
under the pointer in that window's own zoom and rotation. While the
current document floats, a release over the pane the main window draws
copies the artwork into the main window's document. A floating window
with another view of the source document takes a move, and Alt copies.

The release is taken at the start of the frame, before any canvas sees
it, so a release in the first frame over a window still drops the
artwork, and the source move is rolled back first. A release on a
window's title bar, rulers or scroll bars, or after Escape, changes
neither document. This covers floating windows drawn inside the main
window (the web, Wayland and a control channel). A floating window that
is an OS window of its own does not take the artwork yet.

Docs: development.md, target-app-parity.md, gaps.md, roadmap.md,
ui-parity.md.
2026-11-16 03:28:50 -08:00
dotCooCoo c367a8e991 Arrange: a Selection drag released in another document's tiled pane drops the artwork there
Under Window › Arrange › Tile, a Selection move dragged from the current
pane and released over another document's pane copies the artwork into
that document with edit.dropSelection, with no tab hover first. The pane
becomes the current window, and the grab point lands under the pointer in
that pane's own zoom and rotation. A release over another view of the
source document moves the artwork with object.move, and Alt copies it.
The source move is rolled back before the canvas sees the release, also
when the pointer enters the pane and the button goes up in one frame.
Artwork carried to a document through its tab can also be released in a
third document's pane. A release over a pane's rulers or scroll bars, or
after Escape, changes neither document, and a press in another pane with
no artwork carried still only makes its document current. Dragging into a
floating document window and the tab overflow menu are not covered.

Docs: development.md, target-app-parity.md, gaps.md, roadmap.md,
ui-parity.md.
2026-11-16 00:14:41 -08:00
HassanKhan 836d8d4a1c PDF import: a stroke matches only a glyph placed alike, and strokes only it (#8015)
Match a stroke to a filled glyph by its whole placement (origin, size,
horizontal scale, slant and direction), not just its origin, so a stroke
drawn at another size over a filled word stays type of its own. Restyle
only the matched glyphs' text instead of the rest of their run: strokes
over neighbouring glyphs gather and restyle once, so a word filled and
stroked whole stays one run, while a stroke over one glyph of a filled
word strokes that glyph alone.
2026-11-16 11:24:49 +05:00
HassanKhan f17a218cfc PDF import: text filled and stroked in one operator is one Type object (#8015)
With text rendering modes 2 and 6 the reader fills every glyph of a
text-showing operator before stroking them, but the importer only joined
a stroke to the glyph filled last, so a word shown in one Tj came in as
a stroke-only Type over a fill-only one. TextLine now records the glyphs
it fills and stroke_filled matches each stroke to its filled glyph in
order, splitting a run where the stroke differs.
2026-11-16 10:51:59 +05:00
makesomethingshit aac0a8b2a7 Fix #8005: Grow the spectrum with the Color panel 2026-11-16 10:33:31 +09:00
BFlat e34fef895f Merge pull request #7732 from ruchirguitar/feat/swatches-item-context-menu
Swatches: add right-click context menu to swatch items
2026-11-16 02:30:51 +07:00
ruchirguitar 104a844da1 feat(ui): implement Check Spelling modal dialog (#4936)
# Conflicts:
#	docs/roadmap.md
2026-11-15 21:33:12 +05:30
ruchirguitar e9c57f06e4 G12: remove superseded pending validation notes 2026-11-15 14:12:39 +05:30
ruchirguitar 750c75f52f G12: integrate current main and panel view state
Resolve documentation and upstream test-helper conflicts, preserve the upstream helper fix, and adapt context-menu harness views to app state. All 13 Linux CI gates pass on this integrated source.
2026-11-15 14:09:04 +05:30
HassanKhan 75c884e333 Merge remote-tracking branch 'upstream/main' into fix-7741-pdf-text-stroke-cap
# Conflicts:
#	docs/roadmap.md
#	docs/target-app-parity.md
2026-11-15 12:33:21 +05:00
HassanKhan 9dafc08f8f PDF import: a glyph stroked otherwise gets a run of its own (#7741)
A filled glyph joins a run of the same fill whatever its stroke, so with
fill and stroke rendering shown a glyph at a time, the stroke replayed
over the last glyph restyled the whole run: glyphs before it took its
cap, join and miter limit. When that stroke differs from the run's, the
glyph's text now splits off into a run of its own; the line's text is
unchanged, so slots, gaps and authored flags still line up.

Also record the change in the parity and roadmap docs.
2026-11-15 11:05:54 +05:00
ruchirguitar f77bbaf32e docs: record Neon & Glow library in roadmap and align G5 estimate history 2026-11-15 09:55:20 +05:30
ruchirguitar 45aeeeddca G12: fix upstream test helper blocking swatches CI
Give the SVG-filter defaults' square test raster its width and height. All 13 Linux CI gates pass on the integrated source; fresh deep CodeRabbit review reports zero findings.
2026-11-15 09:37:34 +05:30
ruchirguitar 39fdcd1f25 G12: merge main into swatches context menu branch
Resolve documentation conflicts while preserving both panels' evidence. Integration CI stops at the upstream SVG filter test helper compile error tracked in #7727; original feature CI and deep review passed.
2026-11-15 07:57:04 +05:30
ruchirguitar 6f4a651c00 Swatches: add right-click context menu to swatch items 2026-11-15 07:26:16 +05:30
ruchirguitar 1ab2743f8e G5: resolve Tech Circuit documentation merge conflict
Merge current main and retain both the Pencil snapping documentation and Tech Circuit library evidence. Only docs/mcp.md required manual conflict resolution. Focused checks passed: no conflict markers or whitespace errors, all 28 catalogs retain four unique nonempty labels, and brush implementation/tests remain unchanged. No full local Cargo CI rerun.
2026-11-15 07:21:46 +05:30
dotCooCoo 09c6d5dcf1 Fix #7275: a typed artboard name follows its artboard
The rename field in Export for Screens tracked the artboard by its index. If the
artboards changed order while a name was typed (a command from the control channel
or MCP), Enter renamed the artboard that had moved into that index. The field now
tracks the artboard by its id and by the document it was opened in. When that
artboard is deleted, or another document becomes active, while its name is typed,
the field closes, no artboard is renamed, and Escape closes the dialog again.
2026-11-14 13:50:32 -08:00
makesomethingshit 9334dfd8d7 Fix #7275: Rename artboards in Export for Screens 2026-11-14 12:39:11 -08:00
ruchirguitar 1030b7aa71 G5: merge current main for Tech Circuit
Preserve Weather Icons and the Tech Circuit library while resolving documentation and Hungarian catalog conflicts. Validated all 13 cargo xtask ci gates on Linux and a fresh deep CodeRabbit review with zero findings.
2026-11-15 00:05:27 +05:30
ruchirguitar 9c787d2cdc Brushes: built-in Tech Circuit brush library
G5: add original procedural circuit art and pattern brushes, library regression coverage, translations, and progress documentation.
2026-11-14 19:00:49 +05:30
ruchirguitar 831c477ad6 Symbols: built-in Weather Icons symbol library 2026-11-14 15:43:16 +05:30
ruchirguitar 71df7e0e6d #6613: apply approved Gujarati proofreading corrections 2026-11-14 12:20:13 +05:30
ruchirguitar 7929c95ce9 #6613: guard web Gujarati selection and address local review 2026-11-14 10:29:25 +05:30
ruchirguitar 6f6746bd72 #6613: reconcile Gujarati catalog and complete current interface coverage 2026-11-14 09:44:24 +05:30
ruchirguitarandruchirguitar 30eb14d7dc PDF import: outlined Indic glyphs keep their own stroke and transparency (#5235) (#6957)
* PDF import: outlined Indic glyphs keep their own stroke and transparency (#5235)

Follow-up to #6906, for two review findings on how a line kept as
outlines is joined into paths:

- Glyphs were joined when their stroke widths matched; dash, cap, join
  and miter limit were ignored, so a dashed glyph took the stroke of the
  solid one before it. They join only when the whole stroke matches.
- Translucent glyphs were joined into one fill, where overlapping marks
  paint once instead of compositing as the file draws them. Only opaque
  glyphs join.

Also records the fix in the PDF row of docs/target-app-parity.md and in
docs/roadmap.md, as AGENTS.md asks.

Tests: outlined_glyphs_stroked_differently_stay_apart and
outlined_translucent_glyphs_stay_apart (both fail without the change).

* PDF import: outlined Indic glyphs under a soft mask stay apart; check kept geometry (#5235)

Review follow-ups on #6957 and #6906:

- Glyphs kept as outlines under a soft mask were joined into one path,
  so the mask was applied once to all of them where the file applies it
  to each glyph. They now join only when no soft mask is active.
- The fallback tests counted outline nodes only. A new test compares the
  kept outlines (element count and bounding box) with the same file
  opened as outlines, so a dropped or moved glyph fails it.

Tests: outlined_glyphs_under_a_soft_mask_stay_apart (fails without the
change) and kept_glyphs_are_where_the_file_draws_them.

* PDF import: mask outlined Indic glyphs one by one under a soft mask (#5235)

Review follow-up on #6957. Keeping glyphs out of one shared path was not
enough: each path still went into the soft mask's queue and
flush_masked wrapped them all in one masked group, so a mask that is not
constant was applied once to every glyph, where overlapping glyphs
composite one by one in the file.

With a soft mask active the queued art is now drained before the first
glyph and after each one, so every glyph gets a mask of its own.

Test: outlined_glyphs_under_a_varying_soft_mask_are_masked_one_by_one
checks that each outlined glyph carries its own mask (0 of 3 without
the change).

* #6957: clarify soft-mask exception in glyph grouping docs

---------

Co-authored-by: ruchirguitar <info@jeevantirth.org>
2026-11-14 03:26:20 +01:00
Don Omondi cfa3221dd3 Roadmap M3 row: the #1638 note goes in the Status cell 2026-11-13 03:21:08 -05:00
Don Omondi ffc22ffc4c Merge remote-tracking branch 'upstream/main' into fix/graphic-styles-list-height-2992
# Conflicts:
#	docs/roadmap.md
#	docs/target-app-parity.md
2026-11-13 03:20:58 -05:00
yoriswind c103439d2c 6625: respect stroke caps and joins in fill hit testing 2026-11-12 23:57:50 -08:00