Commit Graph
102 Commits
Author SHA1 Message Date
dotCooCoo e2d7976794 Merge main into fix/shear-angle-range 2026-11-17 22:56:09 -08:00
BFlat 50c7208fe3 Merge pull request #8466 from dotCooCoo/perf/find-command-index
Commands: find_command looks commands up in an index built once
2026-11-18 13:15:20 +07:00
BFlat bc30887624 Merge pull request #8382 from dotCooCoo/fix/undo-keeps-view-state
Undo: undo and redo keep the settings changed without an undo step
2026-11-18 12:57:41 +07:00
BFlat bbf6165fc8 Merge pull request #8206 from dotCooCoo/feat/packaging-fold-preview
Packaging Tools: Fold Preview folds the blank in 3D with the printed art on its panels
2026-11-18 10:30:50 +07:00
BFlat 2a28193517 Merge pull request #8167 from dotCooCoo/fix/issue-7849-shape-mode
Pathfinder: Shape Mode buttons warn when a line encloses no area
2026-11-18 10:21:50 +07:00
BFlat dd3a1886a6 Merge pull request #7764 from dotCooCoo/feat/dataset-import-graph-columns
Variables: Import Data Sets reads % columns of graph data files
2026-11-18 10:15:07 +07:00
dotCooCoo 9f84820d88 MCP: transform checks scale, reflect and shear before any step runs
The transform tool runs move, rotate, scale, reflect and shear as separate
commands. A shear angle that object.shear refuses, such as 90, a reflect
axis other than vertical or horizontal, or a scale of 0 failed only after
the earlier steps had changed the art and recorded undo steps. The tool now
checks those params first with the rules the commands use
(scale_factors, reflect_axis and shear_tangent, shared with object.scale,
object.reflect and object.shear), so a refused request changes nothing and
records no undo step.
2026-11-17 17:42:44 -08:00
dotCooCoo f623a28bb0 Commands: find_command looks commands up in an index built once
find_command searched the list of about 1,000 built-in command specs in
order on every call, and a top-level command looks its id up at least
three times before it runs. It now finds a built-in in a map from id to
spec that is made on the first call. When an id is listed twice, the
map keeps the first spec, which is the one the search returned. An id
that is not a built-in still goes to the installed plug-ins' commands
at the time of the call, so installing or removing a plug-in shows at
once and built-ins keep precedence.
2026-11-17 14:27:14 -08:00
dotCooCoo 6e44c63cc3 Undo: undo and redo keep the settings changed without an undo step
Undo and redo put back the whole document a step stored, so settings
that change without an undo step went back with it. Undoing any
earlier edit turned the perspective grid's Lock Grid off again, turned
its Snap to Grid back on, showed a hidden grid and switched the active
plane back. It also reset the grid from Gridline every and
Subdivisions, the export settings assets.settings.set stores, and the
current brush and symbol.

Each undo step now also records these settings as the step left them.
Undo and redo compare that record with the document they bring back:
a setting the step did not change stays as it is now, and a setting
the step changed comes back with the step. So undoing a perspective
grid preset still hides the grid the preset showed, and undoing a grid
definition that locked the grid unlocks it. The point Automatic Plane
Positioning holds still follows the steps, and is let go when the
active plane kept is another one.
2026-11-17 08:40:50 -08:00
dotCooCoo 4911e102b1 Packaging Tools: Fold Preview folds the blank in 3D with the printed art on its panels
Fold Preview (Object › Plug-ins › Packaging Tools, and the Fold Lines panel's button) shows the
document's blank folded about its largest panel, or the panel double-clicked. Creases and
perforations fold 90° away from the printed side and partial cuts 90° toward it. Each panel
samples a raster of the print, with the fold lines and non-printing layers left out, through its
projective map, with a depth buffer; the back shows the board's inside color. The window has a
Fold slider, seven view presets, orbit, zoom, pan and perspective, and its status line reports a
joint that does not close and panels that pass through each other.

- addon.packaging.fold returns each panel's frame, the hinges with their angle and gap, and the
  collisions. A closing hinge's gap is measured with every hinge folded all the way.
- ui.foldPreview sets the window and rejects values of the wrong kind or out of range; saved
  settings out of range are brought into range.
- The print renders off the UI thread where a worker exists and once per document revision. The
  fold and the view image are worked out again only when the document, the settings or the
  window's size change.
2026-11-16 10:20:36 -08:00
dotCooCoo ce6a84bbd9 Merge main into fix/issue-7849-shape-mode 2026-11-16 09:56:10 -08:00
dotCooCoo 9b1823c54c Pathfinder: Shape Mode buttons warn when a line encloses no area
Unite, Minus Front, Intersect, Exclude and Minus Back close open paths,
so a straight line encloses no area and does not change the result.
Until now the line was dropped with no message. Reported in #7849.

- The reply of object.pathfinder.unite, minusFront, intersect, exclude
  and minusBack now carries a warning, which the status bar shows, when
  a selected object is or holds an open path that encloses no area once
  closed (a line in a group or compound path included). The message
  names Object › Path › Outline Stroke. The area is measured with the
  path's fill rule, as Make Compound Shape's check in #7894 does.
- When such a path is what leaves the result empty (Intersect, or a
  line at the back in Minus Front), the error says so. Objects that
  leave nothing without the line keep the plain error.
- Both messages have rows in each complete-message catalog. The params
  text and docs/mcp.md describe the reply field.
2026-11-16 07:37:40 -08:00
dotCooCoo 75b02ea8df Symbols: the panel reads the current symbol without running symbol.list
The Symbols panel and its panel menu asked for the current symbol on
every frame by running symbol.list, which builds a row per symbol and
walks the whole document once per symbol to count its instances. They
now read it from the active document with cmd::current_symbol, the
rule symbol.list itself uses for its `current`: the stored name while
a symbol has it, else the first symbol. symbol.sortByName,
symbol.place, symbol.options and text.insertInline use the same
function, and symbol.list's reply is unchanged.

An idle frame of the panel or its menu now runs no command, so on
macOS the native menu is not brought up to date on every frame while
the panel is open. In a document with 200 symbols and 50,000 objects
the read takes 0.035 us instead of 48.5 ms in a release build (thread
CPU time on Linux, median of 7 runs). The gain matters on large
documents; on small ones it is too small to notice.
2026-11-16 05:29:31 -08:00
BFlat 844f57a209 Merge pull request #7953 from dotCooCoo/feat/trim-hover-preview
Path Precision Tools: Trim at Crossings shows the stretch a click would remove
2026-11-16 09:32:44 +07:00
dotCooCoo 5bba196c4f Path Precision Tools: Trim at Crossings shows the stretch a click would remove
Hovering with the Trim at Crossings Tool draws in red the stretch a click
there would remove, on the same paths and by the same rules as the click,
and nothing over empty canvas or hidden and locked paths. A drag draws
every stretch its rectangle or freehand line would remove while it
reaches at most 32 paths. In isolation mode only paths inside the
isolated object are highlighted.

What a pick removes moves from the command into
vectorcraft_tools::addons::trim::plan, which the command and the tool
both use. A preview spends at most a twentieth of the crossing work a
click may (Work::share); past that it shows nothing, and the click or
release still removes what it reaches. The tool keeps the crossings it
found for the document as it is, so moving along one path does not
search again, and kept crossings still count against a pick's work
budget. Work::spent_since and Work::draw in vectorcraft-pathops measure
and charge that work.

Docs: docs/mcp.md, docs/ui-parity.md, docs/target-app-parity.md.
2026-11-15 11:24:17 -08:00
FredApps c9cad8d017 Merge main into fix/restore-codec-cutover-ci
Port main's new variable-library parsing (variable kinds, image, visibility
and graph values) from roxmltree to craft-xml with the branch's strict
options and attribute validation. Keep both sides' variable tests.
Drop the stale docx::nesting doc link.
2026-11-15 15:43:44 +01:00
dotCooCoo ef3a632869 Merge main into feat/dataset-import-graph-columns 2026-11-15 06:16:34 -08:00
BFlat 97c3226d72 Merge pull request #7773 from dotCooCoo/feat/variables-panel-sort-columns
Variables: Variables, Objects and type columns sort the variable list
2026-11-15 14:43:04 +07:00
BFlat 4a5f07b8c3 Merge pull request #7753 from dotCooCoo/feat/info-panel-tool-readouts
Info: the panel shows the move, transform, Zoom and Paintbrush values of the tool in use
2026-11-15 13:50:30 +07:00
dotCooCoo d5ccac5646 Variables: Variables, Objects and type columns sort the variable list
The Variables panel drew each variable as one "name · object" line in
the order the variables were defined, with no headers and no sorting.

The list now has three columns with headers: the type icon, Variables
and Objects. A click on a header sorts the list by that column, and a
second click reverses the order. The new command variable.sort {by:
name|object|type|none, descending?} sets the order, which is panel
state: not saved and not an undo step. variable.list lists the
variables in that order and reports it as sort. An unknown by, or a
descending that is not true or false, is an error.
2026-11-14 22:21:08 -08:00
dotCooCoo 8f5aed7ea4 Variables: Import Data Sets reads % columns of graph data files
dataset.import refused every header cell that starts with % unless it was
a variable's exact name, so the five-column example on the data source
set-up page did not import. A %Name header now defines the graph variable
Name, or names it when the document has it, and each cell of the column is
the path of a graph data file. The file is read as the Graph Data window's
Import Data reads one, and the data becomes the data set's graph value,
which applies as graph.setData applies it.

A relative path is taken from the new base parameter, else from the folder
of the CSV file at path. A file that is missing, can't be read or is larger
than 1 MB, a file that gives a graph value longer than 256 KB, and %
columns that hold more than 256 MB in all refuse the import with the line
and the column, and the document is left as it was. Each file is read once
per import.

Import Data's text decoding, cell splitting and sheet-to-data steps move
from the Graph Data dialog to the engine (graph/data.rs), so both imports
read a file the same way. dataset.export's warning now lists a % header
over values as refused and a %-prefixed variable of another kind as read
back with another kind.
2026-11-14 22:07:06 -08:00
dotCooCoo bcadfc7ac8 Info: the panel follows the tool in use
While the Selection, Direct Selection or Group Selection tool moves the
selection, or the Gradient tool draws a vector, W and H show the change
in x and y, with the distance and the angle under them. A Scale tool
drag shows its percentages; a Rotate, Reflect or Shear tool drag shows
the center of the selection's box and its angles. The Zoom tool adds the
magnification and the Paintbrush the name of its brush.

W and H follow Use Preview Bounds. With several objects selected, the
panel shows only the fill, stroke and type values they share, and Show
Options adds a tint's swatch and percentage and a gradient's swatch name.

- Tool::readout and Readout (crates/tools/src/readout.rs).
- info.readout returns the selection's size and the tool's readout.
- Docs: docs/mcp.md, docs/ui-parity.md.
2026-11-14 21:31:28 -08:00
dotCooCoo f05d481247 Control bar: Select Similar Objects selects by the attribute its menu keeps
With something selected, the Control bar shows a Select Similar Objects
button and, beside it, the Select Similar Options menu. The button
selects the objects like the first selected one by the attribute kept
for the session; a menu item selects by its attribute and keeps it,
and the kept item is checked. The items are All, Fill Color, Fill &
Stroke, Stroke Color, Stroke Weight, Opacity, Blending Mode,
Appearance, Graphic Style, Shape and Symbol Instance.

- select.similar {by?} runs the select.same command of that name, or
  for "all" matches fill and stroke colors, stroke weight, opacity and
  blending mode together. An unknown by is an error that keeps the
  selection and the kept attribute. The journal records the attribute
  used, so a recorded action repeats it, and a failed script or plug-in
  call puts the kept attribute back.
- The button and menu belong to the Object Options group and sit at
  the right end of the bar, after the X, Y, W and H fields. They take
  only the room the other controls leave, so the bar leaves them out
  before any other control.
- The Paragraph tests' control_bar_node looks for a label before a
  value, so a link's text run listed first no longer stands in for
  the link.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-14 18:41:14 -08:00
Dylan M. Taylor cb5c52f5e6 fix: validate XML attribute identities and preflight GIF frame limits 2026-11-14 23:25:19 +00:00
dotCooCoo 35ab0ee859 Merge main into fix/file-folder-param-classification 2026-11-14 12:17:54 -08:00
dotCooCoo 501dad41a1 Merge main into fix/file-folder-param-classification 2026-11-14 08:23:36 -08:00
dotCooCoo bad6ee22ea Merge main into fix/place-text-utf16-no-bom 2026-11-14 04:55:27 -08:00
BFlat edb228ac33 Merge pull request #7402 from dotCooCoo/fix/more-int-param-wrong-type
MCP: path, type, panel, library, style and ruler indices refuse a wrong-type value
2026-11-14 16:54:34 +07:00
dotCooCoo 2a5f2009d8 Graphs: Import Data reads UTF-16 text files without a byte-order mark
The Graph Data window's Import Data read UTF-16 only after a byte-order
mark, so a UTF-16 file without one filled the cells with NUL characters.
It now reads such a file in the byte order Import Data Sets' rule (#7348)
gives it: at least half of the two-byte units hold a NUL byte, and the
byte order is the one that reads the line breaks. The text is then read
as after a byte-order mark: an odd last byte is dropped and an unpaired
surrogate reads as U+FFFD. A file the rule refuses is read as UTF-8, as
before.

The rule now also gives a byte order to a one-line file, which reads a
line break in neither order: big-endian when more of its units start
with a NUL byte than end with one, else little-endian as before. Import
Data Sets still refuses a one-line file, which has no data rows; read in
the new order, such a file can be refused with a different error first.
2026-11-14 01:51:42 -08:00
dotCooCoo 531fad0532 MCP: path, type, panel, library, style and ruler indices refuse a wrong-type value
A required index given as something other than a whole number of 0 or
more, such as "3", 2.5, -1 or true, was reported as missing: `anchor` of
path.setHandle, path.moveAnchor and text.setPathHandle, `segment` of
path.insertAnchor, and `to` of artboard.reorder, library.moveGroup and
graphicStyle.move. Each now refuses it with "`anchor` must be a whole
number", naming the key; left out or null, it is still missing.

An optional `subpath` of path.appendAnchor, path.close and path.reverse
given that way was read as left out, so the command extended, closed or
reversed the default subpath (path.reverse reversed every subpath). The
`artboard` of the ruler origin commands answered "index out of range"
for such a value and for null. Both now refuse such a value with the
same message and change nothing. A null `artboard` is artboard 0, as one
left out is; a whole number past the artboards is still out of range.
2026-11-13 19:08:16 -08:00
dotCooCoo 78ce56d021 MCP: an integer given as a string or a fraction is refused as the wrong type, not reported as missing
A command that needs a whole number of 0 or more, such as `index` of
`appearance.setItem`, `anchor` of `path.removeAnchor` and
`addon.pen.removePoint`, `sourceDocument` of `edit.dropSelection`, `index`
of `document.activate` and `to` of `document.move`, answered "missing
integer `index`" (or "missing index") both when the key was left out and
when it was given as a value that is not a whole number of 0 or more, such
as "3", 2.5, -1 or true. A value that is given but is not one is now
refused with "`index` must be a whole number", the message object ids
already use. A key left out or given as null is still missing, and an
optional index such as `subpath` keeps its default. Neither error changes
the document or records an undo step.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-13 18:02:42 -08:00
dotCooCoo c1572562de Merge main into fix/file-folder-param-classification 2026-11-13 15:55:47 -08:00
dotCooCoo a2efb2d88b Artboards: delete several artboards and their guides in one pass
Delete Artboards, Delete Empty Artboards and Cut Artboard removed the
chosen artboards one at a time, walking every ruler guide and the layer
tree once per artboard. They now share one helper that removes the
artboards in one walk and their guides in one more, leaving the same
artboards, guides and selected guides as before.

Empty Artboards in Artwork Cleanup had its own copy of the one-pass
removal. It now calls the same helper, and its test reads that helper's
walk counter.
2026-11-13 13:23:42 -08:00
dotCooCoo 947a8ef181 Merge main into fix/file-folder-param-classification 2026-11-13 13:20:25 -08:00
BFlat 637d51df79 Merge pull request #7143 from dotCooCoo/feat/guides-layer-rows
Layers: ruler guide rows have their own eye and lock, and go to the trash
2026-11-14 00:50:35 +07:00
dotCooCoo 5e19c59f33 Automation: one classification of file and folder params
A param key names a file or a folder by a reviewed list of whole names,
read in the context of the command it is for (ParamsPlace): the
plug-in call check, the control server's reply hiding and recorded-step
filtering, and the sweeps' temp-folder redirection all use it.

- `url` (a web link) and `folders` (an export's grouping) no longer
  count as files or folders, and keys that only end like one
  (alignToPath, wholePaths, sortPaths, linksFolder and others) are no
  longer path params in control replies or recorded steps.
- `dir`, `directory` and the folder preferences that prefs.set takes in
  `values` (fontsFolder, pluginsFolder, recoveryFolder,
  templatesFolder) are folders everywhere, so a relative path under one
  outside the read root is taken out of a recorded step.
- A `command.batch` step, an `engine.execute` request and a recorded
  step keep their own command's exceptions below the top level, so the
  sweeps no longer replace a nested web link or export grouping.
- A new test sorts every catalog key that reads like a file or folder
  key into the reviewed lists and checks every classifier against them.
2026-11-13 09:14:58 -08:00
dotCooCoo 4282f4fa99 i18n: Document Info shows every category title and count label in the interface language
Font Details, Linked Images and Embedded Images, and the Objects counts
Compound Paths, Text Objects, Placed Documents, Symbol Instances, Gradient
Meshes, Blends, Envelopes, Intertwine Groups, Opacity Masks and Objects
with Effects had no catalog rows, so the panel and its category menu
showed them in English in every other language. Each complete catalog
now has them, and the Document rows Pattern Swatches (de, it, ja, ko,
pl, uk, vi, zh-hant) and Path Length (bg, el) are added where missing.

The catalog test now checks every category title, every Objects count
label and Document's fixed row labels. document.info and the saved
report keep the English labels.
2026-11-13 06:32:35 -08:00
dotCooCoo fb41d79f28 Layers: ruler guide rows have their own eye and lock, and go to the trash
The eye and lock on a guide's row in the Layers panel hide or lock that
guide alone, in one undo step, and a drag down either column takes guide
rows along with the other rows it passes. A hidden guide is not drawn and
does not snap, and its row is dimmed; a locked guide is drawn and snaps
but can't be selected, moved or deleted. Both can be changed while the
guide's layer is hidden or locked, and the guide shows or can be edited
only when its layer allows it as well. The state is kept through save
and reopen.

- layer.setProps takes ruler guide node ids; every other command still
  refuses them.
- guide.list rows carry the guide's node id and its own hidden and
  locked state.
- Alt-click and Ctrl/Cmd+Alt-click on a guide row's eye or lock act on
  the other layers, as on any row in that layer.
- Object > Lock > Selection and Object > Hide > Selection lock or hide the
  selected ruler guides with the selected art, in one undo step, outside
  isolation mode. Unlock All and Show All, document scope, also unlock or
  show guides locked or hidden on their own and select them as guides.
- Guide rows dropped on the Layers panel's trash delete their guides
  (guide.remove {indexes}). A click on a guide row clears the highlighted
  rows, so Delete deletes the guide; with no row highlighted the trash
  deletes the selected guides.
- guide.remove and guide.setLayer refuse index together with indexes and
  an indexes value that is not a list, and count a repeated index once.
  guide.select, guide.remove and guide.setLayer refuse an indexes list of
  more than 10,000 entries; guide.setLayer cut such a list short before.
- Moving, deleting or moving to another layer a guide that is hidden or
  locked on its own fails with "the guide is hidden or locked"; a guide
  on a hidden or locked layer still fails with "the guide is on a hidden
  or locked layer".

Docs: docs/mcp.md, docs/target-app-parity.md, docs/ui-parity.md.
2026-11-13 06:07:27 -08:00
BFlat 1b9aa07e65 Merge pull request #6995 from dotCooCoo/feat/actions-insert-select-path
Actions: Insert Select Path stores the selected path as a step
2026-11-13 12:27:58 +07:00
dotCooCoo b64b4802f8 Merge main into feat/actions-insert-select-path 2026-11-12 19:01:39 -08:00
dotCooCoo df155042d4 Merge main into feat/image-color-mask 2026-11-12 17:40:13 -08:00
dotCooCoo 2b975d620e Actions: Insert Select Path stores the selected path as a step
The Actions panel menu has Insert Select Path, after Insert Menu Item.
With one whole path or compound path selected, it inserts a Select
Path step into the action being recorded, or after the selected action
or step. Playing the step selects that path again.

- New engine command `select.storedPath {id, fingerprint}`. The step
  stores the path's object id and a fingerprint of its geometry and
  fill rule ("v1:" and 16 lowercase hex digits, FNV-1a 64). Playback
  selects the path only while it exists unchanged and can be selected;
  otherwise the step fails and the selection stays as it was. A path
  on a locked artboard is refused in isolation mode too.
- Capture refuses an empty selection, several objects, selected
  anchors or segments alone, groups, type, guides, a path selected
  together with ruler guides, a member of a compound path, and hidden,
  locked or template art.
- New UI command `ui.action.insertSelectPath {set?, action?, step?}`.
  Step rows show "Select Path".
- `.vcactions` files that hold a Select Path step are written as
  version 4. Reading accepts versions 1 to 4 and refuses a Select Path
  step with invalid params.
- Rows for the new labels and messages in every catalog.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-12 16:02:00 -08:00
dotCooCoo 3efdf4ab9c MCP: a required number given as a string is refused as the wrong type, not reported as missing
A command that needs a number, such as `x` of `shape.rectangle`, `intensity`
of `edit.colors.saturate` or `index` of `object.envelope.setMeshPoint`,
answered "missing number `x`" both when the key was left out and when it was
given as a value that is not a number, such as "40". A value that is given but
is not a number is now refused with "`x` must be a number, not "40"", the
message the optional number checks already use, showing the value as given.
A key left out or given as null is still a missing number. Neither error
changes the document or records an undo step.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-12 15:44:02 -08:00
BFlat d61ad77529 Merge pull request #6909 from dotCooCoo/feat/align-artboards
Align: the Align panel aligns and distributes the selected artboards
2026-11-13 06:11:32 +07:00
BFlat 822d4101b5 Merge pull request #6890 from dotCooCoo/feat/3d-expand-as-wireframes
3D and Materials: Expand as Wireframes turns a 3D object into its edges as paths
2026-11-13 05:23:34 +07:00
dotCooCoo 3e32e99a15 Merge main into feat/align-artboards 2026-11-12 13:47:00 -08:00
dotCooCoo ba20f468b3 Merge main into feat/align-artboards 2026-11-12 11:58:32 -08:00
dotCooCoo fe34c2b818 Merge main into feat/custom-arrowheads 2026-11-12 09:23:20 -08:00
dotCooCoo 8d27e53115 Merge main into feat/image-color-mask 2026-11-12 08:56:33 -08:00
dotCooCoo 2e968acc47 Align: the Align panel aligns and distributes the selected artboards
With the Artboard tool chosen, the Align panel's Align Objects,
Distribute Objects and Distribute Spacing buttons, their UI commands and
the Control bar's Align and Distribute buttons act on the artboards the
tool has selected, as the public page describes:
https://helpx.adobe.com/illustrator/desktop/create-manage-artboards/organize-manage-artboards/align-and-distribute-artboards.html

- artboard.align, artboard.distribute and artboard.distributeSpacing
  move whole artboards with their guides, and with the art inside them
  when Move Artwork with Artboard is on, in one undo step. No undo step
  is recorded when no artboard moves.
- Align To offers Align to Selection and Align to Artboard. Align to
  Artboard keeps the active artboard in place, and the Distribute
  buttons then send the Distribute Spacing value. A locked artboard
  stays where it is. These rules are VectorCraft's own.
- The Control bar shows the Align buttons, the Align To menu and the
  Distribute buttons after the artboard controls while it has room.

Docs: docs/mcp.md, docs/ui-parity.md.
2026-11-12 07:28:16 -08:00