Commit Graph
13 Commits
Author SHA1 Message Date
dotCooCoo cb368c29e4 Merge main into fix/paste-plain-graph-labels 2026-11-14 23:52:57 -08:00
dotCooCoo 277fdb15c7 Paste: Paste without Formatting keeps a pasted graph's labels plain when it is drawn again
A graph keeps its labels' character and paragraph formats for each redraw.
Paste without Formatting reset the labels' text but left those formats in
the graph, so the next redraw (Graph Data, Graph Type) gave the labels their
source formatting back.

Paste without Formatting now drops the formats the graph keeps and sets the
pasted labels as a new graph's labels are set: 9 pt black, unscaled (a
rotated graph's labels keep their rotation), default paragraph attributes,
each keeping its alignment, and white on a dark pie wedge. Before, they took
12 pt and lost their alignment. The rest of the graph's art is pasted as it
was copied. A swatch-linked character fill the graph kept for its labels
stays behind with the other formats.

When the document's swatches give a pasted pie's wedges another color (a
swatch merged into the document's swatch of that name, or a swatch changed
in the document the pie was copied from), Paste and Paste without Formatting
set the legend labels in those wedges white on a dark wedge and black on a
light one, as a redraw does. Before, they kept the color chosen for the
copied wedge, which could leave white text on a light wedge. A label whose
characters are not all white or all black keeps its colors.
2026-11-14 22:09:08 -08:00
dotCooCoo ea3397b35d Merge main into feat/graph-type-dialog 2026-11-14 19:13:24 -08:00
dotCooCoo b12c78a731 Graphs: Outline Stroke and a graph left with only labels keep the plot in place
- Outline Stroke on a graph's strokes, including Object > Expand with
  Stroke on, adjusts the bounds the graph keeps, the same way
  Create Outlines on its labels does. Before, the stroke outlines
  changed the bounds of the art without type, and the next redraw
  stretched the plot by the width the outlines added.
- A graph that keeps `placedArt` and has no art other than type left
  is no longer measured on the bounds of all its art. A label edit on
  such a graph moved and stretched the plot at the next redraw; the
  plot now stays where it is.
- A redraw no longer measures a move or scale on art that has no width
  or no height now, such as a graph left with one axis line. Before,
  the plot collapsed to no width.
- A clipping group in a graph that holds type is measured on its clip
  when the clip does not depend on type, so moving art outside the clip
  does not change the bounds. Blends, envelopes and repeats are
  measured whole, as they are drawn.
- The doc crate's helper is named `graph_art_without_type` and sits
  with the file's other free functions.
- docs/mcp.md lists Outline Stroke and states that moving an outlined
  label, a swatch, an axis or a tick mark on its own can move or scale
  the plot, and that a graph left with only labels, or with art that
  has no width or height, does not follow a move.
- Tests: a scale of the graph made before outlining a label, a move of
  a graph opened from `.ai` after its label is restyled and moved,
  Outline Stroke after a move, a graph left with only its labels or
  with one line, and clipping groups holding type.
2026-11-14 13:45:46 -08:00
dotCooCoo 647a59db01 Merge main into feat/graph-type-dialog 2026-11-14 13:27:10 -08:00
dotCooCoo a134cf6f8d Graphs: Graph Type is a dialog of its own with type buttons and a page per axis
Object > Graph > Type... and a double click on a graph tool open Graph
Type (dialog `graphType`) instead of the generic parameter dialog. A
menu at the top shows Graph Options, Value Axis (Left Axis and Right
Axis with the value axis on both sides) or Category Axis. Graph Options
has a button per graph type, Value Axis with Separate Scales, the Style
checkboxes and the options of the type picked. The axis pages hold Tick
Values with Override Calculated Values, Tick Marks and Add Labels.

Override Calculated Values starts from the values the axis would be
calculated with for the options shown; the engine exposes them as
`graph_type_subject` and `graph_calculated_axes`. With series picked by
Group Selection, the type and value axis go to those series. OK changes
the graph and series the dialog opened on, and with nothing changed it
adds no step of history.

Docs: docs/mcp.md, docs/ui-parity.md and the tool.options text.
2026-11-14 10:27:41 -08:00
dotCooCoo d3789f2b0c Graphs: outlined labels and opened .ai graphs keep the plot in place at the next redraw
- A graph opened from a .ai file now saves `placedArt` too. Moving or
  restyling one of its labels before the first redraw no longer moves or
  stretches the plot.
- Type > Create Outlines on a graph's labels now adjusts the saved bounds,
  so the outlines do not read as a move at the next redraw. A move of
  the graph made before the outlining is still followed.
- A `placedArt` with no width or height falls back to the bounds of all
  of the art, as a graph saved without it does.
- `art_bounds` moves to the doc crate so the .ai reader can use it.
- docs/mcp.md describes `placedArt`, `placed` and when a redraw follows
  a move.
- Tests: a legend across the top, a legend after a right value axis and
  legend labels of several lines keep the plot in place through label
  size changes; moving a category label on its own; outlining labels
  before and after a move; a flat `placedArt`; a label moved in an
  opened .ai graph.
2026-11-14 08:47:03 -08:00
dotCooCoo 5c9717474f Graphs: restyling the labels leaves the plot where it is at the next redraw
The next redraw of a graph compared the bounds of all its generated art,
labels included, with the bounds stored at the last generation, and took
any difference for a move or scale of the graph. Label edits that change
the size of the type (a new size, an indent, a legend size) changed those
bounds without a move, so the plot shifted and stretched when the graph
was drawn again.

The spec now also stores the bounds of the art without type
(`placedArt`), and moves and scales are measured on those. Graphs saved
without them are measured on the whole bounds as before. Moving one
label with Direct Selection no longer moves or stretches the plot at the
next redraw.
2026-11-14 08:00:54 -08:00
dotCooCoo 23d371ca28 Graphs: graph.setType, setData and create refuse params of the wrong type
graph.setType read `axisMin: "10"` as a cleared bound, so the axis went
back to the calculated range, and it ignored a string or number given for
a true/false option, a string for a number and a number for a text option.
graph.setData and graph.create ignored a `csv` that is not a string and
`series`, `categories` or `rows` that are not lists, and read a string in
`rows` as a blank cell.

The three commands now refuse such a value with an error naming the key,
and leave the graph and the undo history as they were. A null is still
read as a key left out, and a null axis bound still goes back to the
calculated value. A negative tick count is refused too.
2026-11-11 16:41:13 -08:00
dotCooCoo 434c032f9e Symbols: Direct Selection sets the solid fill and stroke of one object in a dynamic instance
Squashed from #5962 onto main.
2026-11-09 00:26:11 +07:00
dotCooCoo 6be88a24b4 Fix #785: commands refuse an id that isn't an object id instead of using the selection
Commands whose `id` or `ids` the shared check in Session::execute does not
read still parsed them with id_param/ids_param, which drop anything that is
not a non-negative integer, and then acted on the selection or the current
layer. `object.blend.make {"ids": 3}` blended the selection,
`object.envelope.makeWithWarp {"ids": [2, "x"]}` warped the selection,
`graph.setData {"id": "2"}` changed the selected graph and
`layer.newSublayer {"parent": "2"}` added a sublayer to the current layer.

- cmd::named_ids and cmd::named_id read `ids`/`id` as targets does: a value
  that is not an object id, or an unresolved step reference, is an error.
- The symbol and brush, Live Paint, Shape Builder and Image Trace, blend,
  envelope and mesh, perspective, Liquify, Puppet Warp and graph helpers use
  them in place of the lenient readers.
- layer.clippingMask.toggle checks `id`, and layer.newSublayer checks
  `parent`, with checked_id before falling back to the highlighted row or the
  current layer.
2026-11-02 14:32:49 +07:00
Dylan M. Taylor 7043ef6f3d Extract geometry command helpers 2026-10-28 16:44:11 +00:00
aiongg f209d2aba2 refactor(engine): move cmd/graph.rs items to cmd/graph/{axis,columns,commands,data,designs,edit,generate,labels,markers,series}.rs 2026-10-26 22:01:25 +00:00