Commit Graph
588 Commits
Author SHA1 Message Date
bflatastic 46d804d9d5 Merge main into #8549
# Conflicts:
#	docs/roadmap.md
#	docs/target-app-parity.md
2026-11-19 01:06:53 +07:00
dotCooCoo 6cd6d22167 Merge main into fix/print-overprint-gradient-zero-stops 2026-11-18 07:33:08 -08:00
HassanKhan d9a404f91b PDF import: no stroke match over lines finished past the limit (#8543)
Answers the fourth CodeRabbit review on #8549.

When a fill pass finishes lines beyond MAX_PARKED, their unstroked
glyphs are recorded (bounded at 4096). The first stroke after that
which could have gone over one of them ends the stroke pass, so a TJ
over more than 65 lines that comes back to where it began stays a
filled object and a stroked one for each part, as documented. Any
other first stroke drops the record, so type after an overflowing TJ,
filled only or not, is matched as before.

MAX_HELD's doc now says that one operator filling the same run of more
than 4096 glyphs twice at the same places is matched as well as it can
be: the reader tells no operator's start.
2026-11-18 16:03:34 +05:00
HassanKhan f23eb05224 PDF import: keep stroke boundaries in the fallback and long passes (#8543)
Answers the third CodeRabbit review on #8549.

- stroke_last no longer restyles the glyph drawn last once a boundary
  (end_fills) closed it: a stroke after an ActualText span no longer
  strokes its replacement text. A glyph stroked again where it was just
  drawn still stays one object.
- Past MAX_HELD, the held strokes go over the last run of consecutive
  fills they match with room for all of them, not the first, so a long
  stroke pass no longer takes the same glyphs an earlier operator
  filled at the same place.
- Docs: the limit is 64 kept-back lines plus the open one, so a TJ over
  up to 65 lines stays filled and stroked.
2026-11-18 15:27:08 +05:00
HassanKhan 8796b773ec PDF import: a stroke pass matches only glyphs filled since its last boundary (#8543)
Answers the second CodeRabbit review on #8549.

- A stroke that goes over no filled glyph (stroked type of its own) and
  the start and end of an ActualText span now end the stroke pass
  (Builder::end_fills): the held strokes are matched, the parked lines
  finished and the open line's fills closed, so a later stroke can't go
  over an earlier fill and a later span keeps its own replacement text.
- ActualText fills are ordinary entries in the line's fill list, and
  span strokes are held and matched in replay order like any other, so
  an A/B/A TJ in a span strokes the replacement. The actual_fills map,
  stroke_parked and has_actual_fill are gone.
- Past MAX_HELD, the held strokes are matched to the first run of
  glyphs filled one right after another that they go over
  (Builder::replayed), with bounded work, instead of each to its first
  match, which could reach an earlier operator's fill.
- Docs state that past 64 lines in one operator each part stays a
  filled object and a stroked one.
2026-11-18 14:46:42 +05:00
HassanKhan b3fd70bc52 Merge remote-tracking branch 'upstream/main' into fix-8543-pdf-tj-fill-stroke
# Conflicts:
#	docs/file-format-parity.md
#	docs/roadmap.md
#	docs/target-app-parity.md
2026-11-18 13:12:26 +05:00
BFlat 6e1e6d579e Merge pull request #8542 from Hassan1305/feat-3644-pdf-lang
PDF export: write the document language as the catalog's /Lang
2026-11-18 15:10:05 +07:00
HassanKhan e318f6cc67 PDF import: match a stroke pass to the glyphs filled last, in fill order (#8543)
A TJ can draw the same glyph at the same place twice (its kerning goes
back), so a stroke can't be matched to a filled glyph as it arrives:
[(A) -3500 (B) 4834 (A)] TJ put the first A's stroke on the last A and
left the earlier parts unstroked. Strokes over filled glyphs are now
held until their stroke pass ends and then matched to the glyphs filled
last, in the order they were filled, so each copy is stroked where it
was filled, while a glyph filled and stroked where one filled before
stands still strokes only the newest. At most 4096 strokes are held.

Docs: ordinary text gives one filled and stroked object per part; in an
ActualText span it stays one replacement object on the first glyph's
line and style.
2026-11-18 13:02:58 +05:00
HassanKhan 851c7cb372 PDF import: a TJ whose kerning starts a new line comes in filled and stroked (#8543)
The reader fills every glyph of a text-showing operator, then strokes
them. When a TJ's kerning started a new line part way through, the
first line was finished before the stroke pass came back to it, so its
strokes found no filled glyph and came in as stroke-only type over
fill-only type.

A line a glyph doesn't fit is now parked while a stroke may still be
drawn over it, and a stroke-only glyph is matched against the open line
and then the parked lines, newest first. Parked lines are finished
oldest first before the open line, so drawing order is kept, and at
most 64 are parked.
2026-11-18 12:23:10 +05:00
BFlat ada472586e Merge pull request #8135 from dotCooCoo/fix/confined-exporter-and-placed-pdf-paths
MCP: confined exporter plug-ins and unreadable linked files keep paths outside the read roots
2026-11-18 13:53:34 +07:00
HassanKhan 0865242d2f PDF export: write the document language as the catalog's /Lang (#3644)
The writer passed no language to craft-pdf, so exported and printed
PDFs had no /Lang and accessibility checkers failed primary-language.
Writer::new now passes the BCP 47 tag of the Document Setup language
(new vectorcraft_doc::setup::language_tag, en-US by default) through
write::Writer::new_with_language, which writes the catalog's /Lang and
the XMP dc:language. A language with no tag writes none. /MarkInfo is
left for tagged PDF (#3643).
2026-11-18 11:46:27 +05:00
BFlat 79afbedc40 Merge pull request #7818 from dotCooCoo/fix/painted-type-used-as-a-clipping-path-loses-its
Clipping: a stroked clipping type no longer moves a clip group's fill, knockout or bounds
2026-11-18 13:00:23 +07:00
BFlat 827c80416c Merge pull request #8491 from dotCooCoo/perf/pdf-patch-offset-search
PDF export: Patch::apply finds where each object moved with a binary search
2026-11-18 12:59:26 +07:00
BFlat 10b2d14d1b Merge pull request #8342 from dotCooCoo/fix/issue-1954
Fix #1954: PDF/X CMYK in the output intent's profile is written as DeviceCMYK
2026-11-18 12:57:50 +07:00
BFlat 2d5f988caf Merge pull request #8375 from dotCooCoo/perf/pdf-type3-color-scan-once
PDF import: a Type 3 font's glyph procedures are checked for color once per document
2026-11-18 12:57:14 +07:00
dotCooCoo da061c6dc8 Merge main into fix/confined-exporter-and-placed-pdf-paths 2026-11-17 19:33:39 -08:00
dotCooCoo de501d73f2 PDF export: Patch::apply finds where each object moved with a binary search
Patch::apply wrote each cross-reference entry by walking every edit, so a
pass with many edits took time in proportion to objects times edits. It
now keeps the running total of the length changes and finds, by binary
search over the edits' ends, how far each object moved. For every edit
set that apply still accepts, the written file is byte for byte the same.

An offset that no longer fits the ten digits of a cross-reference entry
(ISO 32000-1, 7.5.4) is now refused with an error instead of writing an
eleven-digit entry that breaks the table. A change in length too large
for an isize is refused with an error instead of wrapping.
2026-11-17 16:24:59 -08:00
dotCooCoo 2bc8a8f9da Merge main into fix/print-near-black-missing-swatch 2026-11-17 13:26:00 -08:00
dotCooCoo 513b4aefaa Merge main into fix/issue-1954 2026-11-17 13:17:24 -08:00
dotCooCoo 3a64d72a64 Merge main into fix/painted-type-used-as-a-clipping-path-loses-its 2026-11-17 13:15:58 -08:00
BFlat 1f84febb08 Merge pull request #8169 from dotCooCoo/fix/symbol-lookup-index
Symbols: render and SVG/PDF export find each instance's symbol in one index
2026-11-18 03:23:44 +07:00
dotCooCoo 556e1552d8 Print: an overprinting gradient keeps the ink below where it puts none on PostScript plates
A PostScript plate has no blending modes, so an overprinting gradient
whose stops mix zero and nonzero ink of a plate was drawn whole on it,
and its paper-white part knocked out the ink below.

On a plate, the EPS writer now clips an overprinting gradient to where
it puts the plate's ink down. Linear, radial and diamond gradients leave
out the stretches between paper-white stops and the padding past a
paper-white end stop. Conic gradients leave out their paper-white
wedges, and freeform gradients leave out their paper-white cells (masked
at Level 3, clipped at Level 2). Fills, strokes (within, along and
across) and characters are covered, on process and spot plates. Where
the gradient puts ink down it is drawn as before, and a gradient with
ink everywhere is written unchanged.

On PostScript plates, a stop or point of an overprinting gradient whose
color counts as black, with up to half a percent of another ink, now
puts none of that other ink down, as a solid fill of that color already
does. PDF plates are unchanged.
2026-11-17 11:02:04 -08:00
dotCooCoo 76078f1991 PDF import: a DeviceCMYK image in a PDF/X file opens with the output intent's profile
A file whose catalog has a CMYK /GTS_PDFX output intent describes its
DeviceCMYK colors with that intent's profile. A DeviceCMYK image in
such a file now opens tagged with that profile, so a CMYK image that a
PDF/X export writes as DeviceCMYK opens with its profile again.

An image drawn where a /DefaultCMYK is in scope keeps no profile, since
the default replaces DeviceCMYK there. The scope is read per image from
the resources it is drawn with, and the image cache keeps the tagged and
untagged reads apart.
2026-11-17 10:44:47 -08:00
dotCooCoo 6007ea7b06 PDF import: a Type 3 font's glyph procedures are checked for color once per document
The scan that looks for d0 glyph procedures ran every time a page or a
form listed a Type 3 font in a font dictionary of its own, and its result
was dropped once the font had been noted. It now runs when the font is
first noted for the document. Each page still maps the font's glyphs,
and the note the import keeps for the font is unchanged.
2026-11-17 10:11:06 -08:00
dotCooCoo 2559231664 Print: a near black linked to a missing swatch keeps its faint ink off PostScript plates
On PostScript separations, up to half a percent of another ink in a color
that counts as 100% black is left off that ink's plate, so an overprinting
near black does not knock out the ink below it. A color linked to a swatch
the document does not have was left out of that rule, although it separates
from its own values like an unlinked color and Overprint Black marks it to
overprint. A 100% K with 0.4% cyan linked to such a name then stayed on the
cyan plate and knocked out the cyan under it.

A link to a missing swatch now counts as unlinked for this rule, on solid
fills, strokes, character fills and gradient stops. Spot swatches and
Registration are still excluded, and PDF plates still draw the faint ink.
2026-11-17 09:49:50 -08:00
dotCooCoo 12977ec543 Fix #1954: PDF/X CMYK in the output intent's profile is written as DeviceCMYK
A PDF/X-3 or PDF/X-4 export tagged every CMYK color with an ICC-based
space of the same profile that the output intent embeds. In PDF/X-3 and PDF/X-4, CMYK colors in the
profile of a CMYK output intent are now DeviceCMYK, and the profile is
written once, as the output intent's DestOutputProfile (ISO 32000-1,
14.11.5:
https://opensource.adobe.com/dc-acrobat-sdk-docs/pdfstandards/PDF32000_2008.pdf#page=641).

- With output.profiles none and a CMYK output intent, PDF/X-3 and PDF/X-4
  write every CMYK color as DeviceCMYK, unless colors are converted to a
  CMYK destination of another profile, which keeps its tag. Before, those
  standards tagged every color whatever profiles said.
- RGB and gray colors stay tagged, and so do CMYK colors and images in
  another profile.
- A CMYK image that carries the output intent's profile is DeviceCMYK,
  and so is every CMYK image when none makes CMYK colors DeviceCMYK. A
  CMYK JPEG then loses its ICC_PROFILE segments.
- Transparency groups blend in DeviceCMYK when CMYK colors are
  DeviceCMYK, also when the file has no ICC-based CMYK space.
- Files without a standard keep the tags that profiles asks for.
- The Save PDF dialog's note for PDF/X-3 and PDF/X-4 says that CMYK
  colors in the output intent's profile are written as DeviceCMYK.

Docs: docs/mcp.md, docs/target-app-parity.md and the document.exportPdf
params text.
2026-11-17 07:30:22 -08:00
dotCooCoo 4c47558d9a Merge main into fix/pdf-large-images-64-bit 2026-11-17 07:06:24 -08:00
BFlat c4147826a3 Merge pull request #7353 from dotCooCoo/fix/i18n-adjacent-placeholders
i18n: messages with values side by side can be translated
2026-11-17 21:32:55 +07:00
BFlat c4163015d9 Merge pull request #8311 from Hassan1305/fix-8300-pdf-fill-only-after-stroke
PDF import: a glyph filled only after one filled and stroked stays unstroked
2026-11-17 19:51:28 +07:00
BFlat 9908e10781 Merge pull request #8299 from dotCooCoo/fix/pdfx-xmp-metadata-date
PDF/X: PDF/X-4 files carry xmp:MetadataDate, equal to xmp:ModifyDate
2026-11-17 18:49:07 +07:00
HassanKhan 007180e2f3 PDF import: a glyph filled only after one filled and stroked stays unstroked (#8300)
Look::takes let a glyph filled only join a run whose glyphs were also
stroked, so after mode 2 text a mode 0 glyph took the run's stroke:
`2 Tr (B) Tj 0 Tr (C) Tj` came in as "BC" stroked throughout. A glyph
now joins only a run drawn alike (fill, stroke, overprints), so a glyph
filled only starts a run of its own and takes a stroke only when the
matched-stroke path (#8039) strokes it.

flush_stroke no longer strokes a whole run in place: a whole run goes
through the split and join code, so fill and stroke rendering glyph by
glyph still builds one stroked run.
2026-11-17 15:59:49 +05:00
BFlat 567485aa12 Merge pull request #8263 from dotCooCoo/feat/print-ink-spot-to-process
Print: Document Ink Options converts one chosen spot ink to process
2026-11-17 17:28:34 +07:00
dotCooCoo 30693f211b PDF/X: PDF/X-4 files carry xmp:MetadataDate, equal to xmp:ModifyDate
A PDF/X-4 export wrote xmp:ModifyDate and xmp:CreateDate in its XMP
metadata but no xmp:MetadataDate. The PDF/X-4 metadata edit now adds
xmp:MetadataDate next to xmp:ModifyDate, with the same value, and grows
the stream's /Length to match. When the export dates the file as modified
later, post::modification_date already rewrites every xmp:MetadataDate,
so the two dates stay equal.

PDF/X-1a, PDF/X-3, PDF/A and plain PDF exports are unchanged.
2026-11-16 23:41:52 -08:00
HassanKhan 971b13843b PDF import: translucent fill-and-stroke type stays two objects (#8015)
A fill and a stroke at the same opacity below 1 were joined into one
type object whose opacity then applies to both together, losing the
darker overlap the file composites. stroke_filled now takes a stroke
only when the fill and the stroke are opaque.

An upright glyph filled and stroked was kept as an outline for the
reshaped-outline fallback while upright glyphs filled only were not;
it is no longer kept either, so such a line can't come in as the
outlines of its stroked glyphs alone.

Docs: the #8015 entries say what is left (translucent type, and a TJ
that starts a new line part way through).
2026-11-17 11:59:20 +05:00
HassanKhan d3640da834 Merge remote-tracking branch 'upstream/main' into fix-8015-pdf-text-fill-stroke
# Conflicts:
#	docs/roadmap.md
#	docs/target-app-parity.md
2026-11-17 11:33:21 +05:00
dotCooCoo a4faf28146 Merge main into feat/print-ink-spot-to-process 2026-11-16 22:16:20 -08:00
dotCooCoo 5d57d83a7c PDF import: test opaque and masked images and the image pixel limit
- New tests: small opaque RGB and gray images are stored as RGB PNGs and an
  image with a soft mask as RGBA; an image with one row more than the
  pixel limit's square is left out with a warning.
- Gray images stay RGB on import, and a comment says why: a gray PNG
  would make the image one that a fill color colorizes.
- Doc comments and the docs line give the limits in GiB, the line moves
  next to the line about refused PDF parts, and it no longer gives a
  timing.
2026-11-16 21:02:47 -08:00
dotCooCoo 977024a4e9 PDF import: 64-bit desktop builds open images up to 4 GB and 2^30 pixels
A PDF, or a `.ai` read through its PDF part, was refused when one image
would decode to more than 1 GB, and the shared reader skipped images of
more than 2^28 pixels. On a 64-bit desktop build both limits are now 4 GB
and 2^30 pixels (`image_limits`), which `MAX_IMAGE_DECODED` and
`open_options()` share; 32-bit and web builds keep 1 GB and 2^28 pixels.
An image past the limit is refused with the same message.

An opaque image is encoded as an RGB PNG from its decoded samples instead
of building an alpha channel and an RGBA copy first.

Docs: docs/target-app-parity.md.

Part of #4366.
2026-11-16 20:16:38 -08:00
dotCooCoo 7ce855ce97 Merge main into feat/print-overprint-black 2026-11-16 19:56:05 -08:00
BFlat 685e77af6b Merge pull request #8236 from dotCooCoo/feat/print-custom-scale-link
Print: a link button keeps Custom Scale W and H equal
2026-11-17 09:49:36 +07:00
el-j a0edcf73c4 Merge remote-tracking branch 'upstream/main' into fix/pdfx-transparency-reduction-6861 2026-11-17 00:42:30 +01:00
dotCooCoo 79fdf113a5 Print: faint ink on paints marked to overprint is kept on PostScript plates
A PostScript plate drew an overprinting fill, stroke or character as
nothing when it put up to half a percent of that plate's ink down, so a
faint ink was lost from the plate. Now only a paint with no ink on the
plate is drawn as nothing, on PostScript and PDF plates alike. The one
exception is a color that counts as 100% black and is not linked to a
spot swatch or Registration: on a PostScript plate, up to half a percent
of another ink in it still counts as none, so a near black set to
overprint keeps the ink below it.
2026-11-16 15:38:42 -08:00
dotCooCoo 97a1a363b8 Merge main into feat/print-overprint-black 2026-11-16 15:09:39 -08:00
dotCooCoo 757b4f7b8f Print: Document Ink Options converts one chosen spot ink to process
Each spot ink in the Output section's Document Ink Options list now has
an icon before its name. Clicking it prints that ink as process: its art
separates onto the process plates and it gets no plate of its own, while
the other spot inks keep theirs. Clicking again keeps it as a spot ink.
While Convert All Spot Colors to Process is on, every spot ink converts
and the icons are dimmed; each ink keeps its own choice for when the
option is turned off. A converted ink's Print box, frequency and angle
are dimmed.

file.print and print.preview take convertToProcess on an output.inks
entry, and print.preview lists every document ink, converted ones
included, in documentInks.
2026-11-16 14:36:05 -08:00
dotCooCoo 7036cfb67c Merge main into feat/print-custom-scale-link 2026-11-16 12:16:47 -08:00
dotCooCoo bd624ac39f Merge feat/print-overprint-black into feat/print-custom-scale-link 2026-11-16 11:41:11 -08:00
dotCooCoo 54d33bd965 Merge main into fix/i18n-adjacent-placeholders 2026-11-16 10:35:25 -08:00
dotCooCoo 22fd959cdd Print: keep faint overprint ink on PDF plates and follow inline graphics
- A PDF plate no longer drops an overprinting paint whose ink on that
  plate is under half a percent: it draws with Darken. PostScript plates,
  which have no blending modes, still draw such a paint as nothing.
- With Overprint Black on, the art of a symbol that type shows as an
  inline graphic has its repainting instances placed too, so their own
  fill and stroke changes decide whether they overprint.
2026-11-16 10:12:41 -08:00
dotCooCoo 49240f08e1 Print: Overprint Black follows instance paints and drawn gradient colors
- A gradient's freeform points count only when its kind is Freeform, in
  the Overprint Black check and in the plate separator. A gradient of
  another kind is checked by its stops.
- Characters inside opacity mask art no longer draw with Darken on
  separations, as the mask art's fills and strokes already do not.
- With Overprint Black on, a symbol instance whose own fill or stroke
  changes or fill stain repaint its art, or whose symbol holds such an
  instance, prints as its placed art and is checked with the paints it
  prints with. Placement stays within the symbol object limit and the
  drawn depth limit, and skips hidden objects and template layers.
2026-11-16 09:54:37 -08:00
dotCooCoo b2a1e86fe9 Print: a link button keeps Custom Scale W and H equal
The Print dialog's General section (and the print preset editor) gets a
link button after Scale W and H. While it is on, typing either percentage
sets the other, and turning it on sets H to W. It is on for new settings,
dimmed with the fields unless Scaling is Custom or a tiling choice,
toggled with a click, Space or Enter, and screen readers hear its name
and on or off state. W and H now take 1 to 1000 %.

The link is saved as scale.linked with the other print settings, in the
document and in print presets. A scale saved without it reads as unlinked,
so earlier settings print as they did. print.setup, print.preview,
file.print and print.presets.save apply the same rules: one percentage
sets the other while linked, a different width and height without a
linked key turn the link off, and with linked: true (or linked: null over
a linked scale) they are an error.
2026-11-16 09:27:38 -08:00