Commit Graph
7 Commits
Author SHA1 Message Date
Don Omondi 4333c58033 Opening a slow file shows a progress window with Cancel and Continue in Background (#5930)
A file that takes longer than 0.4 s to open shows a modal progress window
with its name, a moving bar (reading reports no steps), how many more
files wait, Cancel (file.cancelOpen: the file doesn't open) and Continue
in Background (file.openInBackground). It never opens over another dialog
or progress window.
2026-11-07 00:17:17 +07:00
dotCooCoo 21be9e6b6e Tests: the opening queue tests wait on the worker's signal instead of the clock
The opening tests waited 400 or 500 ms of wall-clock time for files read off
the UI thread, and up to 30 s in loops that polled until the queue emptied.
Under load a read could take longer, and
a_file_that_opens_and_asks_holds_back_the_next_one_ready failed.

wait_read now blocks on each pending file's own result channel and keeps the
result for poll, and open_ready waits and then polls once. The background save
in long_operation_busy_while_a_file_opens_or_a_background_save_runs waits with
background::wait_all, and its job waits on the release channel without a
timeout. Shipped code is unchanged.
2026-11-04 21:37:51 +07:00
ruchirguitarandClaude Opus 5.5 079f5389a6 opening::poll stops once a file it opens asks a question
Of two files read off the UI thread and ready in the same frame, the
first could open and ask about its links or fonts, and the second then
became the active document under that dialog. poll now checks
may_switch after each file it opens too, and leaves the rest for a
later frame.

The queued-reopen test also checks that a later queued activation
stays queued.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-04 08:13:04 +07:00
ruchirguitarandClaude Opus 5.5 e2c8c503c1 opening::poll stops once a queued reopen asks a question
A document asked for again while a dialog was open, and closed
meanwhile, opens again when the dialog closes and may ask about its
links or fonts. poll went on to finish the files read meanwhile, and
each became the active document under that dialog. It now checks
may_switch after each queued activation and leaves the rest, and the
files ready to open, for a later frame.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-04 08:13:04 +07:00
ruchirguitar 5bb682c61e Fix #5369: every way of opening a file focuses its open tab
Squashed from #5420 onto main.
2026-11-03 23:58:01 +07:00
Dylan M. Taylor 460a4f7a91 fix(ui): carry automation scope through opening, file picks and the render worker 2026-11-03 23:29:47 +07:00
aiongg a899981893 refactor(ui-egui): move opening.rs tests to opening/tests.rs 2026-10-26 18:18:18 +00:00