The whole-outline check tests points along every edge, so outlines with
the same corners joined another way do not match; past a work limit it
rejects. Face keys another Retype kept meanwhile are reused and charged
once. The fonts parameter test uses outlines that would match. The parity
note states the search limits.
With Use Preview Bounds on, W and H measure a stroked path from the
outside of its stroke, while the Dimension tool's Linear points only
snapped to the path's anchors, on the stroke's centerline. A dimension
between the corners of a 12 x 6 mm rectangle with a 0.4 mm stroke then
read 11.6 x 5.6 mm.
- With Use Preview Bounds on, a Linear click within 8 pixels of a corner
of the preview bounds of a path or compound path (strokes and effects
included) lands on that corner instead of on that object's anchors,
whatever the snapping options. An anchor of other art nearer the
pointer than the corner takes the point, and a corner that is also an
anchor takes the anchor.
- The point is held against the anchors of the path whose bounds reach
that corner, also when the corner lies far from the path or on another
path's segment. It moves with the path; a later change to the stroke
weight does not move it.
- A press on such a corner picks it when the pointer moves a few pixels
before the release, as on an anchor.
- Hovering by such a corner shows the anchor ring. The ring now also
shows when the pointer is exactly on the point a pick lands on, which
it did not for the end of a dimension's line.
Docs: docs/dimensions.md, docs/target-app-parity.md.
With no place to go on from, the dialog left out edit.findNext's from, so the search went on after the selected type object and passed over its matches: after Find selected a type object, changing the Find text skipped the matches in it. edit.findNext now starts at the first match for a null from, and the dialog sends one.
Answers the second CodeRabbit review on #8549.
- A stroke that goes over no filled glyph (stroked type of its own) and
the start and end of an ActualText span now end the stroke pass
(Builder::end_fills): the held strokes are matched, the parked lines
finished and the open line's fills closed, so a later stroke can't go
over an earlier fill and a later span keeps its own replacement text.
- ActualText fills are ordinary entries in the line's fill list, and
span strokes are held and matched in replay order like any other, so
an A/B/A TJ in a span strokes the replacement. The actual_fills map,
stroke_parked and has_actual_fill are gone.
- Past MAX_HELD, the held strokes are matched to the first run of
glyphs filled one right after another that they go over
(Builder::replayed), with bounded work, instead of each to its first
match, which could reach an earlier operator's fill.
- Docs state that past 64 lines in one operator each part stays a
filled object and a stroked one.
The level a new dimension line lands on now comes from the dimension
lines in the document before the dimension's first preview, so its own
preview is never a level. A dimension drawn earlier between the same two
points now acts as a level as well; before, every dimension of those
points was skipped.
- Of two lines on one level, a line the pointer lies across wins over a
line whose end is nearer the pointer.
- A dropped press while placing removes the level guide with the
preview.
- The reach uses the Smart Guides snapping tolerance helper.
- docs/dimensions.md says the rule applies to a dimension anywhere in
the document.
- The tests are split by behavior, with new tests for the same points,
pointer moves in small steps, the guide after a dropped press and
with Alignment Guides off, and the tie-break.
The preview segment from an anchor with an outgoing handle was drawn as a
quadratic curve through that handle, while a click appends a corner
anchor, which makes the cubic curve that leaves along the handle and
arrives without one. The segment changed shape when the anchor went
down. The rubber band now draws that cubic curve.
Part of #8296.
Contours are read from a starting corner that does not depend on where
the path starts (every tied corner tried), with straight edges split in
two, degenerate curves and empty segments read as one line. A sampled
fit only shortlists a glyph: its whole outline, turned onto the shape,
must lie on it. Face keys are compact hashes, kept per process within a
budget; kept keys stay when new ones do not fit, and go when fonts are
added or rescanned.
A compound path with a locked or hidden part stays whole. A group with
an Attributes note, or any other extra, keeps its type inside. Faces are
counted once against the cap, and no font is read when every shape stays
an outline.
The New Symbol button, the panel menu's New Symbol... and Redefine
Symbol read Shift, and the Delete Symbol button and a symbol dropped on
it read Alt, from the modifiers held at the end of the frame. A key let
go after the primary button in the same frame dropped Shift, so OK made
the art an instance, or dropped Alt, so an unused symbol asked first.
They now read the modifiers that the primary button's release carries,
as art dropped on the panel already does, and fall back to the current
modifiers when no release happened in the frame (keyboard activation).
The drag test helper sends its release with the modifiers held.
Resize Using Percentages now checks the new size as it is before
converting it. A width or height the command refuses (outside 0.1 to
1,000,000) stays, with the mode unchanged and the reason shown, even
when the converted value would be in range, for example 0.05 pt of a
10 pt wide image, which is 0.5%.
Show Slice Numbers now has a sentence. The test goes to the first
category other than Units that still has a row without one (Slices when
none is left) and points at that row.
recolor.apply with `group` rewrote the group by place: the new colors went
to its swatches in order, so a gradient, pattern or None swatch in the group
took a color or was removed, at OK and in the live preview.
The group's colors, from the rows or from `groupColors`, now go to its color
swatches in order, and every other swatch keeps its place and its paint.
`groupColors` counts the color swatches only, as the dialog already does
when it lists a group's colors. swatch.editGroup is unchanged.
`transform` read `reflect` with `as_str`, `copy` with `as_bool` and
passed `origin` through unchecked. A `reflect` of `42` or `true`
skipped the reflect step and reported success for the steps before it,
a `copy` of `"yes"` transformed the original instead of a copy, and an
`origin` that was not two numbers fell back to the selection centre.
The handler now checks all three before it selects `ids` or runs a
step, and returns an error that names the argument. A null value of
any of the three is left out. The tool description and the
`transform` row in docs/mcp.md say so.
Fixes#6448
Switching away from the Selection tool or a shape tool during a drag of
a corner, pie or side widget left the drag's interaction open with its
preview in the document. Both tools now cancel the drag on deactivate,
as Escape does, as the Selection tool already did for a blend widget.
Confirming the dialog with a number, null or list as its action used to run Find, which moved the match found, the selection and the last search. It is now an error, shown as the note, like a field of the wrong type.
A TJ can draw the same glyph at the same place twice (its kerning goes
back), so a stroke can't be matched to a filled glyph as it arrives:
[(A) -3500 (B) 4834 (A)] TJ put the first A's stroke on the last A and
left the earlier parts unstroked. Strokes over filled glyphs are now
held until their stroke pass ends and then matched to the glyphs filled
last, in the order they were filled, so each copy is stroked where it
was filled, while a glyph filled and stroked where one filled before
stands still strokes only the newest. At most 4096 strokes are held.
Docs: ordinary text gives one filled and stroked object per part; in an
ActualText span it stays one replacement object on the first glyph's
line and style.
`(started + SLOW_SECS) - started` rounds below SLOW_SECS for about 1 in 40 start
times, so a_slow_first_read_says_so_until_its_listing_comes failed at random
on main.
The reader fills every glyph of a text-showing operator, then strokes
them. When a TJ's kerning started a new line part way through, the
first line was finished before the stroke pass came back to it, so its
strokes found no filled glyph and came in as stroke-only type over
fill-only type.
A line a glyph doesn't fit is now parked while a stroke may still be
drawn over it, and a stroke-only glyph is matched against the open line
and then the parked lines, newest first. Parked lines are finished
oldest first before the open line, so drawing order is kept, and at
most 64 are parked.