//! Shortcuts the browser would also act on. Many of the app's Cmd and Ctrl chords are the //! browser's too: the View menu's `Cmd+=`, `Cmd+-` and `Cmd+0` zoom the page, Edit's `Cmd+Z` and //! `Cmd+Shift+Z` undo and redo in the browser (in Safari, Undo Close Tab when the page has nothing //! to undo), `Cmd+[` and `Cmd+]` go back and forward, `Cmd+F` finds. eframe lets them through, so //! the browser acted on them as well. For a press the keymap in effect binds (the user's shortcuts //! included), the page's default action is cancelled; the key still reaches egui, which runs the //! command (or a text field its own undo). A few chords never reach a page at all (Safari's //! `Cmd+L`, Chrome's `Cmd+T`, `Cmd+W` and `Cmd+N`): the browser keeps those. use egui::{Key, Modifiers}; /// Whether the browser's own action for a key press is cancelled. `key` is the event's `key` (the /// character typed), `code` its `code` (the key's position), `modifiers` as eframe reports them, /// and `alt_graph` whether AltGr is held. /// /// Only Cmd and Ctrl presses: a plain or Shift press types (cancelling it would drop the /// character it types), and so does AltGr, which Windows reports as Ctrl and Alt held. Cut, Copy /// and Paste (with any other modifiers) are left to the browser, whose clipboard events carry /// their text, and Reload too, as eframe leaves them. pub(crate) fn kept_from_browser(key: &str, code: &str, modifiers: Modifiers, alt_graph: bool) -> bool { if !(modifiers.ctrl || modifiers.mac_cmd) || alt_graph { return false; } if matches!(Key::from_name(key).or(Key::from_name(code)), Some(Key::C | Key::V | Key::X | Key::R)) { return false; } vectorcraft_ui_egui::shortcuts::runs_a_shortcut(key, code, modifiers) } /// Leave a paste to its Paste event (#5555). eframe's web runner reports a Cmd+V press both as the /// key press and, with the clipboard's text, as a Paste event (the browser's `paste` comes in the /// same task as the `keydown`, so both are in one frame's input); the app pastes on each, as egui's /// window integration sends only the Paste. With a Paste in `events`, the paste key's press is /// dropped; its release stays, so the paste chord is still followed (`PasteChord`). A Cmd+V without /// a Paste (a clipboard with no text) keeps its press. pub(crate) fn drop_paste_key_presses(events: &mut Vec) { if !events.iter().any(|e| matches!(e, egui::Event::Paste(_))) { return; } events.retain(|e| !matches!(e, egui::Event::Key { key: Key::V, pressed: true, modifiers, .. } if modifiers.command)); } /// The modifiers of a key event as eframe reports them to egui (its `modifiers_from_kb_event`). #[cfg(target_arch = "wasm32")] fn modifiers(e: &web_sys::KeyboardEvent) -> Modifiers { Modifiers { alt: e.alt_key(), ctrl: e.ctrl_key(), shift: e.shift_key(), mac_cmd: e.meta_key(), command: e.ctrl_key() || e.meta_key() } } /// Whether the app has the keyboard for this event: it went to the canvas, or to the text input /// eframe places right after it while a text field has the focus. Elsewhere (the page's body, a /// file input) eframe ignores the key, so the browser keeps it. #[cfg(target_arch = "wasm32")] fn to_the_app(e: &web_sys::KeyboardEvent) -> bool { use wasm_bindgen::JsCast as _; let Some(target) = e.target() else { return false }; if target.has_type::() { return true; } target .dyn_ref::() .and_then(|input| input.previous_element_sibling()) .is_some_and(|before| before.has_type::()) } /// Cancel the page's default action for [`kept_from_browser`] presses, before eframe's listener /// sees the event (it doesn't stop it). #[cfg(target_arch = "wasm32")] pub(crate) fn keep_app_keys() { use wasm_bindgen::JsCast as _; let Some(window) = web_sys::window() else { return }; let on_key = wasm_bindgen::closure::Closure::::new(|e: web_sys::KeyboardEvent| { // An IME's keys are its own until it commits. if e.is_composing() || !to_the_app(&e) { return; } if kept_from_browser(&e.key(), &e.code(), modifiers(&e), e.get_modifier_state("AltGraph")) { e.prevent_default(); } }); if let Err(e) = window.add_event_listener_with_callback_and_bool("keydown", on_key.as_ref().unchecked_ref(), true) { log::error!("couldn't follow keydown events: {e:?}"); } // The listener lives as long as the page. on_key.forget(); } #[cfg(test)] mod tests { use super::*; /// Cmd as egui reports it on this platform: the Command key on macOS, Ctrl elsewhere. fn cmd() -> Modifiers { if cfg!(target_os = "macos") { Modifiers::MAC_CMD | Modifiers::COMMAND } else { Modifiers::CTRL | Modifiers::COMMAND } } #[test] fn the_keymaps_chords_are_kept_from_the_browser() { for (key, code, mods) in [ ("=", "Equal", cmd()), ("-", "Minus", cmd()), ("0", "Digit0", cmd()), ("z", "KeyZ", cmd()), ("Z", "KeyZ", cmd() | Modifiers::SHIFT), ("[", "BracketLeft", cmd()), ] { assert!(kept_from_browser(key, code, mods, false), "{key} ({code}) {mods:?}"); } } #[test] fn typing_the_clipboard_and_reload_stay_with_the_browser() { for (key, code, mods) in [ // Typing: plain and Shift presses. ("z", "KeyZ", Modifiers::NONE), ("Z", "KeyZ", Modifiers::SHIFT), ("=", "Equal", Modifiers::NONE), // The clipboard's events carry the text; Paste and Match Style is Shift+Cmd+V. ("c", "KeyC", cmd()), ("x", "KeyX", cmd()), ("v", "KeyV", cmd()), ("V", "KeyV", cmd() | Modifiers::SHIFT), ("r", "KeyR", cmd()), ] { assert!(!kept_from_browser(key, code, mods, false), "{key} ({code}) {mods:?}"); } // AltGr+Z types ż on a Polish layout, reported as Ctrl and Alt held on Windows. let ctrl_alt = Modifiers::CTRL | Modifiers::COMMAND | Modifiers::ALT; assert!(!kept_from_browser("ż", "KeyZ", ctrl_alt, true)); assert!(!kept_from_browser("}", "Digit0", ctrl_alt, true)); } fn key(key: Key, pressed: bool, modifiers: Modifiers) -> egui::Event { egui::Event::Key { key, physical_key: None, pressed, repeat: false, modifiers } } #[test] fn a_paste_chord_pastes_once() { // Cmd+V and Cmd+Shift+V (Paste in Place): the press goes, the Paste and the release stay. for mods in [cmd(), cmd() | Modifiers::SHIFT] { let mut events = vec![key(Key::V, true, mods), egui::Event::Paste("".into()), key(Key::V, false, mods)]; drop_paste_key_presses(&mut events); assert_eq!(events, vec![egui::Event::Paste("".into()), key(Key::V, false, mods)], "{mods:?}"); } } #[test] fn keys_without_a_paste_stay() { // No text on the clipboard: no Paste event, so the press is the paste chord's only report. let mut events = vec![key(Key::V, true, cmd()), key(Key::V, false, cmd())]; drop_paste_key_presses(&mut events); assert_eq!(events.len(), 2); // Typing V, and other chords, beside a paste. let typed = vec![key(Key::V, true, Modifiers::NONE), key(Key::C, true, cmd()), egui::Event::Paste("a".into())]; let mut events = typed.clone(); drop_paste_key_presses(&mut events); assert_eq!(events, typed); } }