mirror of
https://github.com/storytold/vectorcraft.git
synced 2026-11-13 23:35:10 +00:00
Ahmed Gomaa
f0e50437c2
A plain Save that the location refuses (read-only filesystem or permission denied) now opens Save As with the name filled in, instead of ending in an error dialog. The refusal travels as a typed engine error (READ_ONLY_LOCATION), so the control protocol and MCP still return an error and never open a panel. Recovery failures, explicit destinations, a busy picker and Close/Quit keep their existing flow. Closes #6146
54 lines
2.1 KiB
Rust
54 lines
2.1 KiB
Rust
use super::{NodeId, cancel};
|
|
|
|
/// The text of [`EngineError::Busy`], which ends every error a frontend reports for it.
|
|
pub const SCRIPT_BUSY: &str = "a script is running: stop it or wait for it to finish";
|
|
|
|
/// Stable prefix for a save refused by the filesystem: choose another destination.
|
|
pub const READ_ONLY_LOCATION: &str = "READ_ONLY_LOCATION";
|
|
|
|
#[derive(Debug, thiserror::Error)]
|
|
pub enum EngineError {
|
|
#[error("unknown command `{0}`")]
|
|
UnknownCommand(String),
|
|
/// An unknown command id, with the command id it most likely misspells.
|
|
#[error("unknown command `{0}`; did you mean `{1}`?")]
|
|
UnknownCommandNear(String, String),
|
|
#[error("command `{0}` is not available right now: {1}")]
|
|
Disabled(String, String),
|
|
#[error("invalid parameters for `{cmd}`: {msg}")]
|
|
BadParams { cmd: String, msg: String },
|
|
#[error("no active document")]
|
|
NoDocument,
|
|
#[error("no such object {0}")]
|
|
NoNode(NodeId),
|
|
#[error("{0}")]
|
|
Other(String),
|
|
/// The save's terminal filesystem error refuses writes here. The reason keeps the path and
|
|
/// system message. This never means an automation-root refusal or a recovery-copy failure.
|
|
#[error("{code}: {0}", code = READ_ONLY_LOCATION)]
|
|
ReadOnlyLocation(String),
|
|
/// The caller asked for the command to stop ([`cancel`]). It changed nothing.
|
|
#[error("cancelled; nothing was changed")]
|
|
Cancelled,
|
|
/// A running script holds the documents until it ends. Nothing was changed.
|
|
#[error("{}", SCRIPT_BUSY)]
|
|
Busy,
|
|
/// A bug: the command panicked. The document was rolled back to its state before the command.
|
|
#[error("internal error in `{cmd}`: {msg} (the document was left as it was before; please report this bug)")]
|
|
Internal { cmd: String, msg: String },
|
|
}
|
|
|
|
impl From<cancel::Cancelled> for EngineError {
|
|
fn from(_: cancel::Cancelled) -> Self {
|
|
EngineError::Cancelled
|
|
}
|
|
}
|
|
|
|
impl From<vectorcraft_doc::DocError> for EngineError {
|
|
fn from(e: vectorcraft_doc::DocError) -> Self {
|
|
EngineError::Other(e.to_string())
|
|
}
|
|
}
|
|
|
|
pub type Result<T> = std::result::Result<T, EngineError>;
|