pauljd/craft-libs
1
0
Fork 0
mirror of https://github.com/storytold/craft-libs.git synced 2026-11-12 01:54:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

craft-media: roundtrip test builds on 32-bit targets (#578)

Browse Source 
`(writes * MIB) as u64` multiplies in `usize` before widening: 4,097 MiB
overflows a 32-bit `usize`, so `cargo test --target i686-pc-windows-msvc`
failed to compile ("this arithmetic operation will overflow"). Widen first.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
John
2026-11-11 07:11:07 -05:00
committed by GitHub
co-authored by Claude Opus 5.5
parent 73702b326a
commit 4970d4cfae
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/media/tests/roundtrip.rs
+1 -1
View File
@@ -309,7 +309,7 @@ fn pcm_past_4_gib_reads_back_whole() {
let out = w.finish().unwrap();
let f = open(&out).unwrap();
let s = &f.tracks[0].samples;
let bytes = (writes * MIB) as u64;
let bytes = writes as u64 * MIB as u64;
assert_eq!(s.iter().map(|s| u64::from(s.size)).sum::<u64>(), bytes);
assert_eq!(s.iter().map(|s| u64::from(s.duration)).sum::<u64>(), bytes / 4);
assert!(s.iter().all(|s| s.size <= 1 << 20));