address review: skip fchown when the stage already has the replaced file's group

2026-11-07 12:13:20 +00:00 · 2026-11-03 19:57:03 +00:00
parent 1dfda4b45a
commit f0b46869f9
1 changed files with 3 additions and 0 deletions
@@ -387,8 +387,11 @@ fn stage(
                            }
                            // The group bits belong to the replaced file's group, which a new
                            // inode need not be in (setgid directory, another primary group).
+                            // A stage already in that group needs no fchown, which some
+                            // filesystems reject even as a no-op.
                            if let Some(replaced) = replaced
                                && p.mode() & 0o070 != 0
+                                && std::os::unix::fs::MetadataExt::gid(&file.metadata()?) != std::os::unix::fs::MetadataExt::gid(replaced)
                                && std::os::unix::fs::fchown(&file, None, Some(std::os::unix::fs::MetadataExt::gid(replaced))).is_err()
                            {
                                let mut p = p;