Commit Graph
2359 Commits
Author SHA1 Message Date
aiongg 46b0240050 Host tests find a list row's pointer-only parts from the row's node
craft-ui testing part_rect_of_node reads a part's rect from the shape record by the owner's
AccessKit node, the lookup Fixture::part_rect makes by id. ThumbTarget::part and TrailingPart::part
name a row's thumbnail and trailing parts; the row declares its parts through them.
LayerInfo::thumb maps a layer part to the thumbnail that shows it, over the order the panel
reads thumbnail clicks by, and craft-layers testing thumb_rect and fx_badge_rect give a host test
the rect of a layer row's thumbnail or fx badge. The drag, menu and frame trials find thumbnails
and the badge this way.
2026-11-12 14:52:31 +00:00
aiongg 09df631cbc feature-root: craft-timeline's interchange formats (xml, otio) are in the one shared build 2026-11-12 14:52:25 +00:00
aiongg 76883fa5df Compare: the rule between the two panes
ComparePair::divider gives the segment in the middle of the gap between the panes, as LightCraft's Compare view draws
a line there; the pair story shows a vertical Divider on it.
2026-11-12 14:52:13 +00:00
aiongg 5daf05ff49 Keyboard Shortcuts: a row's shortcuts show as keycaps
Each shortcut of a row is a chip that shows its chord through Kbd's keycap form, the framework's one look for a
chord, and asks to record over it on a click, Enter or Space. The chips no longer take a full-height button.
2026-11-12 14:52:13 +00:00
aiongg 004ab39f41 CellGrid: cell buttons are small boxes with a control's corners; story rows a text line high
The filter button and the error tag share one cell button look (table ui/cell_button.rs): a raised box with
shape.radius.control corners and a size.icon.sm glyph, so a filter button fits inside its header cell instead of
a pill that covers the heading. The sheet stories' rows are a line of body text high, as a spreadsheet's default
row, under the 20 pt headers.
2026-11-12 14:52:13 +00:00
aiongg 0115deeb45 PointPicker: the well takes the room its row leaves; the story shows the X and Y fields beside it
The well fills its row's width after its siblings (Component::fills) instead of measuring the whole room, so fields
beside it stay in view (ParamRows' point row showed them past the edge). The cross is size.icon.md long. The Default
story shows the picker with its X and Y fields, as a dialog's point row does.
2026-11-12 14:52:13 +00:00
aiongg c3b581de4d Notice cards: the old toast's spacing
A card's padding is space.pad.regular; the icon, the first line of the text and the dismiss button share one centre
line; a card's rows (head, bullet lines, the "and n more" line, actions) are space.gap.stack apart, an inline
notice's lines stay together; and the actions start at the content's start edge under the icon, as the bullet lines
do.
2026-11-12 14:52:13 +00:00
aiongg f3d0a4e2a1 Lists keep the host's selection when the lead's row leaves; a new Layers filter deselects what it hides
follow_lead_source moves the lead to the row now in its place and no longer
selects that row: a row that was deleted or filtered out is not replaced by its
neighbour. LayerFilter::deselect_hidden is the one rule for a newly applied
filter (Photoshop #10879); the panel reports it as a Select on its filter bar's
edit, and an app that sets the filter itself calls it there.
2026-11-12 14:52:13 +00:00
aiongg b1fffa6371 craft-aaf: take Tick, FrameRate and TICKS_PER_SECOND from craft-timeline's crate root
Frame rates live in craft-timeline's rates module, so AAF and OMF import the time types from the crate root, where craft-timeline re-exports them.
2026-11-12 14:50:08 +00:00
aiongg 7110f88fd8 craft-captions: read and write timecode through craft-timeline's timecode module
SCC, MCC and EBU STL labels go through TimecodeFields with timecode::{frames_to_fields, fields_to_frames}. FrameRate, Tick and TICKS_PER_SECOND stay re-exported at the crate root; the re-export of craft-timeline's time module goes, since frame rates and timecode live in rates and timecode.
2026-11-12 14:50:08 +00:00
aiongg c2dba2a1d5 craft-timeline: declare the interchange formats on the framework's time model
ale, build, edl, fx, path, rate and report are modules of the crate again, fcp7 and fcpxml behind the xml feature, otio behind otio, as storytold had them. The format list, the import and export options and the interchange error sit in interchange beside the neutral document and are re-exported at the crate root. The formats read and write time through rates, time and timecode: ALE rows through parse_time, an EDL timecode holds TimecodeFields, FCPXML format names use FrameRate's Display. Serde is always on, so the interchange types derive it unconditionally; the formats keep storytold's no-panic lints.

storytold's interchange tests run as trials of the lib's one test executable: the modules' own tests always, tests/it/{fcp7,fcpxml,otio} with the xml and otio features.
2026-11-12 14:50:08 +00:00
aiongg db654cfdd7 craft-timeline: frame-count timecode parsing, feet + frames, display ids, FrameRate::from_f64_within and Display
parse_frames reads typed timecode, frames and feet + frames as a frame count (drop-frame, relative to a current frame), and parse_time uses it for those displays. format_timecode_frames and format_feet_frames are public; TimeDisplay has id, from_id and frames_per_foot. FrameRate::from_f64_within snaps a container's rate to a standard one within a tolerance, and FrameRate's Display writes the rate as documents and diagnostics do (24, 23.976), without a unit.

storytold's time tests (src/time/tests.rs) run as trials on this API.
2026-11-12 14:42:05 +00:00
aiongg a3434176e4 Dialog bodies: the content sits directly in the dialog body, which is already a stack, so fill-width children take the dialog's width; the Tabs dialog's Position column is as wide as its field and Alignment and Leader share the rest 2026-11-12 14:32:57 +00:00
aiongg 4109fb5973 craft facade: sort the behavior re-export 2026-11-12 14:32:52 +00:00
aiongg 101fde87fc craft facade: re-export craft-behavior as craft::behavior
The layers panel's events carry craft-behavior types (EditEvent, SelectionChange, Mixed, IconId); an app on the facade needs them by name to apply the events.
2026-11-12 14:32:52 +00:00
aiongg eef6832088 contract-api and components-index: regenerated (Component::RULE, shrink order) 2026-11-12 14:32:52 +00:00
aiongg 47c2f5e642 A layer opened from a bar is not the bar's line
A layer's content starts from its opener's scope with the layer-local fields fresh (Scoped::start_layer), in the
measure its container makes under the opener's env as in the run under the layer's, and a layer or pane starts
without InBar. A select in a popover opened from a bar measured as a bar member and fitted its content. The bar
trials that narrowed a select at a fixed width take a narrower bar, since a select in a bar is now its fitted width,
and the rule trials use icon buttons, which keep their width.
2026-11-12 14:32:52 +00:00
aiongg 02f0330866 Bar member rows keep the bar's spacing; RulerBar tenths; Pin Depth buttons side by side
RulerBar, CropBar and WarpFields show the bar's members in rows of their own, which spaced them at gap.row; they
take gap.item, as the bar and ConstraintFields do. RulerBar writes lengths at the ruler unit's readout digits
(tenths of a pixel, as PhotoCraft), not two decimals. PinWarpBar's two Pin Depth buttons stacked in their field and
made the bar's line two controls high, so the end icons sat below the Mode row; they sit in a row.
2026-11-12 14:32:52 +00:00
aiongg 6225657f48 A rule in a bar shows only with the member after it
A component declares itself a rule with Component::RULE; Divider does. In a bar's line the pass holds the shapes a
rule painted until the next member decides whether the view shows it: a member shown keeps them, a member the bar
hides takes them back, and so does the end of the line for a rule with nothing after it. A settling region's record
is taken after that, so a replay shows the line as the run did. A divider was left behind at the bar's end when the
members after it were hidden.
2026-11-12 14:32:52 +00:00
aiongg a5c5d1e497 A select in a bar fits its widest entry, up to a field length
A content-sized select, and any select in a bar, fits its faces: as wide as its widest entry and the chevron need,
with no field floor, and at most a field length, where a longer entry elides. Options bars sized every select to the
field length or kept a 96 pt floor, so the whole-or-nothing rule hid later members the bar had room for. The bar
selects that asked for content sizing themselves no longer need to; LayerFilterBar's type select, in a row of its own,
asks for it.
2026-11-12 14:32:52 +00:00
aiongg d10e5afd19 LayerStyleDialog: the angle field shows its degree unit 2026-11-12 14:32:52 +00:00
aiongg fbab72ae31 TableProperties and the NumberField story use form rows
Both were plain field rows in the old gallery and in DesignCraft's table
panel: number fields keep their number length instead of filling an
inspector column.
2026-11-12 14:32:52 +00:00
aiongg b47165073c A short row gives blank room before content
A row's shrink step first takes its shortfall from the room its leaves hold
beyond their content (a field's or select's length past its text), down to
the width at which each shows its content whole. Only then does content give
way: units made to be cut first, then the rest. A row's children measured in
no room take what they would alone in the row, so a text after a field
reports its line, not what the field left it.

FindBar's count stays on one line beside the search field.
2026-11-12 14:32:51 +00:00
aiongg 9471d93e9b contract-api and components-index: regenerated (filter types, band fill, list command form, SwatchPair glyphs) 2026-11-12 14:32:51 +00:00
aiongg 61f24999ee SwatchPair: the front well's gap takes the surface the pair sits on 2026-11-12 14:32:51 +00:00
aiongg fe872f5fed SwatchPair: a ring well's band has the outline and a line that stands out from its colour on both sides, as the old ring did 2026-11-12 14:32:51 +00:00
aiongg 453257d147 SwatchPair: the wells follow the button row as closely as the old ones did 2026-11-12 14:32:51 +00:00
aiongg 360f57719d SwatchPair: a well's outline sits just outside it, as the old wells' did, inside the pair's size 2026-11-12 14:32:51 +00:00
aiongg 7067a845e5 SwatchPair draws the old look: wells with a light inner line and no selection ring, the front one in a rounded gap; its own defaults and swap glyphs at the two ends of the pair 2026-11-12 14:32:51 +00:00
aiongg 7a02997ac1 CommandPalette: the lead row is the command highlight
ListRow's command flag puts an option that runs a command in the menu row
form: the lead row in accent.solid with text.on_accent, with no lead or
chosen edge. The palette's rows take it; other option lists keep the
option form.
2026-11-12 14:32:51 +00:00
aiongg cc855ef900 Slider ticks: ticks() sets the marks the track paints
Slider and RangeSlider kept their tick count in a prop nothing read, while
the track paints Marks::ticks. ticks() now sets Marks::ticks, the one
store, so 'Triangle, ticks' and the range slider's 'Level' draw their
ticks again. Trial: a slider draws the ticks it is asked for.
2026-11-12 14:32:51 +00:00
aiongg f7d6ae8094 Timeline: track header switches as icon toggle faces
Each switch cell shows a small ToggleButton face with the shared on look,
so the target and output switches show their on state as the old icon
buttons did. The collection's toggle cell beneath keeps the presses. The
row's own on/off icon looks go; one switch_name serves the column
headers and the faces.
2026-11-12 14:32:51 +00:00
aiongg 1bb054f76f PanelMenu story: the panel menu icon button as panel footers show it 2026-11-12 14:32:51 +00:00
aiongg 3da412f36b Toolbar separators between tool groups
AnnotationToolbar puts a vertical divider before each group button, as a
Bar separates its groups. GraphEditor's bottom bar draws a divider rule in
each gap between two button groups, inset from the bar's edges.
2026-11-12 14:32:51 +00:00
aiongg 2e64f951b8 Slicer: accent header band and control-radius tiles
HeaderRegion's band takes a BandFill: a surface or a tone's tinted fill
(HeaderRegion::tint). Tone::soft_fill and Tone::on_soft give a tone's fill
and the ink on it from one token table; StyleCx::tone_fill and the new
tone_on_fill read them. TitleRow::tone sets a header title in that ink.

The slicer's header is an accent band, inset like the body, with its
caption a section-strength TitleRow in accent.on_soft on the funnel's
centre line; its tiles take radius.control instead of the button radius.
2026-11-12 14:32:51 +00:00
aiongg 3ffaa00ea5 craft-layers: the app chooses the filter types the Layers panel offers 2026-11-12 14:32:51 +00:00
aiongg ed285c40f5 contract-api: dialog width roles and the wrap width 2026-11-12 14:32:51 +00:00
aiongg cef153147a PdfExportDialog: the shown page's title heads the page, as Preferences titles its page 2026-11-12 14:32:51 +00:00
aiongg 7bec7dcabf Dialog title type: a dialog's title row takes the heading role, as the old dialogs and PhotoCraft's do 2026-11-12 14:32:51 +00:00
aiongg 2e9fc2ab8c Footer button width: dialog buttons are at least size.dialog.button wide, size.dialog.side_button in a column beside the body, through a Button least_width role 2026-11-12 14:32:51 +00:00
aiongg d62a71318a Dialog width: a dialog opens at least size.dialog.least wide and its paragraphs wrap at size.dialog.wrap, through ContainerProps::least_width and a new wrap_width; content that cannot wrap widens it 2026-11-12 14:32:51 +00:00
aiongg 69d613ff2a contract-api and components-index: regenerated (list part drags, edge press, empty-space menu) 2026-11-12 14:32:51 +00:00
aiongg 77a855fbcc craft-layers: a frame's mask thumbnail, after its content thumbnail, drags the mask (trial) 2026-11-12 14:32:51 +00:00
aiongg 8955294c83 Collections take an opt-in edge press; the Layers panel's Alt-click on the line between two layers clips
- List::edge_press(mods, test): while the modifiers are held, the band of the line between two adjacent rows the
  test gives a cursor for shows that cursor and takes the click (CollectionEvent::EdgePressed), picking neither
  row. The band reaches LINE_REACH from the line; a toggle cell keeps its press. Collections without it are
  unchanged.
- craft-layers: LayersEvent::ClipLine { upper, release } for an Alt-click on the line between two sibling layers,
  with the clip-below or clip-release cursor.
2026-11-12 14:32:51 +00:00
aiongg 0d82cf70b4 Row drags from any part, a text face for trailing parts, thumbnail cursors and the empty space's menu
- ListRow::part_drag(RowDragSpot, payload) replaces thumb_drag: a thumbnail or a trailing part drags instead of
  the row (RowEvent::PartDrag). A trailing part that drags is a handle: its click is the row's.
- TrailingFace::Strong: a text face for a trailing part.
- ListRow::thumb_cursor: the cursor over a thumbnail.
- CollectionEvent::EmptyContextMenu: a secondary click on a collection's empty space.
- craft-layers: the fx badge drags every effect of its layer onto another layer (a transfer, Alt copies) and a
  click on it selects the row; MenuTarget.row is None for the empty space's menu; the load-selection cursor over
  thumbnails while Cmd/Ctrl is held; LayerTree::label_colors_in_menu decides per target whether the row menu
  gets the Label Color submenu.
2026-11-12 14:32:51 +00:00
aiongg 1d2e5ae5bb craft-layers: the row menu of a layer row ends with the Label Color submenu, sharing the eye menu's colours
LayersPanel::row_label_colors turns it off. A thumbnail's menu and the effects and Smart Filter rows' menus have
none.
2026-11-12 14:32:51 +00:00
aiongg b4d2f8cdce craft-layers: a mask thumbnail dropped on another layer's row moves the mask there, Alt copies (LayerDrop::Mask)
The rows take the mask through the list's drop kind for the panel's drag payload. LayerTree::accepts_mask_drop
decides which layers take it; by default a layer takes a mask of a kind it does not have.
2026-11-12 14:32:51 +00:00
aiongg 9ba22550f8 craft-layers: LayersDrag is public, so an app's drop target (a document tab) reads the dragged layers 2026-11-12 14:32:51 +00:00
aiongg dfd1d30270 Layers panel: thumbnail badges at the small icon size
The mask badges and the app's thumbnail badge fill the theme's small icon size (size.icon.sm) within the thumbnail,
and the app's icon draws at the small glyph size (size.icon.glyph_sm), instead of a share of the thumbnail.
2026-11-12 14:32:51 +00:00
aiongg a7b6c9f0f6 List rows take several thumbnail targets; a frame selected as a whole brackets both thumbnails
ListRow::thumb_target takes ThumbTargets, built from one ThumbTarget or an array of them; one set of brackets frames
each run of adjacent targets, so two targets side by side never cut into each other. In the Layers panel,
LayerPart::Pixels on a frame targets its shape and content together, LayerPart::FrameShape the shape alone and
LayerPart::FrameContent the content alone; a click on a frame's first thumbnail reports FrameShape. Story
composites/layers-panel/frame-selected shows it.
2026-11-12 14:32:51 +00:00