Commit Graph
2418 Commits
Author SHA1 Message Date
aiongg f37a8b2a7f Keys: focus_holds answers from routing's own decisions: a list's type-ahead letters, and every press of a menu or recorder, which routing also keeps from egui 2026-11-12 22:54:16 +00:00
aiongg c08ad7196b Keys: a press's release or a clipboard event ends the press a following text links to 2026-11-12 22:54:16 +00:00
aiongg 788c89b024 Commands: a key command closes the open popups, as an app shortcut through close_popups does 2026-11-12 22:54:16 +00:00
aiongg 4e7ab74238 docs: contract-api and components-index regenerated 2026-11-12 22:48:32 +00:00
aiongg b250a325fa F-1 review: layer runs by their clip, opt-in cross flip, capped popups in a region, strip speed in rows
- Story suite: a text run counts as shown by an open layer only when its clip lies
  in that layer; PaintedText records the clip.
- Place::flipping_across: only submenus open upward from a low row; rail and dock
  flyouts slide as PhotoCraft's tool flyouts do.
- Only modal and window layers in an embedded shell's region take the whole
  region; a popup kept in a PopupRegion keeps its cap.
- Strips scroll at rows per second of a control's height and show in the pass
  whose measured content first overflows.
- Trials: a bar menu reopened after scrolling to its end shows one level from
  its first row; a dropdown in a bar menu keeps its cap; a low tool's flyout slides.
2026-11-12 22:46:05 +00:00
aiongg 79c7a62e12 Story suite: a text run in an open layer stays in its part; restore the overflowing-menu story
The text-size case counted only the story's own area as shown, so a scrolled
popup's rows, cut only by its view, read as leaving their part once a density
change moved them past that area. What the story shows is its area and the
layers it has open.
2026-11-12 22:46:05 +00:00
aiongg 26e9a3ac63 Menu bar menus and their submenus stay below the bar
PopupRegion is the screen rect the popups opened in an env stay inside;
overlay::region_for returns it for popups, through the path an embedded shell's
modals take, and the measuring room keeps to it. MenuBar sets it below itself
(OverlayUi::contain_popups_below), so a submenu taller than the room under the
bar scrolls instead of covering the titles. The overflowing-menu story goes: the
story suite's room is shorter than the window a menu fills.
2026-11-12 22:46:05 +00:00
aiongg cdb179df0b Menus taller than their room scroll by strips and the wheel; side overlays open upward
Scroll gets a strip indicator: arrows above and below the view that scroll while
the pointer rests on them, taking height from the view and never width. Menu and
inline menus use it, so every menu layer, the menu bar's included, scrolls in the
room it has. overlay::place opens a side overlay that runs past the bounds the
other way when it fits there, so a tall submenu of a low row opens upward.
2026-11-12 22:46:05 +00:00
aiongg d3dedf55cb docs: contract-api and components-index regenerated 2026-11-12 22:40:25 +00:00
aiongg 7fd2b260db ui-contract: the host's tool gesture holds only beside a modal body that keeps the canvas
The registry keeps the dialog's part and the host's part apart: the
host's gestures join the reach only while a modal body keeps the same
canvas, whatever order the two are made in, so a modal that keeps
nothing (an alert) leaves the canvas blocked. Trials: the host's gesture
lapses when the dialog stops keeping the canvas; under a dialog that
keeps nothing it passes no press and no wheel.

Also: the BlockingOverlay story's drive opens it; rows.rs doc wrapped;
api-map TonePickerRow note names pass_canvas_gesture.
2026-11-12 22:38:11 +00:00
aiongg 13da403b9b ui-contract: only the canvas host passes a tool gesture outside a modal body
A control's registration belongs to the modal whose body makes it and
is dropped outside every modal body, so a picker armed in a panel passes
no press under a modal that opens later. The canvas's host passes its
running tool's gestures with runtime::sampler::pass_tool_gesture, which
belongs to the top modal. Trials: a panel picker passes nothing under a
dialog; the host's tool gesture passes and lapses with the dialog.
2026-11-12 22:38:11 +00:00
aiongg 1108d3e032 ui-panels: dialog stories start closed behind a button that opens the dialog
The Dialog and BlockingOverlay stories bind their open state to an
opener button; the close-box drive opens the dialog first. The story
overlay without a card closes with Escape.
2026-11-12 22:38:11 +00:00
aiongg a539851847 ui-contract: a canvas gesture passed outside every modal body belongs to the top modal
The tool host runs the canvas's tool outside the dialog's body; its
registration holds for the top modal layer, here or in another viewport,
and lapses with it. Trial: a gesture the canvas passes itself reaches it
under the open dialog and lapses when the dialog closes.
2026-11-12 22:38:11 +00:00
aiongg 5f279e9a00 ui-contract: a modal's canvas reach names the gestures it passes
The canvas a modal dialog keeps open (runtime::sampler) passes the view
navigation and, beside it, only the presses the dialog names: a
CanvasGesture is a button with the modifiers it needs held, its drag
included. Sampler::pass_canvas_gesture replaces arm_sampler; the
eyedropper rows, the Color Picker and the tone pickers name a primary
press, Curves names its Cmd-click, and every other press stays blocked.

Trials: the kept view passes the wheel (scroll and zoom) and the middle
pan and blocks the primary press; a modifier gesture passes only with
its modifier. Story: Canvas "under a dialog", a live region under an
open modal.
2026-11-12 22:38:11 +00:00
aiongg 01f146b931 Dialogs: automation answers only what a user can press
StandardPrompt and UnsavedChangesDialog build their buttons, their choice
check and their programmatic OK from one offered list; a choice without an
enabled button is refused. HostedParamDialog opens its values once (remembered
values, defaults) before its first show, OK or set, through the helper the
first pass uses; OK builds its result through one helper; set refuses rows
that are hidden or disabled and reads the value as its row's kind.
set_json_field takes the Context. Automation lists dialog ids as decimal
strings, takes a string or a number, and names only the host's dialogs.
2026-11-12 22:27:40 +00:00
aiongg e51e929e48 Dialogs: automation surface for every StackDialog
StackDialog gains json_fields and set_json_field; DialogHost lists its open
dialogs with their fields, sets one by id, and confirms or cancels by id
whatever the type. HostedParamDialog (values by parameter row, with a
programmatic OK), StandardPrompt and UnsavedChangesDialog (their choice)
implement them. craft_automation::dialogs runs ui.dialog.set/confirm/cancel
on a host and lists its dialogs for ui.inspect.
2026-11-12 22:27:40 +00:00
aiongg 15fe3dba92 docs: contract-api and components-index regenerated 2026-11-12 22:04:33 +00:00
aiongg 11e82a60b2 Canvas: trials for the painted display's surround and paint count; Fixture::frame_shapes clears the texture changes it drops 2026-11-12 22:02:35 +00:00
aiongg 70dd577f01 Canvas: RasterDisplay shows an app-painted document beside a source one (AppPaint) 2026-11-12 22:02:35 +00:00
aiongg b02060f515 Keys: typed text a widget takes is held; apps close popups on a shortcut; the chords the focus holds
A letter typed into an open Select list went to the list's type-ahead and also
stayed in egui's input, where an app's own dispatcher ran it as a tool key. The
strip links each press to the text it typed, the begin hook records which texts a
component took, and a widget or popup holds a press whose text it took, as it
holds the presses its routing takes: the press leaves egui's input and the
runtime's shortcuts.

overlay::close_popups closes the running viewport's popup layers. An app whose
dispatcher reads its shortcuts from egui calls it when a shortcut runs; only the
app knows that a press matched one of its bindings.

keys::focus_holds names whether the focused component holds a chord: claimed, or
held by routing as owned_shortcuts decides. route_press splits into a decision
that reads state only (press_route) and the step that acts on it (apply_press),
so the query and the key stage share one decision and one held predicate.
2026-11-12 22:02:35 +00:00
aiongg ff3638f870 Lists: stacking keys move the rows a drag takes; a held release asks for its pass
key_reorder takes the rows acted_on names, so a stacking key on a selected sub-row moves that sub-row and not its
row. While a press holds a release for a later pass, sensing asks for a repaint, so the release goes out in the next
frame without new input.
2026-11-12 22:02:35 +00:00
aiongg 70dfca7f24 Lists: a drag or Delete of a selected sub-row takes the selected sub-rows only
A sub-row belongs to the row above it, so a gesture on one acts on the selected rows of its own kind. The Layers
panel keeps a Smart Filter row selected beside its layer; a drag of that row carried the layer too, and the drop
rule refused the mixed set.
2026-11-12 22:02:35 +00:00
aiongg bbd51b2db0 Press machine: a press reports its phases in order, one per pass
A release in a pass that still owes the press's Down or DragStart is held for the next pass, with its click
state taken when the button went up. Two clicks in one frame, which the one-press rule splits into
[P1], [R1, P2], [R2], report Down and Activate for both clicks.
2026-11-12 22:02:35 +00:00
aiongg c73f81c011 Keyboard Shortcuts: group header disclosure uses the one disclosure glyph 2026-11-12 22:02:35 +00:00
aiongg 2f7593cbbb layers: a double click on a thumbnail activates it once 2026-11-12 20:37:37 +00:00
aiongg e1d34a0093 Text parts open the framework edit menu on a context request
Every craft text control (TextField, NumberField, ChipField, AltTextField, DateField, ComboBox) shows the
EditMenu in a context menu on a right click in its text, the Menu key or Shift+F10. The open menu holds the
focus without ending the text part's typing run or losing its selection, so Escape closes the menu and the
field keeps editing, and a picked row acts on the field's selection once the focus is back. Rows run their
EditCommands through the command board, the same route an app's Edit menu uses.

- record_context counts a secondary release on a component's text widget
- a secondary press inside the selection keeps the selection
- EditCommand::Delete: the Delete command run from a menu deletes a text part's selection; the Delete and
  Backspace keys stay the text part's own deletion, and editors leave the command to the app
- TextField/NumberField::own_context_menu for a caller that hangs its own context menu on the field
  (the transform fields' unit menu)
2026-11-12 18:32:56 +00:00
aiongg 70d4172b6e Keys: the app's own canvas keeps the presses routed to it in egui's input
A host-drawn region (focus::host_canvas) reads its keys from egui, so a key it
keeps (Tab) must stay there. Stop::host marks it, and the key stage withdraws held
presses only for framework components.
2026-11-12 18:22:18 +00:00
aiongg 978e702874 Keys: a press the focused widget holds leaves egui's input
The strip left Cmd chords and arrows in egui's input and also routed them, so a
focused list row's stacking move and the app's own egui-reading shortcut both ran
on one press. Routing's held-by-the-focused-widget fact, which already filters the
runtime's shortcut list, now also withdraws those presses (and their key-down
state) from the pass's egui input; their releases follow through the strip's
consumed list.
2026-11-12 18:14:39 +00:00
aiongg fd03f1725f Layers: an adjustment layer's row icon is the adjustment_layer glyph, as in the footer and the filter 2026-11-12 17:33:40 +00:00
aiongg 73e652fd7f Layers: small touching lock buttons, small filter toggles, typed thumbnail badges
The Lock row's five buttons are small (ControlSize::Sm) and touch, as Photoshop's, so Fill and its
field stay on the row at a panel's width instead of wrapping below it. The Kind filter toggles are
small too.

LayerInfo::thumb_badge is a ThumbBadge (SmartObject, Shape) that craft-layers paints: a window glyph,
or a path with an anchor on each corner. Kind and mask badges share one badge box, a field well at
the small icon size in the thumbnail's corner.
2026-11-12 17:18:25 +00:00
aiongg ca5cc4ff06 Layer content runs outside its opener's label scopes
A tooltip shown from a field's control recorded its text line in the
field's label scope, so the side label lined up with the tooltip and
dropped under the next row. The overlay host now runs a layer's body
outside the open label and merge scopes.
2026-11-12 16:45:18 +00:00
aiongg da24e6e3c1 Contract: an edit of a given value asks for no rerun
A given value has no read record, so the edit reruns nothing: the component
shows the edit itself, and the app's other views show it in the next frame.
A drag on a given value (the Layers Opacity and Fill sliders) ran two passes
every frame.
2026-11-12 16:38:57 +00:00
aiongg bf99b186ec Rows: no divider under a collection's last row; the Effects header shows no icon
Dividers fall between rows (RowState::last), so a list's last row no longer
draws a rule beside the footer bar's. Photoshop's Effects header shows only its
eye and label; the mock sets no icon and SubRow::icon no longer names one.
2026-11-12 15:59:54 +00:00
aiongg cf928885f8 Layers: the row's effects badge is the fx icon
A list row paints a trailing drag handle's icon face as a mark, not an icon
button: a handle has no node of its own (the row's description names it), and a
button face would add an unnamed button.
2026-11-12 15:59:54 +00:00
aiongg d6ef780c79 Layers: a story with the effects and Smart Filters open 2026-11-12 15:59:54 +00:00
aiongg 5334392883 Layers: effect and Smart Filter sub-rows as Photoshop shows them
A source marks a sub-row with its indent steps (ItemSource::sub_row). The row is
compact, its eye column empty, and its toggle cells sit in its content at that
indent (sub_row_cells): one step past the layer for the header, two for an item.
Presses flip them there and a sweep down the eye column passes them by. No divider
falls between a row and the sub-rows that continue it (RowState::continued).
The mock's Effects header carries the sparkles icon.
2026-11-12 15:59:54 +00:00
aiongg 5f0331fbff Row line: a one-line child sits on the row's line, a taller one at its top
A child placed on an unwrapped row's line reports how far below its top
the centre of its first line lies: half a control's height, a row body's
line, or a container's first child's first line (its header's, else its
body's), which its measuring run records. A child whose first line lies
at half its height is one line (a control, a row of one-line children, a
field with its label beside its control) and sits with its centre on the
row's line, so a side-labelled field holding smaller controls centres
them. A child of more than one line (a column, a field with its label
above or a help line below) sits at the row's top, as does one with no
line of its own (a collection whose rows run along Y), so columns beside
each other share their tops. The row's line is the lowest centre of its
one-line children, or of the line it shares with its container's inline
regions; the row records the line's centre and its height, and takes
that height in its measuring run.

Replaces the line/block split, where every container sat at the row's top.
2026-11-12 15:53:56 +00:00
aiongg 46061c8e44 A stack's header and footer are spaced from its body by the stack's gap
The header is the stack's first row and the footer its last, so the gap
between the stack's children also separates them from the body. A gap set
after the header or footer keeps them in step; footer_gap still sets the
footer's own.
2026-11-12 15:53:56 +00:00
aiongg 18262420d5 Lists keep a hidden document's scroll position: the read step no longer clamps the kept offset against the evicted last extent
A collection kept its offset in session memory but the last pass's extent in
shown memory. While another document showed, the hidden list's shown memory was
evicted, the extent read back as 0, and the read step clamped the offset to 0.
Every later step already clamps against this pass's content, so the read-step
clamp and View.extent go.
2026-11-12 15:48:42 +00:00
aiongg 1ee300bbb3 Toggle cells that are off or mixed and unlinked link glyphs rest in text.faint; on toggles and linked glyphs rest in text.muted; both read in text.normal under the pointer 2026-11-12 15:42:15 +00:00
aiongg 683e9b25da Thumbnails: square, with a frame in line.frame at the slot's edge and the picture inside it; line.frame is a new picture-frame role (near black in dark mode, the control edge in light) 2026-11-12 15:42:15 +00:00
aiongg fdcf5ffac9 One disclosure glyph: sections, tree rows and a row's trailing disclosure paint the filled triangle; the chevron is only the dropdown arrow 2026-11-12 15:42:15 +00:00
aiongg dbe14adf38 Toggle cells and link glyphs rest in text.muted and read in text.normal under the pointer, through one quiet ink rule shared with Disclosure 2026-11-12 15:42:15 +00:00
aiongg ac9dd13cdc Toggle columns: one width from the toggle-column mechanism, a control and the inline gap (ColumnWidth::Toggle, ColumnSpec::toggle) 2026-11-12 15:42:15 +00:00
aiongg 1cc518f92d Icon strokes scale with the glyph: one stroke.icon role, a share of the icon side (Lucide at 1.75 of 24), for stroke sets and the suite's stroke drawings alike 2026-11-12 15:23:58 +00:00
aiongg 93651d8505 Icon catalogue: adjustment layer as a half-filled ring, a filled layer-mask dot, an italic fx, a plain folder for new_folder, and link_layers as the horizontal chain the Layers panel uses 2026-11-12 15:23:58 +00:00
aiongg 95177488d6 An icon button that opens a menu shows the dropdown arrow under its glyph; the corner triangle marks a tool group 2026-11-12 15:23:58 +00:00
aiongg 237e2a1566 Panel footer actions show their icons at the tool size (size.icon.md) 2026-11-12 15:23:58 +00:00
aiongg 6924d6a1bf Rules are 1 pt wide and take a band of their own
Divider and edge rules take the thin stroke (1 pt, whole physical
pixels) instead of one physical pixel; grid rules over the document stay
one physical pixel.

The rules between a container's regions (above and under the header,
beside a ruled footer, before a ruled end region) each get a band in the
region layout, so no rule lies over a region's content at any scale.
Rules drawn along a rect's edge (footer bar, tile grid tail, timeline
graph bar, docked scroll bar, layer row toggle cells) are edge rules on
the side the rule belongs to, so the second pixel at 2x stays off the
neighbour. The split button's divider reads the divider rule's width.
2026-11-12 15:23:58 +00:00
aiongg 5570e075ec ConditionBuilder: the match, field, operator, unit and choice selects fit their widest entry 2026-11-12 15:23:58 +00:00