mirror of
https://github.com/storytold/craft-libs.git
synced 2026-11-10 06:31:36 +00:00
f4fe03610d3d69d4e773941641598b160c42409b
Maintainer review on storytold/wordcraft#3562: spelling looks words up composed (NFC), but add_word, remove_word, ignore_word, custom_word (so loading the dictionary file) and save_user_dictionary's removed list kept the raw lower-cased spelling. A word added or ignored decomposed (`zqprue\u{301}ba`) therefore stayed flagged. - dictionary_key(): lower case, then composed; every write uses it, and in_user_dictionary() looks up composed, so either form adds, ignores, removes and finds the same entry; NFD entries in an existing file load and save composed - English's known_core() reuses in_user_dictionary() instead of a copy of it - issue byte ranges still cover the text as typed - regressions: proof (add, Ignore All, remove, save/load with an NFD entry, both forms rechecked) and engine (review.addToDictionary and review.ignoreAll with the issue's NFD text)
Languages
Rust
98.5%
Max
1.3%
Python
0.2%