Merge remote-tracking branch 'origin/switch-craft-libs-xls' into codex/reviewfix-3841

This commit is contained in:
Dylan M. Taylor
2026-11-12 05:40:59 +00:00
+10
View File
@@ -113,6 +113,16 @@ pub(crate) fn read_xls_budgeted(bytes: &[u8], limits: x::Limits, functions: Func
}
let mut unparsed = false;
for s in &book.sheets {
// craft-xls keeps these rules in its read model, but GridCraft's XLS adapter does not
// import conditional formatting. Its own warnings cover rules it could not decode; this
// reports the additional rules that this adapter drops.
if !s.conditional_formats.is_empty() {
report.warn(warning(&x::Warning::ConditionalFormattingSkipped));
}
// Data validation is not yet imported by this adapter.
if !s.validations.is_empty() {
report.warn(warning(&x::Warning::DataValidationSkipped));
}
let sheet = sheet_of(s, &styles, &mut unparsed);
wb.sheets.push(Arc::new(sheet));
}