pauljd/gridcraft
1
0
Fork 0
mirror of https://github.com/storytold/gridcraft.git synced 2026-11-12 07:32:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix XLS validation warnings

Browse Source
This commit is contained in:
Dylan M. Taylor
2026-11-12 06:13:59 +00:00
parent 73a18c4f4c
commit 794b65ecac
1 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/xlsx/src/xls.rs
+11 -11
View File
@@ -73,8 +73,8 @@ fn warning(w: &x::Warning) -> String {
W::Charts => "Charts in .xls files are not imported yet.".into(),
W::PicturesSkipped => "Some pictures in .xls files were skipped.".into(),
W::ConditionalFormattingSkipped | W::ConditionalFormatting12 => "Some conditional formatting in .xls files was not imported.".into(),
W::DataValidationSkipped => "Some data validation in .xls files could not be read and was skipped.".into(),
W::DataValidationIgnored => "Some data validation records in .xls files were ignored, as Excel ignores them.".into(),
W::DataValidationSkipped => "Some data validation rules in .xls files could not be read and were skipped.".into(),
W::DataValidationIgnored => "Some data validation records in .xls files were ignored, as Excel ignores them: they have no DVal record before them, or come after the number of rules it gives.".into(),
W::Hyperlinks => "Hyperlinks in .xls files are not imported yet.".into(),
W::PivotTables => "PivotTables in .xls files are not imported yet; their values were kept.".into(),
W::CellsOutsideGrid(n) => format!("{n} cells outside the grid were skipped."),
@@ -114,15 +114,15 @@ pub(crate) fn read_xls_budgeted(bytes: &[u8], limits: x::Limits, functions: Func
}
let mut unparsed = false;
for s in &book.sheets {
// craft-xls keeps these rules in its read model, but GridCraft's XLS adapter does not
// import conditional formatting. Its own warnings cover rules it could not decode; this
// reports the additional rules that this adapter drops.
if !s.conditional_formats.is_empty() {
report.warn(warning(&x::Warning::ConditionalFormattingSkipped));
}
// Data validation is not yet imported by this adapter.
if !s.validations.is_empty() {
report.warn(warning(&x::Warning::DataValidationSkipped));
// Report rules craft-xls kept that the adapter cannot represent. craft-xls already warns
// about records it could not decode.
for (dropped, skipped) in [
(!s.conditional_formats.is_empty(), x::Warning::ConditionalFormattingSkipped),
(s.validations.iter().any(|v| validation_of(v).is_none()), x::Warning::DataValidationSkipped),
] {
if dropped {
report.warn(warning(&skipped));
}
}
let sheet = sheet_of(s, &styles, &mut unparsed);
wb.sheets.push(Arc::new(sheet));