mirror of
https://github.com/storytold/pdfcraft.git
synced 2026-11-09 01:26:53 +00:00
address review: check-one writes a record for an unreadable or oversized input
This commit is contained in:
@@ -43,7 +43,18 @@ pub(crate) fn check_one(args: &[String]) -> Result<(), CliError> {
|
||||
let path = *positional(args, CHECK_ONE_OPTIONS).first().ok_or("check-one: missing file")?;
|
||||
let dpi = parse_dpi(flag(args, "--dpi").unwrap_or("36"))?;
|
||||
let start = Instant::now();
|
||||
let bytes = read(path)?;
|
||||
// A file that can't be read (past the input cap, say) is this file's record, not a crash of the child.
|
||||
let bytes = match read(path) {
|
||||
Ok(bytes) => bytes,
|
||||
Err(e) => {
|
||||
let status = if e.contains("larger than") { "input-too-large" } else { "read-error" };
|
||||
let line = serde_json::json!({ "file": path, "status": status, "pages": 0, "failed_pages": 0, "warnings": 0,
|
||||
"ms": start.elapsed().as_millis() as u64, "detail": e.chars().take(400).collect::<String>() });
|
||||
stdout_line(format_args!("{line}"))?;
|
||||
// (the record is the answer `check` reads; the error and exit status are for a direct run)
|
||||
return Err(e.into());
|
||||
}
|
||||
};
|
||||
let (status, pages, failed, detail, warnings) = match inspect(bytes.clone(), None) {
|
||||
Err(e) => (format!("open-error:{}", short(&e.to_string())), 0, 0, e.to_string(), 0),
|
||||
Ok(info) => {
|
||||
|
||||
@@ -113,3 +113,14 @@ fn an_argument_that_is_not_utf8_is_an_error_not_a_panic() {
|
||||
assert!(!stderr.contains("panicked"), "{stderr}");
|
||||
}
|
||||
}
|
||||
|
||||
/// A file `check-one` cannot read is a record on stdout with its own status and the reason, which
|
||||
/// `check` relays, not an empty stdout that reads as a crash.
|
||||
#[test]
|
||||
fn check_one_reports_an_unreadable_file_as_a_record() {
|
||||
let out = Command::new(BIN).args(["check-one", "missing.pdf"]).output().expect("run cli");
|
||||
let stdout = String::from_utf8_lossy(&out.stdout);
|
||||
let record: serde_json::Value = serde_json::from_str(stdout.trim()).unwrap_or_else(|e| panic!("{e}: {stdout:?}"));
|
||||
assert_eq!(record["status"], "read-error");
|
||||
assert!(record["detail"].as_str().is_some_and(|d| d.contains("missing.pdf")), "{record}");
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user