mirror of
https://github.com/storytold/vectorcraft.git
synced 2026-11-12 19:22:48 +00:00
UI: keep numeric field caret on short pointer drags (#1326)
A pointer movement under the click tolerance was still treated as a tap, so the focus click selected the whole numeric value. Any movement from the press now keeps the caret; only a tap without movement selects all. Regression test: a_sub_threshold_movement_released_as_a_click_keeps_its_caret.
This commit is contained in:
@@ -1361,6 +1361,23 @@ fn a_short_drag_released_as_a_click_keeps_its_caret() {
|
||||
assert_eq!(f.frame(vec![enter()], &draw), Some(1273456.0), "typing lands where the drag left the caret");
|
||||
}
|
||||
|
||||
/// #1326: the smallest pointer movement egui still reports as a click (under the 3-point drag
|
||||
/// threshold) must keep the caret too; only a press released where it went down selects all.
|
||||
#[test]
|
||||
fn a_sub_threshold_movement_released_as_a_click_keeps_its_caret() {
|
||||
let mut f = Field::new();
|
||||
let draw = |ui: &mut egui::Ui| numeric_fixture(ui, 0);
|
||||
f.frame(vec![], &draw);
|
||||
let at = f.text_point(field_text(0), 2, 7.0);
|
||||
f.frame(vec![Event::PointerMoved(at), pointer_button(at, true)], &draw);
|
||||
let pressed = f.selection();
|
||||
let nudge = egui::vec2(1.5, 0.0);
|
||||
f.frame(vec![Event::PointerMoved(at + nudge)], &draw);
|
||||
f.frame(vec![pointer_button(at + nudge, false)], &draw);
|
||||
assert_ne!(f.selection(), Some((0, field_text(0).chars().count())), "a 1.5 px movement is a drag, not a tap (#1326)");
|
||||
assert_eq!(f.selection(), pressed, "the movement keeps the caret where the press landed");
|
||||
}
|
||||
|
||||
/// A tap (no movement) on a fresh numeric field still selects all on release.
|
||||
#[test]
|
||||
fn a_tap_without_movement_still_selects_all_on_release() {
|
||||
|
||||
@@ -171,13 +171,13 @@ pub(super) fn select_all_on_focus(ui: &Ui, resp: &Response, text: &str) {
|
||||
});
|
||||
}
|
||||
let clicked_focus = released && ui.data_mut(|d| d.remove_temp::<bool>(pending)).unwrap_or(false) && resp.clicked_by(egui::PointerButton::Primary);
|
||||
// A press released a few points away is a short drag, not a tap. egui still reports a
|
||||
// click, and a release inside one character leaves no text selection, so select-all on
|
||||
// release would replace the drag the user just made (#1326).
|
||||
// Any pointer movement from the press is a drag, not a tap. egui still reports a click for
|
||||
// a movement under its click tolerance, and a release inside one character leaves no text
|
||||
// selection, so select-all on release would replace the drag the user just made (#1326).
|
||||
let dragged = clicked_focus
|
||||
&& ui
|
||||
.data_mut(|d| d.remove_temp::<egui::Pos2>(press_pos))
|
||||
.is_some_and(|p0| ui.input(|i| i.pointer.interact_pos()).is_some_and(|p1| (p1 - p0).length() > 3.0));
|
||||
.is_some_and(|p0| ui.input(|i| i.pointer.interact_pos()).is_some_and(|p1| (p1 - p0).length() > 0.0));
|
||||
if resp.lost_focus() {
|
||||
ui.data_mut(|d| {
|
||||
d.remove_temp::<bool>(pending);
|
||||
|
||||
+1
-1
@@ -320,7 +320,7 @@ macOS cursor delivery (#2292) is narrowed to a native host adapter using the exi
|
||||
|
||||
- **Done:** Divide splits filled paths along open cutting lines and curves (#1307), preserving the frontmost filled appearance, implicit filled closure, holes, unrelated objects and one Undo/Redo; the existing bounded-map fallback remains.
|
||||
|
||||
- **Done:** Numeric fields keep a text drag's start when the pointer gains focus and movement exceeds the click threshold (#1326, in part). A completed focus click selects the whole value; keyboard focus, double-click and numeric stepping remain regression-tested. Short movements still classified as clicks can select all; that case remains open.
|
||||
- **Done:** Numeric fields keep a text drag's start when the pointer gains focus, including short movements that egui still classifies as clicks (#1326). Any pointer movement from the press keeps the caret; only a tap without movement selects the whole value. Keyboard focus, double-click and numeric stepping remain regression-tested (`tests/numfields.rs`, `a_short_drag_released_as_a_click_keeps_its_caret` and `a_sub_threshold_movement_released_as_a_click_keeps_its_caret`).
|
||||
|
||||
- **Done:** DXF reads control-point SPLINE closure (#1299 follow-up after #1320); open curves keep their open state. DXF export now recognizes circular cubic paths conservatively and writes native CIRCLE/ARC where stroke semantics permit; R12 weighted strokes remain POLYLINE, and a non-circular ellipse keeps the existing fallback. Alter Paths for Appearance outlines only the strokes a CAD line can't draw (aligned, profiled, offset dashes, wider than 2.11 mm, or in R13 and R14), so a 1 pt circle or arc stays a CIRCLE or ARC. CNC preset and VCarve QA remain open. Escape leaves Artboard editing for Selection; during a drag it first cancels the gesture. Headless egui key events cover idle Escape, active-drag cancellation and a subsequent Escape in `tests/distortkeys.rs`.
|
||||
- **Done:** DXF reads control-point SPLINE closure (#1299 follow-up after #1320); open curves keep their open state. DXF export now recognizes circular cubic paths conservatively and writes native CIRCLE/ARC where stroke semantics permit; R12 weighted strokes remain POLYLINE. A closed four-cubic ellipse, or a circle scaled out of proportion, is written as a native ELLIPSE in R13 and later; R12 keeps the existing fallback. CNC preset and VCarve QA remain open. Escape leaves Artboard editing for Selection; during a drag it first cancels the gesture. Headless egui key events cover idle Escape, active-drag cancellation and a subsequent Escape in `tests/distortkeys.rs`.
|
||||
|
||||
Reference in New Issue
Block a user