Unit Converter: a null unit is an error

addon.units.convert read {"value": 12, "unit": null} as 12 points. Only an
omitted unit is points now; a null unit is refused as an unknown unit.
This commit is contained in:
dotCooCoo
2026-11-14 20:09:03 -08:00
parent d6761e23ba
commit 71686757ec
2 changed files with 4 additions and 2 deletions
+2 -2
View File
@@ -57,9 +57,9 @@ pub fn in_every_unit(pt: f64) -> Value {
json!({ "points": pt, "units": units })
}
/// The unit `p` gives for a number without a suffix (points when left out).
/// The unit `p` gives for a number without a suffix (points when left out; null is an error).
fn unit_param(p: &Value) -> Result<Unit> {
let Some(given) = p.get("unit").filter(|u| !u.is_null()) else { return Ok(Unit::Points) };
let Some(given) = p.get("unit") else { return Ok(Unit::Points) };
let named = given.as_str().filter(|name| name.len() <= MAX_TEXT_LEN).and_then(Unit::named_east_asian);
named.ok_or_else(|| {
let u = match given {
@@ -155,6 +155,8 @@ fn bad_values_and_units_are_refused() {
json!({"value": 1, "unit": "furlongs"}),
json!({"value": 1, "unit": 5}),
json!({"value": 1, "unit": ["mm"]}),
// Only an omitted `unit` is points.
json!({"value": 1, "unit": null}),
] {
match s.execute("addon.units.convert", &p) {
Err(EngineError::BadParams { cmd, .. }) => assert_eq!(cmd, "addon.units.convert", "{p}"),