Merge pull request #8678 from storytold/train/carry8652

Place: show progress window with Cancel for slow placed files (part of #5930) (#8652)
This commit is contained in:
BFlat
2026-11-19 15:37:00 +07:00
committed by GitHub
12 changed files with 308 additions and 15 deletions
+1
View File
@@ -695,6 +695,7 @@ impl PlaceJob {
/// the renderers' image store for the first frame that draws them
/// ([`super::links::readable_and_kept`]).
pub fn read(self) -> Result<PlaceRead> {
crate::cancel::check()?;
let (mut loaded, slices) = load_sliced(&self.params, PLACE, self.target, true)?;
let linked = loaded.link.is_some() && bool_or(&self.params, "link", true);
match &mut loaded.art {
+6
View File
@@ -1662,6 +1662,12 @@ pub const UI_COMMANDS: &[(&str, &str, &str, &str)] = &[
"",
"{} close the progress window of the files being opened; they go on being read, shown in the status bar → {hidden: n}",
),
(
"file.cancelPlace",
"Cancel Place",
"",
"{} stop placing every file being read in the background (its progress window's Cancel): the files aren't placed → {cancelled: n}",
),
(
"ui.dxfOptionsDialog",
"DXF Options Dialog",
+1
View File
@@ -642,6 +642,7 @@ impl VectorcraftApp {
plugin_runs::show(self, &ctx);
trace_runs::show(self, &ctx);
opening::show(self, &ctx);
placing::show(self, &ctx);
// After every window this pass may open, and before the palette's field takes the keyboard.
panel_docking::close_overlays_for_modal(self, &ctx);
palette::show(self, &ctx);
+14 -3
View File
@@ -135,11 +135,20 @@ pub enum Pressed {
Hide,
}
/// A modal progress window with only a Cancel button (and bound to Esc).
pub fn window_cancel(ctx: &egui::Context, id: &str, heading: &str, body: impl FnOnce(&mut egui::Ui)) -> Option<Pressed> {
window_impl(ctx, id, heading, false, body)
}
/// A modal window (`id`) headed `heading`, in the UI language: `body` draws how far the work has
/// got, then come Cancel (also Esc) and Continue in Background → the one pressed. Work that may
/// take a while in the background shows it: exports, and heavy plug-in filters
/// ([`crate::plugin_runs`]).
pub fn window(ctx: &egui::Context, id: &str, heading: &str, body: impl FnOnce(&mut egui::Ui)) -> Option<Pressed> {
window_impl(ctx, id, heading, true, body)
}
fn window_impl(ctx: &egui::Context, id: &str, heading: &str, allow_hide: bool, body: impl FnOnce(&mut egui::Ui)) -> Option<Pressed> {
let mut pressed = None;
modal::show(ctx, heading, egui::Id::unique(id), -40.0, 20, |ui| {
ui.set_width(360.0);
@@ -152,9 +161,11 @@ pub fn window(ctx: &egui::Context, id: &str, heading: &str, body: impl FnOnce(&m
if widgets::secondary_button(ui, "Cancel").clicked() {
pressed = Some(Pressed::Cancel);
}
ui.add_space(8.0);
if widgets::secondary_button(ui, "Continue in Background").clicked() {
pressed = Some(Pressed::Hide);
if allow_hide {
ui.add_space(8.0);
if widgets::secondary_button(ui, "Continue in Background").clicked() {
pressed = Some(Pressed::Hide);
}
}
});
});
+1
View File
@@ -188,6 +188,7 @@ fn run_ui_part1(app: &mut VectorcraftApp, id: &str, p: &Value) -> Option<Result<
"file.saveInBackground" => Ok(io::hide_saves(app)),
"file.cancelOpen" => Ok(crate::opening::cancel_all(app)),
"file.openInBackground" => Ok(crate::opening::hide_all(app)),
"file.cancelPlace" => Ok(crate::placing::cancel_all(app)),
id if id.starts_with("file.openRecent") => match recent_slot(app, id).filter(|path| recent_readable(path)).cloned() {
Some(path) => io::open_reporting(app, &path),
None => Err("no such recent file".into()),
+1
View File
@@ -241,6 +241,7 @@ pub fn enabled(app: &VectorcraftApp, id: &str) -> bool {
"file.cancelSave" | "file.saveInBackground" => app.background.running(crate::background::Kind::Save),
"file.cancelOpen" => !app.opening.pending.is_empty(),
"file.openInBackground" => crate::opening::any_shown(app),
"file.cancelPlace" => crate::placing::can_cancel(app),
"plugin.cancelRuns" => crate::plugin_runs::any_running(app),
"plugin.hideRuns" => crate::plugin_runs::any_shown(app),
"imageTrace.cancelRuns" => crate::trace_runs::any_running(app),
+6
View File
@@ -1663,6 +1663,12 @@ pub const UI_COMMANDS: &[(&str, &str, &str, &str)] = &[
"",
"{} close the progress window of the files being opened; they go on being read, shown in the status bar → {hidden: n}",
),
(
"file.cancelPlace",
"Cancel Place",
"",
"{} stop placing every file being read in the background (its progress window's Cancel): the files aren't placed → {cancelled: n}",
),
(
"ui.dxfOptionsDialog",
"DXF Options Dialog",
+96 -3
View File
@@ -15,6 +15,7 @@ use std::sync::mpsc::{Receiver, Sender, TryRecvError, channel};
use std::sync::{Arc, Mutex};
use serde_json::{Value, json};
use vectorcraft_engine::cancel::{self, CancelToken};
use vectorcraft_engine::cmd::clipboard::{Clipboard, Flavour, ImageRead, read_image};
use vectorcraft_engine::cmd::place::{PlaceRead, QueueRead};
use vectorcraft_engine::file_access::ScopeHandle;
@@ -154,6 +155,7 @@ enum Pasted {
/// Files being read for Place.
pub struct Pending {
pub(crate) id: u64,
/// The file's name ("photo.tif"; the names joined with ", " for the place cursor's files).
pub(crate) name: String,
/// What the status bar shows ("Placing photo.tif").
@@ -167,13 +169,15 @@ pub struct Pending {
/// [`crate::place::drop_files`]'s do).
dropped: bool,
/// Whether it is a paste's bitmap ([`adopt_for_paste`]) rather than a file.
paste: bool,
pub(crate) paste: bool,
/// The number of the paste's chain ([`Placing::chains`]).
chain: Option<u64>,
done: Receiver<Result<Read, String>>,
/// The automation roots in force when the read started, kept in force when it is placed: a
/// DXF placed against an artboard that changed meanwhile is read again then.
scope: ScopeHandle,
token: CancelToken,
pub hidden: bool,
}
/// A read waiting for the thread that reads the files.
@@ -198,6 +202,7 @@ pub struct Placing {
latest_chain: HashMap<u64, u64>,
/// The number the next chain takes.
next_chain: u64,
pub next_id: u64,
/// The thread that reads the files, one at a time in the order they were started: started with
/// the first read, it ends when the app does.
reader: Option<Sender<Job>>,
@@ -389,6 +394,8 @@ fn spawn_labeled(
let completion = scope.clone();
#[cfg(test)]
let reading = app.placing.reading.clone();
let token = CancelToken::new();
let raised = token.clone();
let job: Job = Box::new(move || {
#[cfg(test)]
{
@@ -396,7 +403,7 @@ fn spawn_labeled(
reading[1].fetch_max(now, std::sync::atomic::Ordering::SeqCst);
}
let r = scope
.run(|| vectorcraft_engine::guard::catch_panic(read))
.run(|| vectorcraft_engine::guard::catch_panic(|| cancel::scope(&raised, None, read)))
.unwrap_or_else(|msg| Err(format!("internal error: {msg} (please report this bug)")));
#[cfg(test)]
reading[0].fetch_sub(1, std::sync::atomic::Ordering::SeqCst);
@@ -421,7 +428,22 @@ fn spawn_labeled(
let _ = reader.send(job);
app.placing.reader = Some(reader);
}
app.placing.pending.push(Pending { name, label: label.clone(), doc, reverts, dropped, paste: chain.is_some(), chain, done, scope: completion });
app.placing.next_id += 1;
let id = app.placing.next_id;
app.placing.pending.push(Pending {
id,
name,
label: label.clone(),
doc,
reverts,
dropped,
paste: chain.is_some(),
chain,
done,
scope: completion,
token,
hidden: false,
});
let status = format!("{label}…");
app.status(status.clone());
Ok(Some(json!({ "background": true, "status": status })))
@@ -770,5 +792,76 @@ pub(crate) fn confirm_swatch_paste(
result
}
/// The progress window's Cancel: the files being read for Place aren't placed.
pub fn cancel_all(app: &mut VectorcraftApp) -> Value {
let mut cancelled = 0;
let mut i = 0;
while i < app.placing.pending.len() {
if !app.placing.pending[i].paste {
let p = app.placing.pending.remove(i);
p.token.cancel();
if app.ui.status == format!("{}…", p.label) {
app.ui.status.clear();
}
if let Some(chain) = p.chain
&& !app.placing.swatch_paste.as_ref().is_some_and(|waiting| waiting.chain == chain)
{
finish_chain(app, chain);
}
cancelled += 1;
} else {
i += 1;
}
}
json!({ "cancelled": cancelled })
}
/// Can any placed file being read be cancelled?
pub fn can_cancel(app: &VectorcraftApp) -> bool {
app.placing.pending.iter().any(|p| !p.paste)
}
/// Is a placed file being read that the progress window shows?
pub fn any_shown(app: &VectorcraftApp) -> bool {
app.placing.pending.iter().any(|p| !p.paste && !p.hidden)
}
/// The progress window of the first file being read for Place, once that has been read for
/// [`crate::export_progress::DELAY`]: a quick place doesn't flash it. Not while a dialog or another
/// progress window (an export, a heavy plug-in filter, an Image Trace, an open) is open: never two modals at once.
pub fn show(app: &mut VectorcraftApp, ctx: &egui::Context) {
let shown: Vec<&Pending> = app.placing.pending.iter().filter(|p| !p.paste && !p.hidden).collect();
let Some(first) = shown.first() else { return };
let now = ctx.input(|i| i.time);
let since = ctx.data_mut(|m| {
let seen = m.get_temp_mut_or_insert_with(egui::Id::unique("placing-seen"), || (first.id, now));
if seen.0 != first.id {
*seen = (first.id, now);
}
seen.1
});
let exporting = app.background.jobs.iter().any(|j| j.progress.is_some() && !j.hidden && !j.cancelled());
let other = exporting || crate::plugin_runs::any_shown(app) || crate::trace_runs::any_shown(app) || crate::opening::any_shown(app);
if now - since < crate::export_progress::DELAY || app.ui.dialog.is_some() || other {
return;
}
let heading = format!("{}…", crate::i18n::msg(&first.label));
let more = shown.len() - 1;
let t = crate::theme::Tokens::get(ctx);
let pressed = crate::export_progress::window_cancel(ctx, "placing-progress", &heading, |ui| {
crate::export_progress::indeterminate(ui, tl!("Reading the file…"));
if more > 0 {
ui.add_space(6.0);
let queued = crate::i18n::tn(more as u64, "{n} more file waiting", "{n} more files waiting");
ui.label(egui::RichText::new(queued).size(11.5).color(t.text_dim));
}
});
if pressed == Some(crate::export_progress::Pressed::Cancel)
&& let Err(e) = app.run("file.cancelPlace", json!({}))
{
app.status(e);
}
}
#[cfg(test)]
mod tests;
+169
View File
@@ -1911,3 +1911,172 @@ fn a_file_read_again_when_placed_stays_within_the_roots_it_was_read_in() {
assert!(app.ui.status.contains("outside the read root"), "{}", app.ui.status);
let _ = std::fs::remove_dir_all(base);
}
/// Draws one frame of the place progress window at `time` seconds → the texts it drew.
fn progress(app: &mut VectorcraftApp, ctx: &egui::Context, time: f64) -> String {
let mut out = ctx.run_ui(egui::RawInput { time: Some(time), ..Default::default() }, |ui| super::show(app, ui.ctx()));
out.textures_delta.clear();
let mut texts = String::new();
for shape in out.shapes {
if let egui::epaint::Shape::Text(t) = shape.shape {
texts.push_str(t.galley.text());
texts.push('\n');
}
}
texts
}
/// #5930: placing a file that takes longer than 0.4 s shows a progress window with its name,
/// an indeterminate moving bar and a Cancel button (Escape); never two modals at once.
#[test]
fn a_file_that_takes_a_while_to_place_shows_a_progress_window() {
let hold = Arc::new(std::sync::atomic::AtomicBool::new(true));
let hold_read = hold.clone();
let services = Services {
read: Some(Box::new(move |p: &str| {
while hold_read.load(std::sync::atomic::Ordering::SeqCst) {
std::thread::sleep(std::time::Duration::from_millis(5));
}
std::fs::read(p).map_err(|e| e.to_string())
})),
..Default::default()
};
let mut app = VectorcraftApp::new(Session::new(), services);
app.placing.off_the_ui_thread = true;
app.run("file.new", json!({"width": 400, "height": 300})).unwrap();
let ctx = egui::Context::default();
crate::theme::install_fonts(&ctx);
assert_eq!(progress(&mut app, &ctx, 0.0), "", "nothing placing");
let slow_path = saved("progress", "slow.png", &picture(Png, 100, 100));
let p = json!({"path": slow_path, "at": [200, 150]});
start(&mut app, &p, false).unwrap();
// Not shown before DELAY (0.4 s)
assert_eq!(progress(&mut app, &ctx, 1.0), "", "not at once");
progress(&mut app, &ctx, 1.0 + crate::export_progress::DELAY + 0.05); // measures first
let texts = progress(&mut app, &ctx, 1.0 + crate::export_progress::DELAY + 0.1);
for want in ["Placing slow.png…", "Reading the file…", "Cancel"] {
assert!(texts.contains(want), "{want} in {texts}");
}
assert!(!texts.contains("Continue in Background"), "no background button in {texts}");
assert!(!texts.contains("waiting"), "{texts}");
// Another file queued shows more waiting
let next_path = saved("progress", "next.png", &picture(Png, 100, 100));
start(&mut app, &json!({"path": next_path, "at": [200, 150]}), false).unwrap();
let texts = progress(&mut app, &ctx, 2.0);
assert!(texts.contains("Placing slow.png…") && texts.contains("1 more file waiting"), "{texts}");
// Never two modals at once
app.ui.dialog = Some(crate::state::Dialog::new(crate::dialogs::save_options::KIND, json!({})));
assert_eq!(progress(&mut app, &ctx, 3.0), "", "never two modals at once");
app.ui.dialog = None;
// Release and finish
hold.store(false, std::sync::atomic::Ordering::SeqCst);
placed(&mut app);
}
/// #5930: cancelling a place aborts the operation, drops the parsed asset, leaves the document
/// completely unmodified (no undo step added, no nodes added), and clears the status bar.
#[test]
fn cancelling_a_place_places_nothing() {
let hold = Arc::new(std::sync::atomic::AtomicBool::new(true));
let hold_read = hold.clone();
let services = Services {
read: Some(Box::new(move |p: &str| {
while hold_read.load(std::sync::atomic::Ordering::SeqCst) {
std::thread::sleep(std::time::Duration::from_millis(5));
}
std::fs::read(p).map_err(|e| e.to_string())
})),
..Default::default()
};
let mut app = VectorcraftApp::new(Session::new(), services);
app.placing.off_the_ui_thread = true;
app.run("file.new", json!({"width": 400, "height": 300})).unwrap();
let before = state(&app);
let initial_names = names(&app);
assert!(!crate::menus::enabled(&app, "file.cancelPlace"));
let slow_path = saved("cancel", "slow.png", &picture(Png, 100, 100));
let p = json!({"path": slow_path, "at": [200, 150]});
start(&mut app, &p, false).unwrap();
assert!(crate::menus::enabled(&app, "file.cancelPlace"));
assert!(crate::opening::long_operation_busy(&app));
assert!(app.ui.status.starts_with("Placing"));
// Cancel the place operation
let cancelled = app.run("file.cancelPlace", json!({})).unwrap();
assert_eq!(cancelled["cancelled"], 1);
assert!(app.placing.pending.is_empty());
assert!(!crate::opening::long_operation_busy(&app));
assert!(!app.ui.status.starts_with("Placing"), "{}", app.ui.status);
assert!(!crate::menus::enabled(&app, "file.cancelPlace"));
// Let the background reader thread finish reading and drain
hold.store(false, std::sync::atomic::Ordering::SeqCst);
app.placing.wait_for_reads();
poll(&mut app);
// Document must be completely unmodified
assert_eq!(state(&app), before, "document unmodified, no undo step added");
assert_eq!(names(&app), initial_names, "no document nodes mutated or added");
assert_eq!(app.session.doc().unwrap().history.undo.len(), 0, "no undo step added");
}
/// #5930: Escape key in the progress window cancels the place operation.
#[test]
fn cancelling_a_place_via_escape_key() {
let hold = Arc::new(std::sync::atomic::AtomicBool::new(true));
let hold_read = hold.clone();
let services = Services {
read: Some(Box::new(move |p: &str| {
while hold_read.load(std::sync::atomic::Ordering::SeqCst) {
std::thread::sleep(std::time::Duration::from_millis(5));
}
std::fs::read(p).map_err(|e| e.to_string())
})),
..Default::default()
};
let mut app = VectorcraftApp::new(Session::new(), services);
app.placing.off_the_ui_thread = true;
app.run("file.new", json!({"width": 400, "height": 300})).unwrap();
let before = state(&app);
let ctx = egui::Context::default();
crate::theme::install_fonts(&ctx);
let slow_path = saved("escape", "slow.png", &picture(Png, 100, 100));
let p = json!({"path": slow_path, "at": [200, 150]});
start(&mut app, &p, false).unwrap();
// First frame initializes the timer at 1.0 s
assert_eq!(progress(&mut app, &ctx, 1.0), "", "not at once");
// Advance time past DELAY
progress(&mut app, &ctx, 1.0 + crate::export_progress::DELAY + 0.05);
let texts = progress(&mut app, &ctx, 1.0 + crate::export_progress::DELAY + 0.1);
assert!(texts.contains("Placing slow.png…"));
assert_eq!(app.placing.pending.len(), 1);
// Send Escape event
let raw_input = egui::RawInput {
events: vec![egui::Event::Key { key: egui::Key::Escape, physical_key: None, pressed: true, repeat: false, modifiers: egui::Modifiers::NONE }],
time: Some(1.0 + crate::export_progress::DELAY + 0.15),
..Default::default()
};
let _ = ctx.run_ui(raw_input, |ui| super::show(&mut app, ui.ctx()));
// Operation was cancelled
assert!(app.placing.pending.is_empty(), "place was cancelled by Escape");
hold.store(false, std::sync::atomic::Ordering::SeqCst);
app.placing.wait_for_reads();
poll(&mut app);
assert_eq!(state(&app), before, "document completely unmodified");
}
+5 -2
View File
@@ -16,7 +16,9 @@ Draft enhancement #5804: Preferences › File Handling can select a raster edito
> **Eraser fill update (2026-11-11):** filled open paths without a visible painted stroke retain fill outside the sweep or Alt-drag marquee (#6582); stroked paths retain main behavior; scores and estimates unchanged.
**Feature evidence last updated:** 2026-11-15.
**Feature evidence last updated:** 2026-11-19.
Placing a file that takes longer than 0.4 s shows a progress window with the placed file name, an indeterminate progress indicator, and a Cancel button (Escape; `file.cancelPlace`); cancelling cleanly halts the operation, clears the status bar, and leaves the document unmodified without undo steps (part of #5930). Evidence: `placing::tests::a_file_that_takes_a_while_to_place_shows_a_progress_window`, `placing::tests::cancelling_a_place_places_nothing`, and `placing::tests::cancelling_a_place_via_escape_key` in `crates/ui-egui/src/placing/tests.rs`. Scores and estimates unchanged.
> **Text thread overlay update (2026-11-11):** repeated selection lookups share an index when needed (#6543); four focused output controls passed; scores and estimates unchanged.
@@ -48,6 +50,7 @@ Artboard Options forwards the active Artboard tool's Scale Artwork with Artboard
| Date | Change | Summary |
|---|---|---|
| 2026-11-19 | minor | G12: Place: show progress window with Cancel for slow placed files exceeding 0.4 s (part of #5930, `file.cancelPlace`); indeterminate moving bar, Cancel (Esc) leaves the document unmodified without undo steps; scores and estimates unchanged. |
| 2026-11-18 | minor | G11: SVG export writes physical unit suffixes on the root <svg width="..." height="..."> for documents with physical units (mm, cm, in, pc), preventing drawings from scaling to 75% in external tools and preserving units across round-trips (#864; general unit preference on restart remains open under #864). Estimate 8–15 → 6–13 h. |
| 2026-11-18 | minor | G5: Media Controls joins Basic Shapes, UI Frames, Map Markers, Inventory Icons, Skill Icons and Weather Icons as a seventh built-in symbol library (Play, Pause, Stop, Skip Next, Shuffle, Repeat; original procedural vector symbols generated in code, no default 9-slice); estimate decremented (3–13 → 2–12 h). |
| 2026-11-18 | minor | G12: Layers panel ruler guide and blend spine row context menus (#8592): Hide/Show, Lock/Unlock, Release Guides, Delete and Locate Object on guide rows; Select, Blend Options…, Reverse Spine, Reverse Front to Back, Expand, Release and Locate Object on blend spine rows. Scores and estimates unchanged. |
@@ -526,7 +529,7 @@ macOS cursor delivery (#2292) is narrowed to a native host adapter using the exi
Estimate unchanged.
- **Done (2026-10-21, #394):** General › Constrain Angle turns the arrow keys' axes (guides stay on the page's), holds Shift drags of the Selection, Direct Selection, Free Transform, Slice Selection, Reshape and Measure tools and the Pen's handles to the turned axes, and new rectangles, rounded rectangles, ellipses, grids, point and area type, Shift-drawn polygons and stars and the shape size dialogs are drawn along it with their bounding box turned; 0° and whole turns are exactly as before, quarter turns exact (<https://helpx.adobe.com/illustrator/desktop/manage-objects/arrange-objects/rotate-objects-by-specific-angles.html>). Flares and the Pen's new paths are not turned yet. Estimate unchanged.
- **Done (2026-10-21, #394):** General › Constrain Angle turns the arrow keys' axes (guides stay on the page's), holds Shift drags of the Selection, Direct Selection, Free Transform, Slice Selection, Reshape and Measure tools and the Pen's handles to the turned axes, and new rectangles, rounded rectangles, ellipses, grids, point and area type, Shift-drawn polygons and stars and the shape size dialogs are drawn along it with their bounding box turned; 0° and whole turns are exactly as before, quarter turns exact (<https://helpx.adobe.com/illustrator/desktop/manage-objects/arrange-objects/rotate-objects-by-specific-angles.html>). Flares and the Pen's new paths are not turned yet. Estimate unchanged. **2026-10-24:** General › Corner Radius is the Rounded Rectangle tool's radius: the tool takes the preference when chosen and when it changes while the tool is active (or lent a selection tool for a drag), and the radius ↑/↓ set while drawing one, or a Tool Options value, becomes the preference, clamped to its 0–1296 pt range (<https://helpx.adobe.com/illustrator/using/drawing-simple-lines-shapes.html>). Estimate unchanged.
- **Done (2026-10-17):** Background Export shows its progress in a dialog with Cancel and Continue in Background (#2564), on the shared cancel token (#2546); a cancelled export writes no file. Save As, Export for Screens and Export Selection don't show it yet. Estimate unchanged. **2026-11-06:** opening a file that takes longer than 0.4 s shows a progress window too, with a moving bar, Cancel and Continue in Background (part of #5930); Save and Place still show only the status bar's spinner. Estimate unchanged. **2026-11-15:** a save that runs in the background shows in that window too, with a moving bar, Cancel (the file stays as it was and the document stays modified) and Continue in Background (`file.cancelSave`, `file.saveInBackground`); Place still shows only the spinner. Estimate unchanged.
- **Done (2026-10-17):** Background Export shows its progress in a dialog with Cancel and Continue in Background (#2564), on the shared cancel token (#2546); a cancelled export writes no file. Save As, Export for Screens and Export Selection don't show it yet. Estimate unchanged. **2026-11-06:** opening a file that takes longer than 0.4 s shows a progress window too, with a moving bar, Cancel and Continue in Background (part of #5930); Save and Place still show only the status bar's spinner. Estimate unchanged. **2026-11-15:** a save that runs in the background shows in that window too, with a moving bar, Cancel (the file stays as it was and the document stays modified) and Continue in Background (`file.cancelSave`, `file.saveInBackground`); Place still shows only the spinner. Estimate unchanged. **2026-11-19:** placing a file that takes longer than 0.4 s shows a progress window too, with the file name, an indeterminate moving bar and Cancel (Esc; `file.cancelPlace`: the file isn't placed and the document stays unmodified; part of #5930). Estimate unchanged.
- **Done:** quick Image Trace presets trace at once and leave the panel as it was; the Image Trace button (Control bar, Properties) opens the controls with Threshold and Advanced (Paths, Corners, Noise), as the public documentation describes (<https://helpx.adobe.com/illustrator/using/image-trace-results-optimization.html>). Other context-specific Properties gaps remain.
- **Done (2026-10-31, #394):** Units › East Asian Type is read, and Q and Ha are units. 1 Q and 1 Ha are each a
quarter of a millimetre (0.709 pt), the Japanese typesetting units: the [Illustrator Scripting Guide's
File diff suppressed because one or more lines are too long
+5 -4
View File
File diff suppressed because one or more lines are too long