mirror of
https://github.com/storytold/vectorcraft.git
synced 2026-11-19 02:03:02 +00:00
Merge pull request #8508 from dotCooCoo/perf/layer-highlight-set
Layers: a Shift-click range looks rows up in a set instead of searching them for each row
This commit is contained in:
@@ -626,12 +626,22 @@ fn highlight(s: &mut Session, p: &Value) -> Result<Value> {
|
||||
"add" | "toggle" => {}
|
||||
other => return Err(bad(C, format!("mode is set, add or toggle, not `{other}`"))),
|
||||
}
|
||||
// `rows` keeps the highlight order. With more than 8 ids, `held` holds the same rows as a set and
|
||||
// answers each lookup; with fewer, each lookup searches `rows`.
|
||||
let mut held: Option<HashSet<NodeId>> = (ids.len() > 8).then(|| rows.iter().copied().collect());
|
||||
let mut last = None;
|
||||
for id in ids {
|
||||
if mode == "toggle" && rows.contains(&id) {
|
||||
let has = held.as_ref().map_or_else(|| rows.contains(&id), |h| h.contains(&id));
|
||||
if mode == "toggle" && has {
|
||||
rows.retain(|r| *r != id);
|
||||
} else if !rows.contains(&id) {
|
||||
if let Some(h) = &mut held {
|
||||
h.remove(&id);
|
||||
}
|
||||
} else if !has {
|
||||
rows.push(id);
|
||||
if let Some(h) = &mut held {
|
||||
h.insert(id);
|
||||
}
|
||||
last = Some(id);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -167,6 +167,183 @@ fn clicking_rows_at_any_depth_highlights_them_and_sets_the_current_layer() {
|
||||
assert_eq!(document_rows(&s), vec![g.0, c.0], "document.inspect lists the rows");
|
||||
}
|
||||
|
||||
/// Run `layer.highlight` with `ids` and `mode` → (the rows it returned, the current layer), after
|
||||
/// checking that the call counted one revision and left the rows it returned highlighted.
|
||||
fn highlight_rows(s: &mut Session, ids: &[NodeId], mode: &str) -> (Vec<NodeId>, Option<NodeId>) {
|
||||
let revision = s.doc().unwrap().revision;
|
||||
let r = run(s, "layer.highlight", json!({"ids": ids.iter().map(|i| i.0).collect::<Vec<_>>(), "mode": mode}));
|
||||
let st = s.doc().unwrap();
|
||||
assert_eq!(st.revision, revision + 1, "{mode} {ids:?}");
|
||||
let rows: Vec<NodeId> = r["rows"].as_array().unwrap().iter().map(|v| NodeId(v.as_u64().unwrap())).collect();
|
||||
assert_eq!(rows, st.layer_rows, "{mode} {ids:?}");
|
||||
(rows, st.active_layer)
|
||||
}
|
||||
|
||||
/// `layer.highlight` keeps the rows in highlight order: `set` and `add` take a repeated id once,
|
||||
/// `toggle` takes an id listed twice off and on again (or on and off, and its layer becomes the
|
||||
/// current one), unknown ids and ids after the first 100,000 are dropped, rows highlighted twice
|
||||
/// stay as they are on `add`, and `toggle` takes every copy off.
|
||||
#[test]
|
||||
fn highlighting_rows_keeps_their_order_with_repeated_unknown_and_excess_ids() {
|
||||
let mut s = session();
|
||||
let (layer, sub, a, g, b, c) = tree(&mut s);
|
||||
let unknown = NodeId(9999);
|
||||
assert_eq!(highlight_rows(&mut s, &[a, g, a, unknown, c], "set"), (vec![a, g, c], Some(layer)));
|
||||
assert_eq!(highlight_rows(&mut s, &[g, b, a, b], "add"), (vec![a, g, c, b], Some(sub)));
|
||||
assert_eq!(highlight_rows(&mut s, &[c, c], "toggle"), (vec![a, g, b, c], Some(layer)));
|
||||
// `sub` goes on and off again; it was the last row added, so its layer is the current one.
|
||||
assert_eq!(highlight_rows(&mut s, &[sub, sub], "toggle"), (vec![a, g, b, c], Some(sub)));
|
||||
assert_eq!(highlight_rows(&mut s, &[a, unknown], "toggle"), (vec![g, b, c], Some(layer)));
|
||||
assert_eq!(highlight_rows(&mut s, &[], "add"), (vec![g, b, c], Some(layer)));
|
||||
assert_eq!(highlight_rows(&mut s, &[], "toggle"), (vec![g, b, c], Some(layer)));
|
||||
s.doc_mut().unwrap().active_layer = Some(sub);
|
||||
assert_eq!(highlight_rows(&mut s, &[], "set"), (vec![], Some(sub)), "no rows: the current layer stays");
|
||||
let mut excess = vec![unknown; 100_000];
|
||||
excess.push(a);
|
||||
assert_eq!(highlight_rows(&mut s, &excess, "set"), (vec![], Some(sub)), "only the first 100,000 ids count");
|
||||
s.doc_mut().unwrap().layer_rows = vec![a, a, g];
|
||||
assert_eq!(highlight_rows(&mut s, &[a, c], "add"), (vec![a, a, g, c], Some(layer)));
|
||||
assert_eq!(highlight_rows(&mut s, &[a], "toggle"), (vec![g, c], Some(layer)));
|
||||
// The same with more than 8 ids.
|
||||
s.doc_mut().unwrap().layer_rows = vec![a, a, g];
|
||||
assert_eq!(highlight_rows(&mut s, &[a, c, c, c, c, c, c, c, c], "add"), (vec![a, a, g, c], Some(layer)));
|
||||
s.doc_mut().unwrap().layer_rows = vec![a, a, g];
|
||||
assert_eq!(highlight_rows(&mut s, &[a, b, b, b, b, b, b, b, b], "toggle"), (vec![g], Some(sub)), "`b` goes on and off 4 times");
|
||||
assert_eq!(highlight_rows(&mut s, &[c, g, sub, g, sub, a, unknown, a, c, layer], "toggle"), (vec![g, layer], Some(layer)));
|
||||
let revision = s.doc().unwrap().revision;
|
||||
assert!(s.execute("layer.highlight", &json!({"ids": [b.0], "mode": "nope"})).is_err());
|
||||
let st = s.doc().unwrap();
|
||||
assert_eq!((st.revision, st.layer_rows.clone()), (revision, vec![g, layer]), "a bad mode changes nothing");
|
||||
}
|
||||
|
||||
/// `layer.highlight`'s rule as a search of the highlighted rows for each id in `p`. The tests
|
||||
/// compare the command with it.
|
||||
fn highlight_by_search(st: &mut DocState, p: &Value) -> Value {
|
||||
let mut ids: Vec<NodeId> = p["ids"].as_array().unwrap().iter().map(|v| NodeId(v.as_u64().unwrap())).collect();
|
||||
ids.truncate(crate::cmd::layer::MAX_ROWS);
|
||||
let mode = p["mode"].as_str().unwrap_or("set");
|
||||
ids.retain(|id| st.doc.node(*id).is_some());
|
||||
let mut rows = st.highlighted_rows();
|
||||
if mode == "set" {
|
||||
rows.clear();
|
||||
}
|
||||
let mut last = None;
|
||||
for id in ids {
|
||||
if mode == "toggle" && rows.contains(&id) {
|
||||
rows.retain(|r| *r != id);
|
||||
} else if !rows.contains(&id) {
|
||||
rows.push(id);
|
||||
last = Some(id);
|
||||
}
|
||||
}
|
||||
if let Some(layer) = last.or(rows.last().copied()).and_then(|id| st.doc.layer_containing(id)) {
|
||||
st.active_layer = Some(layer);
|
||||
}
|
||||
st.layer_rows = rows;
|
||||
st.revision += 1;
|
||||
json!({ "rows": st.layer_rows.iter().map(|i| i.0).collect::<Vec<_>>() })
|
||||
}
|
||||
|
||||
/// Two sessions with `n` squares on a layer and a sublayer after them, and the squares' ids.
|
||||
fn highlight_pair(n: usize) -> (Session, Session, Vec<NodeId>, NodeId) {
|
||||
let make = || {
|
||||
let mut s = super::large_edits::session(n, super::large_edits::square);
|
||||
let sub = id(&run(&mut s, "layer.newSublayer", json!({"name": "Sub"})));
|
||||
(s, sub)
|
||||
};
|
||||
let ((cmd, sub), (search, other)) = (make(), make());
|
||||
assert_eq!(sub, other);
|
||||
let squares = super::large_edits::layer(&cmd, 0).into_iter().filter(|i| *i != sub).collect();
|
||||
(cmd, search, squares, sub)
|
||||
}
|
||||
|
||||
/// `p` for `layer.highlight` with `ids` and `mode`.
|
||||
fn highlight_params(ids: impl IntoIterator<Item = NodeId>, mode: &str) -> Value {
|
||||
json!({"ids": ids.into_iter().map(|i| i.0).collect::<Vec<_>>(), "mode": mode})
|
||||
}
|
||||
|
||||
/// On 3,000 rows `layer.highlight` gives what [`highlight_by_search`] gives: the same rows in the
|
||||
/// same order, the same current layer and the same returned rows, with repeated, unknown and
|
||||
/// toggled ids.
|
||||
#[test]
|
||||
fn layer_highlight_matches_a_search_of_the_rows_for_each_id() {
|
||||
let (mut cmd, mut search, sq, sub) = highlight_pair(3_000);
|
||||
let unknown = NodeId(u64::MAX);
|
||||
let steps = [
|
||||
highlight_params(sq[..2_000].iter().copied(), "set"),
|
||||
highlight_params(sq[1_000..].iter().copied().chain([sub, sq[0]]), "add"),
|
||||
highlight_params([sq[5], sq[5], sub, sq[2_999], unknown, sub, sub], "toggle"),
|
||||
highlight_params(sq[500..520].iter().chain(&sq[510..515]).copied(), "toggle"),
|
||||
highlight_params(sq.iter().rev().step_by(7).copied(), "add"),
|
||||
highlight_params(sq.iter().step_by(3).copied().chain([sub]), "toggle"),
|
||||
highlight_params(Vec::new(), "add"),
|
||||
highlight_params(sq.iter().rev().step_by(2).chain(&sq[..10]).copied(), "set"),
|
||||
highlight_params(Vec::new(), "set"),
|
||||
];
|
||||
for p in &steps {
|
||||
let r = run(&mut cmd, "layer.highlight", p.clone());
|
||||
let expected = highlight_by_search(search.doc_mut().unwrap(), p);
|
||||
let (a, b) = (cmd.doc().unwrap(), search.doc().unwrap());
|
||||
assert_eq!(r, expected, "{}", p["mode"]);
|
||||
assert_eq!((&a.layer_rows, a.active_layer, a.revision), (&b.layer_rows, b.active_layer, b.revision), "{}", p["mode"]);
|
||||
}
|
||||
}
|
||||
|
||||
/// Time `layer.highlight` against [`highlight_by_search`] on one layer of 20,000 paths: `set` of
|
||||
/// all of them, `add` of 10,000 already highlighted and `toggle` of one, 7 runs each, both checked
|
||||
/// to give the same rows and current layer.
|
||||
/// Run with `cargo test --release -p vectorcraft-engine --lib layer_highlight_timing -- --ignored --nocapture`.
|
||||
#[test]
|
||||
#[ignore = "manual timing probe; wall-clock performance depends on machine load"]
|
||||
fn layer_highlight_timing() {
|
||||
let (mut cmd, mut search, sq, _) = highlight_pair(20_000);
|
||||
let steps = [
|
||||
("set of 20,000", highlight_params(sq.iter().copied(), "set")),
|
||||
("add of 10,000", highlight_params(sq[5_000..15_000].iter().copied(), "add")),
|
||||
("toggle of 1", highlight_params([sq[10_000]], "toggle")),
|
||||
];
|
||||
let mut ms = vec![(Vec::new(), Vec::new()); steps.len()];
|
||||
for run_no in 0..7 {
|
||||
for (i, (_, p)) in steps.iter().enumerate() {
|
||||
let mut time_cmd = || {
|
||||
let start = std::time::Instant::now();
|
||||
let r = cmd.execute("layer.highlight", p).unwrap();
|
||||
(start.elapsed().as_secs_f64() * 1000.0, r)
|
||||
};
|
||||
let mut time_search = || {
|
||||
let start = std::time::Instant::now();
|
||||
let r = highlight_by_search(search.doc_mut().unwrap(), p);
|
||||
(start.elapsed().as_secs_f64() * 1000.0, r)
|
||||
};
|
||||
// Alternate which goes first.
|
||||
let ((tc, rc), (ts, rs)) = if run_no % 2 == 0 {
|
||||
let c = time_cmd();
|
||||
(c, time_search())
|
||||
} else {
|
||||
let s = time_search();
|
||||
(time_cmd(), s)
|
||||
};
|
||||
assert_eq!(rc, rs);
|
||||
let (a, b) = (cmd.doc().unwrap(), search.doc().unwrap());
|
||||
assert_eq!((&a.layer_rows, a.active_layer), (&b.layer_rows, b.active_layer));
|
||||
ms[i].0.push(ts);
|
||||
ms[i].1.push(tc);
|
||||
}
|
||||
}
|
||||
let median = |v: &[f64]| {
|
||||
let mut v = v.to_vec();
|
||||
v.sort_by(f64::total_cmp);
|
||||
v[v.len() / 2]
|
||||
};
|
||||
for ((name, _), (search_ms, cmd_ms)) in steps.iter().zip(&ms) {
|
||||
println!(
|
||||
"{name}: search {:.3} ms, command {:.3} ms (median of 7); search runs {search_ms:.3?}, command runs {cmd_ms:.3?}",
|
||||
median(search_ms),
|
||||
median(cmd_ms)
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
fn document_rows(s: &Session) -> Vec<u64> {
|
||||
crate::inspect::document(s)["layerRows"].as_array().unwrap().iter().map(|v| v.as_u64().unwrap()).collect()
|
||||
}
|
||||
|
||||
@@ -1,3 +1,6 @@
|
||||
use std::collections::HashSet;
|
||||
use std::hash::Hash;
|
||||
|
||||
use super::{Paint, Rect, Response, Stroke, StrokeKind, Tokens, Ui, Vec2};
|
||||
|
||||
/// What panels drag onto art and onto each other. One payload type, so the canvas has one drop
|
||||
@@ -159,10 +162,11 @@ pub fn row_click<K: Copy + PartialEq>(order: &[K], highlighted: &[K], anchor: Op
|
||||
/// Apply `click` to the `highlighted` rows, kept in highlight order as `layer.highlight` keeps the
|
||||
/// Layers panel's: a toggled row is appended (or taken off, even the last one), a range replaces the
|
||||
/// rows or adds those not there yet, top-down.
|
||||
pub fn apply_row_click<K: Copy + PartialEq>(highlighted: &mut Vec<K>, click: &RowClick<K>) {
|
||||
pub fn apply_row_click<K: Copy + Eq + Hash>(highlighted: &mut Vec<K>, click: &RowClick<K>) {
|
||||
let add = |rows: &mut Vec<K>, add: &[K]| {
|
||||
let mut held: HashSet<K> = rows.iter().copied().collect();
|
||||
for k in add {
|
||||
if !rows.contains(k) {
|
||||
if held.insert(*k) {
|
||||
rows.push(*k);
|
||||
}
|
||||
}
|
||||
@@ -292,4 +296,29 @@ mod row_click_tests {
|
||||
assert_eq!(applied(vec![50], RowClick::Range(vec![20, 30])), [20, 30]);
|
||||
assert_eq!(applied(vec![30, 50], RowClick::AddRange(vec![20, 30, 40])), [30, 50, 20, 40]);
|
||||
}
|
||||
|
||||
/// A large range gives the rows a search of the highlighted rows for each id gives, in the same
|
||||
/// order, with repeated ids and rows already highlighted kept once.
|
||||
#[test]
|
||||
fn a_large_range_applies_as_a_search_of_the_rows_for_each_id_does() {
|
||||
let searched = |mut rows: Vec<u32>, range: &[u32]| {
|
||||
for k in range {
|
||||
if !rows.contains(k) {
|
||||
rows.push(*k);
|
||||
}
|
||||
}
|
||||
rows
|
||||
};
|
||||
let mut range: Vec<u32> = (0..5_000).collect();
|
||||
range.extend([7, 4_999, 0]);
|
||||
let before = vec![4_000, 9_000, 2, 9_000];
|
||||
let mut added = before.clone();
|
||||
apply_row_click(&mut added, &RowClick::AddRange(range.clone()));
|
||||
assert_eq!(added, searched(before.clone(), &range));
|
||||
assert_eq!(added.len(), 5_002, "the 5,000 ids, the row outside the range and its repeat");
|
||||
let mut set = before;
|
||||
apply_row_click(&mut set, &RowClick::Range(range.clone()));
|
||||
assert_eq!(set, searched(Vec::new(), &range));
|
||||
assert_eq!(set.len(), 5_000);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1491,6 +1491,7 @@ Moved from the ROADMAP's "Shipped so far" on 2026-10-10. Update it when a featur
|
||||
Layer Options for several highlighted rows shows the first row's settings, and OK changes only the settings set in the dialog: each row keeps its own color, Template, Lock, Show, Print, Preview and Dim Images otherwise (`crates/ui-egui/src/dialogs/layer_options.rs` tests).
|
||||
As VectorCraft's own rule, a layer color (`layer.setProps`, `layer.new`, `layer.newSublayer`) or a Live Paint Gap Preview Color (`livePaint.gapOptions`) given as a hex color with an alpha part (`#rrggbbaa` or `#rgba`) is an error and changes nothing, instead of being set without its alpha. Regression tests: `a_layer_color_with_an_alpha_part_is_refused` in `crates/engine/src/tests/layers.rs` and `a_gap_color_with_an_alpha_part_is_refused` in `crates/engine/src/tests/build.rs`.
|
||||
Panel Options › Locate Selected Objects (beyond Illustrator, off by default): when the last selected object changes on the canvas or by a command, the panel opens the layers and groups around it and scrolls to its row, as Locate Object does, without highlighting the row; when Show Layers Only, a search or the filter leaves the object without a row, the panel opens no rows for it and scrolls as with the option off.
|
||||
When more than 8 of its ids name objects in the document (after the list is cut to 100,000), `layer.highlight` in each mode (`set`, `add` and `toggle`) looks each row up in a set of the highlighted rows instead of searching the highlighted rows once for each row; with 8 or fewer it searches them. The Layers panel's preview of a Shift-click or Shift+Ctrl/Cmd-click range, before it sends the command, always looks the rows up in a set. The work grows in step with the number of rows. The rows, their order, the returned rows and the current layer are the same as before. Tests: `tests::layers::layer_highlight_matches_a_search_of_the_rows_for_each_id`, `tests::layers::highlighting_rows_keeps_their_order_with_repeated_unknown_and_excess_ids` and `widgets::drag::row_click_tests::a_large_range_applies_as_a_search_of_the_rows_for_each_id_does`; timing: `cargo test --release -p vectorcraft-engine --lib layer_highlight_timing -- --ignored --nocapture`.
|
||||
With Panel Options › Show Layers Only on, Locate Object is named Locate Layer and highlights the layer that holds the selected object instead of the object's own row, which that mode does not list (help page: https://helpx.adobe.com/illustrator/desktop/manage-layers/create-and-organize-layers/locate-objects-in-the-layers-panel.html). As VectorCraft's own rules, the bottom bar's button and a row's menu are renamed too, the innermost sublayer holding the object is the one highlighted, a layer row locates itself, and the panel opens the layers around it. Locate Object or Locate Layer run again on the row it already highlighted opens the layers around that row again and scrolls to it, VectorCraft's own rule (`locate_layer_highlights_the_layer_holding_the_object` in `crates/engine/src/tests/layers.rs`, `with_show_layers_only_locate_object_becomes_locate_layer` and `a_repeated_locate_reveals_the_row_it_already_highlighted` in `crates/ui-egui/src/panels/layers/tests.rs`).
|
||||
With several objects selected, Locate Object (and Locate Layer) finds the one frontmost in the stacking order, not the one selected last (help page: https://helpx.adobe.com/illustrator/desktop/manage-layers/create-and-organize-layers/locate-objects-in-the-layers-panel.html). Objects on different layers and sublayers are compared by the layers' order. As VectorCraft's own rules, a member selected along with its group counts as in front of the group, and an `id` given to `layer.locate` still wins (`locate_object_finds_the_frontmost_selected_object` in `crates/engine/src/tests/layers.rs`).
|
||||
- **Drawing aids:** Smart Guides and snapping (moving, with the Selection, Group Selection or Direct Selection tool, and resizing by the bounding-box handles with the Selection or Free Transform tool, Shift and Alt too: the dragged corner or side lands on the other objects' anchors and centres ("anchor", "center") or lines up with their edges and centres (a line and "align"); with Smart Guides › Spacing Guides, a moved selection that lines up with nothing along an axis lands as far from its neighbour as two other objects of its row or column are apart, or halfway between its two neighbours, the equal gaps marked; with View › Snap to Grid on, a moved selection lands on the grid instead, by whichever of its edges is nearest a gridline on each axis (the center does not snap), #740, #1816; the Rotate, Scale, Shear and Reflect tools drag from the anchor they grab and snap the pointer the same way, so a corner dragged onto another object's anchor scales exactly onto it, #482; anchors dragged with Direct Selection: the one pressed on lands on other anchors, its own path's that stay put among them, on path segments or in line with them, the others following, Shift keeps 45° steps, and with Smart Guides off Snap to Point pulls it onto anchors; the Artboard tool snaps artboards, and their bleed, to other artboards, bleeds and art, the grid or whole pixels while moving, copying and resizing them, and the Transform panel shows and edits the active artboard's X/Y/W/H; drawn points, #506: hovering shows where the press goes, the point lands on the other objects' anchors, centres and paths ("anchor", "center", "path") or lines up with their anchors, edges and centres ("align"), the Pen's on the path being drawn too, near a construction guide through the anchor before it on that guide (Preferences › Smart Guides › Construction Guides and Angles), and with Shift kept to its 45° step or a square's diagonal it slides along that way into line; the targets are gathered once per document state, from the art in the window, and the anchors, centres and lines near the pointer are found by bisection, so hovering never rescans the document), guides dragged out of the rulers (#451: they snap as moved guides do, Shift to the ruler's ticks; with the Artboard tool they are artboard guides, which run across their artboard only and move, copy and delete with it, `guide.add {artboard}`) that the Selection, Direct Selection and Group Selection tools then pick and drag (#414: the selected guides highlight and move together, Alt copies them, Shift snaps the dragged one to the ticks, otherwise it snaps to pixels, the grid or the edges, centres (so the sides' midpoints) and anchors of the art and the artboards, or with Smart Guides off Snap to Point pulls it onto anchors; Shift-clicked they join the selected art, and Shift-added art keeps them, so guides and art are selected together in either order, Delete then deleting both in one step; the arrow keys nudge them, Delete deletes them, dragging one back onto its ruler deletes it, Lock Guides and Hide Guides leave them alone; `guide.list`, `guide.select`, `guide.move` and `guide.remove` reach agents), a right-click on either ruler or the origin box to pick the document's units (the current one checked; `document.setUnits`, one undo step, #528), and Draw Normal / Behind / Inside modes. Smart Guides: a point drawn with the Pen or a shape tool, and an anchor dragged with Direct Selection, snaps to where paths and ruler guides cross, labelled "intersect" (#1658, part of #1602; a moved selection's own anchors don't, except the anchor the Selection tool grabbed it by). A selection the Selection tool grabs by one of its anchors snaps that anchor onto the other objects' paths ("path"), and where a path crosses another path or a ruler guide ("intersect"), in the order Direct Selection uses for a dragged anchor; when the anchor lands on a path, the selection's bounds do not also line up with other objects (#7411). The archived 2007 [user guide](https://help.adobe.com/archive/en_US/illustrator/cs3/illustrator_cs3_help.pdf#page=55) (page 49) says Smart Guides align the pointer of a moved object to existing paths. Snapping onto paths only when the selection was grabbed by an anchor is VectorCraft's own rule; a selection grabbed anywhere else still lines its bounds up. Tests: `select::tests::a_move_grabbed_by_an_anchor_lands_it_on_another_path`, `a_move_grabbed_by_an_anchor_lands_it_where_paths_cross` and `a_move_grabbed_by_an_anchor_lands_it_where_a_path_crosses_a_ruler_guide`. With Smart Guides › Measurement Labels on, the Line Segment tool labels the segment being drawn with its distance, angle and X and Y offsets (`D`, `Angle`, `dX`, `dY`), and the Pen, Curvature and Smart Pen tools label their rubber band the same way when Enable Rubber Band is on (#2983).
|
||||
|
||||
Reference in New Issue
Block a user