The Symbols panel and its panel menu asked for the current symbol on
every frame by running symbol.list, which builds a row per symbol and
walks the whole document once per symbol to count its instances. They
now read it from the active document with cmd::current_symbol, the
rule symbol.list itself uses for its `current`: the stored name while
a symbol has it, else the first symbol. symbol.sortByName,
symbol.place, symbol.options and text.insertInline use the same
function, and symbol.list's reply is unchanged.
An idle frame of the panel or its menu now runs no command, so on
macOS the native menu is not brought up to date on every frame while
the panel is open. In a document with 200 symbols and 50,000 objects
the read takes 0.035 us instead of 48.5 ms in a release build (thread
CPU time on Linux, median of 7 runs). The gain matters on large
documents; on small ones it is too small to notice.
The XML declaration, DOCTYPE entity subset and root <svg> open now go
through SvgWriter. Mapping and the rest of the document stay in the app.
Width and height stay unitless in one place so #7105 can rebase.
xtask pdf-deps still expected craft-pdf and the patched hayro/krilla
backends at main's 9be9a637 revision after this branch pinned them to
a499742a. Point REV at that pin (still on craft-libs main). Classify
test files in sonar-project.properties the way craft-libs does, so the
quality gate measures the product. Give the EPS operation-budget test
the same 300s cap as the other budget tests; under instrumented coverage
it overran the old 120s cap, while the Ubuntu gate finished in time.
header_size now reads a BMP BITMAPINFOHEADER when the probes refuse the file,
so Paste of a 30,000² poked header reports "too large to draw" instead of
that the size can't be read. through_jpeg encodes with the image crate again
so the block-artifact trace test stays calibrated; the JPEG writer is still
on main's code. Also use a no-break space before ":" in three French typography
rows (unchanged from main) so the catalog check is green.
decode_within mapped every LimitExceeded to Ok(None) ("oversized, accept
unread"). craft-image-codecs raises that for its decompression-bomb guard
when a tiny file declares a large image, so Place accepted a header-only
23,170² gray PNG instead of reporting that its pixels can't be read.
Ok(None) now only when the header says the image would take more than the
allowance as samples or as RGBA. A decode that hits a limit stays an error.
A stored texture longer than the codec's default 2^18-pixel side still
reads back, and a gray PNG is not expanded to RGBA just to get its
levels. The AI writer and the EPS scene refuse an oversized image from
its header, then decode within MAX_IMAGE_PIXELS, keeping the pixels at
their stored depth. Flatten's see-through check uses ImageBlob's
allowance, and links.unembed decodes within MAX_RASTER_ALLOC.
Embedded and linked images read their pixels with decode_within: the
size from the header against the allowance first (as samples and as
RGBA, #1717), then the pixels as stored. map_rgb, sampling, coverage,
link previews and checked_with_pixels all go through it.
decoded_pixels_are_those_the_image_crate_read compares PNG, GIF, WebP,
TIFF and BMP at each depth the image crate writes with its pixels, and
JPEG within two steps, including the pixels checked_with_pixels hands
on. The 11,586² allowance test is a compact PNG; craft-image-codecs
refuses a GIF whose unbacked logical screen is past 256 MiB.
The decoding File › Open, Place and the renderer share moves to
vectorcraft-doc (decode.rs: decode_image, decoded_layout), and SVG
import's images read through it: the size from the header against the
allowance first, then the pixels as stored with the profile the file
embeds (a TIFF's still read by the TIFF reader).
decoded_pixels_are_those_the_image_crate_read compares PNG, GIF, WebP,
TIFF and BMP at each depth the image crate writes with its pixels, and
JPEG within two steps.
The raster path tells formats with craft-image-codecs' detect, reads the
size from the header (vectorcraft-doc's header_size, the renderer's
decoded_layout, a Targa's own header) and decodes with the renderer's
decode_image, the pixels as stored, with the profile the file embeds.
The size notes Open, Place and the Links panel give, and Glass's Load
Texture, read the same way.
opened_rasters_are_the_pixels_the_image_crate_read compares BMP, TGA and
TIFF at 8 and 16 bits, gray and color, with and without alpha, with the
image crate's pixels, and PNG, JPEG, GIF and WebP stored as they are.
Type is drawn as its outlines, so each copy that a fill's or stroke's own
Transform effect makes of type carries the raster effects listed before
it, as a path's copies do. A test checks this for the fill's first
Transform effect and for one listed after a Transform effect with
Transform Patterns on, drawn, expanded and baked.
The progress doc now lists type as covered, states when a later copying
Transform effect does not carry the raster effects before it, drops the
fill or stroke case from the older entry's limitation, and puts the
Rasterize entry back on its own line.
craft-libs main with the JPEG inks reader vectorcraft-doc's CMYK JPEGs use
(#1779) and the craft-jpeg fallback for frames zune-jpeg panics on
(#1782). Cargo.lock regenerated.
Backspace during a press removed the vertex the press had set but left the
press marked as owning a vertex, so a dropped press then removed the vertex
before it. Removing a vertex now clears that mark.
Main now stores a line's or label's added rows by kind (Keep::Kinds),
rewritten paint and row attributes (capture_line_row_writes) and no-op
reorders the way this branch did, so its versions are kept. The branch
adds on top: a stroke painted on a line after its kind lost its stroke
keeps that line's weight, a pasted graph's axis and ring line rows follow
a renamed swatch, and the paint.swap params text says only what the swap
changes is stored.
The renderer's image paint reads sizes from the header (vectorcraft-doc's
header_size, craft-image-codecs' inspect_raster) and decodes through
craft-image-codecs, the pixels as stored, for the formats it drew
before (PNG, JPEG, GIF, WebP, TIFF and BMP). A test compares the pixels
with the image crate's for each PNG color type and depth, palettes and
1-bit gray, GIF, WebP, TIFF, BMP and JPEG.
The JPEG writer goes back to main's jpeg-encoder one: the craft-image-codecs
version wrote a CMYK JPEG's resolution in a little-endian EXIF of another
layout, failing the tests of main's #3084 fix. TIFF LZW strips stay on
craft-stream-codecs, checked against weezl (now a dev-dependency): read
back the same and never larger.
A clipping object written as art cut to it (a group, an image, a symbol
instance, a live object, type, or a path inside art already cut to
another clipping object) lost its name, opacity mask and variable
bindings in the editing data: no written object carried its dictionary,
and a painted one put its name on each of its fill and stroke objects.
The unpainted path that carried its text wrap options now carries its
whole dictionary, in the form the .ai reader reads (art_dictionary in
crates/eps/src/import/ai/read/document.rs). Its fills and strokes keep
only the opacity mask they are drawn through. The path is admitted by
the object count, so at the object limit its dictionary is never left
on the object before it, and a path whose dictionary comes out empty is
taken out again.
Since main leaves rows with no current colors out of the Edit tab, Save
All Colors and the Color Theme Picker, a color the Add Color tool added
(also a row with no current colors) lost its bar and its place in the
color group. Such a row, marked `added`, is no longer counted as an
empty New Row row, so it stays on the Edit tab and in the group.