Commit Graph
14791 Commits
Author SHA1 Message Date
FredApps 827667a321 refactor(codecs): read header sizes and write DIB PNGs with craft-image-codecs
header_size reads every format's header through craft-image-codecs
(probe_allocation_size: stored size with no limit; a GIF's logical
screen through probe_size), no longer through the image crate's
readers. Metafile DIBs are written as PNG by craft-image-codecs.
2026-11-15 22:34:00 +01:00
FredApps 48a8f2a464 Merge remote-tracking branch 'origin/main' into feat/cutover-remaining-codecs 2026-11-15 22:16:07 +01:00
FredApps 0f2cb22ce7 chore(codecs): keep craft-image-codecs on craft-libs main (d6cd7836d)
b3b8521ab isn't on craft-libs main. Its probe_stored_size was only needed for
DXF image sizes, which vectorcraft_doc::header_size already reads from PNG,
JPEG, BMP and TIFF headers.
2026-11-15 21:18:51 +01:00
FredAppsandFredApps bb218101c9 cad: export DXF through craft-dxf's drawing writer (#7847)
* cad: export DXF through craft-dxf's drawing writer

Delete the local ASCII writer and map the document through
craft_dxf::drawing. Public vectorcraft_cad::export, DxfOptions and
DxfVersion stay so vectorcraft#3068 can rebase without a writer API
change. Pin craft-dxf at the craft-libs#1588 branch tip; update the
rev after that PR merges. Golden files lock shapes_doc() bytes for
R12 and 2018 against the old writer. Part of storytold/craft-libs#791
and #778.

* cad: pin craft-dxf to the #1588 tip with Dylan's writer fixes

Point craft-dxf (and craft-codepage from the same rev) at
0b6244f2b9971deaeb6a79d932c818ff94479757, which includes the
Windows golden line-ending fix, BYBLOCK and image-dictionary
key changes, and the compile fix for the dictionary-key test.
Update the pin again to the merge commit after #1588 lands.

* cad: pin shared DXF writer to merged craft-libs #1588

---------

Co-authored-by: FredApps <FredApps@users.noreply.github.com>
2026-11-15 21:07:18 +01:00
FredApps caa62aa79f Merge remote-tracking branch 'origin/main' into work7669 2026-11-15 21:06:46 +01:00
FredApps 8ce8ae076e Merge remote-tracking branch 'origin/feat/cutover-remaining-codecs' into work7669
# Conflicts:
#	crates/cad/src/scene.rs
2026-11-15 21:06:41 +01:00
FredApps 33b5706c7a Merge pull request #7664 from storytold/fix/restore-codec-cutover-ci
Restore shared codec cutover with CI compatibility fixes
2026-11-15 21:05:52 +01:00
BFlat e34fef895f Merge pull request #7732 from ruchirguitar/feat/swatches-item-context-menu
Swatches: add right-click context menu to swatch items
2026-11-16 02:30:51 +07:00
Dylan M. Taylor e3cbc0418b Retain complete JPEG encoder license and source notices 2026-11-15 19:06:56 +00:00
Dylan M. Taylor 9c833595ed Use stored raster preflight for DXF PNG and JPEG images 2026-11-15 19:01:49 +00:00
BFlat 957397e7a1 Merge pull request #7710 from dotCooCoo/feat/packaging-fold-roles
Packaging Tools: Make … Line gives paths a fold line role that their swatch carries
2026-11-16 01:35:03 +07:00
BFlat 9776feb15c Merge pull request #7887 from dotCooCoo/fix/aligned-effect-indices-unmatched
Effects: removing or duplicating several aligned effects of a design's art refuses one that no object has
2026-11-16 01:34:54 +07:00
BFlat 6080a8a87f Merge pull request #7886 from dotCooCoo/fix/span-gradient-stroke-row
Gradients: a gradient spanning the selection on a lower stroke fits the box that stroke paints
2026-11-16 01:34:45 +07:00
BFlat 39336f44d9 Merge pull request #7863 from dotCooCoo/feat/diacritic-position
Type: Adjust Horizontal and Vertical Diacritic Position move marks off their letters
2026-11-16 01:34:36 +07:00
BFlat 689d60d5b8 Merge pull request #7891 from dotCooCoo/fix/plain-paste-merged-swatch-label-contrast
Paste: Paste without Formatting sets pie legend label contrast from merged swatch colors
2026-11-16 01:34:28 +07:00
BFlat 38aec2b2fb Merge pull request #7797 from dotCooCoo/fix/outlined-strokes-under-a-non-uniform-type
Type: outlined strokes on unevenly scaled type keep their thickness in each direction
2026-11-16 01:34:20 +07:00
BFlat ad03b850a5 Merge pull request #7851 from dotCooCoo/fix/intertwine-hit-walk-limit
Selection: an Intertwine group's members in symbol art count toward a click's object limit
2026-11-16 01:34:11 +07:00
BFlat f8af52bba1 Merge pull request #7790 from dotCooCoo/fix/directional-pixel-effects-before-a-rotating-or
Effects: directional pixel effects before a rotating or reflecting Transform effect keep their angle
2026-11-16 01:34:02 +07:00
BFlat 6c0c5fa031 Merge pull request #7861 from dotCooCoo/fix/one-point-brush-continuation-keep-selected
Brushes: a one-point brush.freehand continuation follows keepSelected
2026-11-16 01:33:54 +07:00
BFlat 54d20b303c Merge pull request #7860 from dotCooCoo/feat/variables-data-set-box-rename
Variables: the Data Set box renames the current data set
2026-11-16 01:33:45 +07:00
BFlat 1add7b2643 Merge pull request #7858 from dotCooCoo/fix/symbol-controls-spacer-keeps-transform-room
Control bar: symbol instance controls keep the Transform link's room in a narrow bar
2026-11-16 01:33:37 +07:00
BFlat 0be78d03a3 Merge pull request #7885 from dotCooCoo/fix/radial-blur-center-clamped-field
Effects: Radial Blur's dialog sends a saved Blur Center outside the bounds at the edge
2026-11-16 01:33:27 +07:00
BFlat f4f0c49501 Merge pull request #7892 from dotCooCoo/fix/psd-cut-short-slices-warn
PSD: a slices resource cut short warns that the slices were left out
2026-11-16 01:33:18 +07:00
BFlat a1ec9d7e84 Merge pull request #7852 from dotCooCoo/feat/3d-panel-export-3d-object
3D and Materials: Export 3D Object adds the selection to Asset Export
2026-11-16 01:33:09 +07:00
BFlat b759c9e369 Merge pull request #7874 from dotCooCoo/fix/pdf-dont-include-profiles-removes-image-profiles
PDF export: a set Don't Include Profiles removes image color profiles
2026-11-16 01:33:00 +07:00
BFlat a156cf31f7 Merge pull request #7859 from dotCooCoo/fix/peek-stays-until-pointer-moves
Window: panels shown from the edge hide only after the pointer moves away or a hold ends
2026-11-16 01:32:51 +07:00
BFlat 57e573d914 Merge pull request #7880 from dotCooCoo/fix/drop-target-import-dialogs
Place: an import dialog a drop opened places in the document the file was dropped on
2026-11-16 01:32:43 +07:00
BFlat eaadc48d5a Merge pull request #7835 from dotCooCoo/feat/contextual-task-bar-smooth-free-transform
Contextual Task Bar: the Smooth tool shows its Fidelity and Tool Options
2026-11-16 01:32:29 +07:00
BFlat e1f8a15d61 Merge pull request #7855 from dotCooCoo/fix/live-paint-shift-triple-click-joined-faces
Live Paint: test that a Shift-triple-click keeps joined faces of the same fill
2026-11-16 01:32:15 +07:00
BFlat adc0b1ca98 Merge pull request #7876 from dotCooCoo/fix/mcp-queued-psd-import-options
Docs: queued PSD files ask for their import options with Show Import Options on
2026-11-16 01:32:02 +07:00
BFlat 351e9cfe1e Merge pull request #7856 from dotCooCoo/fix/pdf-knockout-overprint-isolation
PDF import: an isolated group with overprinting art inside stays isolated
2026-11-16 01:31:50 +07:00
BFlat a505c34ceb Merge pull request #7853 from dotCooCoo/fix/svg-blur-by-direction
SVG import: a blur that differs by direction is kept as its SVG filter
2026-11-16 01:31:37 +07:00
BFlat fa7e26aa11 Merge pull request #7882 from dotCooCoo/fix/variable-options-fills-unset-field
Variables: Variable Options fills the field left unset after the Variable changes
2026-11-16 01:31:28 +07:00
BFlat 20e577fe45 Merge pull request #7758 from dotCooCoo/feat/recolor-find-colors
Recolor Artwork: Find shows the selected rows' art and dims the rest
2026-11-16 01:31:19 +07:00
BFlat fe5787405e Merge pull request #7879 from dotCooCoo/fix/screens-artboard-name-keys
Export for Screens: artboard name fields close on a first-frame key and commit when another opens
2026-11-16 01:31:09 +07:00
BFlat f23d7f9d00 Merge pull request #7744 from ruchirguitar/feat/4936-check-spelling-dialog
feat(ui): implement Check Spelling modal dialog (#4936)
2026-11-16 01:31:00 +07:00
FredApps 9d4ac63a91 Merge remote-tracking branch 'origin/main' into work7669 2026-11-15 19:01:36 +01:00
FredApps 3e8f03962b Merge remote-tracking branch 'origin/fix/restore-codec-cutover-ci' into work7669 2026-11-15 19:01:25 +01:00
FredApps b652c6697c fix(codecs): keep main's behaviour where the cutover changed it
- EPS CCITTFaxDecode goes back to hayro-ccitt (main's filters.rs and data.rs):
  craft-stream-codecs decodes /K -1 /Columns 70 data to other rows
  (eps import::tests_images::ccitt_fax_images_draw). DCTDecode is main's again.
- The AI editing writer decodes through the image crate again: going through
  RGBA8 lost 16-bit sources, so their 8-bit warning disappeared
  (ai_editing::tests::sixteen_bit_images_are_written_at_eight_bits).
- Crop Image refuses an image over its allowance by header size again, with
  main's "an image of W × H pixels is too large to draw" message.
- Test fixes: colorized_images writes its gray PNGs gray again, and the PDF
  16→8-bit test expects rounding, as the 8-bit copy is made.
2026-11-15 19:01:25 +01:00
ruchirguitar 18bfc1239b G12: confirm context-menu swatch deletion
Reuse the panel deletion helper so the clicked swatch is deleted only after confirmation. Cover confirmation text, cancellation, clicked-item targeting and Undo across all five views. All 39 Swatches tests and all 13 local CI gates pass; fresh deep CodeRabbit review reports zero findings.
2026-11-15 23:25:36 +05:30
Dylan M. Taylor abe90db45a Cover PNG transparency keys in opaque outline decoding 2026-11-15 17:42:47 +00:00
Dylan M. Taylor 2ad5fa1734 Preserve renderer source limits for streaming PNG reduction 2026-11-15 17:41:07 +00:00
FredApps 59ddf705b9 fix(codecs): read image sizes from headers for PNG, JPEG and TIFF again
craft_image_codecs::probe_size only reads WebP, EXR and the GIF/BMP/TGA family;
for PNG, JPEG and TIFF it returns Unsupported. The cutover used it for header
sizes, so DXF export left every PNG out (cad tests), plugin objects lost PNG
pixels, and EPS image-mask and SVG import fell back to decoding whole images to
learn their size. vectorcraft_doc::header_size reads PNG's IHDR and a JPEG's
frame through craft-image-codecs and other formats through the image crate's
header readers, as main does, without decoding pixels. The SVG filter's JPEG
size comes from jpeg_info instead of a full decode.
2026-11-15 18:35:21 +01:00
FredApps 31658546a8 fix(codecs): build the cutover against craft-libs d6cd7836d
- Test files whose image→craft-image-codecs rewrites didn't compile against
  main's newer tests go back to main's versions (engine fileio/tests.rs,
  tests_tiffbmp.rs, tests/menucmds.rs, eps tests.rs); they still use the image
  crate, which keeps its format features.
- craft_jxl::encode, craft_image_codecs::encode and Image::icc at d6cd7836d.
- jp2read and pdf export pass DecodeOptions, not Limits.
- EPS DCTDecode: grey JPEGs no longer use the image after moving it, and keep
  main's one-channel output.
- svg keeps its direct usvg dependency for main's image href code; pdf keeps
  jpeg-encoder for CMYK JPEGs.
- clippy -D warnings and rustfmt clean.
2026-11-15 18:05:45 +01:00
BFlat 5bd8acfce9 Merge pull request #7762 from dotCooCoo/feat/3d-classic-track-cube
3D (Classic): the track cube turns the object on the Rotation tab
2026-11-16 00:04:07 +07:00
BFlat a391dedfe5 Merge pull request #7875 from dotCooCoo/fix/live-paint-bucket-click-history
Live Paint: Bucket double-click and triple-click match the paint from before a drag, a view-tool press or a joined edge
2026-11-15 23:56:28 +07:00
BFlat cf34cf8ed0 Merge pull request #7829 from dotCooCoo/fix/shadow-validation-builds-its-shadow-geometry
3D: shadow validation casts from the solids it checks
2026-11-15 23:56:19 +07:00
dotCooCoo dc8054fb39 PSD: a slices resource cut short warns that the slices were left out
When image resource 1050 declared more bytes than the image resources
hold, the lookup stopped as if the file stored no slices, and Open and
Place brought the artwork in without the warning that the slices were
left out. The new psdread::resource tells a cut-short resource 1050
apart from one that is absent or that follows another block cut short,
and the slices reader passes that error on, so the warning names it.
Other resource readers keep their behavior.
2026-11-15 08:45:10 -08:00
dotCooCoo cdd4078907 Paste: Paste without Formatting sets pie legend label contrast from merged swatch colors
Paste without Formatting sets each pie legend label in a wedge to white or
black from the wedge colors before it pastes, but a wedge linked to a global
swatch that the document gives another color takes the document's color
only during the paste (swatchConflict "merge", the default). A light wedge
merged into a dark swatch kept a black label, and a later redraw turned it
white.

The copied colors linked to merged swatches now take the document's color
before the labels are set, so the labels match what a redraw sets. Graphic
style links are left for the paste to relink.
2026-11-15 08:42:15 -08:00
dotCooCoo 0cf2aa3f79 Effects: removing or duplicating several aligned effects of a design's art refuses one that no object has
With the art of a graph design in a series given first and aligned: true,
effect.remove and effect.duplicate with `indices` skipped an effect of the
art that no other object has, and edited the others. With art [shadow,
roughen], a mark [shadow] and indices [0, 1], effect.remove took the
mark's shadow off and succeeded. Such an edit is now an error that leaves
the document and its undo history as they are, as the same index given
alone already was. An object that lacks one of the effects while another
object has it is still left out for that effect.
2026-11-15 08:36:31 -08:00