Drawing or exporting a symbol instance looked its symbol up by scanning
the document's symbol list, so a document with many instances and many
symbols spent most of a frame or an export on name comparisons. The
renderer, the SVG and PDF writers and the export walks now find symbols
through SymbolBoxes::symbol, which builds the name index once per frame,
export or walk and returns the first symbol of a name as before.
- Renderer: plain instances, inline graphics, instances with object
effects (their art and the symbol budget) and the effect bounds.
- SVG export: instance art, symbol defs and their reuse check, and the
paint reach of filter regions.
- PDF export: instance art, inline graphics and the brush search of
knockout masks.
- Export warnings and artboard crops measured what each object paints
with new symbol boxes per object, which built the name index again for
every instance. painted_bounds_with and drawn_outline_with take the
boxes once; Object › Rasterize's clipping mask uses them too.
High Fidelity Photo traced with a Limited palette of 64 colors as
overlapping shapes. It now traces with Palette Full Tone at Color detail
85 and Method Abutting; Paths, Corners and Noise stay 50, 50 and 5.
These are VectorCraft's own values.
Palette Full Tone splits its colors until none is wider than its limit,
then, while it has fewer colors than Color detail's value, splits the
narrower ones too, where the image has that many. Its colors then merge
as one only when they look alike: thoroughly mixed and less than 5 apart
in Oklab x 100, or mixed in patches (compression blocks) and less than
1.5 apart. This applies to every Full Tone trace, so an existing Full
Tone trace or saved preset traces differently when traced again.
Automatic's continuous-tone colors keep the earlier count and the RGB
merge.
On 19 photos, cartoons and synthetic shapes, the mean pixel difference
summed over the inputs falls from 80.5 to 65.6 levels: by more than 1%
on 14 inputs and by less than 1% either way on the other 5. Anchors
rise 1.66 times, the SVG size 1.31 times and the trace time 1.9 times;
flat synthetic art costs the most (12 to 400 anchors on one image).
Low Fidelity Photo, 16 Colors, 6 Colors, Black and White Logo and Auto
Color give byte-identical results.
Supersedes #2699 by andeecollard, which moved the photo presets to Full
Tone.
A linked PDF or .ai file that lists the editing file among its
attachments, but whose file specification, EF dictionary or F or UF
stream can't be resolved, was taken for a file without editing data and
copied without its stored paths being checked. Under read roots,
file.package now refuses it with the error for editing data that can't
be read. Opening such a PDF is unchanged.
The plug-in export test removes its folders when it ends.
The Links panel menu's Unembed… now works with several embedded images
selected: it asks for one folder, writes a file for each image there in
the format the image is stored in, and links each image to its file,
keeping its bounds, in one undo step. On the web each image is
downloaded instead.
links.unembed takes `ids` and `folder` for this form. Each file is named
after its image, with characters a file name can't hold replaced by `_`;
a taken name is numbered (`Name 2`), and a file already in the folder is
never replaced. Linked images among `ids` are skipped and listed. When an
image can't be written, the files the call wrote are removed and the
document does not change. A folder outside the automation write roots is
refused. The one-image `{id, path}` form is unchanged.
With Link, File > Place now places an EPS file, a PostScript file and a
PostScript .ai as a linked placed document, but the Place dialog still
counted them as other files, so Link's tooltip did not say they become one
locked object, and the dialog test expected a PostScript .ai to be
embedded.
- `is_vectorcraft_file` counts an EPS, EPSF or PostScript file on disk, and
a PostScript .ai, as a document, and leaves out a DCS file, which is
placed as a linked image.
- Where the platform reads part of a file, it reads only the file's start
and tells a DCS file from it with `place::head_is_dcs` (the check Links
uses), binary EPS headers included.
- The dialog test now checks the .ai, .eps and .ps cases, the bounded read,
DCS files plain and behind a binary header, and a file named .eps that
isn't PostScript.
With `pdfs: "single"` and several assets, layers or selected objects
(`selection: "each"`), document.exportForScreens wrote one PDF named
after the document holding only the first item's art, and every other
item's PDF was left out. Single file puts artboards on the pages of one
PDF; each asset, layer or object is cut out of the document with its own
art, so the export now refuses that combination before it writes any
file, and the Example line refuses it too. `pdfs: "multiple"` still
writes a PDF of each item, and `selection: "one"` writes one PDF either
way.
Docs: params text, docs/mcp.md, docs/target-app-parity.md.
A press on an edge (Shift with Paint Fills alone, or a plain press with
Paint Strokes on) now starts a drag, as a press on a face does. The drag
paints the edge and every visible edge of the same group that it crosses
or comes within 0.0001 pt of, between pointer events and on the release,
as one undo step; Escape cancels it. Edges of other groups and hidden
edges keep their strokes, a drag over edges that already have the stroke
records no undo step, and a drag that starts on a face still fills only
faces. A double-click after such a drag joins through the edges the drag
stroked as the paint they had before it.
livePaint.strokeEdge takes the drag's points and continuation as
livePaint.fill does, and both refuse them with scope connected or
samePaint.
Help page: https://helpx.adobe.com/illustrator/desktop/paint-and-fill/learn-painting-basics/paint-with-the-live-paint-bucket-tool.html
The Symbols panel and its panel menu asked for the current symbol on
every frame by running symbol.list, which builds a row per symbol and
walks the whole document once per symbol to count its instances. They
now read it from the active document with cmd::current_symbol, the
rule symbol.list itself uses for its `current`: the stored name while
a symbol has it, else the first symbol. symbol.sortByName,
symbol.place, symbol.options and text.insertInline use the same
function, and symbol.list's reply is unchanged.
An idle frame of the panel or its menu now runs no command, so on
macOS the native menu is not brought up to date on every frame while
the panel is open. In a document with 200 symbols and 50,000 objects
the read takes 0.035 us instead of 48.5 ms in a release build (thread
CPU time on Linux, median of 7 runs). The gain matters on large
documents; on small ones it is too small to notice.
Under automation read roots, an exporter plug-in's format (plugin.<id>)
counts as an output that carries the native document, since its plug-in
is given the document's JSON. document.serialize, document.export,
document.exportSelection, Export for Screens and assets.export rows and
file.exportAs refuse it before the plug-in runs and before any file or
folder is written when the document links a JavaScript file, a linked
image or placed file, a kept relative path or a data set's image outside
the roots, with the existing errors. The JSON the plug-in is given leaves
out an Export for Screens folder outside the roots.
file.package refuses, before anything is written, a linked file whose
native document it can't read to check: a native document that doesn't
load, a PDF or .ai file that can't be opened (one that needs a password
to open, or a damaged one), and a PDF, .ai or EPS file whose editing data
doesn't load. The error, "a linked file's editing data can't be read to
check it against the read roots", names no file or folder and gets rows
in the complete-message catalogs. A PDF or EPS file without editing data
is copied as before, and packages made without read roots are unchanged.
In a CMYK document the Fill Color and Stroke Color tolerances run from 0
to 100 and measure the Euclidean distance between the C, M, Y and K
percentages; RGB, Gray and Lab colors are converted to CMYK. RGB
documents keep the 0 to 255 RGB distance. The panel's fields take the
range of the active document.
A tolerance above 100 set in an RGB document is kept and applies as 100
while a CMYK document is active. magicWand.set now returns an error for
a tolerance that is out of range or not a number, and for a switch that
is not true or false, and then changes no setting, reset included;
before, it clamped the values and applied reset first.
A Shape Builder gesture that builds nothing now says why when it is
released: "select paths or compound paths" when nothing usable is
selected, "select all paths you want to merge" when the pointer is over
a path or compound path outside the selection, and "no region under the
pointer" otherwise. The message changes nothing in the document, the
selection or the undo history, and the next gesture that builds
something clears it. A gesture made while a large selection's map is
being built gives its message once, when it is replayed.
Tools get Action::Status, which the session passes to the status bar;
the new message has a row in every complete-message catalog.
With Export PDFs As set to a single file, a PDF row writes the first
item's document alone. The check for linked images outside the read
roots now looks only at that document, so an image linked in a later
asset no longer refuses a file that does not carry it.
Holding Backtick while dragging out a rectangle, rounded rectangle,
ellipse, polygon, star or line leaves a copy of the shape being drawn
each time the pointer has moved 8 screen points with the key down, up to
128 copies a drag. Each copy is its own object, drawn as the drag showed
it then. The release keeps the copies and the last shape as one undo
step, and Escape takes them all back. The spacing and the limit are
VectorCraft's own values.
The `backquote` descriptions of `pointer_gesture` name the shape tools.
Docs: docs/mcp.md, docs/target-app-parity.md.
A clip group whose clipping path clips by nothing (an empty group) hides its
members on the canvas, but Pathfinder skipped the group altogether, so
Intersect gave the other objects' overlap. Its members now get an empty
region and count as hidden like any other masked art.
A series read from bands with unstroked markers, or bands alone, kept an
explicit no-stroke paint. With Draw Filled Lines turned off, the thin line
took that paint and was not drawn. Such a series now keeps no stroke, as a
graph drawn here does, and its thin line is drawn in the series color at
1 pt. A series whose markers carry a stroke keeps it.
When a placed EPS or PostScript .ai file is gone, File > Package writes
the PostScript bytes the document holds only for a placed document whose
file name ends in .eps, .epsf, .ps, .ai or .ait. Under any other name,
or for a linked image, the link is reported as missing and nothing is
written for it.
A selected object its clipping masks hide altogether was left out of the
operation. For Intersect, Minus Front (hidden at the back), Minus Back
(hidden in front) and Crop (hidden on top) that changed the result: the
others' overlap or the next object down took its place. It now stays in as
an empty shape for those four, which then give nothing. The other operations
still leave it out, which gives the same art and keeps its style off the
result.
- A crease that runs past the cut outline by the tolerance or more is
reported as outside, though its hinge is still built.
- Two lines that fold, of any role, on top of each other are reported as
duplicate; a line drawn twice is still checked for where it lies.
- Hidden lines are left out in every scope, members of a selected group
included.
- The ids scope gets its own noCut message.
- The notStraight, ambiguous and summary texts say what the check finds:
the summary counts hinges, not creases.
- The fold angle fields, which nothing in this change reads, are removed.
- A window drawn as open cut lines stays a hole when a cut line crosses
it or when slits join it to an outline of open lines, so that three
lines meet at a corner. Cut lines drawn whole that cross a cell leave
it material.
- A slot drawn across the outline is a notch, not a hole, as when the
notch is drawn in the outline; a crease in it lies outside the blank.
- notStraight measures each hinge piece at its farthest point from the
hinge line instead of at five samples.
- Cut lines drawn on top of each other so many times that the gap search
would look at more than 16,777,216 pairs are reported as tooComplex
before the search.
Under automation read roots, every output that carries the native document
(a native file or template, an EPS file, a .ai or .ait file of every
artboard, a PDF of every artboard with Preserve Editing, from
document.serialize, document.export, document.exportSelection,
document.exportPdf, the saves, file.exportAs and Export for Screens rows)
is refused with "a linked image file is outside the read roots" when that
document names a linked image or placed file, a kept relative path or a
data set's image outside the roots, or holds a stored brush entry that
does not read as a brush. Nothing is written and the error names no file
or folder. Outputs without the native document are written as before.
The native document these files carry, and the documents file.package
writes or rewrites, leave out an Export for Screens folder outside the
read roots, as SVG with Preserve Editing already did. file.package refuses
a linked file it copies as it is (a PDF, .ai or EPS file, or a native
document with relink off) whose native document keeps such a folder, with
"a linked file's export folder is outside the read roots".
Export for Screens rows that write one artboard as a native, .ai or EPS
file are checked against that artboard's art. Each asset, layer or
selected object now writes its own native, .ai or EPS file: the per-artboard
document cache was keyed by artboard index alone, so every piece after the
first wrote the first piece's document.
Both messages get rows in the complete-message catalogs.
shape.arc returns an error for a reference that is not a whole number
from 0 to 8, a baseAlong other than x or y (either case), null included
for both, and a slope outside -100 to 100, in both of its forms. Before,
such a value drew the arc from reference point 0 or 8, along the X axis
or with the nearest slope. shape.rectangularGrid and shape.polarGrid
return an error for a divider count that is not a whole number of at
least 0; before, it took the default 5. Each error names the key,
nothing is drawn and no undo step is added. Left-out values keep their
defaults.
FontLikeness::distance left out every number either face does not give,
so a family whose faces give none of them (static faces with no OS/2 or
post table) was 0 from every family, and Show Similar Fonts could list
it right after the chosen family, as an exact match. Faces that share
no number to compare are now f32::INFINITY apart, so such a family
comes after every family of its script group that shares one, and
families equally far keep their order. The order of measured families
does not change. This is VectorCraft's own rule.
Builds on #7983, which added Show Similar Fonts.
path.split (Scissors) and path.cutAtAnchors (Cut Path at Selected
Anchor Points) keep the source path's fill and stroke settings on the
paths they make, and now set every stroke's alignment to Center in the
same undo step, as the help page describes:
https://helpx.adobe.com/illustrator/desktop/draw-shapes-and-paths/modify-paths/split-paths.html
Every stroke row is reset, hidden ones included. A path of several
subpaths has one appearance, so its other subpaths' strokes are
centered too, and a cut member of a compound path centers the compound
path's strokes. An appearance whose strokes are already centered is
left shared. Knife, the erasers and Divide are unchanged.
File > Place with Link (the default) now places an EPS file, a PostScript file or a PostScript .ai from a path as one locked placed document instead of an embedded group. It shows the art that placing without Link gives (clipped to the bounding box, or the art's bounds with crop: "bounding"). Links check, update and relink it, Break Link and Object > Expand give the Link-false group, a save keeps its preview, every output draws its vectors, and Package copies the file, also from the bytes the document holds when the file is gone. Links lists it as EPS or PostScript, also after a save that kept only its preview. A DCS file stays a linked image; Link off and dataBase64 still embed.
readhexstring and readline called the one-byte file read for every input
character, copying each byte into a new vector. They now scan the bytes
left in the file in one slice and advance the file by the bytes they used.
The results are unchanged: the same bytes, the same boolean, the same next
unread byte, from the program's own file (after the whitespace that ends
the last token), a decoded buffer and a filter decoded when first read.
readhexstring stops on the digit that completes the last byte and drops a
lone digit at the end of the data; readline takes CR LF as one line ending,
leaves the byte after a lone CR unread, and leaves the line ending unread
when the line fills the string.
Tests run the new readers next to copies of the byte-at-a-time loops over
13 stream forms and several hundred inputs, comparing the result and
everything left to read; an image read through a readhexstring procedure
is compared with the same samples given as a hexadecimal string. The
import fuzz tests gain readline and a case for both operators.
data_op allows clippy::cognitive_complexity. Without the allow, clippy
rates it 54 against the limit of 30; with the old loops in place it
passes.
A line graph whose style record draws its lines as shapes now opens as a
live graph with Draw Filled Lines on, and its lineShapeWidth becomes the
Line Width (3 pt reads as the default). The flag is ignored when the
points are not connected, as the published file format specification
says (printed pp. 147-148). Saving writes both values in the Gy record.
- Widths from 0.01 to 100 pt are kept. A wider Line Width, a width under
0.01 pt with filled lines, and filled lines without connected points
are saved as the graph's art with the existing warning.
- In a filled-line series, a filled path with the thin black band
outline is read as a band and does not set the series stroke. A
filled path with another outline must be a square marker or legend
swatch; otherwise the graph keeps its art as plain objects.
- The reader in crates/eps/src/import/ai/read/graph.rs reads each value
the writer in crates/eps/src/ai_graph.rs writes; the save-then-open
tests cover the default, 8 pt and 150 pt widths in both .ai forms.
Pathfinder collected a clip group's members as if it were a plain group, so
Divide cut the hidden art too and the result lost the mask. Each member is
now cut to the group's clipping region first (nested clip groups by each
region in turn): its area is intersected with the region, and Divide's
cutting lines keep only their parts inside it. A member the mask hides gives
no piece, a group among other objects takes the style of its top member that
shows, and a selection the masks hide altogether is refused with a reason.
This applies to every object.pathfinder.* operation, which also covers Merge
on masked art (#3367).
A spiral dragged out with the Spiral tool now turns about its center so
that its outer end is at the pointer, so dragging around the center turns
it. A pointer within 0.01 pt of the center keeps the last direction. Alt,
Ctrl/Cmd, Up/Down, Space and Escape work as before, and Shift does not
change the direction.
With General > Constrain Angle other than 0 degrees or a whole turn, a
spiral placed from the Spiral dialog starts along the turned x axis, with
its bounding box turned.
shape.spiral takes an optional rotation (degrees clockwise about cx, cy).
Without it, or at 0 or a whole turn, spirals are drawn as before; a
rotation that is not a number is an error and adds nothing.
Expand Appearance expanded a group's or layer's evaluated members, and the
object of a Crop Marks effect, before giving them new ids. When the raster
budget refused the image for such a member that held a random Transform
effect, the member stayed unexpanded, but its new id gave that effect a new
seed, so the member moved while its effects stayed live.
The group, layer or Crop Marks object now stays as it is in that case, as
it does when its own raster effects go past the budget. The rollback also
removes the images its other members added to the document and gives their
charge back to the budget.
brush_targets checked each brushable node against every target it had
already collected, so P targets cost about P^2/2 comparisons. It now
keeps a HashSet of the ids it has pushed. The output vector is unchanged:
the same ids in the same walk order, each kept where it is first reached.
brush.apply, brush.remove, Expand on brushed paths and the brush library's
apply all collect their targets through it.
A unit test checks the exact result for guides, clipping paths, compound
members, nested compounds, repeated and overlapping roots and a missing
id, and compares it with a copy of the old collector.
Preferences > Plug-ins & Scratch Disks > Plug-in Instruction Budget
(`pluginInstructionBudget`) is a VectorCraft setting. Normal, the default,
keeps the limits a filter run has today. Large gives each object filter run
250 M instructions plus 4,000 per input byte, with the 60 s time budget, Cancel
and the other limits unchanged. An approved heavy filter keeps its 1 G and
300 s with either value; live effects, exporters and importers keep their own
budgets. The next run of an installed filter uses the value in force when the
run is prepared.
prefs.set refuses any value but normal or large; a saved preferences file
with another value reads as Normal and the other preferences load as saved.
Docs: docs/plugins.md, docs/mcp.md, docs/target-app-parity.md.
- With art in some of the group's colors, a second Save Changes after
another edit of a row kept the color the first save gave that row's
swatch, and OK gave the group's colors by row order, which could
overwrite a swatch no row lists. Both now match each swatch to its row,
also through the color that row listed when an earlier save gave the
swatch its color.
- An excluded row leaves its swatch its own color at Save Changes and at
OK, with or without art. `recolor.apply` takes "keep" in `groupColors`
for a swatch that keeps its color without the Global Adjust.
- `swatch.editGroup` given the color keys of the group's own colors keeps
those colors unrounded and records no undo step.
Object › Plug-ins › Packaging Tools › Check Fold Lines, and the Fold Lines
panel's Check button, check the fold lines of the selection, or of the
document while nothing is selected (`addon.packaging.check`).
- Cut lines bound the material: each connected piece that encloses an
area is one blank, its largest closed cut line is the outline, and a
closed cut line inside it is a hole. A slot drawn as a rectangle across
the outline leaves the same material as a notch drawn in it, and an
outline drawn as several open cut lines works too.
- Creases, partial cuts and perforations divide a blank into panels; the
pieces between the same two panels form one hinge.
- 15 issue codes, errors and warnings, each naming its lines; cut line
ends within a tolerance (0.1 pt, 0.01 to 10) are joined and reported as
a gap. With `select`, the lines the issues name are selected.
- The panel lists the issues in the interface language, with a summary
line; clicking an issue or its Select button selects its lines. The
list is kept until the document changes.
`vectorcraft_pathops::adjacency` maps paths as live_paint does and keeps,
for each edge, every input it lies on and the faces on both sides; the
blank model is `vectorcraft_three_d::fold::blanks`. The engine now depends
on vectorcraft-three-d directly.
Docs: docs/mcp.md (Check Fold Lines), crates/pathops/README.md, ROADMAP.
- swatch.library.add lists a library pattern swatch that stands for a
swatch added earlier in the same call under existing, not twice
under added.
- An empty library file (.gpl, .ase, .vcswatches) loads as an empty
library again; only a document with no swatches is refused. A
PostScript file whose swatches are only the default ones is refused
like a .ai or .eps.
- The Swatch Libraries filter of Other Library… also lists .ait and
.epsf files.
- The library panel finds a loaded library's pattern swatch by looking
only at libraries that have pattern swatches.
- The Czech message for Copy to User Defined names pattern swatches.
- Color spelling in the new params text and comments; docs/mcp.md
rewrapped.
A Linear point picked near the end of another dimension's line landed
beside it when zoomed in: the tool's own pick skipped dimension artwork,
so that end pulled the point only within the Smart Guides tolerance,
while an anchor of the art pulls it from 8 pixels.
- With Smart Guides or Snap to Point on, a point that no anchor of the
art within 8 pixels takes lands on the end of a visible, unlocked
dimension's dimension line, or on the far end of its extension line,
within 8 pixels, with no link to that dimension. The end of an
extension line next to the point it measures is not an end, so an
anchor that a dimension already measures still takes the point.
- A point that nothing else places lands on the closest point of such
a line within 8 pixels, as it does on a segment of the art.
- With Smart Guides and Anchor/Path Labels on, a point on an anchor or
a line end shows the "anchor" label, and a point on a segment or line
shows the "path" label. A point on a line end is marked as an anchor.
- A press on a line end that moves a few pixels picks it, as a press on
an anchor does.
Docs: docs/dimensions.md, docs/target-app-parity.md.
A Group Selection marquee selected the anchor points inside it, as a
Direct Selection marquee does, so a path it crossed was only partly
selected. The Selection tool hides its bounding box while anchors are
picked, so after switching to it no box appeared around the objects.
The marquee now selects every object it touches, whole (members of
groups too, and with Shift it toggles them), as an Alt-drag marquee
with Direct Selection already does; a compound path it touches is
selected whole, as that marquee selects it. E during the drag still
selects only the objects entirely inside the marquee.
Fixes#8047
A format row's file key was made before the top-level `antiAlias` was added to
its options, so a PDF row that sets no bleed and one that asks for the
document's bleed wrote two identical files under Include Bleed. The key is
now made again after the merge.
Preferences › Performance › Low-Latency Drawing (lowLatencyDrawing, off by
default) is read when the app starts and asks for wgpu's AutoNoVsync. The
present mode comes from --present-mode, then VECTORCRAFT_PRESENT_MODE, then
the preference, then the default; with the preference off and no override
the window surface is unchanged. The startup log names "(preference)" or
"(override)" after the mode.
Whenever the window presents without vsync, from the preference or an
override, main-window frames start at most 240 times a second (about
4.17 ms apart). The wait comes before egui reads the frame's input, and
the frame's time moves on by it. With vsync the display paces the frames
and no cap applies.
The checkbox shows on the desktop with the note that it applies the next
time VectorCraft starts. A value that is not a boolean is an error.
Fixes#6013
Swatches › Open Swatch Library › Other Library… read a document's
swatches without its pattern swatches, so a pattern from a .ai swatch
library came in only as the colors it uses.
- swatch.library.load keeps a document's pattern swatches, and keeps
the document for a library that has them. swatch.library.add brings
the pattern with its tile and art, as a pattern swatch with the
library swatch's name, placement and color group.
- The library panel draws those pattern swatches from their pattern.
- The Swatch Libraries filter of Other Library… lists .ai and .eps
files.
- A file with no swatches, and a .ai or .eps whose swatches are only
the default ones, are refused with "`<file>` has no swatches of its
own". Copy to User Defined refuses a loaded library with pattern
swatches, since a .vcswatches file can't hold them.
Docs: docs/mcp.md, docs/target-app-parity.md.
The art that clicks and marquees test leaves 3D effects unprojected again.
The faces of a layer's 3D effect carry the layer's id, which a click
cannot select, so a click on a member of such a layer selected nothing.
Use Preview Bounds still measures the projected art.
Save Changes now gives the group the same colors OK would: a color removed
with the Remove Color tool removes its swatch, and a color added with the
Add Color tool joins the group after its other colors, also when the art
holds colors of the group. `swatch.editGroup` takes `null` in `colors` to
remove the swatch at that place.
After the save, the rows follow the saved group, so a later edit or OK does
not remove or add a color a second time.