Commit Graph
8148 Commits
Author SHA1 Message Date
BFlat e41d583ddd Merge pull request #5586 from dotCooCoo/fix/text-tweaker-range
Text Tweaker: align byte ranges to character boundaries
2026-11-04 19:17:45 +07:00
BFlat 9b2ec6e85a Merge pull request #5585 from dotCooCoo/fix/kerning-parentheses-wrap
Character: Kerning reads (10+5)*2 as nothing instead of 10+5*2
2026-11-04 19:17:33 +07:00
dotCooCoo af14fe3d59 Align Text Tweaker ranges to character boundaries 2026-11-04 18:56:40 +07:00
dotCooCoo a7266dd10a Character: Kerning reads (10+5)*2 as nothing instead of 10+5*2
Numeric fields dropped every parenthesis before reading a value, so
(10+5)*2 typed into a field committed 20. Only the Kerning field, which
shows its automatic value as (12), now drops one pair of parentheses
around the whole text. Parentheses anywhere else are refused, and fields
without that display refuse them too.
2026-11-04 18:56:36 +07:00
BFlat 42de898d01 Merge pull request #5541 from dotCooCoo/feat/navigator-panel-options
Navigator: Panel Options sets the view box color and draws dashed lines as solid
2026-11-04 18:54:17 +07:00
BFlat 110441e363 Merge pull request #5540 from dotCooCoo/fix/style-attrs-range
Validate character style numeric dimensions
2026-11-04 18:54:00 +07:00
BFlat cabafe3bfb Merge pull request #5581 from dotCooCoo/fix/layer-color-refuses-alpha
Layers: a layer or gap color with an alpha part is refused instead of losing its alpha
2026-11-04 18:53:43 +07:00
BFlat 19014392f8 Merge pull request #5574 from dotCooCoo/fix/dialog-color-refuses-alpha
Dialogs: a color with an alpha part is refused instead of losing its alpha
2026-11-04 18:53:27 +07:00
BFlat 0f2b927378 Merge pull request #5577 from dotCooCoo/fix/same-symbol-reference-docs
Select: describe which object Same Symbol Instance compares with
2026-11-04 18:53:11 +07:00
BFlat 57777a333d Merge pull request #5583 from dotCooCoo/fix/global-edit-options-close
Global Edit: the options dropdowns close when Global Edit starts
2026-11-04 18:53:00 +07:00
BFlat 2f565dd212 Merge pull request #5580 from dotCooCoo/fix/kerning-mixed-modes
Type: Kerning menu lists Auto and Optical for mixed kerning modes
2026-11-04 18:52:45 +07:00
BFlat 4443c594e9 Merge pull request #5579 from dotCooCoo/fix/prefs-reapply-keeps-render-threads
Preferences: a Render Threads change before the first UI pass restarts the canvas renderer
2026-11-04 18:52:30 +07:00
BFlat edbe4d42bb Merge pull request #5576 from dotCooCoo/fix/pattern-done-gives-back-lent-type-tool
Type: Done during a Cmd press does not save empty point type
2026-11-04 18:52:15 +07:00
BFlat 9af799cf8b Merge pull request #5575 from dotCooCoo/fix/backquote-at-release
Canvas: a drag's release reads Backtick as it was at the button-up
2026-11-04 18:52:05 +07:00
BFlat 0476998117 Merge pull request #5572 from dotCooCoo/fix/optical-arabic-test-craft-fonts-guard
Tests: skip the Arabic Optical kerning test without craft-fonts
2026-11-04 18:51:49 +07:00
BFlat f21b3c4b13 Merge pull request #5571 from dotCooCoo/fix/direct-marquee-long-path
Direct Selection: a marquee over a long path tests its segments without building a path for each
2026-11-04 18:51:34 +07:00
BFlat 38521de60b Merge pull request #5570 from dotCooCoo/fix/hide-others-locked-layer-and-guides
Object: Unselected Artwork keeps groups that hold a selected layer or a locked guide
2026-11-04 18:51:19 +07:00
BFlat 75a961c282 Merge pull request #5569 from dotCooCoo/fix/ai-incomplete-brush-object-counted
.ai import: a brush object without a name counts as a brush left out
2026-11-04 18:51:04 +07:00
BFlat 5ddf7c2948 Merge pull request #5568 from dotCooCoo/fix/held-escape-after-tools-cancel
Shortcuts: a held Escape that cancels a Tools or ruler move skips the tool
2026-11-04 18:50:52 +07:00
BFlat d15b10f054 Merge pull request #5567 from dotCooCoo/fix/node-render-anti-alias
Render: node renders follow the anti-aliasing option
2026-11-04 18:50:36 +07:00
BFlat fcc3620050 Merge pull request #5566 from dotCooCoo/fix/select-same-text-skips-template-layers
Select: the font Same commands skip type on a template sublayer
2026-11-04 18:50:21 +07:00
dotCooCoo 6fa0d6e4e0 Navigator: cached raster effects follow Draw Dashed Lines as Solid Lines
The raster-effect cache key now includes the setting, so a renderer that
draws the same art with it on and then off no longer reuses a drop
shadow or other raster effect made with the other setting.
2026-11-04 18:29:29 +07:00
dotCooCoo ddf3373cf0 Navigator: translate the Light Red view box preset
Add a Light Red row next to Light Blue in all 26 catalogs, so the preset
name in Panel Options shows in the interface language.
2026-11-04 18:29:28 +07:00
dotCooCoo 30f903bf60 Navigator: Panel Options sets the view box color and draws dashed lines as solid
The Navigator panel menu's Panel Options… is enabled and opens a dialog with
the view box color (a preset or a custom color; Light Red, today's color, is
the default) and Draw Dashed Lines as Solid Lines, off by default, which draws
dashed strokes without their dashes in the panel's thumbnail only. The
options are kept with the UI state, and ui.navigatorPanelOptions sets them.

RenderOptions::solid_dashes draws dashed strokes as solid lines, including
type strokes and the silhouettes of stroke effects.
2026-11-04 18:29:28 +07:00
dotCooCoo a403e75802 Validate character style numeric dimensions
Squashed from #5540 onto main.
2026-11-04 18:29:25 +07:00
dotCooCoo d79f5ccb75 Layers: a layer or gap color with an alpha part is refused instead of losing its alpha
layer.setProps, layer.new, layer.newSublayer and livePaint.gapOptions read
an 8-digit hex color such as #ff000080 as #ff0000 and set it without its
alpha. They now refuse it with the error a bad color already gets, and
change nothing. #rgba was already refused. #rrggbb, #rgb, a preset index
and a preset name are read as before.
2026-11-04 18:29:17 +07:00
dotCooCoo 12508e6c60 Dialogs: a color with an alpha part is refused instead of losing its alpha
`Color::from_hex` reads `#rrggbbaa` and keeps only its first six digits, so
a `color` set to `#ff000080` through `ui.dialog.set` was applied as
`#ff0000` without an error by Tile Edge Color, Live Paint Selection Tool
Options, Live Paint Bucket Options and Gap Options.

- A new `checked` next to `resolve` in `dialogs/tile_edge_color.rs` gives
  the existing "is not a colour" error for an 8-digit hex color, and
  otherwise reads the color as `resolve` does. `resolve` is unchanged, so
  the swatches the dialogs draw with it show such a color by its RGB as
  before.
- Each of the four dialogs' OK checks the color with `checked` first, and
  leaves the dialog open with nothing changed. Tile Edge Color and Gap
  Options already refused `#rgba`, which `from_hex` does not read. Live
  Paint Selection and Live Paint Bucket used to ignore a color they could
  not read, such as `#f008`, and apply their other fields; their OK now
  refuses it.
- With Preview on, Gap Options sends no color for a `#rrggbbaa` value, so
  the groups keep their own color, and the previewed gaps draw in black.

Docs: the params text, docs/mcp.md, docs/control-protocol.md and
docs/target-app-parity.md.
2026-11-04 18:29:13 +07:00
dotCooCoo f65cd179f8 Docs: re-wrap the select.same paragraph in docs/mcp.md 2026-11-04 18:29:09 +07:00
dotCooCoo 8762242dfe Select: describe which object Same Symbol Instance compares with
The params text of select.same.symbolInstance, docs/mcp.md and
docs/target-app-parity.md now say that the object compared with can be
of any kind (a group member selected on its own, or an object that is
not a symbol instance, which leaves the selection empty), and that new
art on a locked artboard is not passed over while it stays selected.
A test covers the three cases.
2026-11-04 18:29:09 +07:00
dotCooCoo dbfe3fdc38 Global Edit: the options dropdowns close when Global Edit starts
The Global Edit Options dropdowns in the Control bar and in the
Properties panel's Quick Actions turn their button off while Global
Edit is on, but a popup that was already open stayed open and still
changed the options. Both dropdowns now close their popup while Global
Edit is on, and it stays closed after Global Edit stops until the
button is clicked again.
2026-11-04 18:29:06 +07:00
dotCooCoo f11df30d23 Type: Kerning menu lists Auto and Optical for mixed kerning modes
A selection that mixed kerning modes left the Kerning dropdown without
its Auto and Optical entries, so one mode could not be set on all of
it. The menu now lists both entries with neither checked.
2026-11-04 18:29:03 +07:00
dotCooCoo 4a9ccc6fe3 Preferences: a Render Threads change before the first UI pass restarts the canvas renderer
The first UI pass applies the saved preferences again (#4837) by removing
the record of what was last applied. A Render Threads change made by a
control request between an earlier tick and that pass was then applied
with no previous value to compare, so the canvas renderer kept its old
thread count. The pass now forces the theme refresh and keeps the
record, so the thread change still restarts the renderer.
2026-11-04 18:29:00 +07:00
dotCooCoo c220c500e9 Type: Done during a Cmd press does not save empty point type
Done (pattern editing), Stop Editing Opacity Mask and Exit Isolation
Mode end the Type tool's edit first, so point type a click placed and
left empty is discarded. While a Cmd/Ctrl press had lent a selection
tool, the Type tool was not the active tool, its edit was not ended,
and the empty point type was saved into the pattern tile or the mask.

The lent tool is now given back first. A drag the lent tool started is
kept as its own step, with its last position applied when Real-time
Drawing and Editing is off.
2026-11-04 18:28:56 +07:00
dotCooCoo 1600696aea Canvas: a drag's release reads Backtick as it was at the button-up
A press or release of Backtick, or a window focus loss, that came after
the mouse button went up in the same frame changed whether the drag
committed a pattern-only transform. The release now takes Backtick's
state at the button-up from the frame's ordered input events.
2026-11-04 18:28:53 +07:00
dotCooCoo 5ebb6796fe Tests: skip the Arabic Optical kerning test without craft-fonts
optical_pair_after_rtl_separate_mark_uses_base_outline sets Noto Sans
Arabic, which is not in assets/fonts. Without CRAFT_FONTS_DIR the font
database returns a fallback face, so the test checked that face instead.
The test now skips when Noto Sans Arabic is missing, as the Shippori
Mincho tests in the same file do.
2026-11-04 18:28:50 +07:00
dotCooCoo c24c06ef7f Direct Selection: a marquee over a long path tests its segments without building a path for each
The marquee's segment test built a two-anchor path for every segment and ran
hit::intersects_rect on it. It now skips a segment whose anchors and handles
all lie past one side of the marquee, and tests the rest directly with the same
bounds and edge checks, so it selects the same segments.

A marquee over 10,000 anchors, press to release (anchor_bench, median of 7):
one open path of 200,000 anchors 84.9 ms -> 24.1 ms, 2,000 closed paths of 50
anchors 27.5 ms -> 13.5 ms, one closed path of 50,000 anchors 14.6 ms -> 8.5 ms.
2026-11-04 18:28:47 +07:00
dotCooCoo e67277ebe7 Hide: Unselected Artwork keeps groups that hold a selected layer or a locked guide
A layer nested in a group whose art was all locked counted for nothing,
so the group was hidden or locked with the layer inside it. The selected
layer now counts as selected itself.

While Lock Guides was on, a guide path that was locked itself, or sat in
a locked object, was not kept, so the group around it was hidden. Guide
paths inside locked objects are now kept too.
2026-11-04 18:28:44 +07:00
dotCooCoo 55dc5bb4a5 .ai import: a brush object without a name counts as a brush left out
A plug-in object that names a brush kind but ends before the brush's
name was dropped without a trace. When it was the file's only brush
object, the document kept the default brushes and showed no note. It is
now counted with the other brushes that can't be read, so the file gets
the Brushes panel note and no default brushes.
2026-11-04 18:28:40 +07:00
dotCooCoo 67cc383d77 Shortcuts: a held Escape that cancels a Tools or ruler move skips the tool
Holding Escape to cancel a floating Tools panel move or a ruler-origin
drag no longer passes its key repeats to the active tool or to the
other Escape actions (pattern edit, isolation, a flyout) once the
cancel frame has passed. The repeats are skipped until Escape is
released or pressed again. Tests hold Escape through both cancels in
each screen mode.
2026-11-04 18:28:37 +07:00
dotCooCoo 4c51f853c1 Render: node renders follow the anti-aliasing option
render_node_with and render_node_thumbnail_with drew into a new context
without setting its aliasing threshold, so AntiAlias::None still gave
smooth edges. Both now set the threshold from the options, as a page
render does.
2026-11-04 18:28:35 +07:00
dotCooCoo abc2201664 Select: the font Same commands skip type on a template sublayer
Squashed from #5566 onto main.
2026-11-04 18:28:32 +07:00
BFlat 8cac1b8802 Merge pull request #4517 from dotCooCoo/fix/document-color-mode-converts-effects-and-graphs
Document Color Mode: convert reusable paints and restore them with Undo
2026-11-04 18:24:51 +07:00
BFlat 74ccfdde05 Merge pull request #5563 from dotCooCoo/fix/many-anchors-editing
Render: a long stroke is outlined only near the view after an edit
2026-11-04 18:24:32 +07:00
BFlat 3c3ff35e8a Merge pull request #5564 from dotCooCoo/fix/hidden-group-floating-reply
Panels: showing a hidden floating group returns its window's panels
2026-11-04 18:24:17 +07:00
BFlat 093d90844d Merge pull request #5537 from dotCooCoo/fix/textedit-reject-bad-offsets
Type: text commands refuse negative or fractional byte offsets
2026-11-04 18:24:00 +07:00
BFlat 23e7e5011e Merge pull request #5558 from dotCooCoo/fix/i18n-term-tests-match-words
i18n: leading and Tracking term checks match whole words in the right label
2026-11-04 18:21:20 +07:00
dotCooCoo f0f19077df Document Color Mode: convert reusable paints and restore them with Undo
Squashed from #4517 onto main.
2026-11-04 16:55:43 +07:00
dotCooCoo 3fbdf72231 Docs: the long-stroke line names the strokes of path objects 2026-11-04 16:55:30 +07:00
dotCooCoo 8d0f251c37 Examples: anchor_bench's doc comment says what the example prints 2026-11-04 16:55:30 +07:00
dotCooCoo d6190e79e0 Render: a filter layer's offscreen culls art and crops long strokes to its own area
On a multithreaded context, a drop shadow or glow drawn through a filter
layer is drawn into an offscreen that covers the art plus the blur's
spread, but its frame kept the view's visible rect. Art outside the view
but within the spread was culled, so it cast no shadow, and a long stroke
was outlined only near the view, so its far parts no longer fed the blur.
The offscreen's frame now takes its visible rect from its own area, and
the frame of content kept from an earlier split takes the window it is
drawn over.
2026-11-04 16:55:30 +07:00