Commit Graph
11639 Commits
Author SHA1 Message Date
dotCooCoo 712e567a95 .cdr import: outlines behind the fill come in below the fill
Bit 0x10 of an outline's line type puts the outline behind the fill, so
that a filled shape shows only its outer half. The reader now reports
it, and the importer paints such a stroke before the fill. A clipping
container's outline behind its fill becomes a stroke of its own below
the clipping group, the two grouped together, since a clipping path's
stroke paints over the clipped objects. PROVENANCE.md row R49 gives the
sample files.
2026-11-12 13:33:33 -08:00
dotCooCoo f8ad4565d0 .cdr import: an outline is dashed only when its line type says so
Bit 0x04 of an outline's line type marks it dashed. Some drawings store
dashes in outlines without that bit, and their own preview pictures show
those outlines solid; the reader drew them dashed. Such outlines now
come in solid. PROVENANCE.md row R48 gives the sample files.
2026-11-12 12:52:45 -08:00
dotCooCoo 907ca62d62 .cdr import: name lenses and object transparency in the warnings
An object with a lens or a transparency carries argument 8000. The
reader does not apply it, and the object comes in opaque; the warnings
now say so instead of nothing. PROVENANCE.md row R47 lists the sample
files that carry the argument.
2026-11-12 12:42:08 -08:00
dotCooCoo 4507c470e3 .cdr import: clipping containers clip the objects they hold
A container carries argument 8005, whose id names the LIST grp of the
document's LIST clpt with the same id in its spnd chunk. The reader now
gives the container with that group's objects, which keep their own
transforms, and the importer makes a clipping group of them: the
container's shape is the clipping path and keeps its fill and outline.
Before, only the container came in, with no warning.

A container whose group is missing is damage. A group already being
read, or more than 64 clipped groups one inside another, is left out
with the limit warning; the container stays as a plain shape either way.
PROVENANCE.md row R46 gives the layout and the sample files it was
checked against.
2026-11-12 12:26:53 -08:00
dotCooCoo 977b5773c3 .cdr import: bit 0x10 of a layer's flags no longer makes it a grid
A layer without a loda of its own is taken by the low four bits of its
flags' byte 0: 0x0a guides, or a grid when bit 0x10 is also set, and
0x08 the desktop only when byte 2 is set. Sample files flag drawing
layers 0x10, 0x18 and 0x58 with byte 2 clear, which the reader took for
grid layers and left out, and 0x08 with byte 2 clear, which it took for
the desktop.
2026-11-12 12:04:20 -08:00
dotCooCoo 2cd5ad52d1 .cdr import: objects without their own fill or outline take their style's
From version 7 a drawing keeps its styles in LIST stlt, and an object
names its style in argument 200. An object without a fill (20) or
outline (10) argument of its own now takes the fill and outline its
style gives, through the style's parents where the style leaves one to
them. Before, such objects came in without a fill or outline.

The table is read only when it parses to the end of its list; a table
that does not is damage when an object needs a style from it. Its
entries and styles count toward the chunk limit. PROVENANCE.md row R45
gives the layout and the sample files it was checked against.
2026-11-12 12:01:08 -08:00
dotCooCoo 4c8cfda86a .cdr import: read layouts as public sample files store them
Version 2 files (markers m and l) start their settings after a 1-bit
picture, so the page box is read two bytes after the settings offset in
the header, and their drawn objects keep the fill at byte 105 and the
shape at 136. Files with the marker l flag drawn objects 0xc0 and are now
read; the marker d, which no sample shows, is refused. A record that does
not start with 24, or a drawn object of an unknown type, ends the walk
instead of reading the bytes after it as records. A rectangle's radius
follows its height directly.

A layer's kind comes from the object type in its own loda (11 grid,
12 guides, 17 desktop), so drawing layers flagged 0x10 or 0x08 are no
longer dropped or taken for the desktop. Object type 0x25 is read as a
path from version 10, and arrowhead ids are looked for from version 6.

PROVENANCE.md now cites the Kaitai specification, the ZIP specification,
the file utility's magic, PRONOM and the public sample files whose bytes
each row was checked against.
2026-11-12 11:38:11 -08:00
dotCooCoo 6785e8df53 .cdr import: a page that shares no layer puts its layers on top
A page whose bottom layer is new now goes below the lowest layer the rest of
the page shares with earlier pages, and on top when it shares none, so the
layers keep the order they were first seen in.
2026-11-12 09:48:38 -08:00
dotCooCoo 0e146cc363 Docs: keep main's other format summary rows
Restores the second "Formats opened or placed" row as main has it; this
pull request changes only the first row.
2026-11-12 09:24:17 -08:00
dotCooCoo 59db4313b1 File formats: open and place .cdr drawings, versions 1 to 27
File › Open and File › Place read .cdr drawings of versions 1 to 27,
and .cdt templates open as new untitled documents. A new L0 crate,
vectorcraft-cdr, reads the WL files of versions 1 and 2, the RIFF chunk
tree of versions 3 on with its compressed lists, and the ZIP packages of
versions 14 on with their data streams. The importer maps pages to
artboards side by side, layers by name, the master page's guidelines to
guides, groups, curves, paths, rectangles, ellipses, arcs and polygons
with uniform fills and outlines.

Versions 1 and 2 open as one page and one layer of rectangles, whole
ellipses and curves. Version 3 keeps transforms, fills and outlines in
each object, and a group's matrix places its objects; envelopes are not
applied, with a warning. Version 4 reads as version 5 with 12-byte u16
colors and fixed-point transforms.

Text, bitmaps, blends, contours, brush strokes, fountain, pattern,
texture and PostScript fills and arrowheads are left out, and the open
warnings name each kind in every complete catalog. RIFF files that name
a version before 3, drawings after 27 and encrypted, ZIP64 or split
packages are refused with a message. crates/cdr/PROVENANCE.md lists the
public source of each record layout.
2026-11-12 09:03:17 -08:00
BFlat 10ea235ee4 Merge pull request #6659 from ruchirguitar/fix/numfield-short-drag-1326
Numeric fields: a sub-threshold pointer movement keeps its caret (#1326)
2026-11-12 22:21:11 +07:00
BFlat 6bd9b9e50d Merge pull request #6870 from dotCooCoo/fix/portal-save-filter-shape
Save As: a save goes ahead when the portal answers with a file type of another shape
2026-11-12 22:02:14 +07:00
BFlat f5c5d9a702 Merge pull request #6829 from dotCooCoo/feat/dynamic-text-point-type
Type: Dynamic Text turns point type into area type with Block on
2026-11-12 22:02:05 +07:00
BFlat ddafb28aeb Merge pull request #6888 from dotCooCoo/fix/read-roots-scripts-recovery
MCP: plug-in, recovery and script report replies leave out paths outside the read roots
2026-11-12 22:01:56 +07:00
BFlat c1f3ebbdb3 Merge pull request #6869 from dotCooCoo/fix/exif-quarter-turn-resolution
Images: an image its orientation turns is stored as shown, at its own size and with its inks
2026-11-12 22:01:46 +07:00
BFlat a1abf13a8a Merge pull request #6852 from dotCooCoo/feat/objects-on-path-select-move-detach
Objects on Path: the Select/Move widget chooses an object and drags it to another place along the path
2026-11-12 22:01:35 +07:00
BFlat c607814697 Merge pull request #6798 from dotCooCoo/feat/brushes-dry-media-library
Brushes: a built-in Dry Media library of grainy chalk, pencil, crayon and charcoal art brushes
2026-11-12 22:01:26 +07:00
BFlat 8b6ed41ef0 Merge pull request #6846 from dotCooCoo/test/not-aligned-pixel-grid-kinds
Select: test Not Aligned to Pixel Grid with images, symbols, type and live objects
2026-11-12 22:01:15 +07:00
BFlat e659160bb5 Merge pull request #6868 from dotCooCoo/fix/blend-shadow-unclipped-mask
Render: blend steps' drop shadows draw under an opacity mask with Clip off
2026-11-12 22:01:05 +07:00
BFlat 558fec9f96 Merge pull request #6838 from dotCooCoo/fix/3d-transparent-gradient-member-order
3D: a solid in a transparent gradient keeps the shared face order
2026-11-12 22:00:51 +07:00
BFlat 6758872adb Merge pull request #6867 from dotCooCoo/fix/ui-egui-parallel-test-races
Tests: font menu and menu bar tests allow for fonts and plug-ins other tests change
2026-11-12 22:00:42 +07:00
BFlat 50da206604 Merge pull request #6877 from dotCooCoo/fix/svg-use-text-inherits
SVG import: a <use> of a text passes its text properties on to the text
2026-11-12 22:00:34 +07:00
BFlat c44103f8c3 Merge pull request #6853 from dotCooCoo/feat/patterns-optical-effects
Swatch libraries: Patterns › Optical Effects adds wave, moiré and op-art patterns
2026-11-12 22:00:23 +07:00
BFlat 7cf4275fce Merge pull request #6866 from Taha-Mahmoodi/fix/macos-tmp-symlink-tests
tests: canonicalize macOS temp paths in two engine tests
2026-11-12 22:00:10 +07:00
BFlat 5c5bb69c37 Merge pull request #6671 from thisisgomaa/file/save-read-only-offers-save-as
Save on a read-only location offers Save As
2026-11-12 22:00:00 +07:00
ruchirguitar 5b2264bb8f Merge remote-tracking branch 'upstream/main' into fix/numfield-short-drag-1326
# Conflicts:
#	docs/gaps.md
#	docs/ui-parity.md
2026-11-12 19:52:50 +05:30
ruchirguitar be1b946b1e Docs: revision rows for the numeric-field tap tolerance (#1326) 2026-11-12 19:46:23 +05:30
ruchirguitar 3adadd52f4 UI: a tap within 1 pt still selects a numeric field's value (#1326)
Review feedback: with no tolerance, pen or trackpad jitter turned a tap
into a drag and the value was no longer selected. A release within 1 pt
of the press is a tap; anything further keeps the caret.
Regression test: a_tap_with_a_pixel_of_jitter_still_selects_all_on_release.
2026-11-12 19:40:04 +05:30
BFlat 71b889605d Merge pull request #6717 from dotCooCoo/feat/type-path-center-on-top
Type: Center on Top and Center on Bottom for type on a closed path
2026-11-12 21:04:31 +07:00
BFlat 9fcddf68d1 Merge pull request #6849 from dotCooCoo/feat/warp-images
Warp: the Warp effects bend an image's pixels with its frame
2026-11-12 21:04:22 +07:00
BFlat e280b28393 Merge pull request #6871 from dotCooCoo/fix/eps-predefined-cmap-type
EPS import: CIDFonts only named, over a predefined CJK CMap, set their characters as live type
2026-11-12 21:04:13 +07:00
BFlat 16bb8c37dc Merge pull request #6843 from dotCooCoo/fix/read-roots-findfiles
Read roots: links.findFiles and image.info follow the configured read roots
2026-11-12 21:04:04 +07:00
BFlat cebc0b6f6c Merge pull request #6872 from dotCooCoo/docs/plugins-safe-mode-wrap
Docs: docs/plugins.md paragraphs wrap at the file's width
2026-11-12 21:03:53 +07:00
BFlat 6961a96f89 Merge pull request #6842 from dotCooCoo/fix/legacy-ai-vertical-roman-tcy
Legacy .ai: type keeps Standard Vertical Roman Alignment and Tate-chu-yoko
2026-11-12 21:03:45 +07:00
BFlat 032770e046 Merge pull request #6848 from dotCooCoo/test/direct-group-selection
Tests: Direct Selection marquee and hover and Group Selection pass through raster effects
2026-11-12 21:03:35 +07:00
dotCooCoo 2212739c54 MCP: plug-in, recovery and script report replies leave out paths outside the read roots
A client confined by --automation-read-root saw paths outside its read
roots that the person or an earlier request had put in the session:

- plugin.list: the plug-in folder last loaded and its failed files;
  plugin.list and plugin.info: a plug-in's source file; plugin.list,
  plugin.safeMode and plugin.setEnabled: the file of a plug-in turned
  off for the next launch.
- file.recovery.list and file.recovery.restore: a document's original
  file; file.recovery.list and file.recovery.save: the recovery folder.
- ui.inspect's scriptReport: the files a run wrote and the included
  file a failed run stopped in.

A folder outside the read roots is now null, and a file outside them is
named by its file name. plugin.setEnabled {file} takes that name. The
restored documents keep their files, and unconfined clients and the
app's own UI see the same replies as before.
2026-11-12 06:03:01 -08:00
dotCooCoo 705503da6d Objects on Path: plug-ins may call Select and Move Object on Path
object.objectsOnPath.selectMember and object.objectsOnPath.moveMember
change only the document and its selection, as the other Objects on
Path commands do, so both join the commands a plug-in may call when its
manifest lists them.
2026-11-12 06:02:04 -08:00
dotCooCoo 0576806e1a Merge main into feat/patterns-optical-effects 2026-11-12 05:55:42 -08:00
dotCooCoo 8187f7ae00 Images: a CMYK JPEG turned by its EXIF orientation keeps its inks
A four-component JPEG whose EXIF orientation turns or flips it went
through the image decoder, which reads CMYK JPEGs as RGB, and was
stored as an RGB PNG without its inks. It is now stored the way a
turned CMYK TIFF is: its inks, 8 bits each, turned and written as a
CMYK TIFF with the turned resolution.

- vectorcraft_doc::cmyk::turned_cmyk turns the inks of a CMYK JPEG or
  TIFF, next to stored_cmyk_tiff; tiff_inks is private again.
- raster_image swaps the resolution axes inline, as its HEIF branch
  does.
- The links comment and the docs/target-app-parity.md line on EXIF
  orientation now describe the turned CMYK TIFF.
2026-11-12 05:45:26 -08:00
dotCooCoo 909f0ff301 SVG import: the path a text follows counts toward the <use> text limit
A text on a path that many <use> elements show was laid out along the
whole path once per <use>, and the path was found in the file and parsed
again each time, while the 1 MiB limit on texts built for <use> elements
counted only the text's nodes and characters. A file with a short text on
a very long path and many <use> elements of it could keep the importer
busy far past that limit.

- The elements of the path a <textPath> follows now count toward the
  limit. Past it, the remaining <use> elements show the text with its own
  properties, and the warning names text paths as well as text.
- The path of each <textPath> is found and parsed once and shared by
  every <use> that shows its text.

Files within the limit import as before.
2026-11-12 05:43:42 -08:00
dotCooCoo 0b22997201 Docs: the Dynamic Text entries in docs/mcp.md name point type
The Dynamic Text: Block entry says the Contextual Task Bar offers the
item for point type too, and that turning it on makes point type area
type with Block on. The Dynamic Text entry no longer says point type in
the selection is left as it is.
2026-11-12 05:33:38 -08:00
dotCooCoo f317aefa44 Tests: the file-dialog menu test reruns while fonts or plug-ins change
`the_menu_bar_is_inert_while_a_file_dialog_is_open` excused a missing
menu row when the composite font or plug-in it named was gone at the
time of the check. A test running alongside can remove such a font and
define it again between the menu read and the check, and the test then
failed. It now runs inside `undisturbed`, as the file's other tests that
compare menu reads do. When the shortcut, plug-in or font generation
changes during a run, the test runs again on a new app. Every row from
before the dialog must then be back as it was.
2026-11-12 05:32:35 -08:00
dotCooCoo 6e9ffa92cc Merge main into feat/brushes-dry-media-library 2026-11-12 05:31:21 -08:00
Ahmed Gomaa 421fead32b Merge upstream main into file/save-read-only-offers-save-as 2026-11-12 15:24:23 +02:00
dotCooCoo 1bf09bf72e SVG import: a <use> of a text passes its text properties on to the text
The element a <use> shows inherits from the <use> rather than from where it
is defined (SVG 2, https://www.w3.org/TR/SVG2/struct.html#UseElement). A
text shown by a <use> now takes the font, size, weight, fill, stroke and
other text properties the <use> or its parents set, in clip paths too,
while the text's own properties still win. Uses with the same parent and
properties share one text. A <use> inside the text it shows is ignored for
inheritance, and texts built for <use> elements stop at 1 MiB of text with
a warning.
2026-11-12 05:24:22 -08:00
Taha-Mahmoodi 0014d19257 Merge remote-tracking branch 'origin/main' into fix/macos-tmp-symlink-tests
# Conflicts:
#	docs/development.md
2026-11-12 17:45:37 +04:30
dotCooCoo 6849bd5422 Docs: docs/plugins.md paragraphs wrap at the file's width
Rewrap the prose in docs/plugins.md whose lines broke well short of
the file's 120-column width or ran past it, including the Safe Mode
sentence, the permission-name and install-confirmation sentences, and
the grants.json paragraph. Each rewrapped line is at most 120 columns.
No words, punctuation, code blocks or tables change.
2026-11-12 05:12:10 -08:00
dotCooCoo 366d09d285 Save As: a save goes ahead when the portal answers with a file type of another shape
The save dialog read the portal's current_filter with zvariant's tuple
conversion, which panics on a structure with fewer fields than the
tuple. On Linux and the BSDs the dialog's thread then ended after the
user picked a file, and nothing was saved. The label is now read only
from a (sa(us)) structure, the shape the FileChooser portal defines.
An answer of another shape keeps the path and names no file type, as
an answer without current_filter does. A structure with more fields
than (sa(us)) also no longer names a file type.
2026-11-12 05:09:40 -08:00
dotCooCoo 438a39fdf4 Render: blend steps' drop shadows draw under an opacity mask with Clip off
An object with an opacity mask draws offscreen over the bounds the
renderer gives it. For a live object (a blend, envelope or repeat) those
bounds took in effects in symbol art and brush art inside it, but not a
path's own effects, so with Clip off the drop shadows of a blend's steps
were cut off at the steps' bounds and did not draw where the mask art
leaves them uncovered. The bounds now also take in how far each path's
own effects paint past it.
2026-11-12 05:09:18 -08:00
BFlat 89fba4ebfd Merge pull request #5446 from Taha-Mahmoodi/fix/import-document-title
Fix #3626: an imported document takes the title the file carries
2026-11-12 20:09:15 +07:00