Commit Graph
15378 Commits
Author SHA1 Message Date
dotCooCoo 9255edc3d8 Merge main into feat/3d-classic-light-sphere 2026-11-15 09:29:07 -08:00
dotCooCoo bf2a90ed90 Merge main into feat/3d-bevel-reset 2026-11-15 09:28:38 -08:00
dotCooCoo a9119df4bc i18n: drop the ka and ru toolbar error rows that main already has 2026-11-15 09:24:23 -08:00
dotCooCoo bb3653e98f Docs: the command palette is named by its menu item, not by ⌘K
The egui crate's header comment and the M14.8 line in
docs/target-app-parity.md called it "the ⌘K palette" and "a ⌘K command
palette". Cmd+K runs edit.preferences, and help.commandPalette (Help ›
Search Commands…) defaults to Cmd+Shift+/. Both now name the menu item,
and the crate comment links the palette module.
2026-11-15 09:22:55 -08:00
dotCooCoo cd30b7b31e Merge main into fix/expand-appearance-nested-instance-effects 2026-11-15 09:20:32 -08:00
dotCooCoo 51803c222d Docs: moving a label can scale the plot of a graph saved without placedArt
docs/mcp.md said that moving a label on its own never moves or scales a
graph's plot. A graph saved without `placedArt`, or with one that has no
width or height, is measured on `placed`, the bounds of all of its art
including the labels. Moving an outermost label of such a graph on its
own changes those bounds, and the next redraw moves and scales the plot.
The paragraph now says so.
2026-11-15 09:19:33 -08:00
dotCooCoo 8263e36a8f Expand Appearance: shadow and glow images keep their blend mode
The image made of an object's shadows and outer glows took the default
blend mode, so a Multiply shadow (Drop Shadow's default) over colored art
became a plain shadow painted over it. When the shadows and glows all use
one blend mode, the image now paints with it, for the object's own effects
and for nested symbol instances alike.
2026-11-15 09:18:57 -08:00
dotCooCoo b6463e53cc Paragraph: threaded Kurikaeshi Moji Shori leads come from one pass over the frames
A thread of frames that hold only repeat marks or soft returns made each
frame look back through every frame before it, so opening or flowing such
a story took quadratic time, with the setting off as well. The leads are
now carried forward in one pass.
2026-11-15 09:13:16 -08:00
dotCooCoo 1e32738b8f MCP: confined SVG output checks the linked images the file draws
The read-root check for SVG output now looks at the same art the
writer draws:

- A placed document's art is checked, with the pixels its file holds.
  A placed native file that links an image outside the read roots was
  written with that path under Images: Link.
- Hidden objects inside symbols, patterns and graph designs are left
  out unless hidden layers are kept, as they are in the layers.
- With profile tiny12 the file leaves out opacity masks, and their
  images are not checked.
- An object whose effect SVG has no filter for is checked as the image
  the file draws of it, for file output and clipboard.exportSvg alike.

The last three refused files and clipboard SVG that name no file
outside the roots.
2026-11-15 09:13:08 -08:00
dotCooCoo 19c7b2bd46 Merge main into fix/js-interp-errors-translated 2026-11-15 09:08:56 -08:00
dotCooCoo 79c696d879 Merge main into feat/3d-soft-shadows 2026-11-15 09:08:53 -08:00
dotCooCoo be4dab1e8c Merge main into feat/recolor-add-remove-color-tools 2026-11-15 09:08:28 -08:00
dotCooCoo 3e4b8d81ff Merge main into fix/an-image-whose-recode-fails-is-written-without 2026-11-15 09:08:24 -08:00
dotCooCoo fd468f0042 Merge main into fix/custom-toolbar-errors-translated 2026-11-15 09:08:24 -08:00
dotCooCoo 59889cd2af Merge main into feat/properties-graph-section 2026-11-15 09:08:13 -08:00
dotCooCoo 73502e83ac SVG: hidden pieces of a cut image put no shared image in the defs
The pieces a Warp effect cuts an image into share one <image> in the
defs. The writer counted every piece, hidden ones included, so pieces
the file leaves out (hidden, or in a hidden clip group) still put an
<image> into the defs, with the linked file's path under Images: Link.
A confined caller's read-root check looks only at the art the file
draws and did not refuse it.

Image sharing and the colorized-image counts now walk only the art the
writer draws: hidden layers and objects only with hidden layers kept,
and never a template layer's art.
2026-11-15 09:06:13 -08:00
FredApps 31658546a8 fix(codecs): build the cutover against craft-libs d6cd7836d
- Test files whose image→craft-image-codecs rewrites didn't compile against
  main's newer tests go back to main's versions (engine fileio/tests.rs,
  tests_tiffbmp.rs, tests/menucmds.rs, eps tests.rs); they still use the image
  crate, which keeps its format features.
- craft_jxl::encode, craft_image_codecs::encode and Image::icc at d6cd7836d.
- jp2read and pdf export pass DecodeOptions, not Limits.
- EPS DCTDecode: grey JPEGs no longer use the image after moving it, and keep
  main's one-channel output.
- svg keeps its direct usvg dependency for main's image href code; pdf keeps
  jpeg-encoder for CMYK JPEGs.
- clippy -D warnings and rustfmt clean.
2026-11-15 18:05:45 +01:00
BFlat 5bd8acfce9 Merge pull request #7762 from dotCooCoo/feat/3d-classic-track-cube
3D (Classic): the track cube turns the object on the Rotation tab
2026-11-16 00:04:07 +07:00
dotCooCoo 3dad1013a4 Image Trace: Noise leaves cut-edge blends out of a speck's color
When Noise picks the nearest color for a speck, the speck's average now
leaves out the semi-transparent pixels along a cut-out image's edge that
are the color beside them blended with the transparent background.
settle_cut_edges returns which pixels those are. A speck made only of
them merges by border. In Grayscale the speck's gray is read with luma,
the gray Grayscale traces with, and the test probe shift_probe denoises
as a trace does.

The docs now say the rule applies in Color and Grayscale (in Black and
White a region has only one neighboring color, so Black and White Logo
changes only by its Noise value), name `ea3f81d9c3` as the base of the
measurements, and say that the gradient-border test sets Noise 15
because at Noise 8 its borders stray 0.92 px against a 0.9 px limit.
2026-11-15 09:01:14 -08:00
dotCooCoo 65b2129138 Live Paint: livePaint.strokeEdge refuses a through id that is not one of the group's edges
`through` now takes only the ids of the group's edges, each once: a face's
id, an unknown id, another group's edge or an edge given twice is an error
and changes nothing. A hidden edge in it is still skipped by the join. For
a double-click the Bucket passes only edges of the group, each once, so an
earlier click that filled a face whose fill was the edge's stroke paint
(Paint Fills and Paint Strokes both on) no longer sends that face.

The Bucket finds the faces a fill drag crossed among those whose bounds
meet the drag's bounds only.

A canvas test covers the middle-button press and the Space-held press
between two Bucket clicks. The progress-doc line lists the new tests, and
docs/mcp.md says which edges the tool passes in `through`.

Follows #7875.
2026-11-15 09:00:15 -08:00
BFlat a391dedfe5 Merge pull request #7875 from dotCooCoo/fix/live-paint-bucket-click-history
Live Paint: Bucket double-click and triple-click match the paint from before a drag, a view-tool press or a joined edge
2026-11-15 23:56:28 +07:00
BFlat cf34cf8ed0 Merge pull request #7829 from dotCooCoo/fix/shadow-validation-builds-its-shadow-geometry
3D: shadow validation casts from the solids it checks
2026-11-15 23:56:19 +07:00
Dylan M. Taylor 40518f790c Pin native writer APIs to merged craft-libs 2026-11-15 16:56:16 +00:00
dotCooCoo be2f993c4b PDF export: Preserve Numbers keeps a gray image's profile when RGB is tagged as sRGB
With Preserve Numbers, a non-sRGB RGB destination and RGB colors
ICC-tagged as sRGB (the `all` profiles setting, PDF/A-2b, PDF/X-3 and
PDF/X-4), a gray image that carries an ICC profile was converted to sRGB
grays and lost its profile. It now keeps its profile there, as in the
other destinations other than sRGB.
2026-11-15 08:56:03 -08:00
dotCooCoo 24867f7827 Paste: legend labels in a pie's wedges follow wedges that take the document's swatch
When a pasted pie's wedge links a global swatch that the document gives
another color (swatchConflict "merge", the default), the wedge takes the
document's color. Its legend label kept the contrast it had in the copy,
so a wedge that turned dark could show a black label, and one that
turned light a white label, until the pie was drawn again.

Pasting now reads which wedges show a dark fill before the copy is
linked to the document's swatches. A pie whose wedges change darkness
gets the legend label contrast a redraw sets: white on a dark wedge,
black on a light one. Pies whose legend labels have a fill of their own
keep it. This applies to every paste command, Paste without Formatting
included, and to pies inside opacity masks.
2026-11-15 08:53:31 -08:00
dotCooCoo c08b4d932f MCP docs: Kurikaeshi Moji Shori says null leaves the setting as it is 2026-11-15 08:52:00 -08:00
dotCooCoo 303d0c0a05 PSD: a version 6 slice record whose ID is 16 is read as a slice
A version 6 slices resource may follow a record with a descriptor of
version 16, and the reader took any record that starts with the value
16 for one. A record whose ID is 16 then had its first bytes read as a
descriptor, and the records after it were misread or left out. When the
records read one after another, followed by nothing or by one
descriptor (the layout ag-psd writes), only the last record is checked
for a descriptor. Files that follow each record with a descriptor are
read as before.
2026-11-15 08:45:10 -08:00
dotCooCoo dc8054fb39 PSD: a slices resource cut short warns that the slices were left out
When image resource 1050 declared more bytes than the image resources
hold, the lookup stopped as if the file stored no slices, and Open and
Place brought the artwork in without the warning that the slices were
left out. The new psdread::resource tells a cut-short resource 1050
apart from one that is absent or that follows another block cut short,
and the slices reader passes that error on, so the warning names it.
Other resource readers keep their behavior.
2026-11-15 08:45:10 -08:00
dotCooCoo cdd4078907 Paste: Paste without Formatting sets pie legend label contrast from merged swatch colors
Paste without Formatting sets each pie legend label in a wedge to white or
black from the wedge colors before it pastes, but a wedge linked to a global
swatch that the document gives another color takes the document's color
only during the paste (swatchConflict "merge", the default). A light wedge
merged into a dark swatch kept a black label, and a later redraw turned it
white.

The copied colors linked to merged swatches now take the document's color
before the labels are set, so the labels match what a redraw sets. Graphic
style links are left for the paste to relink.
2026-11-15 08:42:15 -08:00
dotCooCoo f1f4d629e8 Panels: the double triangle on a panel's tab strip cycles its display sizes
A double triangle at the right end of the tab strip of Align, Attributes,
Character, Color, Flattener Preview, Gradient, Info, Paragraph, Stroke,
Transform and Transparency steps the active panel through its display
sizes. The sizes are the states the panel menu's Show/Hide Options items
set (Transparency: thumbnails and options, thumbnails alone, neither),
largest first, and the smallest goes back to the largest.

window.panel.cycleOptions {panel} does the same and returns
{panel, size, sizes}. An unknown panel or a panel without sizes is an
error and changes nothing.

Docs: docs/mcp.md, docs/control-protocol.md, docs/ui-parity.md.
2026-11-15 08:39:43 -08:00
dotCooCoo e02faf2293 Merge main into fix/trace-noise-nearest-color 2026-11-15 08:38:54 -08:00
dotCooCoo f0ba18f793 Place: the place cursor keeps an encrypted PDF and asks for its password
file.place.queue read each file without a password, so an encrypted
PDF, .ai or .ait file was skipped and never reached the cursor. It now
stays in the cursor at 612 x 792 pt, VectorCraft's own size, with
needsPassword: true and no thumbnail. A click or drag on it in the app
asks for its password, with the Place dialog's Show Import Options on
or off; headless, a click on it places nothing. A file that fails for
a bad option or for another reason is still refused or skipped.

File > Place of an encrypted PDF given a page and no password, with
Show Import Options on, now asks for the password too, as it does with
the option off; it used to fail for want of the password.
2026-11-15 08:36:54 -08:00
dotCooCoo 0cf2aa3f79 Effects: removing or duplicating several aligned effects of a design's art refuses one that no object has
With the art of a graph design in a series given first and aligned: true,
effect.remove and effect.duplicate with `indices` skipped an effect of the
art that no other object has, and edited the others. With art [shadow,
roughen], a mark [shadow] and indices [0, 1], effect.remove took the
mark's shadow off and succeeded. Such an edit is now an error that leaves
the document and its undo history as they are, as the same index given
alone already was. An object that lacks one of the effects while another
object has it is still left out for that effect.
2026-11-15 08:36:31 -08:00
dotCooCoo 94c815d971 Paint: invert and complement of design art alone still reject a bad target
paint.invert and paint.complement given only the art of a graph design,
with no item, returned success for a target other than "object" or
"contents", because the topmost-fill path read the target only after the
early return for design art. The target is now read before that return.
2026-11-15 08:36:20 -08:00
FredApps 5d492ebad2 Merge #7664 (fix/restore-codec-cutover-ci) into feat/cutover-remaining-codecs
Conflicts resolved in favour of main/#7664 in the 13 source files both touched
(doc/cmyk.rs, metafile/dib.rs, pdf images, svg import/files.rs, render paint and
encode tests, trace, engine load.rs), keeping main's newer TIFF/CMYK, DIB and PDF
image fixes. vectorcraft-doc stays on main's version until its CMYK reader moves
to craft-tiff. The image crate keeps its format features, and usvg, tiff,
zune-jpeg, hayro-ccitt and jpeg-encoder stay for the readers not yet moved.
Codec crates pinned to craft-libs d6cd7836d364177661b0ae17f48a0805e83a5f32.

Also fixes the compile errors CodeRabbit flagged (jp2read DecodeOptions,
filters.rs use-after-move) and the encode() arity at d6cd7836d.
2026-11-15 17:35:43 +01:00
dotCooCoo 527a2142d9 Effects: Radial Blur's dialog sends a saved Blur Center outside the bounds at the edge
A Radial Blur whose saved centerX or centerY lies outside 0 to 1 draws
at the nearest edge, and its dialog showed the center there. The dialog
kept the saved value in its fields, though, so OK without moving the
center sent that value, and effect.setParams refused it.

The Blur Center box now writes the center it shows, kept within 0 to 1,
into the dialog's fields on every frame, so OK stores the edge.
2026-11-15 08:35:38 -08:00
dotCooCoo 133e54b970 Gradients: a gradient spanning the selection on a lower stroke fits the box that stroke paints
With span: "selection", paint.setStroke placed the gradient on the union of
each target's topmost stroke box, also when `item` named a lower stroke,
including an aligned row of a graph design's art. With a 40 pt lower stroke
under a 1 pt topmost one, the gradient reached 0.5 pt past the objects
instead of 20 pt. Each target's box is now that of the row it edits.
2026-11-15 08:34:35 -08:00
dotCooCoo 4f09041edc 3D and Materials: the Bevel section's Reset restores only the bevel settings
A Reset button next to Extrude & Bevel's Bevel heading, on the Object
tab of the options dialog and of the 3D and Materials panel, sets Bevel
Shape, Width, Height, Repeat, Space, Bevel Inside and Bevel both sides
back to their defaults. Depth, Twist, Taper, Cap, the rotation, the
lights and the graphics keep their values. In the panel the reset goes
to each selected Extrude & Bevel as one undo step. The button is
unavailable while every bevel setting is at its default, and a setting
the selected effects hold with different values counts as changed.
2026-11-15 08:31:47 -08:00
dotCooCoo 1df834568d Variables: Variable Options fills the field left unset after the Variable changes
Setting the Variable field through ui.dialog.set clears Name and Kind
until a frame fills them from the chosen variable. Setting Name or Kind
alone before that frame marked the fields as filled, so the other field
stayed null and the dialog showed "null" for Name or a blank Kind. OK
already read a null field as the variable's own value, so only the
displayed field was wrong.

A frame now fills every field when the chosen variable changes, and
after that fills only a field that is still null, keeping a field that
was set.
2026-11-15 08:31:19 -08:00
dotCooCoo 9382b0ab0a Place: an import dialog a drop opened places in the document the file was dropped on
A file dropped on a canvas that asks for import options (a layered PSD,
a PDF with several pages, a DXF drawing, a text file) kept only its
placement params in the dialog. The dialog's OK then placed the file in
whichever document was active at that moment, and placed it even when
the dropped-on document had been reverted since.

The drop now carries its target document and revert count in the place
params, as the place cursor's import options carry their token. Placing
checks them on the drop and again on the dialog's OK: the file goes to
the document it was dropped on, which becomes active again, and is not
placed when that document has been closed or reverted. The dialog then
stays open and shows the reason. The checks drop_files ran itself now
run in that one place.
2026-11-15 08:30:35 -08:00
dotCooCoo 521f5dc6c8 Selection: Select Behind keeps one limit of symbol art when it falls back
Select Behind gave the general traversal a fresh limit of symbol art when
it fell back to it, for an envelope in Edit Contents or a root that is
not a layer. One Select Behind could then walk twice MAX_SYMBOL_NODES
objects of symbol art.

A root that is not a layer now sends Select Behind to the general
traversal before the first pass walks any art. For an envelope in Edit
Contents, the objects the first pass found stay first, and the general
traversal finds the rest with what is left of the limit.
2026-11-15 08:30:27 -08:00
dotCooCoo e837dae7b3 Export for Screens: artboard name fields close on a first-frame key and commit when another opens
Escape or Enter pressed in the first frame that draws an artboard's name
field was dropped: the field asked for focus and skipped its key checks,
while the dialog kept itself open for the field. The field now ends the
edit on either key in that frame too.

A double-click on an earlier artboard's name, with both clicks in one
frame, replaced the edit of a later artboard before that artboard's field
was drawn, so the name typed there was lost. The typed name now goes to
its artboard before the new field opens.

Follows #7695.
2026-11-15 08:30:11 -08:00
dotCooCoo d089df0ab5 Recolor Artwork: Find tries every lighter tint down to 1%
When a selected row listed the twenty tints from 25% through 6% of a color
of an unselected row, Find left that color undimmed although its 5% tint
was free. The search now tries each tint a percent apart from 25% down to
1% before leaving a color as it is.
2026-11-15 08:28:08 -08:00
dotCooCoo 2dceb279d3 Merge main into fix/graph-axes-group-edits-kept 2026-11-15 08:25:28 -08:00
dotCooCoo d39334a751 Graphs: a row written to an axis line is kept for its kind
appearance.addFill and appearance.addStroke on an axis line, tick mark
or radar ring stored only the attributes the new row changed on the
line, so a stroke the kind kept from another line came back when the
graph was drawn again, although the line showed the new black stroke.
They now store the row they add for the line's kind when it becomes the
line's topmost visible row of its kind.

An appearance.copyFrom of some attributes, appearance.setItem and
stroke.set stored only what they changed, so a paint, stroke weight,
row opacity or blend mode that the line already showed did not replace
what its kind kept. What they write to the line's topmost visible rows
is now stored for the kind, as paint.setStroke stores the paint it
writes. Row opacity and blend mode are stored apart, so an edit of one
leaves the other as the kind keeps it, and a null weight or opacity
writes nothing.
2026-11-15 08:25:21 -08:00
FredApps 1a9fc9fbe2 Merge remote-tracking branch 'origin/main' into pr7664 2026-11-15 17:24:49 +01:00
dotCooCoo 93c7f4d88b Merge main into fix/pdf-dont-include-profiles-removes-image-profiles 2026-11-15 08:19:34 -08:00
dotCooCoo ccbfc61b46 Merge main into feat/kurikaeshi-moji-shori 2026-11-15 08:19:29 -08:00
dotCooCoo 1bdac35a94 Merge main into fix/pdf-preserve-numbers-tagged-images 2026-11-15 08:19:22 -08:00
dotCooCoo 4573e47ab8 Merge main into feat/3d-classic-black-overprint 2026-11-15 08:19:15 -08:00