Select > Same, Select by Color (select.color) and document.find looked up
the parent of every object they checked by its id, through
Document::parent_of and Document::node, to tell members of a compound
path and faces of a Live Paint group from other objects. The walk
already stands on that parent, so it now hands it to the check with the
object. walk_selectable keeps its signature and visits the same objects
in the same order.
The selected objects, their order and the count reply are the same as
before, and so is the Reselect state of Select > Same. Tests compare the
walk and the parents it hands out with the old walk and
Document::parent_of, and the results of six Same commands and
select.color with the old per-id loop, in four isolation scopes, from
rectangles at the top level, in a group and in a sublayer, compound path
members, Live Paint faces and a compound path. In a damaged document
that holds an id twice, the parent read is the one that holds the
object being checked.
The gain shows on large documents. With 220,482 objects, the search of
Select > Same > Fill Color takes a median of 24 ms of CPU time instead
of 83 ms, and of Stroke Color 22 ms instead of 60 ms (release build on
Linux, seven alternating runs of both loops in one process; an ignored
test, select_same_perf, times them).
A swatch dragged from the Swatches panel, in any view, and released on
the New Swatch button is copied through swatch.duplicate without
opening the New Swatch dialog. A swatch that is part of the selection
carries the other selected swatches with it, and the copies of one drop
are one undo step. Each copy goes just after its swatch and in its color
group, takes the usual "copy" name, and is selected. Modifiers held on
release do not change the drop. Color groups, None and Registration are
not duplicated; a user swatch whose name starts with a bracket is. The
button is outlined only while such a swatch of the active document is
held over it, so a paint from another panel, art, a swatch dragged from
another document and a swatch deleted during the drag duplicate nothing.
A click on the button still opens New Swatch.
The help page lists the characters Type > Show Hidden Characters makes
visible: paragraph returns, forced line breaks, tabs, spaces, nonbreaking
spaces, discretionary hyphens and the end of the text
(https://helpx.adobe.com/illustrator/desktop/design-with-text/special-characters-glyphs/insert-white-space-and-break-characters.html).
The canvas marked only plain spaces, paragraph ends and the story's end.
It now draws an arrow across each tab's advance to its stop, a ring over
a nonbreaking space (U+00A0) and a smaller one over a narrow nonbreaking
space (U+202F), a short tick over the spaces of a set width (U+2000 to
U+200A, U+205F, U+3000), a not sign at a discretionary hyphen (U+00AD)
whether or not the line breaks there, and a bent arrow after a line that
a forced line break (U+2028) ends, which no longer gets a pilcrow. The
mark shapes are VectorCraft's own.
The marks follow each glyph's baseline, so they sit along the column in
vertical type and along the path in type on a path, which had no marks
before. A right-to-left line gets its pilcrow at its left end.
Opening a .ai from its editing data alone checked whether the text
document makes all of its type, then built the document, and each step
decoded and parsed the text document and scanned the text objects'
frames again. A file with envelopes of type, which waits on its PDF
part, did this up to four times.
The check and the builds now share one read of the frames and of the
text document. It is kept with the decoded editing data for the build
with the PDF part and for the build without it that can follow, also
when the check failed. The build applies its own pattern paints to the
shared text document, as before.
The document and notes are unchanged: new tests compare them against
the same opens with every check and build reading the text afresh, and
count one read and one scan on each route.
The line under the Preferences fields now shows a sentence for the Smart
Guides box and for each of the 14 Smart Guides settings, from Color to
Snap to Perpendicular, when the pointer is over the row or its control
has the keyboard focus. A screen reader gets the same sentence as the
control's description. Every complete catalog has a row for each one.
Tests: the one-sentence test covers the Smart Guides category, and new
tests check the hover and keyboard-focus sentences.
Leaving isolation mode in a Live Paint group (object.exitIsolation, or
object.isolate on a level outside the group) adds the shown, unlocked
paths, compound paths and groups of them drawn in it to the group as
Live Paint > Merge does, in one undo step. Faces and edges the new paths
do not cross keep their paint. This also applies when a group drawn in
the Live Paint group was isolated in turn. An exit with nothing to add
changes nothing and records no undo step.
Type, images, and hidden or locked objects drawn in the group, and
groups holding one, stay in it as they are. Gap Options, Merge and
Release now keep them; before, they replaced every child of the group
with the rebuilt parts, so such objects were deleted. Only the group's
sources group and paths named Face or Edge count as its parts.
Help page: https://helpx.adobe.com/illustrator/desktop/paint-and-fill/learn-painting-basics/modify-live-paint-groups.html
While the Type tool edits text on Windows and Linux, Alt+8, Alt+G, Alt+;,
Alt+7, Alt+6, Alt+2, Alt+R, Alt+-, Alt+Shift+-, Alt+[, Alt+Shift+[, Alt+]
and Alt+Shift+] type a bullet, copyright sign, ellipsis, pilcrow, section
sign, trademark sign, registered sign, en dash, em dash and curly quotes at
the caret, or in place of the selected text, as one undo step. Text that
the keyboard layout or an input method types for the chord is typed as it
came, and AltGr (Ctrl+Alt) keeps its own characters. On macOS, Option
types these characters as before. Outside text editing the chords type
nothing.
- The Blend Options dialog sends the spacing, count or orientation only
when it was set in the dialog or differs from the first blend's, so
OK on several blends no longer copies the first blend's spacing and
orientation onto the others.
- object.blend.options: a spacing mode without a count keeps the count
of a blend already in that mode. An orientation other than page or
path, a spacing that is not a string, and `value` without `spacing`
are errors (orientation also in object.blend.make and the options new
blends start with).
- The Blend panel dims Type and Ramp while any selected blend has no
spine, since the command refuses easing for such a selection.
- Tests check the live preview while a Ramp or Shift drag is under way.
Supersedes #8022 by ruchirguitar.
Each spot ink in the Output section's Document Ink Options list now has
an icon before its name. Clicking it prints that ink as process: its art
separates onto the process plates and it gets no plate of its own, while
the other spot inks keep theirs. Clicking again keeps it as a spot ink.
While Convert All Spot Colors to Process is on, every spot ink converts
and the icons are dimmed; each ink keeps its own choice for when the
option is turned off. A converted ink's Print box, frequency and angle
are dimmed.
file.print and print.preview take convertToProcess on an output.inks
entry, and print.preview lists every document ink, converted ones
included, in documentInks.
Choosing the Pen again while it draws a path inside a compound path sends only select.set for the compound path, as Escape and Enter do: the path stays open, no undo step is added and the next click starts a new path. Ending a path outside any compound path sends no selection change.
The writer measured which way each patch turns only at its first corner,
along the straight lines to the next corners. A patch whose point is
dragged across it, or whose handles cross at a corner, passed as a
plain patch and was written as a mesh. Each corner of each patch is now
measured along the straight lines and along its handles, and a mesh
whose corners turn different ways is written as its drawn look with the
warning.
- Tests: a patch folded at a corner by a moved point and by crossed
handles; a reflected mesh read back draws the same points and opacity
across each patch; an envelope in a symbol's art with its grid and
contents in the symbol's own space opens as the art it draws, and one
in a file without a template box is left unread.
- The fuzz case for written meshes moves next to the other editing-data
cases in import_fuzz.rs.
- Docs: file-format-parity.md says a reflected mesh opens with each
row's points in reverse order, and how envelopes in symbols open;
target-app-parity.md links the help page on mesh point opacity.
Type > Insert Break Character > Forced Line Break (type.insert
{char: "forcedLineBreak"}) inserted a line feed, which starts a new
paragraph. It now inserts U+2028, the character Shift+Enter types, so the
new line stays in the same paragraph; paragraphReturn still inserts a line
feed.
While the Type tool edits text and no ids are given, type.insert (every
Insert Special, Whitespace and Break Character item) now replaces the
tool's selection or inserts at its caret, as one undo step, and moves the
caret after it. After Select All in threaded text it replaces the whole
story. With ids or id it appends to the objects they name, and without a
Type tool edit it appends to the selected type objects.
A menu item whose label ends with "…" opens the generic parameter dialog
headed by that label without the "…". The heading looked up only the
label without the "…", and most catalogs hold "Clean Up" only as the
menu label "Clean Up…", so Object › Path › Clean Up… was headed "Clean
Up" in French. The heading now takes the menu item's row without its
"…" and falls back to the plain row, in the order the effect dialog's
heading uses (dialogs/effect.rs, heading_label). Where a catalog has
both rows with different wording, the heading now reads as the menu
item does.
Clean Up's options now have rows in every complete catalog: "Empty Text
Paths" was missing from all of them, and Gujarati also lacked
"Unpainted Objects".
A Shift-click with the place cursor now opens the current file's import
options (Text, DXF, Place PDF or Place PSD) before it is placed, whether
the cursor was loaded with Show Import Options on or off or by
file.place.queue. OK places the file at the click and the cursor moves to
the next file. The options the cursor was loaded with for the file's
format are put aside so the dialog opens, and are used when no dialog
opens for the file (a PNG image, a one-page PDF, a linked PSD file). A
Shift-drag places at the dragged size, as a drag does. Headless, where no
dialog can open, a Shift-click places as a click does.
The place tool marks a Shift-click's file.place with
showImportOptions: true.
Docs: docs/mcp.md, docs/target-app-parity.md.
select.magicWand searched lists in three places: paintable looked up
each object's parent in the list of compound paths, add mode looked up
each hit in the selection, and subtract mode looked up each selected
object in the hits. These lookups now use HashSets. The output is still
built by walking the lists, so the wand selects the same objects in the
same order as before.
A test compares paintable, added, subtracted and select.magicWand in
set, add and subtract mode with copies of the earlier searches on a
20,000-path document. An ignored release-build probe times both.
While the palette is open, the highlighted result is marked where it
lives, in the same frame the arrow keys or the pointer move the
highlight. A result with an item of the in-window menu bar has that
menu's title outlined, and a box under it shows the item's whole path
(Effect › Stylize › Round Corners…). A panel points at the Window menu.
A tool has its slot's button outlined on the toolbar its row names, or
its own button on a strip torn off its group. The box beside it, on
the canvas side of the toolbar, names the tool, or reads "In the Direct
Selection Tool group: press and hold to open it" for a tool hidden in a
group; screen readers hear that sentence with the search field's
description. The box stays inside the window and off the button and
the palette's popup: beside a button, its text wraps to up to three
rows to fit before the popup or the window's edge, and where it still
would not fit, the footer shows the text and only the outline is
drawn. When the popup covers the control,
nothing is drawn and the footer names the home. Highlighting a result
opens no menu, flyout or All Tools drawer, shows no toolbar and leaves
the chosen tool as it is.
With the system's menu bar, nothing is drawn over it, and the footer
reads "In the menu bar:" and the path. When no control in view shows
the home (Presentation Mode, toolbars hidden by Window › Tools or Tab,
a button scrolled out of view or under a floating panel or another
toolbar), the footer names the home followed by "not shown now". A
command with no menu item reads "No menu item" there, with its
shortcut.
The menu bar, the Tools panel, the toolbars made with New Toolbar and
the strips torn off them note where they draw each control only while
the palette is open, and only controls wholly in view. The list keeps
one pass of each window. The palette uses
only the controls noted in the current pass of its own window, and
shows no footer line for the home in the pass that opens it, before
anything is noted.
learn.locateTool's search for a tool's place moves into a function
without side effects (locate::find), which the palette calls with the
order its rows use. Learn calls it and then shows the toolbar, flyout
or drawer as before, and the mark's outline is shared.
New strings have rows in every catalog.
P, a click on the active Pen's button and `tool.select {tool: "pen"}`
now end the path being drawn through the same cleanup as Escape: the
path stays open and selected (a path inside a compound path leaves the
compound path selected), the Pen stays chosen, no undo step is added,
and the next click starts a new path. An anchor or handle being dragged
is committed first. With no path being drawn nothing changes.
Before this change the Pen kept drawing the same open path when it was
chosen again; the Blend test that stated that rule now checks the new
behavior.
When the Color Guide's base is a spot color, or a tint of one, picked in
the Swatches panel, with the Color panel's tint slider or with the base
chip, the cells right of the center in the base row of Tints/Shades are
now tints of that spot color. A click paints the art with the tint, a
drag carries it, and Save Colors as Swatches and Save Color Group to
Swatches make tint swatches linked to the spot color, so they follow an
edit of it. Shades, other rows, Warm/Cool, Vivid/Muted and a Limit to
Library give process colors, as before.
A cell's tint is the base's tint reduced by the share the cell goes
toward white. The guide follows a rename of the spot color swatch.
`swatch.new {colors}` and `swatch.newGroup {colors}` take
`{swatch, tint}` entries: a tint below 100% of a global or spot color
becomes a tint swatch ("Name 40%") linked to it.
A swatch or color group dragged from the Swatches panel, in any view,
and released on the Delete Swatch button is deleted through
swatch.delete, even while nothing is selected and the button is
disabled for clicks. A swatch that is part of the selection carries the
other selected swatches of its kind with it. The drop asks first as a
plain click does, and Alt does not skip the question; Cancel keeps
everything, and OK deletes them in one undo step. None and Registration
are never taken. The button is enabled while swatches are selected or
while a swatch or group of the active document is being dragged, and it
is outlined only while such a swatch or group is held over it. A paint
from another panel, art, and a swatch dragged from another document
delete nothing.
The list's drop zone now ends where the list does. It used the list's
height before the list shrank to its rows, so with few rows it reached
over the buttons below and took a release on them: a paint dropped on
Delete Swatch became a new swatch.
A selected live polygon shows a small diamond beside the middle of the
right side of its bounding box, with the Selection tool and with the
Rectangle, Rounded Rectangle, Ellipse, Polygon and Star tools, while the
bounding box and edges are shown. Dragging it sets the side count from 3
to 11: down adds a side and up removes one for every 12 screen pixels
along the box's own vertical axis, and the pointer shows the count while
measurement labels are on. A polygon of more than 11 sides keeps its
count until the drag goes up, which gives it 11. The drag sends
object.setLiveShape {sides} in one undo step, none when the count ends
where it began, and Escape puts the count back. Typed counts keep their
3 to 1000 range. The widget is drawn only while the box is drawn, so it
hides during a move, a turn and its own drag.
The help page describes the widget and its 3 to 11 range:
https://helpx.adobe.com/illustrator/desktop/draw-shapes-and-paths/modify-live-shapes/add-or-remove-sides-from-polygons.html
The widget's look and place, the drag direction, the step and the rule
for more than 11 sides are VectorCraft's own.
Docs: docs/target-app-parity.md and docs/ui-parity.md.
On a path or compound path, a Transform effect with copies listed after
the object's own Rasterize effect now places the one image Rasterize
makes of the art before it on the original and on each copy: copy k
through the effect's map applied k times, with its pixel grid and its
room around the art, the last copy lowest and the original on top.
Before, the Transform effect copied the art and Rasterize made one image
of all the copies on a grid square to the page.
The image is made once for every placement, also when a shadow or glow
is listed between the Rasterize and Transform effects. The canvas, the
object's bounds, Expand Appearance and PDF export use the same
placements; Expand Appearance and PDF export make a group of images that
share the one image's pixels. Copies stop where the copied art stops,
and a copy scaled to nothing is left out.
The line under the Preferences fields now describes each of the 12 Guides
& Grid settings, from Snap to Grid to Pattern Editing's Tile Edge Color,
when the pointer is over the row or its control has the keyboard focus,
and a screen reader gets the same sentence. Each sentence states what
VectorCraft does with the setting. Rows are added to every complete
catalog.
Tests: the one-sentence-per-setting test now covers Guides & Grid, and
two new tests check the sentence on hover and on keyboard focus.
The editing copy of a PDF-compatible .ai wrote every gradient mesh as
its drawn look. Meshes the .ai reader reads back as they are are now
written as meshes:
- Each mesh is a /Mesh record: 2 /Version, its type and grid size,
/Data, then each patch row by row with its place, the color space
where it changes (gray, RGB or CMYK) and its four corners: color,
opacity, point, and the handles towards the next corner and the one
before it. Its opacity, blending mode and knockout shape are set
before the record, and its name and opacity mask follow it.
- A reflected mesh, whose patches all turn the other way, is written
with its columns in reverse order, which draws the same mesh.
- In a symbol's art the corners are written about the canvas point of
the ruler origin, y up, as an image's matrix there is. An envelope's
grid in a symbol's art is now written in the same space, and the
envelope's contents in its dictionary in the canvas's space, y down.
- Each mesh is checked with the reader's own reading before it is
written. Written as their drawn look with a warning: meshes with a
point in a Lab color, with more than 128 rows or columns, folded
meshes (patches that turn different ways), meshes the reader would
read with other points, handles or colors, meshes in pattern tiles
and in art cut to a clipping object, and every mesh on a large
canvas. A mesh's drawn look is written at any depth of nested
symbols and live objects.
Each construct is written in the form the .ai reader at e142c5fcee
reads: /CS, /Type, /Size, /P, /N and /E in mesh.rs:180-234, corners
with or without an opacity by their count of values in read_corners
(mesh.rs:239), the patches joined into one mesh in one_mesh
(mesh.rs:298); /Mesh X!, X# and /End X! in read/ops.rs:219-232; the
transparency after the record in read/art.rs:281 (end_mesh) and
read/ops.rs:344. /Version and /Data are passed over by that reader
(mesh.rs:234). Corners in a symbol's art rest on a reader change in
this commit.
The reader changes how any .ai opens:
- Mesh records and envelope grids in a symbol's art are read in canvas
space (read/document.rs:947 image_space), and an envelope's contents
in its dictionary in the canvas's space, y down. In a file without a
template box such a mesh is left unread, its symbol is not read
whole, as with an image there (read/art.rs:634), and its instances
open as the page draws them. Envelopes in symbols in .ai files saved
by earlier VectorCraft builds open differently.
- A point of a patch whose corners differ in color model keeps its own
color when the patches are joined into one mesh.
Gradient meshes, mesh points and their opacity:
https://help.adobe.com/archive/en_US/illustrator/cs5/illustrator_cs5_help.pdf#page=200
Patch meshes (corners joined by cubic edges with control points):
https://opensource.adobe.com/dc-acrobat-sdk-docs/pdfstandards/pdfreference1.7old.pdf#page=321
Tests: the round trip of meshes with RGB, CMYK and gray points, a moved
point with handles of its own, part-transparent points, a name,
opacity, blending mode and knockout shape, hidden and locked, with an
inverted, unlinked opacity mask, in groups, opacity masks, symbols,
opacity masks in symbols, a document of two artboards and eight levels
down, compared point by point, handle by handle and channel by channel
at the 4 decimals written; reflected meshes, mirrored across and
along; the record's form, including corners in a symbol's art and an
envelope's grid and contents there; an envelope in a symbol read back
with its contents and their gradient in place; the same bytes on a
second write; each case written as its drawn look, with its paths read
back over the mesh's box; reading a mesh in a symbol's art with and
without a template box; /Version and /Data passed over; the color
model rule; fuzz cases for damaged written meshes, a symbol's
included.
Docs: docs/file-format-parity.md, docs/target-app-parity.md.
The starting desired size came from the preview cache, matched by settings
only, so an edit made after the preview drew and before the button's click
was handled gave the previous art's size. The cache is now used only when
it holds the active document at its current revision; otherwise the image
is made once and kept for the preview drawn in the same frame.
The size in K is computed with a u128 product, so a file past about 4 MiB
on a 32-bit target (wasm32) no longer reads smaller than it is.
A command that needs a value, such as Transparency, is listed in the
editor only while it has a shortcut. shortcuts.set now refuses a hold
shortcut for such a command without a shortcut, and the command loses
its hold shortcut when its shortcut is cleared or given to another
entry, through shortcuts.set, the Keyboard Shortcuts dialog or an
imported set. Its key no longer runs a command the editor does not show,
and it is free for another entry without a conflict.
Two settings of a blend read from the editing data came from rounding
instead of from the file:
- The orientation was whichever of Align to Page and Align to Path laid
the steps out closer to where they are drawn. The check compares the
steps' centers, which turning the steps along the spine leaves in
place, so on a straight spine both fit and the rounding of the drawn
steps decided. The reader now reads the record's word 5 (0 is Align to
Page; a 32-bit float of 8 or more is Align to Path) and keeps that
orientation when it lays the steps out as drawn: in place, at their
drawn sizes and with each one's outline where it is drawn, which
turning a step moves. Otherwise it takes the closest, as before.
- A blend with no spine part opened with a straight spine and an anchor
at each key. When its record names the keys in their order, it now
opens with no spine of its own, which lays out the same straight
lines between the keys' centers. A record that names them in another
order still gets the straight spine in the record's order.
Blend Options, orientation and spines:
https://helpx.adobe.com/illustrator/desktop/manage-colors/apply-transparency-and-blending/blend-options-overview.html
Tests: the record's word 5 (0, 8, 8 plus an angle, and values that name
no orientation); the record's orientation kept where both lay out alike,
and not taken where it would turn the drawn steps (rectangles on a
vertical spine, triangles on a spine running right to left); outlines
that match whatever anchor a path starts at, with another anchor on a
side, with contours in another order and with a lone anchor, and live
art compared by its size; a blend with no spine part in record order
and in the other order.
With Limit to Library set and the Global Adjust at 0%, Save Changes and
New Color Group gave a group each row's new color as it was, while OK gives
the library's nearest color. A row set without being snapped, for example
through `ui.dialog.set`, saved a color outside the library. Both now give
the group the library's nearest color, as OK does.
When the saved preset the Save PDF dialog has chosen is deleted while
the dialog is open, Reset now returns an error naming it, shown in the
status bar, and leaves every field, passwords included, as it is. A
dialog's reset callback returns a Result for this; Flare Tool Options
and Objects on Path Options return Ok. The ui.dialogReset params text
and docs/mcp.md name the error.
After Save Changes, OK with only a new name sent the group's saved colors
as color keys, which hold hundredths of a unit. A swatch with finer
components, such as a CMYK swatch no row lists, was rewritten with the
rounded color. OK now sends `"keep"` for each saved swatch, so the rename
leaves every color as it is.
The parity line said a soft-edged gray stroke running out of black loses
"3 or 4 pixels" where it meets black. It now says 3 or 4 of the 16 pixel
centers along its middle nearest black, as docs/image-trace-adjustments.md
and the test count them.
In docs/image-trace-adjustments.md, gray near black on blurred edges now
traces gray at fewer of its pixel centers instead of "losing pixels", a
wider band loses some or most of its gray instead of part of it (bands 3
and 4 pixels wide at a blur of 1 pixel keep about 60 of 336), and the
paragraph is wrapped to the file's line width.